1. Jan 11, 2024
    • Michal Kucharczyk's avatar
      frame-support: sp-runtime dependency updated (serde) (#2907) · c8112e2c
      Michal Kucharczyk authored
      `frame-support` crate compilation fails (reported by @koute):
      
      ```
      $ cargo check --no-default-features --target=wasm32-unknown-unknown
      
      error[E0277]: the trait bound `GC: Serialize` is not satisfied
          --> substrate/frame/support/src/genesis_builder_helper.rs:32:24
           |
      32   |     serde_json::to_string(&GC::default())
           |     --------------------- ^^^^^^^^^^^^^^ the trait `Serialize` is not implemented for `GC`
           |     |
           |     required by a bound introduced by this call
           |
      note: required by a bound in `serde_json::to_string`
          --> /home/kou/.cargo/registry/src/index.crates.io-6f17d22bba15001f/serde_json-1.0.111/src/ser.rs:2209:17
           |
      2207 | pub fn to_string<T>(value: &T) -> Result<String>
           |        --------- required by a bound in this function
      2208 | where
      2209 |     T: ?Sized + Serialize,
           |                 ^^^^^^^^^ required by this bound in `to_string`
      help: consider further restricting this bound
           |
      30   |     GC: BuildGenesisConfig + Default + serde::Serialize,
           |                                      ++++++++++++++++++
      ```
      
      This PR should fix this.
      
      For all runtimes `sp-runtime/serde` feature was likely enabled by this
      (and few other pallets):
      
      https://github.com/paritytech/polkadot-sdk/blob/f2a750ee86e72c9ab677aaf588d0a33ee8446bef/substrate/frame/system/Cargo.toml#L27
      c8112e2c
  2. Jan 10, 2024
  3. Jan 09, 2024
  4. Jan 08, 2024
  5. Jan 07, 2024
  6. Jan 06, 2024
  7. Jan 05, 2024
  8. Jan 04, 2024
    • asynchronous rob's avatar
      proposer: return optional block (#2834) · 19de1c96
      asynchronous rob authored
      This opens up the proposer to only optionally create blocks. Nodes may
      only make blocks when there are transactions or the chain is scheduled.
      
      ---------
      
      Co-authored-by: command-bot <>
      19de1c96
    • Marcin S.'s avatar
      Update missing worker binaries error (#2853) · e07476e3
      Marcin S. authored
      Please let me know if this would be a better UX. Should we have specific
      links in the error message?
      e07476e3
    • dependabot[bot]'s avatar
      Bump webpki from 0.22.0 to 0.22.4 (#2849) · 99290fd9
      dependabot[bot] authored
      Bumps [webpki](https://github.com/briansmith/webpki) from 0.22.0 to
      0.22.4.
      <details>
      <summary>Commits</summary>
      <ul>
      <li>See full diff in <a
      href="https://github.com/briansmith/webpki/commits">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      
      [![Dependabot compatibility
      score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=webpki&package-manager=cargo&previous-version=0.22.0&new-version=0.22.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits
      that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after
      your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge
      and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating
      it. You can achieve the same result by closing it manually
      - `@dependabot show <dependency name> ignore conditions` will show all
      of the ignore conditions of the specified dependency
      - `@dependabot ignore this major version` will close this PR and stop
      Dependabot creating any more for this major version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this minor version` will close this PR and stop
      Dependabot creating any more for this minor version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this dependency` will close this PR and stop
      Dependabot creating any more for this dependency (unless you reopen the
      PR or upgrade to it yourself)
      You can disable automated security fix PRs for this repo from the
      [Security Alerts
      page](https://github.com/paritytech/polkadot-sdk/network/alerts
      
      ).
      
      </details>
      
      Signed-off-by: default avatardependabot[bot] <[email protected]>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      99290fd9
    • PG Herveou's avatar
      Contracts build risc-v fixtures (#2554) · f82c2977
      PG Herveou authored
      
      
      Follow up from #2347 this time to verify that fixtures build to RISC-V
      
      ---------
      
      Co-authored-by: default avataralvicsam <[email protected]>
      Co-authored-by: default avatarAlexander Samusev <[email protected]>
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      f82c2977
    • Dónal Murray's avatar
    • ordian's avatar
      malus: add new variant SupportDisabled (#2835) · b0a8746a
      ordian authored
      This variant pretends that nobody is disabled onchain.
      b0a8746a
    • Bastian Köcher's avatar
      Remove `dotgraph` feature (#2848) · 5b9e69d3
      Bastian Köcher authored
      Apparently the implementation is broken and is generating warnings in
      the build. Not sure this was used any way by anyone.
      
      Closes: https://github.com/paritytech/polkadot-sdk/issues/2836
      5b9e69d3
    • Lauro Gripa's avatar
      Fix vote weights of ranked members in the Society pallet (#2758) · 924089ff
      Lauro Gripa authored
      
      
      This PR fixes a bug in the tally accrual of approvals/rejections for
      Candidates and Defender. The issue happened because:
      - The `match maybe_old` is reducing `weight` from the tally:
      ```
      Some(Vote { approve: true, weight }) => tally.approvals.saturating_reduce(weight),
      Some(Vote { approve: false, weight }) => tally.rejections.saturating_reduce(weight),
      ```
      - But `match approval` is accruing only `1` to the tally:
      ```
      true => tally.approvals.saturating_accrue(1),
      false => tally.rejections.saturating_accrue(1),
      ```
      
      This way, if a member is rank 1 his vote is going to have weight 1 when
      accruing but weight 4 when reducing from the tally. For example, let's
      say:
      - There's a Candidate with 0 approvals and 12 rejections;
      - A ranked Member votes against the Candidate;
      - The tally changes to 0 approvals and 13 rejections (should be 16);
      - The Member changes his vote to an approval;
      - Now tally changes to 1 approvals and 9 rejections, removing the
      accrued approvals from other Members;
      - If the Member keeps changing his vote, it wipes the tally clean.
      
      So this PR changes `match approval` to accrue `weight` instead of just
      `1` and changes the tests:
      - Fixes `challenges_work`. This test started failing after the fix. The
      reason is that the test assumes that all Members have equal weights to
      their votes, but Member 10 is ranked, so his vote should have weight 4
      against the Defender. So instead of using Member 10, I added Member 50
      of rank 0 to keep the same logic;
      - Improves `votes_are_working`. Added some assertions to check if the
      tally is correct even after a ranked Member changes his vote a couple
      times;
      - Fixes `waive_repay_works`. Unrelated to the bug, but this test was
      yielding a false positive. The test is ranking up Member 20, but
      asserting the rank of Member 10, which is already ranked up.
      
      ---------
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: command-bot <>
      924089ff