Skip to content
  1. Oct 08, 2020
    • Bastian Köcher's avatar
      Fixes logging of target names with dashes (#7281) · db8a0caf
      Bastian Köcher authored 
      * Fixes logging of target names with dashes

There was a bug in tracing-core which resulted in not supporting dashes
in target names. This was fixed upstream. Besides that a test was added
to ensure that we don't break this again.

* Extend test
      db8a0caf
    • Alexander Theißen's avatar
      seal: Add automated weights for contract API calls (#7017) · 443725f0
      Alexander Theißen authored 
      

* seal: Add capability to put uninstrumented code (for benchmarks)

Benchmarks should only measure the overhead of the API calls itself.
For that reason we want to run them without instrumentation.

* seal: Cap the the data length for deposited events

Data used in events has storage implications for archive nodes.
Those need to keep the events in storage forever. For that reason
we want to limit the amount of storage that can be used inside events.

* seal: Fix error reporting in the case out of bound sandbox access

* seal: Refactor existing benchmarks

* seal: Convert benchmark file to tabs

* seal: Add benchmarks for functions called by contracts

* seal: Create a default schedule from benchmark generated WeightInfo

* seal: Make use of WeightInfo in extrinsic weight annotations

* seal: Replace the old schedule by the benchmark generated one

* Review: Fix copy paste typo in schedule construction

* Review: Fix stale docs

* Fix whitespace errors

Co-authored-by: default avatarSergei Shulepov <[email protected]>

* Review: Use checked_div in order to be more defensive

* Review: Rename no_charge to already_charged

* Review: Whitelist caller of extrinsics

* Review: Remove trailing whitespace

* Review: Remove confusing "self::" syntax

* Review: Add docs for the benchmark prepration submodule

* Review: Move code generation functions to own module

* Review: Refactor and document benchmark helper functions

* Remove additional empty line

* Added missing comment on caller_funding

* Update frame/contracts/src/benchmarking/code.rs

Co-authored-by: default avatarSergei Shulepov <[email protected]>

* Fix missing sp_std::prelude import in code.rs

* cargo run --release --features runtime-benchmarks --manifest-path bin/node/cli/Cargo.toml -- benchmark --chain dev --steps 50 --repeat 20 --extrinsic * --execution=wasm --wasm-execution=compiled --output ./bin/node/runtime/src/weights --header ./HEADER --pallet pallet_contracts --heap-pages 4096

* Use weights from the benchmark machine for the substrate node

* Remove prefixes from Schedule members

* Data lengths in the WeightInfo Trait are specified in kilobytes

* Rename ApiWeights to HostFunctionWeights

Co-authored-by: default avatarSergei Shulepov <[email protected]>
Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      443725f0
    • Sergey Pepyakin's avatar
      bump-allocator: document & poison (#7277) · aba0128f
      Sergey Pepyakin authored 
      

* bump-allocator: refine comments

* Rename EMPTY_MARKER to Nil

It's a misnomer since it doesn't actually denote an empty list as it might suggest but rather the end of a list. So I borrowed Nil from Cons/Nil.I could've gone with Null, especially considering that the variant name is already named `Null`, but I preferred `Nil` because the NIL_MARKER is not 0 as `null` may suggest, but rather 0xFFFFFFFF.

* Rename N to N_ORDERS; docs;

Supply a, hopefully, more readable comment as well.

* allocator poisoning: document and enforce.

* Review: Fix line wrapping for a call

Co-authored-by: default avatarBastian Köcher <[email protected]>

* add a test on oom

* Update primitives/allocator/src/freeing_bump.rs

* Make ui tests happy

Co-authored-by: default avatarBastian Köcher <[email protected]>
Co-authored-by: default avatarBastian Köcher <[email protected]>
      aba0128f
  3. Oct 02, 2020
  5. Sep 30, 2020
    • Denis_P's avatar
      WIP: remove deprecated only/except clauses (#7229) · cdff10e1
      Denis_P authored 
      * change (CI): remove deprecated only/except clauses

* change (CI): remove

* change (CI): debug regex

* change (CI): regex shouldn't be surrounded with quotes in `rules`

* change (CI): no quotes in `rules`

* change (CI): debug workflow

* change (CI): almost equal

* change (CI): splinters

* change (CI): some details [chaos:basic]

* change (CI): add manual substrate build on PRs

* change (CI): mistake with publish-to-crates-io

* change (CI): reapproach chaos-only; rename rules anchors [skip ci]

* change (CI): add linux and mac to manual jobs for PRs [skip ci]

* change (CI): remove `pre-v` tags rules [skip ci]

* change (CI): add subkey for macos build as manual on PRs as well

* change (CI): add glob to match every changed file in monitoring

* test (CI): [chaos:basic]
      cdff10e1
    • Bastian Köcher's avatar
      Fix compilation with environmental on latest nightly (#7238) · adc1892f
      Bastian Köcher authored
      adc1892f
  7. Sep 25, 2020
  9. Sep 23, 2020
  11. Sep 22, 2020
  13. Sep 21, 2020
  15. Sep 18, 2020
    • Jon Häggblad's avatar
      grandpa-rpc: use FinalityProofProvider to check finality for rpc (#6215) · 8a0ac4c4
      Jon Häggblad authored 
      * grandpa-rpc: use FinalityProofProvider to check finality for rpc

* grandpa-rpc: minor tidy

* grandpa-rpc: remove dyn FinalityProofProvider

* grandpa-rpc: remove unused dependencies

* node: move finality_proof_provider setup

* grandpa-rpc: print error reported by finality_proof_provider

* grandpa-rpc: add note about unnecessary encode/decode

* grandpa-rpc: dont encode/decode and use correct hash

* grandpa-rpc: set_id is optional

* grandpa-rpc: create test for prove_finality

* grandpa-rpc: set visibility back to how it was

* grandpa-rpc: remove unused dependency

* grandpa-rpc: minor tidy

* grandpa: doc strings

* grandpa-rpc: rename to prove_finality

* grandpa-rpc: use current set id if none is provided

* grandpa-rpc: remove unnecessary check in test

* node: group finality_proof_provider in rpc_setup

* grandpa: make prove_finality concrete in FinalityProofProvider

* grandpa-rpc: wrap finality output in struct and store as Bytes

* grandpa-rpc: exhaustive error codes and wrap

* grandpa-rpc: let prove_finality take a range instead of a starting point

* grandpa-rpc: fix test for changed API

* grandpa-rpc: fix line length

* grandpa: fix reviewer nits

* node/rpc: fix reviewer comments
      8a0ac4c4
    • Anton Gavrilov's avatar
      Prometheus metrics for RPC calls (#7088) · 2c5a82f8
      Anton Gavrilov authored 
      * WS and HTTP middlewares added

* Prometheus endpoint added

* Counters renamed

* Proper style for inc

* Metrics initialization re-written

* Rework to handler middleware

* Introduce transport prefix for metrics

* String shortened

* Commented code removed, new line inserted

* One more string shortened

* Wasm build fixed

* Wasm build fixed once again

* Rework to shared metrics

* Added collectors label

* Tilde removed from cargo

* Switch to owned metrics in parameters
      2c5a82f8
    • Wei Tang's avatar
      pow: replace the thread-base mining loop with a future-based mining worker (#7060) · 5380bbce
      Wei Tang authored 
      

* New worker design

* Remove unused thread import

* Add back missing inherent data provider registration

* Add function to get a Cloned metadata

* Add some docs

* Derive Eq and PartialEq for MiningMetadata

* Fix cargo lock

* Fix line width

* Add docs and fix issues in UntilImportedOrTimeout

* Update client/consensus/pow/src/lib.rs

Co-authored-by: default avatarDavid <[email protected]>

* Add back comments

Co-authored-by: default avatarBastian Köcher <[email protected]>
Co-authored-by: default avatarDavid <[email protected]>
      5380bbce
    • Benjamin Kampmann's avatar
      Tracing for wasm with bridging to native (#6916) · a9c73113
      Benjamin Kampmann authored 
      

* implement events handling, implement parent_id for spans & events

* add events to sp_io::storage

* update test

* add tests

* adjust limit

* let tracing crate handle parent_ids

* re-enable current-id tracking

* add test for threads with CurrentSpan

* fix log level

* remove redundant check for non wasm traces

* remove duplicate definition in test

* Adding conditional events API

* prefer explicit parent_id over current,

enhance test

* limit changes to client::tracing event implementation

* remove From impl due to fallback required on parent_id

* make tracing codecable

* replace with global tracing

* new tracing interface

* impl TracingSubscriber in client

* implement access to global TracingSubscriber from primitives

* span for wasm

* increment towards Wasm Tracing Subscriber implementation

* increment, remove sp-tracing from runtime-interface

* increment, it compiles

* attained original functionality with new mechanism

* implement remaining TracingSubscriber functions

* remove spans from decl_module

* add handling for encoded values

* Revert "replace with global tracing"

This reverts commit 8824a60deea54d9b437407a21c8ceaf6a1902ee5.

* Wasm Side Tracing

* tracing on wasm

* enable tracing wasm on node-runtime

* export all the macros in std

* tracing subscriber on wasm-side only

* pass spans and events over and record them

* reactivate previous code and  cleanup

* further cleaning up

* extend the span macros, activate through executive

* tracking the actual extrinsic, too

* style

* fixing tests

* spaces -> tabs

* attempting to reactivate params

* activate our tests in CI

* some passing

* tests passing

* with core lazy

* global tracer for wasm side with pass over

* fixing metadata referencing

* remove const_fn feature requirement

* reenable dispatch traces

* reset client tracing

* further cleaning up

* fixing runtime-test

* move tracing-build setup into runtime-test

* Merge DebugWriter from tracing and frame-support, move to sp-std

* remove dangling fixme

* Docs for tracing primitives

* cleaning up a bit more

* Wasm interface docs

* optimise docs.rs setup

* adding tracing flags to uncomment

* remove brace

* fixing imports

* fixing broken syntax

* add required modules

* nicer formatting

* better target management

* adding low level storage tracing events into frame

* add custom Debug impl for WasmMetadata

* cloning profiler

* adding info about cloning profiler

* using in-scope for within calls

* proper time tracing, cleaning up println

* allow to disable tracing on runtime_interface-macro

* disable tracing for wasm-tracing-interface

* simplify wasm-tracing-api

* update client to new interface

* fixing docs and tests for sp-tracing

* update integration tests

* re-activating enter_span

* dropping FIXME, it's documented

* fix formatting

* fix formatting

* fix imports

* more debug info

* inform wasm about it being disabled by returning 1

* only one tracer, but enabled multi-all support

* make trait pub again for tests

* Apply suggestions from code review

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>

* fixing wasm doc tests for proper usage

* remove unnecessary import

* fixing formatting

* minor style fixes

* downgrading wabt

* update error message for UI

* Fix interface test

* next attempt to fix macros

* geee

* revert tracing on hashed for future PR

* remove local macros, use originals

* we are able to convert to static items

* implement more WasmValue types

* adding support to convert str, debug and encoded values

* more minor fixes

* revert unsafe 'static making

* fix indentation

* remove commented lines

* bump all them tracing versions

* cleaning up docs and info

* document new flag

* the new layered system handles span cloning better

* Apply suggestions from code review

Co-authored-by: default avatarDavid <[email protected]>

Co-authored-by: default avatarMatt Rutherford <[email protected]>
Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
Co-authored-by: default avatarDavid <[email protected]>
      a9c73113
  17. Sep 17, 2020
    • Wei Tang's avatar
      Use tracing-based subscriber logging (#6825) · 9fdd4672
      Wei Tang authored 
      

* init_logger: switch from log-based to tracing-based and add compatibility layer

* Move tracing profiling subscriber related config realization

* sp-tracing: change profiling to be a layer instead of a subscriber

* Enable profiling layer in cli

* Change all test env_logger init to sp_tracing::try_init_simple

* Remove all local env_logger dependency

* Add missing tracing-subscriber dependency

* frame-sudo: fix tests

* frame-support: fix tests

* Fix frame/pallet and executor tests

* Fix the remaining tests

* Use subscriber's try_init as recommended by @davidbarsky

* Be explict that the tracing-log feature is needed

* Set subscriber writer to stderr

* Shorter line width

* Update cargo lock tracing version

* Fix sc_tracing crate compile

* Fix sc_authority_discovery crate test

* unremove default-features

* Leave enabled to default true

* Warn if global default cannot be set

* Fix unused import

* Remove unused PROXY_TARGET

* Change all reference from rc5 to rc6

* Change all reference of rc2 to rc6

* Fix styling

* Fix typo

* make logger init error'ing

* re-fixing the test issue

Co-authored-by: default avatarBenjamin Kampmann <[email protected]>
      9fdd4672
    • Shawn Tabrizi's avatar
      Add benchmarking pipeline to node-template (#7122) · ab97e949
      Shawn Tabrizi authored
      ab97e949
  19. Sep 15, 2020
    • Bastian Köcher's avatar
      Improve error output of wasm-builder when wasm ins't installed (#7105) · 9dd5812e
      Bastian Köcher authored 
      This improves the error message of wasm-builder when the wasm toolchain
isn't installed. Currently we print that the wasm toolchain is not
installed, but the actual problem is that there is a bug in the
packaging in rust. This will now be much easier to debug, by printing
the full error message of the compiler.
      9dd5812e
  21. Sep 14, 2020
  23. Sep 13, 2020
  25. Sep 11, 2020
    • cheme's avatar
      state_machine no_std witness externalities (#6934) · 232a30fd
      cheme authored 
      

* checkpoint before removing CT from change trie

* before trie backend without tx

* undo

* Started no transaction, but would need using a different root
calculation method, out of the scope of this pr, will roll back.

* Remove NoTransaction.

* partially address review.
dummy stats implementation for no_std.

* Remove ChangeTrieOverlay.

* modified function

* Remove witness_ext

* need noops changes root

* update from cumulus branch

* line break

* remove warning

* line break

* From review: renamings and stats active in no std (except time).

* include cache, exclude change trie cache with individual temporary bad looking
no_std check

* little test

* fuse imports and filter_map prepare_extrinsics_input_inner fold.

* put back ExtInner into Ext, awkward double proto for new function.

* Apply suggestions from code review

* Update primitives/state-machine/Cargo.toml

Co-authored-by: default avatarBastian Köcher <[email protected]>
      232a30fd
  27. Sep 10, 2020
  29. Sep 09, 2020
  31. Sep 08, 2020
  33. Sep 03, 2020
  35. Sep 01, 2020
  37. Aug 31, 2020
    • cheme's avatar
      Update substrate bip39 version. (#6955) · 734d30bf
      cheme authored 
      * update bip39 version

* and lock
      734d30bf
    • Max Inden's avatar
      client/cli/src/config: Warn on low file descriptor limit (#6956) · 875daa31
      Max Inden authored 
      * client/cli/src/config: Warn on low file descriptor limit

Substrate sets the soft file descriptor limit to the hard limit at
startup. In the case of the latter being low already (< 10_000) a
Substrate node under high demand might run into issues e.g. when opening
up new TCP connections or persisting data to the database.

With this commit a warn message is printed to stderr.

* client/cli/Cargo.toml: Update to fdlimit 0.2.0
      875daa31
  39. Aug 29, 2020
  41. Aug 27, 2020
  43. Aug 24, 2020
    • thiolliere's avatar
      update tracing attribute (#6950) · d628c62d
      thiolliere authored
      d628c62d
    • Ashley's avatar
      Add a `LightSyncState` field to the chain spec (#6894) · f009f6c2
      Ashley authored 
      

* Reset code, almost ready for PR

* Improved build_hardcoded_spec

* Fix line widths

* Fix tests

* Fix sc-service-test

* Suggestions from code review

* Rename to LightSyncState

* It's not syncing :^(

* It syncs!

* Remove rpc call

* Convert spaces to tabs

* Moved sc-service things to export_sync_state.rs

* Fix tests

* Wait for syncing with network_status_sinks

* Remove sc-network from node-template

* Apply suggestions from code review

Co-authored-by: default avatarBastian Köcher <[email protected]>

* Various changes, split the flag up into 2 pieces to make testing easier.

* Update client/cli/src/commands/build_spec_cmd.rs

Co-authored-by: default avatarBastian Köcher <[email protected]>

* Revert a lot of changes

Co-authored-by: default avatarBastian Köcher <[email protected]>
      f009f6c2
    • Max Inden's avatar
      client/authority-discovery: Append PeerId to Multiaddr at most once (#6933) · 5c500aa7
      Max Inden authored 
      * client/authority-discovery/worker: Extract address getter

* client/authority-discovery: Test for no duplicate p2p components

* client/authority-discovery: Append PeerId to Multiaddr at most once

When collecting the addresses to be published for the local node,
`addresses_to_publish` adds the local nodes `PeerId` to each
`Multiaddr`. Before doing so, ensure the `Multiaddr` does not already
contain one.

* client/authority-discovery: Remove explicit return
      5c500aa7
  45. Aug 21, 2020
    • Qinxuan Chen's avatar
      Remove duplicated dependencies (#6930) · 8ae16955
      Qinxuan Chen authored 
      

Signed-off-by: default avatarkoushiro <[email protected]>
      8ae16955
    • Max Inden's avatar
      *: Update to next libp2p version 0.24.0 (#6891) · 69e349bd
      Max Inden authored 
      * *: Update to next libp2p version (likely v0.24.0)

* Revert "*: Update to next libp2p version (likely v0.24.0)"

This reverts commit ffe1545aba6c2557a2843579de331f3fc1c60743.

* */Cargo.toml: Update to libp2p v0.24.0

* client/network/src/service: Handle ConnectionClosed returning Option

* Cargo.*: Test kad usize conversion

* Revert "Cargo.*: Test kad usize conversion"

This reverts commit ad317879782f982cb4a4c76029a72b5b97e82bec.

* Cargo.lock: Update to libp2p-kad v0.22.1

* client/cli/Cargo.toml: Update to libp2p 0.24.0
      69e349bd