Skip to content
  1. Nov 03, 2023
  3. Nov 01, 2023
  5. Oct 31, 2023
  7. Oct 27, 2023
  9. Oct 24, 2023
  11. Oct 19, 2023
  13. Oct 18, 2023
  15. Oct 16, 2023
  17. Oct 04, 2023
  19. Sep 29, 2023
  21. Sep 28, 2023
    • Mira Ressel's avatar
      fix(review-bot): pull secrets from `master` environment (#1745) · 7ca0d65f
      Mira Ressel authored
      7ca0d65f
    • Javyer's avatar
      Added `review-bot` to fine tune review requirements (#1673) · 4384c613
      Javyer authored 
      Created a Github Action that uses the [Review-Bot
app](https://github.com/paritytech/review-bot) to require more fine
tuned requirements to review pull requests before allowing the PR to be
merged.

This uses
[`pull_request_target`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target)
for the event, not `pull_request`. This is a security measure so that an
attacker doesn’t have access to the secrets.

All the rules have been copied from the original
`.github/pr-custom-review.yml` file.

I want to clarify, this particular commit is **not intended to replace
PRCR yet**.

# Advantages it brings over `PRCR`

Most of the features available in `PRCR` have been duplicated and
enhanced. For a complete detailed write up, please see:
- paritytech/pr-custom-review#114 -> Proposal for the rewrite
- [Review Bot
Documentation](https://github.com/paritytech/review-bot/blob/main/README.md)

The most important features are:
- `include` and `exclude` fields now accept an array, making it easier
to read the regular expressions.
- Ability to skip a rule
- We can set that PRs coming from a particular user or team will cause
the rule to be skipped.
- This is used in the `Audit rule`, which was requested by
@the-right-joyce.
  - This resolves paritytech/pr-custom-review#136
- Ability to request fellows instead of teams
- As requested in polkadot-fellows/runtimes#7, this bot has the ability
to request fellows by rank instead of users.
- We currently have polkadot-fellows/runtimes#31 which is using that
feature.

Aside from all the rules available in `PRCR` I have added a particular
rule to lock the review-bot files and require a review from the
`locks-review` team, the @paritytech/ci team and the
@paritytech/opstooling team to ensure that the file has been written
correctly.

## Next steps

The next steps will consist on paritytech/review-bot#53, once this issue
has been resolved, and `review-bot` has worked without any issues on
this repository for a while, we will upgrade it to be able to fully
replace `PRCR`.
      4384c613
  23. Sep 25, 2023
  25. Sep 18, 2023
  27. Sep 13, 2023
  29. Sep 11, 2023
  31. Sep 08, 2023
  33. Sep 07, 2023
  35. Sep 06, 2023
    • Chevdor's avatar
      Prevent a fail prdoc check to block (#1433) · 00901523
      Chevdor authored
      00901523
    • Egor_P's avatar
      GHW for building and publishing docker images (#1391) · eeb368ed
      Egor_P authored 
      * add ghw and scripts for docker image deployment

* debug

* add permissions for content

* fix path to the bin folder

* add tags

* rename env

* fix path to docker file

* make polkadot-parachain executable

* fix typo

* fix more typos

* test

* revert back  use of  working directory

* mke bin executable in the artifacts folder

* use cd instead of working directory

* change path to cash

* fix path to cash

* change cache key

* delete old flows

* addressed PR comments

* fix path

* reorg docker files
      eeb368ed
    • Chevdor's avatar
      Fix PRdoc check (#1419) · 50de035f
      Chevdor authored
      50de035f
    • Chevdor's avatar
      Add PRdoc check (#1408) · eaf380aa
      Chevdor authored 
      * Add test prdoc
* Prepare for the check
* Escape PR number
* Fix conditional step
* Add checkout and actual check
* Cleanup
* Minor fixes
* Add doumentation
* Add more doc
      eaf380aa
  37. Sep 05, 2023
  39. Sep 04, 2023
    • Chevdor's avatar
      Markdown linter (#1309) · a30092ab
      Chevdor authored 
      

* Add markdown linting

- add linter default rules
- adapt rules to current code
- fix the code for linting to pass
- add CI check

fix #1243

* Fix markdown for Substrate
* Fix tooling install
* Fix workflow
* Add documentation
* Remove trailing spaces
* Update .github/.markdownlint.yaml

Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
* Fix mangled markdown/lists
* Fix captalization issues on known words
      a30092ab
  41. Aug 30, 2023
  43. Aug 29, 2023
  45. Aug 28, 2023
    • Alexander Samusev's avatar
      [ci] Fix check-licenses (#1208) · c58db695
      Alexander Samusev authored 
      * [DNM] Debug check-licenses

* fix gha

* add permissions

* add install

* add debug

* try one path

* run for each repo

* rm check d labels

* run 3 in parallel

* try fail-fast: false

* fix gitlab pipeline
      c58db695
  47. Aug 26, 2023
  49. Aug 25, 2023