Skip to content
  1. Jan 12, 2022
  2. Jan 11, 2022
  3. Jan 10, 2022
  4. Jan 09, 2022
  5. Jan 08, 2022
  6. Jan 07, 2022
  7. Jan 06, 2022
  8. Jan 05, 2022
  9. Jan 04, 2022
  10. Jan 03, 2022
  11. Dec 31, 2021
  12. Dec 30, 2021
  13. Dec 28, 2021
  14. Dec 27, 2021
    • João Paulo Silva de Souza's avatar
      make check-dependent-* only be executed in PRs (#10545) · 670d2b08
      João Paulo Silva de Souza authored
      Make check-dependent-* jobs only be executed in PRs instead of both PRs and master.
      
      Reason 1: The companion is not merged at the same time as the parent PR
      ([1](https://github.com/paritytech/parity-processbot/issues/347#issuecomment-994729950)), therefore
      the pipeline will fail on master since the companion PR is not yet merged in the other repository.
      This scenario is demonstrated by the pipeline of https://github.com/paritytech/substrate/commit/3d8ce673.
      
      Reason 2: The job can still fail on master due to a new commit on the companion PR's repository which was merged after `bot merge` happened, as demonstrated by the following scheme:
      
      1. Parent PR is merged
      2. Companion PR is updated and set to merge in the future
      3. In the meantime a new commit is merged into the companion PR repository's master branch
      4. The `check-dependent-*` job runs on master but, due to the new commit, it fails for unrelated reasons
      
      While "Reason 2" can be used as an argument against this PR, in that it would be useful to know if the integration is failing on master, "Reason 1" should be taken care of due to this inherent flaw of the current companion build system design.
      670d2b08
  15. Dec 26, 2021
  16. Dec 25, 2021
    • Bastian Köcher's avatar
      Improve SS58 related errors (#10541) · 849cf6ce
      Bastian Köcher authored
      * Improve SS58 related errors
      
      This improves the SS58 error, especially when it comes to parsing public keys with unknown SS58
      address formats.
      
      * Make CI happy
      
      * More fixes
      
      * More
      
      * 🤦
      
      * fml...
      849cf6ce