Skip to content
  1. Dec 05, 2023
  2. Dec 04, 2023
    • Just van Stam's avatar
      Fix XCMP max message size check (#1250) · a9738ade
      Just van Stam authored
      
      
      Improved max message size logic and added test for it
      
      ---------
      
      Co-authored-by: default avatarFrancisco Aguirre <[email protected]>
      Co-authored-by: command-bot <>
      a9738ade
    • dependabot[bot]'s avatar
      Bump multihash from 0.17.0 to 0.18.1 (#2592) · 6d50cd43
      dependabot[bot] authored
      Bumps [multihash](https://github.com/multiformats/rust-multihash) from
      0.17.0 to 0.18.1.
      <details>
      <summary>Changelog</summary>
      <p><em>Sourced from <a
      href="https://github.com/multiformats/rust-multihash/blob/master/CHANGELOG.md">multihash's
      changelog</a>.</em></p>
      <blockquote>
      <h2><a
      href="https://github.com/multiformats/rust-multihash/compare/v0.18.0...v0.18.1">v0.18.1</a>
      (2023-04-14)</h2>
      <h3>Bug Fixes</h3>
      <ul>
      <li>don't panic on non minimal varints (<a
      href="https://redirect.github.com/multiformats/rust-multihash/issues/293">#293</a>)
      (<a
      href="https://github.com/multiformats/rust-multihash/commit/c3445fc5041b0fc573945321ebd4b0cdffe0daa5">c3445fc</a>),
      closes <a
      href="https://redirect.github.com/multiformats/rust-multihash/issues/282">#282</a></li>
      </ul>
      <h2><a
      href="https://github.com/multiformats/rust-multihash/compare/v0.17.0...v0.18.0">0.18.0</a>
      (2022-12-06)</h2>
      <h3>
      
       BREAKING CHANGES</h3>
      <ul>
      <li>
      <p>update to Rust edition 2021</p>
      </li>
      <li>
      <p><code>Multihash::write()</code> returns bytes written</p>
      <p>Prior to this change it returned an empty tuple <code>()</code>, now
      it returns
      the bytes written.</p>
      </li>
      </ul>
      <h3>Features</h3>
      <ul>
      <li>add <code>encoded_len</code> and bytes written (<a
      href="https://redirect.github.com/multiformats/rust-multihash/issues/252">#252</a>)
      (<a
      href="https://github.com/multiformats/rust-multihash/commit/b3cc43ecb6f9c59da774b094853d6542430d55ad">b3cc43e</a>)</li>
      </ul>
      <h3>Bug Fixes</h3>
      <ul>
      <li>remove Nix support (<a
      href="https://redirect.github.com/multiformats/rust-multihash/issues/254">#254</a>)
      (<a
      href="https://github.com/multiformats/rust-multihash/commit/ebf57ddb82be2d2fd0a2f00666b0f888d4c78e1b">ebf57dd</a>),
      closes <a
      href="https://redirect.github.com/multiformats/rust-multihash/issues/247">#247</a></li>
      <li>update to Rust edition 2021 (<a
      href="https://redirect.github.com/multiformats/rust-multihash/issues/255">#255</a>)
      (<a
      href="https://github.com/multiformats/rust-multihash/commit/da53376e0d9cf2d82d6c0d10590a77991cb3a6b6">da53376</a>)</li>
      </ul>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/multiformats/rust-multihash/commit/02c5c664a7e59f6ecf84e81276c4eb8bb65693d5"><code>02c5c66</code></a>
      chore: Release multihash version 0.18.1</li>
      <li><a
      href="https://github.com/multiformats/rust-multihash/commit/d08a25d8d624f4a3afcad0ecf724f7d9a20b5e28"><code>d08a25d</code></a>
      chore: add 0.18.1 to changelog</li>
      <li><a
      href="https://github.com/multiformats/rust-multihash/commit/c3445fc5041b0fc573945321ebd4b0cdffe0daa5"><code>c3445fc</code></a>
      fix: don't panic on non minimal varints (<a
      href="https://redirect.github.com/multiformats/rust-multihash/issues/293">#293</a>)</li>
      <li><a
      href="https://github.com/multiformats/rust-multihash/commit/f015e0a2e4f55742eca95ddbb5561d8c703d551f"><code>f015e0a</code></a>
      chore: Release</li>
      <li><a
      href="https://github.com/multiformats/rust-multihash/commit/8651573323c4191931e12cf9f1ed5feabf5a4989"><code>8651573</code></a>
      Two small cleanups before the release (<a
      href="https://redirect.github.com/multiformats/rust-multihash/issues/257">#257</a>)</li>
      <li><a
      href="https://github.com/multiformats/rust-multihash/commit/048d2350b3fa3ac1fec59bbf8cd8063e00b13593"><code>048d235</code></a>
      chore: add v0.18 changelog (<a
      href="https://redirect.github.com/multiformats/rust-multihash/issues/253">#253</a>)</li>
      <li><a
      href="https://github.com/multiformats/rust-multihash/commit/da53376e0d9cf2d82d6c0d10590a77991cb3a6b6"><code>da53376</code></a>
      fix: update to Rust edition 2021 (<a
      href="https://redirect.github.com/multiformats/rust-multihash/issues/255">#255</a>)</li>
      <li><a
      href="https://github.com/multiformats/rust-multihash/commit/ebf57ddb82be2d2fd0a2f00666b0f888d4c78e1b"><code>ebf57dd</code></a>
      fix: remove Nix support (<a
      href="https://redirect.github.com/multiformats/rust-multihash/issues/254">#254</a>)</li>
      <li><a
      href="https://github.com/multiformats/rust-multihash/commit/b3cc43ecb6f9c59da774b094853d6542430d55ad"><code>b3cc43e</code></a>
      feat: add <code>encoded_len</code> and bytes written (<a
      href="https://redirect.github.com/multiformats/rust-multihash/issues/252">#252</a>)</li>
      <li>See full diff in <a
      href="https://github.com/multiformats/rust-multihash/compare/v0.17.0...v0.18.1">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      
      [![Dependabot compatibility
      score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=multihash&package-manager=cargo&previous-version=0.17.0&new-version=0.18.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits
      that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after
      your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge
      and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating
      it. You can achieve the same result by closing it manually
      - `@dependabot show <dependency name> ignore conditions` will show all
      of the ignore conditions of the specified dependency
      - `@dependabot ignore <dependency name> major version` will close this
      group update PR and stop Dependabot creating any more for the specific
      dependency's major version (unless you unignore this specific
      dependency's major version or upgrade to it yourself)
      - `@dependabot ignore <dependency name> minor version` will close this
      group update PR and stop Dependabot creating any more for the specific
      dependency's minor version (unless you unignore this specific
      dependency's minor version or upgrade to it yourself)
      - `@dependabot ignore <dependency name>` will close this group update PR
      and stop Dependabot creating any more for the specific dependency
      (unless you unignore this specific dependency or upgrade to it yourself)
      - `@dependabot unignore <dependency name>` will remove all of the ignore
      conditions of the specified dependency
      - `@dependabot unignore <dependency name> <ignore condition>` will
      remove the ignore condition of the specified dependency and ignore
      conditions
      
      
      </details>
      
      ---------
      
      Signed-off-by: default avatardependabot[bot] <[email protected]>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      Co-authored-by: default avatarSebastian Kunert <[email protected]>
      6d50cd43
    • Bastian Köcher's avatar
      pallet-ranked-collective: Ensure to cleanup state in `remove_member` (#2591) · a1b2ecb9
      Bastian Köcher authored
      
      
      This ensures that we cleanup the state of `who` in `remove_member`.
      
      ---------
      
      Co-authored-by: default avatarLiam Aharon <[email protected]>
      a1b2ecb9
    • Eugen Snitko's avatar
      Cargo caching with forklift (#2466) · e6b9da13
      Eugen Snitko authored
      This PR adds cargo caching feature with custom ['forklift'
      tool](https://gitlab.parity.io/parity/infrastructure/ci_cd/forklift/forklift)
      Forklift acts as RUSTC_WRAPPER, intercepts rustc calls and stores
      produced artifacts in S3 bucket (see [forklift
      readme](https://gitlab.parity.io/parity/infrastructure/ci_cd/forklift/forklift/-/blob/main/README.MD?ref_type=heads)
      for detailed description)
      
      All settings are made in [`.forklift` job's
      before_script](https://github.com/paritytech/polkadot-sdk/blob/es/forklift-test/.gitlab-ci.yml#L119)
      and affect all jobs that extend `.docker-env` job
      
      To disable feature set `FORKLIFT_BYPASS` variable to true in [project
      settings in
      gitlab](https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/settings/ci_cd)
      e6b9da13
    • Bastian Köcher's avatar
      contracts-fixtures: Do not assume that `rustup` is installed (#2586) · aa4754e3
      Bastian Köcher authored
      The build script was assuming that `rustup` is installed, which breaks
      the build on systems that do not use `rustup`. This pull request just
      fixes it by not panicking on the call to `rustup`.
      aa4754e3
    • Branislav Kontur's avatar
    • Alexander Samusev's avatar
      84559b96
    • Chevdor's avatar
      PRDoc new schema (#1946) · 756a12d5
      Chevdor authored
      
      
      ## Overview
      
      This PR brings in the new version of prdoc v0.0.6 and allows:
      - local schema
      - local config
      - local template
      
      It also fixes the existing prdoc files to match the new schema.
      
      ## todo
      
      - [x] add a brief doc/tldr to help contributors get started
      - [x] test CI
      - [x] finalize schema
      - [x] publish the next `prdoc` cli version (v0.0.7 or above)
      
      ---------
      
      Co-authored-by: default avatarEgor_P <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      756a12d5
    • Serban Iorga's avatar
      Cleanup XCMP `QueueConfigData` (#2142) · 1266de39
      Serban Iorga authored
      Removes obsolete fields from the `QueueConfigData` structure. For the
      remaining fields, if they use the old defaults, we replace them with the
      new defaults.
      
      Resolves: https://github.com/paritytech/polkadot-sdk/issues/1795
      1266de39
    • gupnik's avatar
      Fixes runtime type with doc parsing in derive_impl (#2594) · 35c39c96
      gupnik authored
      Step in https://github.com/paritytech/polkadot-sdk/issues/171
      
      This PR fixes a bug in `derive_impl` causing `#[inject_runtime_type]`
      attribute to be parsed incorrectly when docs are added.
      35c39c96
    • Marcin S.'s avatar
      707dbcc6
  3. Dec 02, 2023
  4. Dec 01, 2023
    • Davide Galassi's avatar
      Bandersnatch: ring-context generic over domain size (#2581) · ecfdb2b7
      Davide Galassi authored
      Serialized length is now statically computed depending on the domain
      size.
      
      Opens the primitive to more generic usages not related to Sassafras
      expectations
      
      Address one point of
      https://github.com/paritytech/polkadot-sdk/issues/2364
      ecfdb2b7
    • Michal Kucharczyk's avatar
      sassafras: taplo happy (#2583) · 5789d6a7
      Michal Kucharczyk authored
      fixes: `taplo format check`
      5789d6a7
    • dependabot[bot]'s avatar
      Bump the known_good_semver group with 1 update (#2575) · 87a73e7a
      dependabot[bot] authored
      
      
      Bumps the known_good_semver group with 1 update:
      [syn](https://github.com/dtolnay/syn).
      
      Updates `syn` from 2.0.38 to 2.0.39
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/dtolnay/syn/releases">syn's
      releases</a>.</em></p>
      <blockquote>
      <h2>2.0.39</h2>
      <ul>
      <li>Fix parsing of return expression in match guards (<a
      href="https://redirect.github.com/dtolnay/syn/issues/1528">#1528</a>)</li>
      <li>Improve error message on labeled loop as value expression for break
      (<a
      href="https://redirect.github.com/dtolnay/syn/issues/1531">#1531</a>)</li>
      </ul>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/dtolnay/syn/commit/924217c1734c085ee6cdb5e198d36d610c234313"><code>924217c</code></a>
      Release 2.0.39</li>
      <li><a
      href="https://github.com/dtolnay/syn/commit/95aeeb559866368d8b910d388c8e04b96083666a"><code>95aeeb5</code></a>
      Merge pull request <a
      href="https://redirect.github.com/dtolnay/syn/issues/1531">#1531</a>
      from dtolnay/breaklabel</li>
      <li><a
      href="https://github.com/dtolnay/syn/commit/b88f86fae5c1ac284179181bf7a34549e6d96d7c"><code>b88f86f</code></a>
      Ignore single_element_loop clippy lint in test</li>
      <li><a
      href="https://github.com/dtolnay/syn/commit/a876185366557cb0e0e175c3be48721c8cc0d8e6"><code>a876185</code></a>
      Improve error on break followed by labeled loop</li>
      <li><a
      href="https://github.com/dtolnay/syn/commit/32ab9794d6b75248c1946ae18baab12a46137eb0"><code>32ab979</code></a>
      Add test of ambiguous label parsing in break</li>
      <li><a
      href="https://github.com/dtolnay/syn/commit/6f658f88a213e25b7ac7ec2dc77c537de679b745"><code>6f658f8</code></a>
      Merge pull request <a
      href="https://redirect.github.com/dtolnay/syn/issues/1530">#1530</a>
      from dtolnay/canbeginexpr</li>
      <li><a
      href="https://github.com/dtolnay/syn/commit/20497e1a555812cfe05769b4d8c117c4e0e4edbd"><code>20497e1</code></a>
      More precise decision to parse expression after return keyword</li>
      <li><a
      href="https://github.com/dtolnay/syn/commit/c6a651aa12447d50c22db3189ef38cff90fc267b"><code>c6a651a</code></a>
      Update name of ExprReturn parse function to match variant name</li>
      <li><a
      href="https://github.com/dtolnay/syn/commit/c2745901009f7d65e7b708cd80031642038f765e"><code>c274590</code></a>
      Indicate that peek argument refers to syn::Ident</li>
      <li><a
      href="https://github.com/dtolnay/syn/commit/3e67cb0c660fc906770d212465652bfeb7a75727"><code>3e67cb0</code></a>
      Merge pull request <a
      href="https://redirect.github.com/dtolnay/syn/issues/1529">#1529</a>
      from dtolnay/up</li>
      <li>Additional commits viewable in <a
      href="https://github.com/dtolnay/syn/compare/2.0.38...2.0.39">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      
      [![Dependabot compatibility
      score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=syn&package-manager=cargo&previous-version=2.0.38&new-version=2.0.39)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits
      that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after
      your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge
      and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating
      it. You can achieve the same result by closing it manually
      - `@dependabot show <dependency name> ignore conditions` will show all
      of the ignore conditions of the specified dependency
      - `@dependabot ignore <dependency name> major version` will close this
      group update PR and stop Dependabot creating any more for the specific
      dependency's major version (unless you unignore this specific
      dependency's major version or upgrade to it yourself)
      - `@dependabot ignore <dependency name> minor version` will close this
      group update PR and stop Dependabot creating any more for the specific
      dependency's minor version (unless you unignore this specific
      dependency's minor version or upgrade to it yourself)
      - `@dependabot ignore <dependency name>` will close this group update PR
      and stop Dependabot creating any more for the specific dependency
      (unless you unignore this specific dependency or upgrade to it yourself)
      - `@dependabot unignore <dependency name>` will remove all of the ignore
      conditions of the specified dependency
      - `@dependabot unignore <dependency name> <ignore condition>` will
      remove the ignore condition of the specified dependency and ignore
      conditions
      
      
      </details>
      
      Signed-off-by: default avatardependabot[bot] <[email protected]>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      87a73e7a
    • Davide Galassi's avatar
      Sassafras Consensus Pallet (#1577) · 095f4bd9
      Davide Galassi authored
      
      
      This PR introduces the pallet for Sassafras consensus.
      
      ## Non Goals
      
      The pallet delivers only the bare-bones and doesn't deliver support for
      auxiliary functionalities such as equivocation report and support for
      epoch change via session pallet.
      
      These functionalities were drafted in the [main
      PR](https://github.com/paritytech/polkadot-sdk/pull/1336), but IMO is
      better to introduce this auxiliary stuff in a follow up PR and after
      client code.
      
      ## Potential follow ups
      
      https://github.com/paritytech/polkadot-sdk/issues/2364
      
      ---------
      
      Co-authored-by: default avatarSebastian Kunert <[email protected]>
      Co-authored-by: default avatarKoute <[email protected]>
      Co-authored-by: default avatarMichal Kucharczyk <[email protected]>
      Co-authored-by: default avatarAndré Silva <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      095f4bd9
    • dependabot[bot]'s avatar
      Bump proc-macro-crate from 1.3.1 to 2.0.0 (#2557) · 7f0beaf2
      dependabot[bot] authored
      
      
      Bumps [proc-macro-crate](https://github.com/bkchr/proc-macro-crate) from
      1.3.1 to 2.0.0.
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/bkchr/proc-macro-crate/releases">proc-macro-crate's
      releases</a>.</em></p>
      <blockquote>
      <h2>v2.0.0</h2>
      <h2>What's Changed</h2>
      <ul>
      <li>Release 2.0.0 by <a
      href="https://github.com/bkchr"><code>@​bkchr</code></a> in <a
      href="https://redirect.github.com/bkchr/proc-macro-crate/pull/39">bkchr/proc-macro-crate#39</a></li>
      </ul>
      <p><strong>Full Changelog</strong>: <a
      href="https://github.com/bkchr/proc-macro-crate/compare/v1.3.1...v2.0.0">https://github.com/bkchr/proc-macro-crate/compare/v1.3.1...v2.0.0</a></p>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/bkchr/proc-macro-crate/commit/cc100ed2bc1ac9bb81812fd435a43e2ef023f355"><code>cc100ed</code></a>
      Merge pull request <a
      href="https://redirect.github.com/bkchr/proc-macro-crate/issues/39">#39</a>
      from bkchr/bkchr-2.0.0</li>
      <li><a
      href="https://github.com/bkchr/proc-macro-crate/commit/39a7c1844fc4d73ef397a7e8d9419f1f3381aa44"><code>39a7c18</code></a>
      Release 2.0.0</li>
      <li>See full diff in <a
      href="https://github.com/bkchr/proc-macro-crate/compare/v1.3.1...v2.0.0">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      
      [![Dependabot compatibility
      score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=proc-macro-crate&package-manager=cargo&previous-version=1.3.1&new-version=2.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits
      that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after
      your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge
      and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating
      it. You can achieve the same result by closing it manually
      - `@dependabot show <dependency name> ignore conditions` will show all
      of the ignore conditions of the specified dependency
      - `@dependabot ignore <dependency name> major version` will close this
      group update PR and stop Dependabot creating any more for the specific
      dependency's major version (unless you unignore this specific
      dependency's major version or upgrade to it yourself)
      - `@dependabot ignore <dependency name> minor version` will close this
      group update PR and stop Dependabot creating any more for the specific
      dependency's minor version (unless you unignore this specific
      dependency's minor version or upgrade to it yourself)
      - `@dependabot ignore <dependency name>` will close this group update PR
      and stop Dependabot creating any more for the specific dependency
      (unless you unignore this specific dependency or upgrade to it yourself)
      - `@dependabot unignore <dependency name>` will remove all of the ignore
      conditions of the specified dependency
      - `@dependabot unignore <dependency name> <ignore condition>` will
      remove the ignore condition of the specified dependency and ignore
      conditions
      
      
      </details>
      
      Signed-off-by: default avatardependabot[bot] <[email protected]>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      7f0beaf2
    • Andrew Jones's avatar
      Contracts: make benchmark dependencies optional in `std` feature (#2576) · dfd7b15e
      Andrew Jones authored
      `wasm-instrument` and `rand` are optional and only used in benchmarking,
      so should not be pulled in by default as part of the `std` feature.
      dfd7b15e
    • Liam Aharon's avatar
      Enforce consistent and correct toml formatting (#2518) · 4a293bc5
      Liam Aharon authored
      Using taplo, fixes all our broken and inconsistent toml formatting and
      adds CI to keep them tidy.
      
      If people want we can customise the format rules as described here
      https://taplo.tamasfe.dev/configuration/formatter-options.html
      
      @ggwpez
      
      , I suggest zepter is used only for checking features are
      propagated, and leave formatting for taplo to avoid duplicate work and
      conflicts.
      
      TODO
      - [x] Use `exclude = [...]` syntax in taplo file to ignore zombienet
      tests instead of deleting the dir
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      4a293bc5
    • Parth's avatar
      Add `recorded_keys` function to get recorded keys from the proof recorder (#2561) · 52132636
      Parth authored
      
      
      # Description
      
      - What does this PR do?
      This PR adds function to get recorded keys from proof recorder instance
      - Why are these changes needed?
      This change is required to get the keys accessed by the trie backend
      during the runtime execution. The keys are already tracked by proof
      recorder, just aren't exposed publicly.
      - How were these changes implemented and what do they affect?
      The changes are implemented by adding a public function in proof
      recorder that simply clones the `recorded_keys` field. It is pure
      addition of function and AFAIK does not affect anything.
      
      
      # Checklist
      
      - [x] My PR includes a detailed description as outlined in the
      "Description" section above
      - [ ] My PR follows the [labeling requirements](CONTRIBUTING.md#Process)
      of this project (at minimum one label for `T`
        required)
      - [ ] I have made corresponding changes to the documentation (if
      applicable)
      - [ ] I have added tests that prove my fix is effective or that my
      feature works (if applicable)
      
      ---------
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      52132636
  5. Nov 30, 2023
    • asynchronous rob's avatar
      Remove dependency on rand's SliceRandom shuffle implementation in gossip-support (#2555) · 1f2ccaea
      asynchronous rob authored
      In gossip-support, we shuffled the list of authorities using the
      `rand::seq::SliceRandom::shuffle`. This function's behavior is
      unspecified beyond being `O(n)` and could change in the future, leading
      to network issues between nodes using different shuffling algorithms. In
      practice, the implementation was a Fisher-Yates shuffle. This PR
      replaces the call with a re-implementation of Fisher-Yates and adds a
      test to ensure the behavior is the same between the two at the moment.
      1f2ccaea
    • dependabot[bot]'s avatar
      Bump the known_good_semver group with 2 updates (#2570) · 6742aba0
      dependabot[bot] authored
      
      
      Bumps the known_good_semver group with 2 updates:
      [serde](https://github.com/serde-rs/serde) and
      [clap](https://github.com/clap-rs/clap).
      
      Updates `serde` from 1.0.188 to 1.0.193
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/serde-rs/serde/releases">serde's
      releases</a>.</em></p>
      <blockquote>
      <h2>v1.0.193</h2>
      <ul>
      <li>Fix field names used for the deserialization of
      <code>RangeFrom</code> and <code>RangeTo</code> (<a
      href="https://redirect.github.com/serde-rs/serde/issues/2653">#2653</a>,
      <a
      href="https://redirect.github.com/serde-rs/serde/issues/2654">#2654</a>,
      <a
      href="https://redirect.github.com/serde-rs/serde/issues/2655">#2655</a>,
      thanks <a
      href="https://github.com/emilbonnek"><code>@​emilbonnek</code></a>)</li>
      </ul>
      <h2>v1.0.192</h2>
      <ul>
      <li>Allow internal tag field in untagged variant (<a
      href="https://redirect.github.com/serde-rs/serde/issues/2646">#2646</a>,
      thanks <a
      href="https://github.com/robsdedude"><code>@​robsdedude</code></a>)</li>
      </ul>
      <h2>v1.0.191</h2>
      <ul>
      <li>Documentation improvements</li>
      </ul>
      <h2>v1.0.190</h2>
      <ul>
      <li>Preserve NaN sign when deserializing f32 from f64 or vice versa (<a
      href="https://redirect.github.com/serde-rs/serde/issues/2637">#2637</a>)</li>
      </ul>
      <h2>v1.0.189</h2>
      <ul>
      <li>Fix &quot;cannot infer type&quot; error when internally tagged enum
      contains untagged variant (<a
      href="https://redirect.github.com/serde-rs/serde/issues/2613">#2613</a>,
      thanks <a href="https://github.com/ahl"><code>@​ahl</code></a>)</li>
      </ul>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/serde-rs/serde/commit/44613c7d0190dbb5ecd2d5ec19c636f45b7488cc"><code>44613c7</code></a>
      Release 1.0.193</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/c706281df3c8d50dba1763f19c856df2746eba6c"><code>c706281</code></a>
      Merge pull request <a
      href="https://redirect.github.com/serde-rs/serde/issues/2655">#2655</a>
      from dtolnay/rangestartend</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/65d75b8fe3105f00ab2e01537d568d4587167582"><code>65d75b8</code></a>
      Add RangeFrom and RangeTo tests</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/332b0cba40bcbcc7a6b23a9706277c54791a9856"><code>332b0cb</code></a>
      Merge pull request <a
      href="https://redirect.github.com/serde-rs/serde/issues/2654">#2654</a>
      from dtolnay/rangestartend</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/8c4af412969086bc8f54fdc2a079d373632e0a03"><code>8c4af41</code></a>
      Fix more RangeFrom / RangeEnd mixups</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/24a78f071b22ae491eec4127be696ac255b9b5d3"><code>24a78f0</code></a>
      Merge pull request <a
      href="https://redirect.github.com/serde-rs/serde/issues/2653">#2653</a>
      from emilbonnek/fix/range-to-from-de-mixup</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/c91c33436d7aaef7472ebc18b734ddc9b5bd11fa"><code>c91c334</code></a>
      Fix Range{From,To} deserialize mixup</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/2083f43a287cac8302009fda5bbe41518dd83209"><code>2083f43</code></a>
      Update ui test suite to nightly-2023-11-19</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/4676abdc9e6bbbddfb33a00ce8d7e81e92f01120"><code>4676abd</code></a>
      Release 1.0.192</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/35700eb23e21d8cb198ef4a422ddad13b855ce3b"><code>35700eb</code></a>
      Merge pull request <a
      href="https://redirect.github.com/serde-rs/serde/issues/2646">#2646</a>
      from robsdedude/fix/2643/allow-tag-field-in-untagged</li>
      <li>Additional commits viewable in <a
      href="https://github.com/serde-rs/serde/compare/v1.0.188...v1.0.193">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      Updates `clap` from 4.4.6 to 4.4.10
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/clap-rs/clap/releases">clap's
      releases</a>.</em></p>
      <blockquote>
      <h2>v4.4.10</h2>
      <h2>[4.4.10] - 2023-11-28</h2>
      <h3>Documentation</h3>
      <ul>
      <li>Link out to changelog</li>
      <li>Cross link derive's attribute reference to derive tutorial</li>
      </ul>
      <h2>v4.4.9</h2>
      <h2>[4.4.9] - 2023-11-27</h2>
      <h3>Fixes</h3>
      <ul>
      <li><em>(help)</em> Show correct <code>Command::about</code> under
      flattened headings</li>
      <li><em>(help)</em> Respect <code>hide</code> when flattening
      subcommands</li>
      </ul>
      <h2>v4.4.8</h2>
      <h2>[4.4.8] - 2023-11-10</h2>
      <h3>Features</h3>
      <ul>
      <li>Add <code>Command::flatten_help</code> to allow <code>git stash
      -h</code> like help for subcommands</li>
      </ul>
      </blockquote>
      </details>
      <details>
      <summary>Changelog</summary>
      <p><em>Sourced from <a
      href="https://github.com/clap-rs/clap/blob/master/CHANGELOG.md">clap's
      changelog</a>.</em></p>
      <blockquote>
      <h2>[4.4.10] - 2023-11-28</h2>
      <h3>Documentation</h3>
      <ul>
      <li>Link out to changelog</li>
      <li>Cross link derive's attribute reference to derive tutorial</li>
      </ul>
      <h2>[4.4.9] - 2023-11-27</h2>
      <h3>Fixes</h3>
      <ul>
      <li><em>(help)</em> Show correct <code>Command::about</code> under
      flattened headings</li>
      <li><em>(help)</em> Respect <code>hide</code> when flattening
      subcommands</li>
      </ul>
      <h2>[4.4.8] - 2023-11-10</h2>
      <h3>Features</h3>
      <ul>
      <li>Add <code>Command::flatten_help</code> to allow <code>git stash
      -h</code> like help for subcommands</li>
      </ul>
      <h2>[4.4.7] - 2023-10-24</h2>
      <h3>Performance</h3>
      <ul>
      <li>Reduced code size</li>
      </ul>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/clap-rs/clap/commit/c0a1814d3c1d93c18faaedc95fd251846e47f4fe"><code>c0a1814</code></a>
      chore: Release</li>
      <li><a
      href="https://github.com/clap-rs/clap/commit/c83e681e20b05f7e128088f47f8fcfc44e8ea166"><code>c83e681</code></a>
      docs: Update changelog</li>
      <li><a
      href="https://github.com/clap-rs/clap/commit/91bcac4ca9d442786f554abeb7b1ed6d7a464a42"><code>91bcac4</code></a>
      Merge pull request <a
      href="https://redirect.github.com/clap-rs/clap/issues/5230">#5230</a>
      from epage/migrate</li>
      <li><a
      href="https://github.com/clap-rs/clap/commit/030d87505d150345ddd425c1df21c034d2ae7748"><code>030d875</code></a>
      docs: Link out to the changelog at the relevant tag</li>
      <li><a
      href="https://github.com/clap-rs/clap/commit/b661a9de04aebd1adaaafdbf7e470f07a8d8a36d"><code>b661a9d</code></a>
      Merge pull request <a
      href="https://redirect.github.com/clap-rs/clap/issues/5229">#5229</a>
      from epage/derive</li>
      <li><a
      href="https://github.com/clap-rs/clap/commit/a08587b00e347492165ded1415bad6ab339e9f0b"><code>a08587b</code></a>
      docs(derive): Link to tutorial sections for attributes</li>
      <li><a
      href="https://github.com/clap-rs/clap/commit/21b671f689bc0b8d790dc8c42902c22822bf6f82"><code>21b671f</code></a>
      chore: Release</li>
      <li><a
      href="https://github.com/clap-rs/clap/commit/93ba76dbaaf9136313a4fe2978693cc39fa467dd"><code>93ba76d</code></a>
      docs: Update changelog</li>
      <li><a
      href="https://github.com/clap-rs/clap/commit/c1c55b30d853446e2cab78664c0d22c1b77d4dfd"><code>c1c55b3</code></a>
      Merge pull request <a
      href="https://redirect.github.com/clap-rs/clap/issues/5228">#5228</a>
      from epage/flat</li>
      <li><a
      href="https://github.com/clap-rs/clap/commit/b13f6d98622b80ba30e63c2c6e65d218cc8a4de3"><code>b13f6d9</code></a>
      fix(help): Hide 'help' if only flattened subcommand</li>
      <li>Additional commits viewable in <a
      href="https://github.com/clap-rs/clap/compare/v4.4.6...v4.4.10">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits
      that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after
      your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge
      and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating
      it. You can achieve the same result by closing it manually
      - `@dependabot show <dependency name> ignore conditions` will show all
      of the ignore conditions of the specified dependency
      - `@dependabot ignore <dependency name> major version` will close this
      group update PR and stop Dependabot creating any more for the specific
      dependency's major version (unless you unignore this specific
      dependency's major version or upgrade to it yourself)
      - `@dependabot ignore <dependency name> minor version` will close this
      group update PR and stop Dependabot creating any more for the specific
      dependency's minor version (unless you unignore this specific
      dependency's minor version or upgrade to it yourself)
      - `@dependabot ignore <dependency name>` will close this group update PR
      and stop Dependabot creating any more for the specific dependency
      (unless you unignore this specific dependency or upgrade to it yourself)
      - `@dependabot unignore <dependency name>` will remove all of the ignore
      conditions of the specified dependency
      - `@dependabot unignore <dependency name> <ignore condition>` will
      remove the ignore condition of the specified dependency and ignore
      conditions
      
      
      </details>
      
      Signed-off-by: default avatardependabot[bot] <[email protected]>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      6742aba0
    • juangirini's avatar
      Add missing glossary to ref docs (#2572) · c30ed6f2
      juangirini authored
      This PR is the same as
      https://github.com/paritytech/polkadot-sdk/pull/2273, but that one had
      too many conflicts after a base change. As it is a just one file PR I
      decided to start over with a clean slate.
      
      ---
      This PR adds some missing glossary definitions to the Developer Hub ref
      docs
      
      FIxes https://github.com/paritytech/polkadot-sdk-docs/issues/40
      c30ed6f2
    • Sebastian Kunert's avatar
      PoV Reclaim (Clawback) Node Side (#1462) · 9a650c46
      Sebastian Kunert authored
      This PR provides the infrastructure for the pov-reclaim mechanism
      discussed in #209. The goal is to provide the current proof size to the
      runtime so it can be used to reclaim storage weight.
      
      ## New Host Function
      - A new host function is provided
      [here](https://github.com/skunert/polkadot-sdk/blob/5b317fda
      
      /cumulus/primitives/pov-reclaim/src/lib.rs#L23).
      It returns the size of the current proof size to the runtime. If
      recording is not enabled, it returns 0.
      
      ## Implementation Overview
      - Implement option to enable proof recording during import in the
      client. This is currently enabled for `polkadot-parachain`,
      `parachain-template` and the cumulus test node.
      - Make the proof recorder ready for no-std. It was previously only
      enabled for std environments, but we need to record the proof size in
      `validate_block` too.
      - Provide a recorder implementation that only the records the size of
      incoming nodes and does not store the nodes itself.
      - Fix benchmarks that were broken by async backing changes
      - Provide new externalities extension that is registered by default if
      proof recording is enabled.
      - I think we should discuss the naming, pov-reclaim was more intuitive
      to me, but we could also go with clawback like in the issue.
      
      ## Impact of proof recording during import
      With proof recording: 6.3058 Kelem/s
      Without proof recording: 6.3427 Kelem/s
      
      The measured impact on the importing performance is quite low on my
      machine using the block import benchmark. With proof recording I am
      seeing a performance hit of 0.585%.
      
      ---------
      
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarDavide Galassi <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      9a650c46
    • joe petrowski's avatar
      Withdraw Assets Before Checking Out in `OnReapIdentity` impl (#2552) · 64361ac1
      joe petrowski authored
      
      
      Follow up to fix a bug from #1814 discovered in XCM emulator testing.
      
      I mistakenly thought that checking out an asset would withdraw it from
      the sender. This actually withdraws the asset before checking out.
      
      ---------
      
      Co-authored-by: default avatarAdrian Catangiu <[email protected]>
      Co-authored-by: default avatarLiam Aharon <[email protected]>
      64361ac1
    • Kian Paimani's avatar
      Introduce Polkadot-Sdk `developer_hub` (#2102) · eaf1bc56
      Kian Paimani authored
      
      
      This PR introduces the new crate `developer_hub` into the polkadot-sdk
      repo. The vision for the developer-hub crate is detailed in [this
      document](https://docs.google.com/document/d/1XLLkFNE8v8HLvZpI2rzsa8N2IN1FcKntc8q-Sc4xBAk/edit?usp=sharing).
      
      <img width="1128" alt="Screenshot 2023-11-02 at 10 45 48"
      src="https://github.com/paritytech/polkadot-sdk/assets/5588131/1e12b60f-fef5-42c4-8503-a3ba234077c3">
      
      
      Other than adding the new crate, it also does the following: 
      
      * Remove the `substrate` crate, as there is now a unique umbrella crate
      for multiple things in `developer_hub::polkadot_sdk`.
      * (backport candidate) A minor change to `frame-support` macros that
      allows `T::RuntimeOrigin` to also be acceptable as the origin type.
      * (backport candidate) A minor change to `frame-system` that allows us
      to deposit events at genesis because now the real genesis config is
      generated via wasm, and we can safely assume `cfg!(feature = "std")`
      means only testing. related to #62.
      * (backport candidate) Introduces a small `read_events_for_pallet` to
      `frame_system` for easier event reading in tests.
      * From https://github.com/paritytech/polkadot-sdk-docs/issues/31, it
      takes action on improving the `pallet::call` docs.
      * From https://github.com/paritytech/polkadot-sdk-docs/issues/31, it
      takes action on improving the `UncheckedExtrinsic` docs.
      
      ## Way Forward
      
      First, a version of this is deployed temporarily
      [here](https://blog.kianenigma.nl/polkadot-sdk/developer_hub/index.html).
      I will keep it up to date on a daily basis.
      
      ### This Pull Request
      
      I see two ways forward: 
      
      1. We acknowledge that everything in `developer-hub` is going to be WIP,
      and merge this asap. We should not yet use links to this crate anywhere.
      2. We make this be the feature branch, make PRs against this, and either
      gradually backport it, or only merge to master once it is done.
      
      I am personally in favor of option 1. If we stick to option 2, we need a
      better way to deploy a staging version of this to gh-pages.
      
      ### Issue Tracking
      
      The main issues related to the future of `developer_hub` are: 
      
      - https://github.com/paritytech/polkadot-sdk-docs/issues/31
      - https://github.com/paritytech/polkadot-sdk-docs/issues/4
      - https://github.com/paritytech/polkadot-sdk-docs/issues/26 
      - https://github.com/paritytech/polkadot-sdk-docs/issues/32
      - https://github.com/paritytech/polkadot-sdk-docs/issues/36
      
      
      ### After This Pull Request
      
      - [ ] create a redirect for
      https://paritytech.github.io/polkadot-sdk/master/substrate/
      - [x] analytics 
      - [ ] link checker
      - [ ] the matter of publishing, and how all of these relative links for
      when we do, that is still an open question. There is section on this in
      the landing page.
      - [ ] updated https://paritytech.github.io/
      
      ---------
      
      Co-authored-by: default avatarLiam Aharon <[email protected]>
      Co-authored-by: default avatarJuan Girini <[email protected]>
      Co-authored-by: default avatarbader y <[email protected]>
      Co-authored-by: default avatarSebastian Kunert <[email protected]>
      Co-authored-by: default avatarJames Wilson <[email protected]>
      Co-authored-by: default avatarMichal Kucharczyk <[email protected]>
      eaf1bc56
    • Aaro Altonen's avatar
      Register metrics for the notification handles (#2562) · 180a6ad9
      Aaro Altonen authored
      Add metrics for notification handles so substream events are correctly
      reported to Prometheus
      180a6ad9
    • Javyer's avatar
      upgraded review bot to 2.3.0 (#2549) · e41a0e72
      Javyer authored
      Upgraded to version 2.3.0 which includes:
      - paritytech/review-bot#103
      - paritytech/review-bot#102
      e41a0e72
  6. Nov 29, 2023
    • PG Herveou's avatar
      Contracts: use compiled rust tests (#2347) · 2135fa87
      PG Herveou authored
      
      
      see #2189
      
      This PR does the following:
      - Bring the user api functions into a new pallet-contracts-uapi (They
      are currently defined in ink!
      [here])(https://github.com/paritytech/ink/blob/master/crates/env/src/engine/on_chain/ext.rs)
      - Add older api versions and unstable to the user api trait.
      - Remove pallet-contracts-primitives and bring the types it defined in
      uapi / pallet-contracts
      - Add the infrastructure to build fixtures from Rust files and test it
      works by replacing `dummy.wat` and `call.wat`
      - Move all the doc from wasm/runtime.rs to pallet-contracts-uapi.
      
      This will be done in a follow up:
      - convert the rest of the test from .wat to rust
      - bring risc-v uapi up to date with wasm
      - finalize the uapi host fns, making sure everything is codegen from the
      source host fns in pallet-contracts
      
      ---------
      
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      2135fa87
    • Joshy Orndorff's avatar
      Parachain Template: Prune `AuxStore` bound and corresponding crate dependency (#2303) · f69069bd
      Joshy Orndorff authored
      
      
      This small PR removes an unnecessary trait bound to the `AuxStore` trait
      from the Parachain template's `rpc.rs` file.
      
      With that bound removed, the entire dependency on `sc-client-api` can
      also be removed.
      
      ---------
      
      Co-authored-by: default avatarJoshy Orndorff <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      f69069bd
    • Michal Kucharczyk's avatar
      state-db: log_target usage fixed (#2547) · c68ce6e1
      Michal Kucharczyk authored
      Use `LOG_TARGET/LOG_TARGET_PIN` in logs.
      c68ce6e1
    • Alexandru Vasile's avatar
      chainHead: Backport error codes from spec (#2539) · ecdf3439
      Alexandru Vasile authored
      
      
      This PR backports the error codes from the spec.
      
      This relies on two specs for defining the error codes:
      - Our rpc-spec-v2 https://github.com/paritytech/json-rpc-interface-spec.
      - JSON-RPC spec https://www.jsonrpc.org/specification#error_object.
      
      To better describe the error codes, they are divided into two separate
      modules `rpc_spec_v2` and `json_rpc_spec` respectively.
      
      The `InvalidSubscriptionID` and `FetchBlockHeader` are merged into the
      JSON-RPC spec `INTERNAL_ERROR`.
      While the other error codes are adjusted from spec.
      
      Errors that are currently in use:
      - -32801 block hash not reported by chainHead_follow or block hash has
      been unpinned
      - -32802 chainHead_follow started with withRuntime == false
      - -32803 chainHead_follow did not generate an
      operationWaitingForContinue event
      
      The following are errors defined in the [JSON-RPC
      spec](https://www.jsonrpc.org/specification#error_object):
      - -32602 The provided parameter isn't one of the expected values, has
      different format or is missing
      - -32603 Internal server error
      
      Note: Error `-32801` must be introduced and generated by the outstanding
      https://github.com/paritytech/polkadot-sdk/issues/1505
      
      Closes: https://github.com/paritytech/polkadot-sdk/issues/2530
      
      ---------
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      ecdf3439
    • Vladimir Istyufeev's avatar
    • Bastian Köcher's avatar
      sp-api: Sprinkle some `automatically_derived` attributes · 08f29af6
      Bastian Köcher authored
      This attribute is informing tooling that the code is automatically
      derived and thus, should not enable any linting.
      08f29af6