Skip to content
  1. Jan 03, 2024
    • Svyatoslav Nikolsky's avatar
      Upgrade @polkadot/api and @polkadot/util package version to latest (#2821) · ac7352ef
      Svyatoslav Nikolsky authored
      Otherwise I'm getting this error:
      https://github.com/polkadot-js/api/pull/4952/files#diff-4cab1e3a83a624e52dc0c30047addb28184fdceac6acb930787af9c3aac50706L668
      when running `./cumulus/scripts/bridges_rococo_westend.sh
      init-bridge-hub-rococo-local` - guess it is related to recent Snowbridge
      merge?
      ac7352ef
    • dependabot[bot]'s avatar
      Bump chevdor/srtool-actions from 0.9.1 to 0.9.2 (#2840) · 73942e01
      dependabot[bot] authored
      
      
      Bumps
      [chevdor/srtool-actions](https://github.com/chevdor/srtool-actions) from
      0.9.1 to 0.9.2.
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/chevdor/srtool-actions/commit/48e9baed50ca414936dfac59d34d8b9bbe581abd"><code>48e9bae</code></a>
      Remove extra quotes</li>
      <li>See full diff in <a
      href="https://github.com/chevdor/srtool-actions/compare/v0.9.1...v0.9.2">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      
      [![Dependabot compatibility
      score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=chevdor/srtool-actions&package-manager=github_actions&previous-version=0.9.1&new-version=0.9.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits
      that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after
      your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge
      and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating
      it. You can achieve the same result by closing it manually
      - `@dependabot show <dependency name> ignore conditions` will show all
      of the ignore conditions of the specified dependency
      - `@dependabot ignore this major version` will close this PR and stop
      Dependabot creating any more for this major version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this minor version` will close this PR and stop
      Dependabot creating any more for this minor version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this dependency` will close this PR and stop
      Dependabot creating any more for this dependency (unless you reopen the
      PR or upgrade to it yourself)
      
      
      </details>
      
      Signed-off-by: default avatardependabot[bot] <[email protected]>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      73942e01
  2. Jan 02, 2024
  3. Jan 01, 2024
    • Squirrel's avatar
      Extract PartialComponents into a type alias (#2767) · 1dd1a160
      Squirrel authored
      Pulling PartialComponents into a named `Service` type stops clippy
      complaining about type complexity and also makes the type signatures a
      little less scary to read.
      
      There's two instances where we can't pull it out into a type because a
      nightly feature has not yet been stabilised (E.g. the `imp Fn` isn't
      stabilised in a type alias context here:
      https://github.com/paritytech/polkadot-sdk/blob/d84e135b
      
      /polkadot/node/service/src/lib.rs#L477
      ).
      
      ---------
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      1dd1a160
  4. Dec 31, 2023
  5. Dec 29, 2023
    • Marcin S.'s avatar
      PVF: ensure job processes are cleaned up, add tests (#2643) · 8bf5a1c0
      Marcin S. authored
      Fixes a potential memory leak.
      
      `PR_SET_PDEATHSIG` is used to terminate children when the parent dies.
      Note that this is subject to a race. There seems to be a raceless
      alternative [here](https://stackoverflow.com/a/42498370/6085242), but
      the concern is small enough that a bit more complexity doesn't seem
      worth it. Left a bit more info in the code comment.
      8bf5a1c0
    • Liam Aharon's avatar
      Development Environment Advice Reference Doc (#2759) · 45f4d9a2
      Liam Aharon authored
      
      
      Closes https://github.com/paritytech/polkadot-sdk-docs/issues/63
      
      ---------
      
      Co-authored-by: default avatarDónal Murray <[email protected]>
      Co-authored-by: default avatarPG Herveou <[email protected]>
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      45f4d9a2
    • Sergej Sakac's avatar
      Broker pallet: fix interlacing (#2811) · ae14e6da
      Sergej Sakac authored
      With the current code, when a user interlaces their region, the end
      result will be three regions in the state:
      - the non-interlaced region
      - first part of the interlaced region
      - second part of the interlaced region
      
      The existing implementation retains the non-interlaced region in the
      state, leading to a problematic scenario:
      
      1. User 1 acquires a region from the market.
      2. User 1 then interlaces this region.
      3. Subsequently, User 1 transfers one part of the interlaced regions to
      User 2.
      Despite this transfer, User 1 retains the ability to assign the entire
      original non-interlaced region, which is inconsistent with the fact that
      they no longer own one of the interlaced parts.
      
      This PR resolves the issue by removing the original region, ensuring
      that only the two new interlaced regions remain in the state.
      ae14e6da
  6. Dec 28, 2023
    • Jun Jiang's avatar
      a813e4da
    • dependabot[bot]'s avatar
      Bump the known_good_semver group with 2 updates (#2810) · 00cb41b9
      dependabot[bot] authored
      
      
      Bumps the known_good_semver group with 2 updates:
      [syn](https://github.com/dtolnay/syn) and
      [serde_yaml](https://github.com/dtolnay/serde-yaml).
      
      Updates `syn` from 2.0.41 to 2.0.43
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/dtolnay/syn/releases">syn's
      releases</a>.</em></p>
      <blockquote>
      <h2>2.0.43</h2>
      <ul>
      <li>Insert trailing comma if not already present when printing a 1-tuple
      in pattern position (<a
      href="https://redirect.github.com/dtolnay/syn/issues/1553">#1553</a>)</li>
      </ul>
      <h2>2.0.42</h2>
      <ul>
      <li>Documentation improvements</li>
      </ul>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/dtolnay/syn/commit/95ee05214030f936b8db3ee295188d5dc2c89621"><code>95ee052</code></a>
      Release 2.0.43</li>
      <li><a
      href="https://github.com/dtolnay/syn/commit/7383e81b1ab6f9983692ebd9d6caa54aeff8fb85"><code>7383e81</code></a>
      Merge pull request <a
      href="https://redirect.github.com/dtolnay/syn/issues/1559">#1559</a>
      from dtolnay/pattuple</li>
      <li><a
      href="https://github.com/dtolnay/syn/commit/712fde5a6fce0e7bee3615ab5c7545ce442bf034"><code>712fde5</code></a>
      Fix ToTokens for PatTuple to insert trailing comma</li>
      <li><a
      href="https://github.com/dtolnay/syn/commit/ed9b94e3395cffb33db4254439e23dbc3a2e9e43"><code>ed9b94e</code></a>
      Merge pull request <a
      href="https://redirect.github.com/dtolnay/syn/issues/1558">#1558</a>
      from dtolnay/tupletests</li>
      <li><a
      href="https://github.com/dtolnay/syn/commit/ec8517b33c137c48c38b74ba5be21815763a50f5"><code>ec8517b</code></a>
      Add tuple comma tests</li>
      <li><a
      href="https://github.com/dtolnay/syn/commit/3cf16c76bdbe4e16261a167592a77edab853c6aa"><code>3cf16c7</code></a>
      Merge pull request <a
      href="https://redirect.github.com/dtolnay/syn/issues/1557">#1557</a>
      from dtolnay/snapshotparsequote</li>
      <li><a
      href="https://github.com/dtolnay/syn/commit/553549ff12358a6ad95baaed2601a9dab541d693"><code>553549f</code></a>
      Generalize snapshot parsing to types that do not implement Parse</li>
      <li><a
      href="https://github.com/dtolnay/syn/commit/f9ad833e4a77c61003861f4e14d16b10b9708f9e"><code>f9ad833</code></a>
      Merge pull request <a
      href="https://redirect.github.com/dtolnay/syn/issues/1556">#1556</a>
      from dtolnay/punctuatedsnapshot</li>
      <li><a
      href="https://github.com/dtolnay/syn/commit/131b40ba2904ec8755bb34466f369072dc34d588"><code>131b40b</code></a>
      Debug impl for punctuated::Pairs superseded by Punctuated</li>
      <li><a
      href="https://github.com/dtolnay/syn/commit/3f12d652a8871955a7e27e0369933288bc387dd5"><code>3f12d65</code></a>
      Include punctuation tokens in snapshot tests containing Punctuated</li>
      <li>Additional commits viewable in <a
      href="https://github.com/dtolnay/syn/compare/2.0.41...2.0.43">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      Updates `serde_yaml` from 0.9.27 to 0.9.29
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/dtolnay/serde-yaml/releases">serde_yaml's
      releases</a>.</em></p>
      <blockquote>
      <h2>0.9.29</h2>
      <ul>
      <li>Turn on <code>deny(unsafe_op_in_unsafe_fn)</code> lint</li>
      </ul>
      <h2>0.9.28</h2>
      <ul>
      <li>Update <code>unsafe-libyaml</code> dependency to pull in unaligned
      write fix</li>
      </ul>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/dtolnay/serde-yaml/commit/b957d2b15d7f3d96279997800fa0610b41b8fe00"><code>b957d2b</code></a>
      Release 0.9.29</li>
      <li><a
      href="https://github.com/dtolnay/serde-yaml/commit/007fc2d5c1987847a0f1ac95885c56f8e6e5f808"><code>007fc2d</code></a>
      Merge pull request <a
      href="https://redirect.github.com/dtolnay/serde-yaml/issues/401">#401</a>
      from dtolnay/unsafeop</li>
      <li><a
      href="https://github.com/dtolnay/serde-yaml/commit/5bac2475b0017d6a635d641df17165d71b951f0e"><code>5bac247</code></a>
      Fill in unsafe blocks inside unsafe functions</li>
      <li><a
      href="https://github.com/dtolnay/serde-yaml/commit/0f6dba18ab8db598c4963e9242afd490ee0202f0"><code>0f6dba1</code></a>
      Turn on deny(unsafe_op_in_unsafe_fn)</li>
      <li><a
      href="https://github.com/dtolnay/serde-yaml/commit/1b6e44837f0db0a1c15537311fed3579a7e8c6d2"><code>1b6e448</code></a>
      Release 0.9.28</li>
      <li><a
      href="https://github.com/dtolnay/serde-yaml/commit/ec1a3145d7b6b809f7b3aa2d9dcd7db30f0588d4"><code>ec1a314</code></a>
      Force unsafe-libyaml version that contains unaligned write fix</li>
      <li><a
      href="https://github.com/dtolnay/serde-yaml/commit/a6b2dc075a6eb1bed0d927df7b7ac2bb288f3bb4"><code>a6b2dc0</code></a>
      Update name of blocks_in_if_conditions clippy lint</li>
      <li>See full diff in <a
      href="https://github.com/dtolnay/serde-yaml/compare/0.9.27...0.9.29">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits
      that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after
      your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge
      and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating
      it. You can achieve the same result by closing it manually
      - `@dependabot show <dependency name> ignore conditions` will show all
      of the ignore conditions of the specified dependency
      - `@dependabot ignore <dependency name> major version` will close this
      group update PR and stop Dependabot creating any more for the specific
      dependency's major version (unless you unignore this specific
      dependency's major version or upgrade to it yourself)
      - `@dependabot ignore <dependency name> minor version` will close this
      group update PR and stop Dependabot creating any more for the specific
      dependency's minor version (unless you unignore this specific
      dependency's minor version or upgrade to it yourself)
      - `@dependabot ignore <dependency name>` will close this group update PR
      and stop Dependabot creating any more for the specific dependency
      (unless you unignore this specific dependency or upgrade to it yourself)
      - `@dependabot unignore <dependency name>` will remove all of the ignore
      conditions of the specified dependency
      - `@dependabot unignore <dependency name> <ignore condition>` will
      remove the ignore condition of the specified dependency and ignore
      conditions
      
      
      </details>
      
      Signed-off-by: default avatardependabot[bot] <[email protected]>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      00cb41b9
    • Sophia Gold's avatar
      Fix slot_duration divide by zero panic in rococo-parachain runtime (#2612) · 201ec44a
      Sophia Gold authored
      Adds the fix in https://github.com/paritytech/polkadot-sdk/pull/2039 to
      the rococo-parachain runtime.
      201ec44a
  7. Dec 27, 2023
  8. Dec 26, 2023
  9. Dec 25, 2023
  10. Dec 24, 2023
  11. Dec 23, 2023
    • Liam Aharon's avatar
      Improve `TryDecodeEntireState` output (#2724) · 8acd6300
      Liam Aharon authored
      Found some areas for improvement while working on
      https://github.com/polkadot-fellows/runtimes/pull/122.
      
      ## Improvements
      
      - If multiple keys in a storage item (e.g. a map) are undecodable,
      return all the undecodable keys rather than only the first one found
      - Include the key of the undecodable storage in the INFO log
      - Write output as hex string where appropriate
      - Write INFO log on successful decoding
      8acd6300
  12. Dec 22, 2023
    • Bastian Köcher's avatar
    • joe petrowski's avatar
      Rococo & Westend People Chain (#2281) · ecbbb5a7
      joe petrowski authored
      
      
      Rococo and Westend runtimes for the "People Chain". This chain contains
      the Identity pallet with plans to migrate all related data from the
      Relay Chain.
      
      Changes `IdentityInfo` to:
      
      - Remove `additional_fields`.
      - Add `github` and `discord` as first class fields. From scraping chain
      data, these were the only two additional fields used (for the Fellowship
      and Ambassador Program, respectively).
      - Rename `riot` to `matrix`.
      
      Note: This will use the script in
      https://github.com/paritytech/polkadot-sdk/pull/2025 to generate the
      genesis state.
      
      TODO:
      
      - [x] https://github.com/paritytech/polkadot-sdk/pull/1814 and
      integration of the Identity Migrator pallet for migration.
      - [x] Tests: https://github.com/paritytech/polkadot-sdk/pull/2373
      
      ---------
      
      Co-authored-by: default avatarMuharem <[email protected]>
      Co-authored-by: default avatarMichal Kucharczyk <[email protected]>
      Co-authored-by: default avatarDónal Murray <[email protected]>
      Co-authored-by: default avatarRichard Melkonian <[email protected]>
      Co-authored-by: default avatarLiam Aharon <[email protected]>
      ecbbb5a7
    • Sachin Charakhwal's avatar
      fix overflow in `balance_to_point` conversion (#2706) · 4c0e0e07
      Sachin Charakhwal authored
      Closes #416
      
      As I mentioned in the above issue `balance_to_points` conversion
      currently overflows the `Balance` types even before computing the actual
      points for the given tokens. This fixes that,
      4c0e0e07
    • Emanuele Valzano's avatar
      incrementing sufficient accounts references with saturating_add for safety. (#2768) · 0ce506ef
      Emanuele Valzano authored
      
      
      Even though it is difficult to overflow the sufficients variable, since
      an attacker that is willing to rapidly increase the number must every
      time deposit a minimum deposit of a given asset, it is safer to use
      saturating_add().
      
      ---------
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      0ce506ef
    • Svyatoslav Nikolsky's avatar
      Final nits for bridge-hub-test-utils (#2788) · b62df695
      Svyatoslav Nikolsky authored
      closes https://github.com/paritytech/parity-bridges-common/issues/2739
      b62df695
    • dependabot[bot]'s avatar
      Bump unsafe-libyaml from 0.2.9 to 0.2.10 (#2776) · 0686cf17
      dependabot[bot] authored
      
      
      Bumps [unsafe-libyaml](https://github.com/dtolnay/unsafe-libyaml) from
      0.2.9 to 0.2.10.
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/dtolnay/unsafe-libyaml/releases">unsafe-libyaml's
      releases</a>.</em></p>
      <blockquote>
      <h2>0.2.10</h2>
      <ul>
      <li>Fix write to improperly aligned pointer in 32-bit targets (<a
      href="https://redirect.github.com/dtolnay/unsafe-libyaml/issues/21">#21</a>)</li>
      </ul>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/dtolnay/unsafe-libyaml/commit/61f3ab82b271ac90d6a04f65520614ca08c58abe"><code>61f3ab8</code></a>
      Release 0.2.10</li>
      <li><a
      href="https://github.com/dtolnay/unsafe-libyaml/commit/d90d7abc4e31d590881a055c6ade175e40cd498f"><code>d90d7ab</code></a>
      Clean up some redundant casts</li>
      <li><a
      href="https://github.com/dtolnay/unsafe-libyaml/commit/7755559145c9cf5573639bfecc557893d4a46b0d"><code>7755559</code></a>
      Merge pull request <a
      href="https://redirect.github.com/dtolnay/unsafe-libyaml/issues/24">#24</a>
      from dtolnay/mallocalign</li>
      <li><a
      href="https://github.com/dtolnay/unsafe-libyaml/commit/b8a0863c1bb2a0e1b3d226679e4a7bd31d14c2b4"><code>b8a0863</code></a>
      Fix insufficient alignment of malloc's return value on 32-bit</li>
      <li><a
      href="https://github.com/dtolnay/unsafe-libyaml/commit/389373f0d99dd8726eb52199e622056aa1d4ac8f"><code>389373f</code></a>
      Merge pull request <a
      href="https://redirect.github.com/dtolnay/unsafe-libyaml/issues/23">#23</a>
      from dtolnay/malloc</li>
      <li><a
      href="https://github.com/dtolnay/unsafe-libyaml/commit/fd41ef659dcd9eaa973771985edce227cdcfe084"><code>fd41ef6</code></a>
      Check arithmetic in malloc computations</li>
      <li><a
      href="https://github.com/dtolnay/unsafe-libyaml/commit/9e054fbfee5523f904bd70091170ad7a0e5402a2"><code>9e054fb</code></a>
      Merge pull request <a
      href="https://redirect.github.com/dtolnay/unsafe-libyaml/issues/22">#22</a>
      from dtolnay/force</li>
      <li><a
      href="https://github.com/dtolnay/unsafe-libyaml/commit/5b40a9e0edc5c5e87585d49f9fd34603c2c4742b"><code>5b40a9e</code></a>
      Check more arithmetic operations</li>
      <li><a
      href="https://github.com/dtolnay/unsafe-libyaml/commit/97a4332d8d5a47478e659cb9b872ed6613eee8a9"><code>97a4332</code></a>
      Delete cast to long followed by size_t</li>
      <li><a
      href="https://github.com/dtolnay/unsafe-libyaml/commit/e5f4bbd0f0ff8c48c8df8e88f810e5d0c4143159"><code>e5f4bbd</code></a>
      Clean up duplicated casting to size_t</li>
      <li>Additional commits viewable in <a
      href="https://github.com/dtolnay/unsafe-libyaml/compare/0.2.9...0.2.10">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      
      [![Dependabot compatibility
      score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=unsafe-libyaml&package-manager=cargo&previous-version=0.2.9&new-version=0.2.10)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits
      that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after
      your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge
      and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating
      it. You can achieve the same result by closing it manually
      - `@dependabot show <dependency name> ignore conditions` will show all
      of the ignore conditions of the specified dependency
      - `@dependabot ignore this major version` will close this PR and stop
      Dependabot creating any more for this major version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this minor version` will close this PR and stop
      Dependabot creating any more for this minor version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this dependency` will close this PR and stop
      Dependabot creating any more for this dependency (unless you reopen the
      PR or upgrade to it yourself)
      You can disable automated security fix PRs for this repo from the
      [Security Alerts
      page](https://github.com/paritytech/polkadot-sdk/network/alerts).
      
      </details>
      
      Signed-off-by: default avatardependabot[bot] <[email protected]>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      0686cf17
    • joe petrowski's avatar
      Update Safe Call Filters (#2786) · d7ca2cb5
      joe petrowski authored
      
      
      - Updates all safe call filters to allow `system::authorize_upgrade`.
      - Updates Coretime safe call filter to allow `sudo` and
      `system_set_storage`.
      - Update Coretime teleports to allow teleportation with other system
      chains.
      
      ---------
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      d7ca2cb5
    • Bastian Köcher's avatar
      pallet-sudo: Accept `Root` origin as valid sudo (#2783) · 96bec7a7
      Bastian Köcher authored
      This changes `pallet-sudo` to also accept `Root` origin for
      `ensure_sudo`. This can be useful for parachains who allow the relay
      chain to have superuser rights to setup the sudo pallet for example.
      96bec7a7
    • Bastian Köcher's avatar
    • Branislav Kontur's avatar
  13. Dec 21, 2023
  14. Dec 20, 2023
    • joe petrowski's avatar
      Fix Coretime Master (#2765) · d84e135b
      joe petrowski authored
      Should have merged master into #2682 before merging.
      d84e135b
    • Dónal Murray's avatar
      Fix clippy lints behind feature gates and add new CI step all features (#2569) · d68868f6
      Dónal Murray authored
      
      
      Many clippy lints usually enforced by `-Dcomplexity` and `-Dcorrectness`
      are not caught by CI as they are gated by `features`, like
      `runtime-benchmarks`, while the clippy CI job runs with only the default
      features for all targets.
      
      This PR also adds a CI step to run clippy with `--all-features` to
      ensure the code quality is maintained behind feature gates from now on.
      
      To improve local development, clippy lints are downgraded to warnings,
      but they still will result in an error at CI due to the `-Dwarnings`
      rustflag.
      
      ---------
      
      Co-authored-by: default avatarLiam Aharon <[email protected]>
      d68868f6
    • joe petrowski's avatar
      Add Authorize Upgrade Pattern to Frame System (#2682) · 280aa0b5
      joe petrowski authored
      Adds the `authorize_upgrade` -> `enact_authorized_upgrade` pattern to
      `frame-system`. This will be useful for upgrading bridged chains that
      are under the governance of Polkadot without passing entire runtime Wasm
      blobs over a bridge.
      
      Notes:
      
      - Changed `enact_authorized_upgrade` to `apply_authorized_upgrade`.
      Personal opinion, "apply" more accurately expresses what it's doing. Can
      change back if outvoted.
      - Remove `check_version` in favor of two extrinsics, so as to make
      _checked_ the default.
      - Left calls in `parachain-system` and marked as deprecated to prevent
      breaking the API. They just call into the `frame-system` functions.
      - Updated `frame-system` benchmarks to v2 syntax.
      
      ---------
      
      Co-authored-by: command-bot <>
      280aa0b5
    • André Silva's avatar
      use a single source for simple-mermaid dependency (#2760) · b51904da
      André Silva authored
      this breaks cargo vendor which is necessary for building polkadot with
      nix
      b51904da
    • Muharem Ismailov's avatar
      pallet-asset-conversion: Decoupling Native Currency Dependancy (#2031) · 4f832ea8
      Muharem Ismailov authored
      closes https://github.com/paritytech/polkadot-sdk/issues/1842
      
      Decoupling Pallet from the Concept of Native Currency
      
      Currently, the pallet is intrinsically linked with the concept of native
      currency, requiring users to provide implementations of the
      `fungible::*` and `fungibles::*` traits to interact with native and non
      native assets. This incapsulates some non-related to the pallet
      complexity and makes it less adaptable in contexts where the native
      currency concept is absent.
      
      With this PR, the dependence on `fungible::*` for liquidity-supplying
      assets has been removed. Instead, the native and non-native currencies'
      handling is now overseen by a single type that implements the
      `fungibles::*` traits. To simplify this integration, types have been
      introduced to facilitate the creation of a union between `fungible::*`
      and `fungibles::*` implementations, producing a unified `fungibles::*`
      type.
      
      One of the reasons driving these changes is the ambition to create a
      more user-friendly API for the `SwapCredit` implementation. Given that
      it interacts with two distinct credit types from `fungible` and
      `fungibles`, a unified type was introduced. Clients now manage potential
      conversion failures for those credit types. In certain contexts, it's
      vital to guarantee that operations are fail-safe, like in this impl -
      [PR](https://github.com/paritytech/polkadot-sdk/pull/1845), place in
      [code](https://github.com/paritytech/polkadot-sdk/blob/20b85a5f
      
      /cumulus/primitives/utility/src/lib.rs#L429).
      
      Additional Updates:
      - abstracted the pool ID and its account derivation logic via trait
      bounds, along with common implementation offerings;
      - removed `inc_providers` on a pool creation for the pool account;
      - benchmarks:
      -- swap complexity is N, not const;
      -- removed `From<u128> + Into<u128>` bound from `T::Balance`;
      -- removed swap/liquidity/.. amount constants, resolve them dynamically
      based on pallet configuration;
      -- migrated to v2 API;
      - `OnUnbalanced` handler for the pool creation fee, replacing direct
      transfers to a specified account ID;
      - renamed `MultiAssetId` to `AssetKind` aligning with naming across
      frame crates;
      
      related PRs:
      - (depends) https://github.com/paritytech/polkadot-sdk/pull/1677
      - (caused) https://github.com/paritytech/polkadot-sdk/pull/2033
      - (caused) https://github.com/paritytech/polkadot-sdk/pull/1876
      
      ---------
      
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      Co-authored-by: default avatarLiam Aharon <[email protected]>
      4f832ea8