Skip to content
  1. Aug 11, 2021
  2. Aug 10, 2021
  3. Aug 09, 2021
    • Marek Kotewicz's avatar
      DatabaseSource::Auto (#9500) · a2f75241
      Marek Kotewicz authored
      * implement "auto" database backend in client/db, in progress, #9201
      
      * move fn supports_ref_counting from DatabaseSource enum to Database trait to make it work correctly for all types of dbs
      
      * update kvdb_rocksdb to 0.13 and use it's new config feature  to properly auto start existing database
      
      * tests for auto database reopening
      
      * introduce OpenDbError to cleanup opening database error handling and handle case when database is not enabled at the compile time
      
      * cargo fmt strings again
      
      * cargo fmt strings again
      
      * rename DataSettingsSrc to fix test compilation
      
      * fix the call to the new kvdb-rocksdb interdace in tests to fix compilation
      
      * simplify OpenDbError and make it compile even when paritydb and rocksdb are disabled
      
      * cargo fmt
      
      * fix compilation without flag with-parity-db
      
      * fix unused var compilation warning
      
      * support different paths for rocksdb and paritydb in DatabaseSouce::Auto
      
      * support "auto" database option in substrate cli
      
      * enable Lz4 compression for some of the parity-db colums as per review suggestion
      
      * applied review suggestions
      a2f75241
  4. Aug 07, 2021
    • Liu-Cheng Xu's avatar
      Expose UnsafeRpcError (#9515) · f0dbe25e
      Liu-Cheng Xu authored
      f0dbe25e
    • Shawn Tabrizi's avatar
      FRAME Weights with Storage Metadata (#9471) · 0489c176
      Shawn Tabrizi authored
      
      
      * weights with metadata
      
      * fix
      
      * fix contract test
      
      * skip metadata tag
      
      * special handling for `frame_system`
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/system/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * add skip metadata to contracts
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * fix contract test
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_democracy --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/democracy/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bounties --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bounties/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * expose component information
      
      * fix test generation
      
      * refactor list benchmarks
      
      * move component selection out of runtime
      
      * add benchmark verification
      
      * missing feature
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bounties --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bounties/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_democracy --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/democracy/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * add internal repeats
      
      * update weights with internal repeats
      
      * fix warning
      
      * return error with pov
      
      * try without tracking
      
      * Revert "return error with pov"
      
      This reverts commit 44c36cbbd3c6818f36f377e3e291f1df156e40f7.
      
      * Revert "try without tracking"
      
      This reverts commit f401c44aebff2232389d8d307b20924891e5d77d.
      
      * Revert "Revert "try without tracking""
      
      This reverts commit 4b4e05929802ad3e8154e107359447634e5fb21b.
      
      * state without tracking
      
      * fix build
      
      * temp test
      
      * split db and timing benchmarks
      
      * extend db results?
      
      * default repeat is internal
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_democracy --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/democracy/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * fix warning
      
      * bump linked hash map
      
      * use linked hash map for storage tracker
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_democracy --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/democracy/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * remove conflicting short command
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_democracy --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/democracy/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * missed one linked hashmap
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bounties --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bounties/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bounties --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bounties/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * new weights with latest changes
      
      * Update frame/benchmarking/src/utils.rs
      
      Co-authored-by: default avatarParity Benchmarking Bot <[email protected]>
      0489c176
  5. Aug 05, 2021
  6. Aug 04, 2021
    • Bastian Köcher's avatar
      Decouples light-sync state from chain spec (#9491) · 6e4d30e8
      Bastian Köcher authored
      * Decouples light-sync state from chain spec
      
      This decouples the light-sync state from chain spec. First, the
      light-sync state currently only works with BABE+Grandpa, so not
      all *Substrate* based chains can use this feature. The next problem was
      also that this pulled the `sc-consensus-babe` and `sc-finality-grandpa`
      crate into `sc-chain-spec`.
      
      If a chain now wants to support the light-sync state, it needs to add
      the `LightSyncStateExtension` to the chain spec as an extension. This is
      documented in the crate level docs of `sc-sync-state-rpc`. If this
      extension is not available, `SyncStateRpc` fails at initialization.
      
      * Fix compilation for browser
      
      * Fmt
      6e4d30e8
  7. Aug 03, 2021
  8. Aug 02, 2021
  9. Jul 30, 2021
  10. Jul 29, 2021
    • Bastian Köcher's avatar
      Improve `state` related logs to use a more uniform format (#9452) · f07f6930
      Bastian Köcher authored
      * Improve `state` related logs to use a more uniform format
      
      The logging before wasn't that uniform and not that great to read/parse.
      Now we are using a uniform format for all the logs. Besides these
      changes, there are some minor changes around the code that calls the
      state machine.
      
      * Make CI happy
      
      * Use HexDisplay for `ext_id`
      f07f6930
  11. Jul 28, 2021
  12. Jul 27, 2021
  13. Jul 26, 2021
  14. Jul 24, 2021
  15. Jul 23, 2021
  16. Jul 22, 2021
  17. Jul 21, 2021
  18. Jul 17, 2021
  19. Jul 16, 2021
  20. Jul 14, 2021
  21. Jul 13, 2021
  22. Jul 12, 2021
  23. Jul 11, 2021
    • Benjamin Kampmann's avatar
      Attempting to fix publishing (#9140) · c78c2892
      Benjamin Kampmann authored
      
      
      * mark template and utils as non-publish
      
      * switch to development version for testing
      
      * activate unleash check
      
      * maybe if I disable all rules...
      
      * Fix isolated compilation of `max-encoded-len-derive` with `syn`
      
      error[E0369]: binary operation `==` cannot be applied to type `syn::Path`
        --> src/lib.rs:88:29
         |
      88 |             .filter(|attr| attr.path == parse_quote!(max_encoded_len_crate))
         |                            --------- ^^ ----------------------------------- _
         |                            |
         |                            syn::Path
      
      error: aborting due to previous error
      
      For more information about this error, try `rustc --explain E0369`.
      Error: could not compile `max-encoded-len-derive`
      
      * WIP: bump changes crates since v3 tag to next breaking
      
      cargo unleash version bump-breaking --changed-since v3.0.0
      cargo unleash version set-pre dev --changed-since v3.0.0
      
      FIXME: Don't modify crates that are not yet released, e.g.
      `max-encoded-len-derive`
      
      * Update lockfile
      
      * WIP: Bump sp-transaction-pool as well
      
      * WIP: Bump sp-offchain as well
      
      * WIP: Bump frame-system-rpc-runtime-api as well
      
      * WIP: Bump sp-authority-discovery as well
      
      * Manually deactivate dev-deps before `cargo unleash check`
      
      Otherwise we run into `Cycle detected` error.
      
      * Bump sp-consensus-slots
      
      * Add missing Cargo.lock change
      
      * Bump sp-consensus-vrf as well
      
      * Bump sp-keyring as well
      
      * Bump sp-consensus-pow as well
      
      * Try to speed up the `unleash-check` job
      
      Previously, the job took 106 minutes - let's see if explicitly
      specifying a `CARGO_TARGET_DIR` will help
      
      * fixup: Ensure the temp target dir exists for unleash check
      
      * Bump pallet-transaction-payment-rpc-runtime-api as well
      
      Needed for Polkadot
      
      * Bump pallet-transaction-payment-rpc as well
      
      Needed for Polkadot
      
      * Try updating crates after patching in the Polkadot CI job
      
      * Use another approach to update patched Substrate crates
      
      * Try to update all sp-core versions in Polkadot CI job
      
      * Simplify sp-core version checking
      
      * Apply another shellcheck lint
      
      * Just do the simplest thing I guess
      
      * Welp don't do --offline then
      
      * Clean up `unleash-check` job triggers
      
      Co-authored-by: default avatarDenis Pisarev <[email protected]>
      
      * Fix a note in unleash-check cache step
      
      * Add a note about temporary optimization in cargo-unleash
      
      * Pin a newer version of cargo-unleash
      
      Co-authored-by: default avatarIgor Matuszewski <[email protected]>
      Co-authored-by: default avatarDenis Pisarev <[email protected]>
      c78c2892
  24. Jul 09, 2021
    • Kian Paimani's avatar
      Make election benchmarks more *memory-aware* (#9286) · 3850a433
      Kian Paimani authored
      
      
      * Make benchmarks a bit better with mem
      
      * Make election benchmarks more *memory-aware*
      
      * Fix a few errors
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Manually fix the weights
      
      * Update lock file
      
      * remove dupe
      
      * Fix tests
      
      * cargo update pwasm
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      3850a433
  25. Jul 08, 2021
    • Seun Lanlege's avatar
      sc-transcation-pool refactor (#9228) · 2ae9d367
      Seun Lanlege authored
      * Use TransactionPool trait
      
      * sc-transaction-pool-primitives
      
      * sc-transaction-pool-api
      
      * TP
      
      * bye sc_transaction_graph
      
      * fix line widths
      
      * fix import errors
      
      * fix import errors
      
      * fix import errors 🤦🏾‍♂️
      
      * fix import errors 🤦🏾‍♂️🤦🏾‍♂️🤦🏾‍♂️
      
      * remove sp-keyring
      2ae9d367
  26. Jul 07, 2021
    • Shawn Tabrizi's avatar
      Include `StorageInfo` in Benchmarking Pipeline (#9090) · b42b8fc5
      Shawn Tabrizi authored
      
      
      * extend storageinfo
      
      * extend_storage_info
      
      * use vec
      
      * add storage info to pipeline
      
      * get read and written keys
      
      * undo storageinfo move
      
      * refactor keytracker
      
      * return read / write count
      
      * playing with key matching
      
      * add basic `StorageInfo` constructor
      
      * add whitelisted to returned info
      
      * fix some test stuff
      
      * pipe comments into benchmark data
      
      * add_storage_comments
      
      * add comments to template
      
      * track only storage prefix
      
      * Update frame/benchmarking/src/lib.rs
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * fix test
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * remove test logs
      
      * add temp benchmark script
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * remove keytracker and use trackedstoragekey
      
      * add comment for unknown keys
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_timestamp --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/timestamp/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * remove duplicate comments with unknown keys
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_timestamp --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/timestamp/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * refactor bench tracker, and fix results
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * fix child tries in new tracker
      
      * extra newline
      
      * fix unused warning
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_timestamp --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/timestamp/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * fix master merge
      
      * storage info usage refactor
      
      * remove now unused
      
      * fix refactor
      
      * use a vec for prefix
      
      * fix tests
      
      * also update writer to use vec
      
      * disable read and written keys for now
      
      * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/system/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Update frame/system/src/weights.rs
      
      * fix test
      
      * Delete weights.rs
      
      * reset weights
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      b42b8fc5
    • Bastian Köcher's avatar
      Clean up sc-allocator (#9295) · 7bbf9492
      Bastian Köcher authored
      7bbf9492
    • Sergey Pepyakin's avatar
      PVF: NaN canonicalization & deteriministic stack (#9069) · f388b66a
      Sergey Pepyakin authored
      
      
      * NaN canonicalization
      
      * Introduce a simple stack depth metering
      
      * Be explicit about the wasm features we enable
      
      * Pull the latest latast fix for the pwasm-utils crate
      
      * Disable `wasm_threads` as well.
      
      * Factor out deterministic stack params
      
      * Add more docs
      
      * Remove redundant dep
      
      * Refine comments
      
      * Typo
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      f388b66a
    • cheme's avatar
      Paged keys rpc for child storage. (#9100) · d80e1bc9
      cheme authored
      
      
      * childstate_getKeysPaged rpc
      
      * Rename `v` to `iter`.
      
      * Update client/api/src/backend.rs
      
      Co-authored-by: default avatarAlexander Popiak <[email protected]>
      
      * Update client/api/src/backend.rs
      
      Co-authored-by: default avatarAlexander Popiak <[email protected]>
      
      Co-authored-by: default avatarAlexander Popiak <[email protected]>
      d80e1bc9