Skip to content
  1. Apr 30, 2022
  2. Apr 29, 2022
    • Roman Proskuryakov's avatar
      Upgrade to libp2p 0.44.0 (#11009) · 887acda7
      Roman Proskuryakov authored
      * Update libp2p to 0.43.0, lru to 0.7.3
      
      * Fix websoket Incoming::Data
      
      * Rename ProtocolsHandler -> ConnectionHandler, remove inject_dis/connected, minor fixes
      
      * Fix args for inject_connection* callbacks
      
      * Fix DialPeer/DialAddress
      
      * Fix debug fmt
      
      * Add Endpoint to NetworkState
      
      * Fix Kad::get_record by key
      
      * Fix Sha2_256::digest
      
      * Fix IntoConnectionHandler
      
      * Fix borrowchk
      
      * Fix DialError::WrongPeerId
      
      * Remove NodeHandlerWrapperError
      
      * Fix KademliaEvent variants
      
      * Fix impl Add for String
      
      * Fix tabs in network_state
      
      * Apply cargo fmt
      
      * Fix a typo in req/resp
      
      * Fix tests
      
      * Fix peer_info:entry.info_expire
      
      * Fix PeerInfoBehaviour inject_address_change and inject_connection_closed
      
      * Patch libp2p to 0.44.0#6cc3b4e
      
      * Fix inject_connection_closed kad, req/resp
      
      * Apply cargo fmt
      
      * Use libp2p from crates.io
      
      * Fix review notes
      887acda7
  3. Apr 28, 2022
  4. Apr 27, 2022
    • Zeke Mostov's avatar
      Nomination Pools (#10694) · 247f33dc
      Zeke Mostov authored
      
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Add admin roles and make some calls permissionless
      
      * Destroy pool in withdraw unbonded
      
      * Add docs on pool admin
      
      * Fixup tests
      
      * Test unbond_other permissionless scenarios
      
      * Test withdraw unbonded permissionless
      
      * Test only can join open pools
      
      * Move unsafe set state to mock
      
      * Test: nominate_works
      
      * Add bounds: MinJoinBond, MinCreateBond, MaxPools
      
      * Test MinCreateBond, MinJoinBond, MaxPools
      
      * Add post checks to tests
      
      * Remove some TODOs
      
      * Setup weight infrastructure
      
      * Benchmark claim_payout
      
      * Benchmark create
      
      * Benchmark nominate
      
      * Benchmark join
      
      * Benchmark unbond_other
      
      * Refactor join benchmark to use scenario setup
      
      * Clean up and address warnings
      
      * Basic withdraw unbonded benchmarks
      
      * Refactor nominate benchmark
      
      * Refactor claim payout
      
      * Add feature sp-staking/runtime-benchmarks
      
      * Get node runtime to compile
      
      * Get node to run
      
      * Make claim_payout bench work with node
      
      * Make pool_withdraw_unbonded bench work with node
      
      * Make withdraw_unbonded_other work with node runtime'
      
      * Make create benchmark work with node
      
      * Make nominate benchmark work with node runtime
      
      * WiP new benchmark crate
      
      * Implement initial mock for benchmarks
      
      * Establish benchmark setup logic
      
      * Get claim payout and nominate benchmarks working
      
      * Remove pool bench utils; make struct fields pub insteaad
      
      * Get more benchmarks to work; trim interface trait
      
      * Some more top level docs
      
      * Finish tranistion benchmarks to crate
      
      * Hook up benchmark pallet to node runtime
      
      * Get benches to work with node runtime
      
      * cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_nomination_pools --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/nomination-pools/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Benchmark withdraw_unbonded_other_kill
      
      * Delete old benchmarking files
      
      * Refunds for withdraw_unbonded
      
      * Remove some TODOs
      
      * 'Don't return an option for the current_era'
      
      * Streamline extrinsic docs
      
      * small docs tweaks
      
      * Refactor ledger::slash
      
      * Add on_slash impl for nomination pools
      
      * slash refactor wip
      
      * WIP slash working
      
      * DRY Ledger::stash
      
      * Fix slash saturation
      
      * Remove unused param from slash
      
      * Docs and warnings
      
      * Test ledger::slash
      
      * save progress
      
      * Introduce counter for delegators
      
      * Add tests for max delegator errors
      
      * Reproducible account ids
      
      * Adapt tests to new account id format
      
      * Simplify create_accounts api
      
      * Fix staking tests
      
      * Save PerBill slash impl before removing
      
      * Rever ledger slash test
      
      * Get node runtime to work
      
      * Organize sub pools by unbond era, not curren era
      
      * staking: Proportional ledger slashing
      
      * Some comment cleanup
      
      * Add more test post checks
      
      * Update frame/staking/src/pallet/mod.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Tests: account for storing unbond era
      
      * Improve docs for staking interface
      
      * Add events Created, Destroyed
      
      * withdraw_unbonded: Remove useless withdraw dust check
      
      * Test: withdraw_unbonded_other_handles_faulty_sub_pool_accounting
      
      * Add extrinsics: set_state_other, set_metadata
      
      * Test: set_state_other_works
      
      * Test: set_metadata_works
      
      * Add benchmarks for set_state_other, set_metadata
      
      * Fix benchmarks
      
      * Add weight info for new extrinsics
      
      * Some feedback
      
      * duo feedback
      
      * Incorporate some more feedback
      
      * integrate more kian feedback
      
      * integrate more kian feedback
      
      * More improvements
      
      * Add destroying_mul
      
      * Make do_reward_payout take refs
      
      * Remove some TODOs
      
      * Add test for saturating
      
      * feedback
      
      * Fix join test
      
      * use `inner` for nested types in nomination pools (#11030)
      
      * Use nested inner type for pool
      
      * make tests and benchmarks work
      
      * remove feat
      
      * all tests work now
      
      * fix node-runtime
      
      * nomination-pools: update benches for new account format (#11033)
      
      * Update benches to new account format
      
      * More sensible seeds
      
      * bring back rward account sanity check
      
      * Comment
      
      * Add extrinsic set_configs (#11038)
      
      * Better sanity checks for nomination pools  (#11042)
      
      * new sanity checks, few other changes
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * nomination-pools: Fix state event regression + benches (#11045)
      
      * new sanity checks, few other changes
      
      * Fix benches, improve sanity check
      
      * Remove useless clear storage in benchmarking
      
      * Set state
      
      * Save
      
      * Doc
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarkianenigma <[email protected]>
      
      * FMT
      
      * Try fill in all staking configs
      
      * Fix build
      
      * More changes to nomination pools (#11050)
      
      * new sanity checks, few other changes
      
      * some last touches as a whole
      
      * Apply suggestions from code review
      
      * Remove redundant event
      
      * Improve unbond_other error handling
      
      * Remove comment
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      Co-authored-by: default avataremostov <[email protected]>
      
      * Remove sanity module and some TODOs
      
      * round of feedback and imp from kian
      
      * Add TODO for ED QoL at reward pool creation
      
      * Make sure reward pool never gets dusted
      
      * Improve error type
      
      * demonstrate per_thing usage
      
      * Update sanity check & fix create_works
      
      * Improve test ext pool creation & fix some more tests
      
      * Try revert
      
      * Revert "Try revert"
      
      This reverts commit c044c94730e1a370eecd8f5b2c4f632835913063.
      
      * Revert "Improve test ext pool creation & fix some more tests"
      
      This reverts commit 1e862a64a7423479260c6e5ad1bd4c8c95651f3a.
      
      * Revert "Update sanity check & fix create_works"
      
      This reverts commit 568a7b727687e4d585e2796afc638df97b83c632.
      
      Roll back reward account funding
      
      * Revert "Improve error type"
      
      This reverts commit 4b993ee601a037e7a44e4a49bbfd60cf45b38b78.
      
      * Revert "Make sure reward pool never gets dusted"
      
      This reverts commit e7a3eb45bdfd156d3f6d94d194e988032ebbc593.
      
      revert
      
      * Update some tests
      
      * FMT
      
      * Test that era offset works correctly
      
      * Update mocks
      
      * Remove unnescary docs
      
      * Doc updates
      
      * Update calculate_delegator_payout_works_with_a_pool_of_1
      
      * Fix test: claim_payout_works
      
      * do_reward_payout_correctly_sets_pool_state_to_destroying
      
      * Remove test do_reward_payout_errors_correctly
      
      * Fix test: do_reward_payout_works
      
      * Fix test: create_errors_correctly
      
      * Fix test: create works
      
      * Fix test: unbond_other_of_3_works
      
      * Ensure that ED is transferred into reward pool upon creation
      
      * WIP pool lifecycle test
      
      * Fix benchmarks
      
      * Add sanity check for ED + reward pools
      
      * `bond_extra` for nomination pools (#11100)
      
      * bond_extra for nomination pools
      
      * Update frame/nomination-pools/src/lib.rs
      
      * Update frame/nomination-pools/src/lib.rs
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * add benchmarks
      
      * remove the min logic of bond_extra
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * FMT
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * make it compile end to end
      
      * Update some type viz
      
      * Update kick terminology
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      * Cache bonded account when creating pool
      
      * Add bond extra weight stuff
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update docs for pool withdraw unbonded
      
      * Update docs for unbond
      
      * Improve Doc
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update frame/nomination-pools/Cargo.toml
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Improve Docs
      
      * Some docs improvements
      
      * fmt
      
      * Remove unlock_era
      
      * Fix accidental frame-support regression
      
      * Fix issue with transactions in tests
      
      * Fix doc links
      
      * Make sure result in test is used
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Fix can toggle state
      
      * Account for new_funds in ok to be open
      
      * Update docs: ok_to_withdraw_unbonded_other_with
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Remove some staking comments
      
      * Rename SubPoolsWithEra to UnbondingPoolsWithEra
      
      * Use validators length for benchmarks
      
      * Use metadata length for benchmarks
      
      * Remove debug assert eq
      
      * docs
      
      * Fix test: withdraw_unbonded_other_errors_correctly
      
      * Fix check for having enough balance to create the pool
      
      * Bond event for pool creation
      
      * Ok to be open
      
      * FMT
      
      * Remove _other postfix
      
      * Update frame/staking/src/lib.rs
      
      * Adjust tests to account for only remove when < ED
      
      * Remove stale TODOs
      
      * Remove dupe test
      
      * Fix build
      
      * Make sure to convert to u256 so we don't saturate
      
      * Refund depositor with reward pool fee
      
      * FMT
      
      * Remove reachable defensive
      
      * Use compact encoding for relevant extrinsics
      
      * Remove unnescary make_free_be for cleaning reward account
      
      * Add not to maintainers for reward account accounting
      
      * Remove note to maintainers from public doc
      
      * Make sure all configs have currency balance
      
      * Avoid saturation in balance_to_unbond
      
      * Partial Unbonding for Nomination Pools (#11212)
      
      * first draft of partial unbonding for pools
      
      * remove option
      
      * Add some more tests and fix issues
      
      * Fix all tests
      
      * simplify some tests
      
      * Update frame/nomination-pools/src/mock.rs
      
      * remove clone
      
      * rename to delegator_unbonding_eras
      
      * Update frame/nomination-pools/src/tests.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update frame/nomination-pools/src/tests.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update frame/nomination-pools/src/tests.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * remove pub
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * undo
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * leftovers
      
      * fix invariant
      
      * Fix the depositor assumption
      
      * round of self-review
      
      * little bit more cleanup
      
      * Update frame/nomination-pools/src/mock.rs
      
      * Apply suggestions from code review
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Fix interpretation of MinCreateBond
      
      * controvesial refactor
      
      * rename
      
      * make everything build
      
      * add TODO about killing the reward account
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      * last self-review
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update Cargo.lock
      
      * Rename Delegator to PoolMember
      
      * fmt
      
      * Get runtime to build with runtime-benchmarks feature
      
      * Update Cargo.lock
      
      * Fix asserts to work in more scenarios
      
      * gte not gt
      
      * cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_nomination_pools --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/nomination-pools/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Update frame/staking/src/mock.rs
      
      * Update frame/nomination-pools/src/lib.rs
      
      * Update frame/staking/src/slashing.rs
      
      * Apply suggestions from code review
      
      * fmt
      
      * Fix some tests
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: default avatarParity Bot <[email protected]>
      Co-authored-by: default avatarkianenigma <[email protected]>
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      247f33dc
  5. Apr 26, 2022
  6. Apr 22, 2022
  7. Apr 21, 2022
  8. Apr 20, 2022
  9. Apr 19, 2022
  10. Apr 15, 2022
    • Georges's avatar
      Adding benchmarking for new `frame_election_provider_support` (#11149) · ae75a371
      Georges authored
      * First stab at adding benchmarking for
      `election-provider-support` onchain
      
      * Adding `BoundedPhragMMS` and fixing stuff
      
      * Fixing node runtime
      
      * Fixing tests
      
      * Finalising all benchmarking stuff
      
      * better comments
      
      * Better benchmarking config
      
      * Better `WeightInfo` and benchmarking
      
      * Fixing tests
      
      * Adding some documentation
      
      * Fixing some typos
      
      * Incorporating review feedback
      
      * cleanup of rustdocs
      
      * rustdoc changes
      
      * changes after code review
      
      * Fixing some errors.
      
      * Fixing dependencies post merge
      
      * Bringing back `UnboundedExecution`
      
      * Better rustdoc and naming
      
      * Cargo.toml formatting
      ae75a371
  11. Apr 14, 2022
  12. Apr 13, 2022
    • Adrian Catangiu's avatar
      Expose MMR root through runtime API - use it in BEEFY client (#11183) · 80ce5c57
      Adrian Catangiu authored
      * beefy-gadget: allow custom runtime api provider
      
      * beefy-gadget: use mock runtime api in tests
      
      * pallet-mmr: expose mmr root from state through runtime API
      
      * beefy-gadget: get mmr root from runtime state
      
      * pallet-beefy-mmr: remove MmrRoot from header digests
      
      * frame/mmr: move mmr primitives out of frame
      
      * frame/mmr: completely move primitives out of frame
      
      * address review comments
      
      * beefy-mmr: bring back mmr root from header digest
      
      * clippy fixes for rustc 1.60
      
      * address review comments
      80ce5c57
  13. Apr 12, 2022
    • Bastian Köcher's avatar
      Finality notification: Optimize calculation of stale heads (#11200) · cc4b5c48
      Bastian Köcher authored
      
      
      * Finality notification: Optimize calculation of stale heads
      
      While looking into some problem on Versi where a collator seemed to be stuck. I found out that it
      was not stuck but there was a huge gap between last finalized and best block. This lead to a lot
      leaves and it was basically trapped inside some loop of reading block headers from the db to find
      the stale heads. While looking into this I found out that `leaves` already supports the feature to
      give us the stale heads relative easily. However, the semantics change a little bit. Instead of
      returning all stale heads of blocks that are not reachable anymore after finalizing a block, we
      currently only return heads with a number lower than the finalized block. This should be no problem,
      because these other leaves that are stale will be returned later when a block gets finalized which
      number is bigger than the block number of these leaves.
      
      While doing that, I also changed `tree_route` of the `FinalityNotification` to include the
      `old_finalized`. Based on the comment I assumed that this was already part of it. However, if
      wanted, I can revert this change.
      
      * FMT
      
      * Update client/service/src/client/client.rs
      
      Co-authored-by: default avatarAndré Silva <[email protected]>
      
      * Do not include the last finalized block
      
      * Rename function
      
      * FMT
      
      * Fix tests
      
      * Update figure
      
      Co-authored-by: default avatarAndré Silva <[email protected]>
      cc4b5c48
  14. Apr 11, 2022
    • Bastian Köcher's avatar
      Prepare for rust stable 1.60 (#11138) · f517e57f
      Bastian Köcher authored
      
      
      * Prepare for rust stable 1.59
      
      Besides preparing the UI tests this also adds a new script update-rust-stable.sh script for
      simplifying the update of a rust stable version. This script will run all UI tests for the new
      rust stable version and updating the expected output.
      
      * Ensure we run the UI tests in CI
      
      * use staging ci image
      
      * More test updates
      
      * Unignore test (#11097)
      
      * empty commit for pipeline rerun
      
      * empty commit for pipeline rerun
      
      * Try to make clippy happy
      
      * More clippy fixes
      
      * FMT
      
      * ci image production
      
      Co-authored-by: default avataralvicsam <[email protected]>
      Co-authored-by: default avatarAlexander Samusev <[email protected]>
      f517e57f
  15. Apr 08, 2022
  16. Apr 07, 2022
  17. Apr 04, 2022
  18. Apr 03, 2022
  19. Apr 02, 2022
  20. Apr 01, 2022
  21. Mar 31, 2022
    • Georges's avatar
      Enforce `MaxEncodedLen` impl for `NposSolution` (#11103) · 0e0d0a67
      Georges authored
      * Fail if `MaxVoters` too small
      
      * Fixing benchmarking test, better naming of error
      
      * reverting accidental change
      
      * use fully qualified syntax
      no need to interate to calculate len
      
      * Fail directly if too many voters
      0e0d0a67
  22. Mar 29, 2022
  23. Mar 27, 2022
  24. Mar 25, 2022
    • Adrian Catangiu's avatar
      Implement Lean BEEFY (#10882) · 498e8c18
      Adrian Catangiu authored
      
      
      Simplified BEEFY worker logic based on the invariant that GRANDPA
      will always finalize 1st block of each new session, meaning BEEFY
      worker is guaranteed to receive finality notification for the
      BEEFY mandatory blocks.
      
      Under these conditions the current design is as follows:
      - session changes are detected based on BEEFY Digest present in
        BEEFY mandatory blocks,
      - on each new session new `Rounds` of voting is created, with old
        rounds being dropped (for gossip rounds, last 3 are still alive
        so votes are still being gossiped),
      - after processing finality for a block, the worker votes if
        a new voting target has become available as a result of said
        block finality processing,
      - incoming votes as well as self-created votes are processed
        and signed commitments are created for completed BEEFY voting
        rounds,
      - the worker votes if a new voting target becomes available
        once a round successfully completes.
      
      On worker startup, the current validator set is retrieved from
      the BEEFY pallet. If it is the genesis validator set, worker
      starts voting right away considering Block #1 as session start.
      
      Otherwise (not genesis), the worker will vote starting with
      mandatory block of the next session.
      
      Later on when we add the BEEFY initial-sync (catch-up) logic,
      the worker will sync all past mandatory blocks Signed Commitments
      and will be able to start voting right away.
      
      BEEFY mandatory block is the block with header containing the BEEFY
      `AuthoritiesChange` Digest, this block is guaranteed to be finalized
      by GRANDPA.
      
      This session-boundary block is signed by the ending-session's
      validator set. Next blocks will be signed by the new session's
      validator set. This behavior is consistent with what GRANDPA does
      as well.
      
      Also drop the limit N on active gossip rounds. In an adversarial
      network, a bad actor could create and gossip N invalid votes with
      round numbers larger than the current correct round number. This
      would lead to votes for correct rounds to no longer be gossiped.
      
      Add unit-tests for all components, including full voter consensus
      tests.
      
      Signed-off-by: default avatarAdrian Catangiu <[email protected]>
      Co-authored-by: default avatarTomasz Drwięga <[email protected]>
      Co-authored-by: David Salami <Wizdave97>
      498e8c18
  25. Mar 24, 2022
    • Keith Yeung's avatar
      Allow pallet error enum variants to contain fields (#10242) · 208be869
      Keith Yeung authored
      
      
      * Allow pallet errors to contain at most one field
      
      * Update docs on pallet::error
      
      * Reword documentation
      
      * cargo fmt
      
      * Introduce CompactPalletError trait and require #[pallet::error] fields to implement them
      
      * cargo fmt
      
      * Do not assume tuple variants
      
      * Add CompactPalletError derive macro
      
      * Check for error type compactness in construct_runtime
      
      * cargo fmt
      
      * Derive CompactPalletError instead of implementing it directly during macro expansion
      
      * Implement CompactPalletError on OptionBool instead of Option<bool>
      
      * Check for type idents instead of variant ident
      
      * Add doc comments for ErrorCompactnessTest
      
      * Add an trait implementation of ErrorCompactnessTest for ()
      
      * Convert the error field of DispatchError to a 4-element byte array
      
      * Add static check for pallet error size
      
      * Rename to MAX_PALLET_ERROR_ENCODED_SIZE
      
      * Remove ErrorCompactnessTest trait
      
      * Remove check_compactness
      
      * Return only the most significant byte when constructing a custom InvalidTransaction
      
      * Rename CompactPalletError to PalletError
      
      * Use counter to generate unique idents for assert macros
      
      * Make declarative pallet macros compile with pallet error size checks
      
      * Remove unused doc comment
      
      * Try and fix build errors
      
      * Fix build errors
      
      * Add macro_use for some test modules
      
      * Test fix
      
      * Fix compilation errors
      
      * Remove unneeded #[macro_use]
      
      * Resolve import ambiguity
      
      * Make path to pallet Error enum more specific
      
      * Fix test expectation
      
      * Disambiguate imports
      
      * Fix test expectations
      
      * Revert appending pallet module name to path
      
      * Rename bags_list::list::Error to BagError
      
      * Fixes
      
      * Fixes
      
      * Fixes
      
      * Fix test expectations
      
      * Fix test expectation
      
      * Add more implementations for PalletError
      
      * Lift the 1-field requirement for nested pallet errors
      
      * Fix UI test expectation
      
      * Remove PalletError impl for OptionBool
      
      * Use saturating operations
      
      * cargo fmt
      
      * Delete obsolete test
      
      * Fix test expectation
      
      * Try and use assert macro in const context
      
      * Pull out the pallet error size check macro
      
      * Fix UI test for const assertion
      
      * cargo fmt
      
      * Apply clippy suggestion
      
      * Fix doc comment
      
      * Docs for create_tt_return_macro
      
      * Ensure TryInto is imported in earlier Rust editions
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Fix up comments and names
      
      * Implement PalletError for Never
      
      * cargo fmt
      
      * Don't compile example code
      
      * Bump API version for block builder
      
      * Factor in codec attributes while derving PalletError
      
      * Rename module and fix unit test
      
      * Add missing attribute
      
      * Check API version and convert ApplyExtrinsicResult accordingly
      
      * Rename BagError to ListError
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Use codec crate re-exported from frame support
      
      * Add links to types mentioned in doc comments
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * cargo fmt
      
      * cargo fmt
      
      * Re-add attribute for hidden docs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarKian Paimani <[email protected]>
      208be869
  26. Mar 18, 2022
  27. Mar 16, 2022
    • Georges's avatar
      Moving `NposSolution` to frame (#11031) · 26a8c7e6
      Georges authored
      
      
      * Move `sp-npos-elections-solution-type`
      to `frame-election-provider-support`
      First stab at it, will need to amend some more stuff
      
      * Fixing tests
      
      * Fixing tests
      
      * Fixing cargo.toml for std configuration
      
      * fmt
      
      * Committing suggested changes
      renaming, and re exporting macro.
      
      * Removing unneeded imports
      
      * Move `NposSolution` to frame
      
      * Removing `npos_election` dependencies
      Implementing _fpes better
      
      * some feedback for moving NPoSSolution to frame
      
      * fmt
      
      * more formatting
      
      * Fixed some imports and fmt
      
      * Fixing docs
      
      Co-authored-by: default avatarkianenigma <[email protected]>
      26a8c7e6
    • Falco Hirschenberger's avatar
      Prevent possible rocksdb-corruption by running benchmark-storage (#11040) · 7a54efd1
      Falco Hirschenberger authored
      * Prevent possible rocksdb-corruption by running benchmark-storage
      
      Also adds a `sanitize_key` function to strip path-prefixes from the db-keys (for databases that
      use prefixed keys such as rocksdb)
      
      fixes #10998
      
      * Fix @cheme
      
       's annotations.
      
      * Update utils/frame/benchmarking-cli/src/storage/write.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Make logic match the name of bool flag `invert_inserts`
      
      * Remove unused lifetime
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      7a54efd1