Skip to content
Snippets Groups Projects
  1. Aug 10, 2023
  2. Aug 09, 2023
  3. Aug 08, 2023
  4. Aug 07, 2023
  5. Aug 05, 2023
  6. Aug 04, 2023
  7. Aug 03, 2023
  8. Aug 02, 2023
  9. Aug 01, 2023
  10. Jul 31, 2023
    • Marcin S.'s avatar
      98.6% OF DEVELOPERS CANNOT REVIEW THIS PR! [read more...] (#7337) · 85b06f18
      Marcin S. authored
      
      * [WIP] PVF: Split out worker binaries
      
      * Address compilation problems and re-design a bit
      
      * Reorganize once more, fix tests
      
      * Reformat with new nightly to make `cargo fmt` test happy
      
      * Address `clippy` warnings
      
      * Add temporary trace to debug zombienet tests
      
      * Fix zombienet node upgrade test
      
      * Fix malus and its CI
      
      * Fix building worker binaries with malus
      
      * More fixes for malus
      
      * Remove unneeded cli subcommands
      
      * Support placing auxiliary binaries to `/usr/libexec`
      
      * Fix spelling
      
      * Spelling
      
      Co-authored-by: default avatarMarcin S. <marcin@realemail.net>
      
      * Implement review comments (mostly nits)
      
      * Fix worker node version flag
      
      * Rework getting the worker paths
      
      * Address a couple of review comments
      
      * Minor restructuring
      
      * Fix CI error
      
      * Add tests for worker binaries detection
      
      * Improve tests; try to fix CI
      
      * Move workers module into separate file
      
      * Try to fix failing test and workers not printing latest version
      
      - Tests were not finding the worker binaries
      - Workers were not being rebuilt when the version changed
      - Made some errors easier to read
      
      * Make a bunch of fixes
      
      * Rebuild nodes on version change
      
      * Fix more issues
      
      * Fix tests
      
      * Pass node version from node into dependencies to avoid recompiles
      
      - [X] get version in CLI
      - [X] pass it in to service
      - [X] pass version along to PVF
      - [X] remove rerun from service
      - [X] add rerun to CLI
      
      - [X] don’t rerun pvf/worker’s (these should be built by nodes which have rerun enabled)
      
      * Some more improvements for smoother tests
      
      - [X] Fix tests
      - [X] Make puppet workers pass None for version and remove rerun
      - [X] Make test collators self-contained
      
      * Add back rerun to PVF workers
      
      * Move worker binaries into files in cli crate
      
      As a final optimization I've separated out each worker binary from its own crate
      into the CLI crate. Before, the worker bin shared a crate with the worker lib,
      so when the binaries got recompiled so did the libs and everything transitively
      depending on the libs. This commit fixes this regression that was causing
      recompiles after every commit.
      
      * Fix bug (was passing worker version for node version)
      
      * Move workers out of cli into root src/bin/ dir
      
      - [X] Pass in node version from top-level (polkadot)
      - [X] Add build.rs with rerun-git-head to root dir
      
      * Add some sanity checks for workers to dockerfiles
      
      * Update malus
      
        + [X] Make it self-contained
        + [X] Undo multiple binary changes
      
      * Try to fix clippy errors
      
      * Address `cargo run` issue
      
      - [X] Add default-run for polkadot
      - [X] Add note about installation to error
      
      * Update readme (installation instructions)
      
      * Allow disabling external workers for local/testing setups
      
        + [X] cli flag to enable single-binary mode
        + [X] Add message to error
      
      * Revert unnecessary Cargo.lock changes
      
      * Remove unnecessary build scripts from collators
      
      * Add back missing malus commands (should fix failing ZN job)
      
      * Some minor fixes
      
      * Update Cargo.lock
      
      * Fix some build errors
      
      * Undo self-contained binaries; cli flag to disable version check
      
        + [X] Remove --dont-run-external-workers
        + [X] Add --disable-worker-version-check
        + [X] Remove PVF subcommands
        + [X] Redo malus changes
      
      * Try to fix failing job and add some docs for local tests
      
      ---------
      
      Co-authored-by: default avatarDmitry Sinyavin <dmitry.sinyavin@parity.io>
      Co-authored-by: default avatars0me0ne-unkn0wn <48632512+s0me0ne-unkn0wn@users.noreply.github.com>
      Co-authored-by: parity-processbot <>
      85b06f18
  11. Jul 28, 2023
  12. Jul 27, 2023
  13. Jul 25, 2023
  14. Jul 24, 2023
  15. Jul 22, 2023
    • Xiliang Chen's avatar
      add missing feature flag (#7537) · 79341dd4
      Xiliang Chen authored
      79341dd4
    • jserrat's avatar
      add tests to worker common thread (#7372) · 3f8c3454
      jserrat authored
      
      * add tests to worker common thread
      
      * fix formatting
      
      * move worker commons unit test from integration tests to worker file and do some improvements
      
      * fix import on it/worker_common
      
      * move worker commons unit test to test module
      
      * cargo fmt
      
      * move cpu_time_monitor_loop to test outside of thread module
      
      * change worker thread unit test to use assert_eq
      
      * fix formatting
      
      * adding new methods to WaitOucome, fix pvf worker unit test
      
      * fix formatting
      
      * remove is_finished and is_timeout methods from WaitOutcome
      
      * fix wait_for_threads_with_timeout_returns_outcome test
      
      * ".git/.scripts/commands/fmt/fmt.sh"
      
      * add common worker cond_notify_on_done_should_update_wait_outcome_when_panic test
      
      ---------
      
      Co-authored-by: default avatarMarcin S <marcin@realemail.net>
      Co-authored-by: command-bot <>
      3f8c3454
  16. Jul 21, 2023
  17. Jul 20, 2023
  18. Jul 19, 2023
  19. Jul 18, 2023