- Nov 28, 2022
-
-
Andrei Sandu authored
* RollingSession: add fn contains Signed-off-by:
Andrei Sandu <[email protected]> * handle_import_statements fix ancient dispute check Signed-off-by:
-
Marcin S. authored -
Mattia L.V. Bradascio authored
* Add buckets below 5ms * Add more specific histogram buckets * Add more specific buckets * cargo fmt
-
- Nov 26, 2022
-
-
Sebastian Kunert authored
* Add option ot add outbound_only configurations * Improve comment
-
- Nov 24, 2022
-
-
tugy authored
* add wss and update dns * fix wrong node id
-
- Nov 23, 2022
-
-
eskimor authored
* We actually don't need to rate limit redundant requests. Those redundant requests should not actually happen, but still. * Add some logging. * Also log message when the receiving side hit the rate limit. * Update node/network/dispute-distribution/src/sender/mod.rs Co-authored-by:
Alexandru Vasile <[email protected]> Co-authored-by:
eskimor <[email protected]> Co-authored-by:
-
Marcin S. authored
* Add PVF module documentation TODO (once the PRs land): - [ ] Document executor parametrization. - [ ] Document CPU time measurement of timeouts. * Update node/core/pvf/src/lib.rs Co-authored-by:
Andrei Sandu <[email protected]> * Clarify meaning of PVF acronym * Move PVF doc to implementer's guide * Clean up implementer's guide a bit * Add page for PVF types * pvf: Better separation between crate docs and implementer's guide * ci: Add "prevalidating" to the dictionary * ig: Remove types/chain.md The types contained therein did not exist and the file was not referenced anywhere. Co-authored-by:
-
- Nov 18, 2022
-
-
Koute authored
* Remove the `wasmtime` feature flag * Update `substrate` to the newest `master` * Update `substrate` to the newest `master`
-
- Nov 17, 2022
-
-
Tsvetomir Dimitrov authored
* Change best effort queue behaviour in `dispute-coordinator` Use the same type of queue (`BTreeMap<CandidateComparator, ParticipationRequest>`) for best effort and priority in `dispute-coordinator`. Rework `CandidateComparator` to handle unavailable parent block numbers. Best effort queue will order disputes the same way as priority does - by parent's block height. Disputes on candidates for which the parent's block number can't be obtained will be treated with the lowest priority. * Fix tests: Handle `ChainApiMessage::BlockNumber` in `handle_sync_queries` * Some tests are deadlocking on sending messages via overseer so change `SingleItemSink`to `mpsc::Sender` with a buffer of 1 * Fix a race in test after adding a buffered queue for overseer messages * Fix the rest of the tests * Guide update - best-effort queue * Guide update: clarification about spam votes * Fix tests in `availability-distribution` * Update comments * Add `make_buffered_subsystem_context` in `subsystem-test-helpers` * Code review feedback * Code review feedback * Code review feedback * Don't add best effort candidate if it is already in priority queue * Remove an old comment * Fix insert in best_effort
-
Andrei Sandu authored
Signed-off-by:
-
Kutsal Kaan Bilgin authored
-
- Nov 16, 2022
-
-
Tsvetomir Dimitrov authored
* Fix typos * Filter unconfirmed disputes in provisioner - random_selection * Rework dispute coordinator to return `DisputeStatus` with `ActiveDisputes` message. * Rework the random_selection implementation of `select_disptues` in `provisioner` to return only confirmed disputes. * Filter unconfirmed disputes in provisioner - prioritized_selection * Add test for unconfirmed disputes handling * Fix `dispute-distribution` tests
-
- Nov 15, 2022
-
-
Marcin S. authored
Was seeing these warnings when running `cargo check --all`: ``` warning: for loop over an `Option`. This is more readably written as an `if let` statement --> node/core/approval-voting/src/lib.rs:1147:21 | 1147 | for activated in update.activated { | ^^^^^^^^^^^^^^^^ | = note: `#[warn(for_loops_over_fallibles)]` on by default help: to check pattern in a loop use `while let` | 1147 | while let Some(activated) = update.activated { | ~~~~~~~~~~~~~~~ ~~~ help: consider using `if let` to clear intent | 1147 | if let Some(activated) = update.activated { | ~~~~~~~~~~~~ ~~~ ``` My guess is that `activated` used to be a SmallVec or similar, as is `deactivated`. It was changed to an `Option`, the `for` still compiled (it's technically correct, just weird), and the compiler didn't catch it until now. -
eskimor authored
Co-authored-by:
-
- Nov 14, 2022
-
-
eskimor authored
* Only report concluded if there is an actual dispute. Hence no "non"-disputes will be added to disputes anymore. * Fix redundant check. * Test for no onesided disputes. Co-authored-by:
-
- Nov 12, 2022
-
-
ordian authored
* approval-voting: remove a redundant check * candidate-validation: remove unreachable check
-
- Nov 11, 2022
-
-
Tsvetomir Dimitrov authored
* Scraper processes CandidateBacked events * Change definition of best-effort * Fix `dispute-coordinator` tests * Unit test for dispute filtering * Clarification comment * Add tests * Fix logic If a dispute is not backed, not included and not confirmed we don't participate but we do import votes. * Add metrics for refrained participations * Revert "Add tests" This reverts commit 7b8391a087922ced942cde9cd2b50ff3f633efc0. * Revert "Unit test for dispute filtering" This reverts commit 92ba5fe678214ab360306313a33c781338e600a0. * fix dispute-coordinator tests * Fix scraping * new tests * Small fixes in guide * Apply suggestions from code review Co-authored-by:
-
- Nov 08, 2022
-
-
Marcin S. authored
* Fix a couple of typos * Retry failed PVF execution PVF execution that fails due to AmbiguousWorkerDeath should be retried once. This should reduce the occurrence of failures due to transient conditions. Closes #6195 * Address a couple of nits * Write tests; refactor (add `validate_candidate_with_retry`) * Update node/core/candidate-validation/src/lib.rs Co-authored-by:
Andronik <[email protected]> Co-authored-by:
eskimor <[email protected]> Co-authored-by:
-
Andrei Sandu authored
* Impl dynamic window size. Keep sessions for unfinalized chain Signed-off-by:
-
Marcin S. authored
-
- Nov 07, 2022
-
-
Michal Kucharczyk authored* BlockId removal: &Hash to Hash It changes &Block::Hash argument to Block::Hash. This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292) * missing file corrected * update lockfile for {"substrate"} Co-authored-by: parity-processbot <> -
Alexander Samusev authored
* Pipeline with ci image with rust 1.65 * fix a warning * return production image Co-authored-by:
-
- Nov 04, 2022
-
-
Tom authored
* add stake.plus bootnodes * add stake.plus bootnodes for westend, kusama and polkadot Co-authored-by:senseless <[email protected]> Co-authored-by: parity-processbot <>
-
- Nov 03, 2022
-
-
Michal Kucharczyk authored
* BlockId removal: refactor: Backend::block_indexed_body It changes the arguments of `Backend::block_indexed_body` method from: `BlockId<Block>` to: `&Block::Hash` This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292) * update lockfile for {"substrate"} Co-authored-by: parity-processbot <>
-
- Nov 02, 2022
-
-
Michal Kucharczyk authored
* BlockId removal: refactor: Backend::justifications It changes the arguments of `Backend::justifications` method from: `BlockId<Block>` to: `&Block::Hash` This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292) * formatting * update lockfile for {"substrate"} Co-authored-by: parity-processbot <>
-
- Nov 01, 2022
-
-
alexgparity authored
* Replace parachain/parathread boolean by enum * Address PR comments * Update dependencies * ParaType -> ParaKind * Swap enum field order to avoid migration * Rename paratype field to parakind * Manual en-/decocing of Parakind * Manual TypeInfo for ParaKind * rename field back to parachain * minor * Update runtime/parachains/src/paras/mod.rs Co-authored-by:
-
Michal Kucharczyk authored
* BlockId removal: refactor: BlockBackend::block_body It changes the arguments of `BlockBackend::block_body` method from: `BlockId<Block>` to: `&Block::Hash` This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292) * update lockfile for {"substrate"} Co-authored-by: parity-processbot <> -
Marcin S. authored
* Rename timeout consts and timeout parameter; bump leniency * Update implementor's guide with info about PVFs * Make glossary a bit easier to read * Add a note to LENIENT_PREPARATION_TIMEOUT * Remove PVF-specific section from glossary * Fix some typos
-
- Oct 31, 2022
-
-
Andrei Sandu authored
* Add approval voting db sanity check Signed-off-by:
-
- Oct 26, 2022
-
-
Marcin S. authored
* Log exit status code for workers * Make log for execute job conclusion match prepare job conclusion Trace log for conclusion of prepare job: ```rs gum::debug!( target: LOG_TARGET, validation_code_hash = ?artifact_id.code_hash, ?worker, ?rip, "prepare worker concluded", ); ``` Co-authored-by: parity-processbot <>
-
- Oct 22, 2022
-
-
Boluwatife Bakre authored
* Fix for issue #2403 * Nightly fmt * Quick documentation fixes * Default Implementation * iter() function integrated * Implemented iter functionalities * Fmt * small change * updates node-network * updates in dispute-coordinator * Updates * benchmarking fix * minor fix * test fixes in runtime api * Update primitives/src/v2/mod.rs Co-authored-by:
-
Mara Broda authored
* Bump spec_version to 9310 * bump transaction_version (0.9.31) (#6171) * Bump transaction_version for polkadot * Bump transaction_version for kusama * Bump transaction_version for rococo * Bump transaction_version for westend * Bump transaction_version for polkadot * Bump transaction_version for kusama * Bump transaction_version for rococo * Bump transaction_version for westend * Bump crate versions (0.9.31)
-
- Oct 18, 2022
-
-
Michal Kucharczyk authored
* BlockId removal: refactor: StorageProvider It changes the arguments of `Backend::StorageProvider` trait from: block: `BlockId<Block>` to: hash: `&Block::Hash` * Update node/client/src/lib.rs Co-authored-by:
Bastian Köcher <[email protected]> * update lockfile for {"substrate"} Co-authored-by:
-
ordian authored
* availability-recovery: use `IfDisconnected::TryConnect` for chunks * fix tests
-
Sebastian Kunert authored
* Move clap to 4.0.9 * Remove "deprecated" feature flag * Convert to default_value_t * update lockfile for {"substrate"} * Add group(skip) to avoid naming conflict * More group(skip) Co-authored-by: parity-processbot <>
-
- Oct 13, 2022
-
-
Javier Viola authored
* bump version * make test required * change zombienet version * change zombienet version * bump version and typo * typo and add within
-
Sergej Sakac authored
* pallet-mmr: RPC API works with block numbers * small fix * update * change types * update lockfile for {"substrate"} Co-authored-by: parity-processbot <> -
Marcin S. authored
* Add some documentation * Add `compilation_timeout` parameter for PVF preparation job * Update buckets in prometheus metrics * Update prepare/queue tests * Update pvf-prechecking overview in implementer docs * Fix some CI checks
-
Mattia L.V. Bradascio authored
* Malus: add disputed block percentage * Bump clap to support value_parser with range * Add rand crate and use Bernoulli and Distribution * Add conditional logic based on sampled value from Bernoulli distribution * Add SuggestGarbageCandidateOptions struct * Cleanup tests * * Replace unwrap with expect and meaningful error message * * Remove Inner * Remove intercept_outgoing * * Rename sampled variable * Move info! logs to include candidate hash of malicious candidate * * Add percentage option to dispute_ancestor * * Support static probability for `ReplaceValidationResult` proxy * Update some comments and docs * * Add `--percentage` to `back-garbage-candidate` variant * Rename structs for consistency * * Add probabilistic behavior to `dispute-ancestor` variant * Add probabilistic behavior to `back-garbage-candidate` variant * Rename structs in dispute variant * * More descriptive comments * * cargo +nightly fmt --all * * Move Bernoulli distributrion to ReplaceValidationResult constructor * Rename random_bool to behave_maliciously * * Remove dangling comment * * Consistent log * * Add logs based on sampled value * * Cargo +nightly fmt --all * * Remove unused percentage attributed after moving Bernoulli to constructor * Squashed commit of the following: commit e4361b6d Author: Chris Sosnin <[email protected]> Date: Mon Oct 10 10:06:44 2022 +0400 Fix flaky test (#6131) * Split test + decrease test timeout * fmt * spellcheck commit f614752c Author: girazoki <[email protected]> Date: Mon Oct 10 06:39:30 2022 +0200 Add event to asset claim (#6029) commit 71197818 Author: Leszek Wiesner <[email protected]> Date: Mon Oct 10 00:23:54 2022 +0200 Companion for 12109 (#5929) * Update following `pallet-vesting` configurable `WithdrawReasons` * Update lib.rs * Update lib.rs * Update lib.rs * update lockfile for {"substrate"} * fix warning Co-authored-by:
Shawn Tabrizi <[email protected]> Co-authored-by: parity-processbot <> commit 60735044 Author: Bastian Köcher <[email protected]> Date: Fri Oct 7 13:40:40 2022 +0200 Companion for upgrading pin-project (#6118) * Companion for upgrading pin-project This will remove some warnings with the latest rustc nightly/stable. https://github.com/paritytech/substrate/pull/12426 * update lockfile for {"substrate"} Co-authored-by: parity-processbot <> commit c8151aed Author: Sergej Sakac <[email protected]> Date: Thu Oct 6 19:20:58 2022 +0200 Maximum value for `MultiplierUpdate` (#6021) * update multiplier * fix * update lockfile for {"substrate"} * fmt * fix typo Co-authored-by: parity-processbot <> commit 8d1c16dc Author: Adrian Catangiu <[email protected]> Date: Thu Oct 6 12:58:39 2022 +0300 service: use MmrRootProvider as custom BEEFY payload provider (companion for 12428) (#6112) * service: use MmrRootProvider as custom BEEFY payload provider * update lockfile for {"substrate"} Co-authored-by: parity-processbot <> commit 910e2184 Author: Branislav Kontur <[email protected]> Date: Thu Oct 6 10:03:34 2022 +0200 Skip `unexpected metric type` * Dump more info for `unexpected metric type` * Skip `unexpected metric type` commit af6a5cd9 Author: Andronik <[email protected]> Date: Thu Oct 6 00:36:51 2022 +0200 update kvdb & co (#6111) * toml changes * REVERTME: patch * adapt parachains db interface * fix Cargo.toml patch after master rebase * fix av-store * fix chain-selection * fix parachains-db? * Revert "fix Cargo.toml patch after master rebase" This reverts commit 3afcbf033c86027b3f2b909d83ec703591bdd287. * Revert "REVERTME: patch" This reverts commit 464b717cf4142d3d09c3d77b83700b632d8c5f54. * Use `Ok` imported from prelude Co-authored-by:
Oliver Tale-Yazdi <[email protected]> * Resolve merges Signed-off-by:
Roman Useinov <[email protected]> commit 4aea71a9 Author: Alexander Theißen <[email protected]> Date: Wed Oct 5 15:15:07 2022 +0200 Pass through `runtime-benchmark` feature (#6110) commit 42c043d7 Author: Keith Yeung <[email protected]> Date: Wed Oct 5 17:47:15 2022 +0800 Properly migrate weights to v2 (#6091) * Create migration for config pallet * Use XcmWeight in XCM pallet extrinsics * Link to PR in doc comment * cargo fmt * Fix tests * Fix tests * Remove unused import * Update runtime/parachains/src/configuration/migration.rs Co-authored-by:
Tsvetomir Dimitrov <[email protected]> * Update roadmap/implementers-guide/src/node/disputes/dispute-distribution.md Co-authored-by:
dependabot[bot] <[email protected]> * Change `LruCache` paramerter to `NonZeroUsize` * Change type of `session_cache_lru_size` to `NonZeroUsize` * Add expects instead of unwrap Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by:
Sebastian Kunert <[email protected]> Co-authored-by:
Alexander Samusev <[email protected]> * Revert "Squashed commit of the following:" This reverts commit 5001fa5d1dcd366029d156f81c40b99ca29d8f77. * * Remove unused imports * * cargo +nightly fmt --all * Make tweaks based on PR comments * unit test related to gum formatting * cargo +nightly fmt --all * Resolve merge conflicts * cargo +nightly fmt --all * Fix tests so they use cli rather than cmd * CI unused import check fix * Move info! log to startup * make info log more comprehensible Signed-off-by:
Serban Iorga <[email protected]> Co-authored-by:
Chris Sosnin <[email protected]> Co-authored-by:
Keith Yeung <[email protected]> Co-authored-by:
Alexander Theißen <[email protected]> Co-authored-by:
Gavin Wood <[email protected]> Co-authored-by:
Branislav Kontur <[email protected]> Co-authored-by:
Adrian Catangiu <[email protected]> Co-authored-by:
Sergej Sakac <[email protected]> Co-authored-by:
Leszek Wiesner <[email protected]> Co-authored-by:
girazoki <[email protected]> Co-authored-by:
-
- Oct 12, 2022
-
-
asynchronous rob authored
* refactor grid topology to expose more info to subsystems * fix grid_topology test * fix overseer test * Update node/network/protocol/src/grid_topology.rs Co-authored-by:
Vsevolod Stakhov <[email protected]> * Update node/network/protocol/src/grid_topology.rs Co-authored-by:
-
