Commit b3532393 authored by Mattia L.V. Bradascio's avatar Mattia L.V. Bradascio Committed by GitHub
Browse files

Malus: add disputed block percentage (#6100)

* Malus: add disputed block percentage

* Bump clap to support value_parser with range

* Add rand crate and use Bernoulli and Distribution

* Add conditional logic based on sampled value from Bernoulli distribution

* Add SuggestGarbageCandidateOptions struct

* Cleanup tests

* * Replace unwrap with expect and meaningful error message

* * Remove Inner
* Remove intercept_outgoing

* * Rename sampled variable
* Move info! logs to include candidate hash of malicious candidate

* * Add percentage option to dispute_ancestor

* * Support static probability for `ReplaceValidationResult` proxy
* Update some comments and docs

* * Add `--percentage` to `back-garbage-candidate` variant
* Rename structs for consistency

* * Add probabilistic behavior to `dispute-ancestor` variant
* Add probabilistic behavior to `back-garbage-candidate` variant
* Rename structs in dispute variant

* * More descriptive comments

* * cargo +nightly fmt --all

* * Move Bernoulli distributrion to ReplaceValidationResult constructor

* Rename random_bool to behave_maliciously

* * Remove dangling comment

* * Consistent log

* * Add logs based on sampled value

* * Cargo +nightly fmt --all

* * Remove unused percentage attributed after moving Bernoulli to constructor

* Squashed commit of the following:

commit e4361b6d
Author: Chris Sosnin <[email protected]>
Date:   Mon Oct 10 10:06:44 2022 +0400

    Fix flaky test (#6131)

    * Split test + decrease test timeout

    * fmt

    * spellcheck

commit f614752c
Author: girazoki <[email protected]>
Date:   Mon Oct 10 06:39:30 2022 +0200

    Add event to asset claim (#6029)

commit 71197818


Author: Leszek Wiesner <[email protected]>
Date:   Mon Oct 10 00:23:54 2022 +0200

    Companion for 12109 (#5929)

    * Update following `pallet-vesting` configurable `WithdrawReasons`

    * Update lib.rs

    * Update lib.rs

    * Update lib.rs

    * update lockfile for {"substrate"}

    * fix warning

Co-authored-by: default avatarShawn Tabrizi <[email protected]>
    Co-authored-by: parity-processbot <>

commit 60735044
Author: Bastian Köcher <[email protected]>
Date:   Fri Oct 7 13:40:40 2022 +0200

    Companion for upgrading pin-project (#6118)

    * Companion for upgrading pin-project

    This will remove some warnings with the latest rustc nightly/stable.

    https://github.com/paritytech/substrate/pull/12426

    * update lockfile for {"substrate"}

    Co-authored-by: parity-processbot <>

commit c8151aed
Author: Sergej Sakac <[email protected]>
Date:   Thu Oct 6 19:20:58 2022 +0200

    Maximum value for `MultiplierUpdate` (#6021)

    * update multiplier

    * fix

    * update lockfile for {"substrate"}

    * fmt

    * fix typo

    Co-authored-by: parity-processbot <>

commit 8d1c16dc
Author: Adrian Catangiu <[email protected]>
Date:   Thu Oct 6 12:58:39 2022 +0300

    service: use MmrRootProvider as custom BEEFY payload provider (companion for 12428) (#6112)

    * service: use MmrRootProvider as custom BEEFY payload provider

    * update lockfile for {"substrate"}

    Co-authored-by: parity-processbot <>

commit 910e2184
Author: Branislav Kontur <[email protected]>
Date:   Thu Oct 6 10:03:34 2022 +0200

    Skip `unexpected metric type`

    * Dump more info for `unexpected metric type`

    * Skip `unexpected metric type`

commit af6a5cd9


Author: Andronik <[email protected]>
Date:   Thu Oct 6 00:36:51 2022 +0200

    update kvdb & co (#6111)

    * toml changes

    * REVERTME: patch

    * adapt parachains db interface

    * fix Cargo.toml patch after master rebase

    * fix av-store

    * fix chain-selection

    * fix parachains-db?

    * Revert "fix Cargo.toml patch after master rebase"

    This reverts commit 3afcbf033c86027b3f2b909d83ec703591bdd287.

    * Revert "REVERTME: patch"

    This reverts commit 464b717cf4142d3d09c3d77b83700b632d8c5f54.

    * Use `Ok` imported from prelude

Co-authored-by: default avatarBastian Köcher <[email protected]>

    * update lockfile for {"substrate"}

    * Revert "update lockfile for {"substrate"}"

    This reverts commit fdc623de226f7645741b86c4b1a7d030fed2172d.

    * cargo update -p sp-io

Co-authored-by: default avatarBastian Köcher <[email protected]>
    Co-authored-by: parity-processbot <>

commit 9a3cf4cd


Author: Gavin Wood <[email protected]>
Date:   Wed Oct 5 22:17:59 2022 +0100

    Companion for #11649: Bound uses of `Call` (#5729)

    * Fixes

    * Clear out old weights

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

    * Resolve merges

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

    * Fix weight traits

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

    * polkadot runtime: Clippy

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

    * rococo runtime: update pallet configs

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

    * Add preimage migration

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

    * Add all migrations

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

    * Democracy is not on Westend

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

    * [Migration] Refund stored multisig calls (#6075)

    * Add Preimages to referenda config

    Needed since Gov V2 just merged.

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

    * Update weights

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

    * Add multisig migration to Westend+Rococo

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

    * Fix Executive syntax

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

    * Bump Substrate

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
    Co-authored-by: parity-processbot <>
Co-authored-by: default avatarRoman Useinov <[email protected]>

commit 4aea71a9
Author: Alexander Theißen <[email protected]>
Date:   Wed Oct 5 15:15:07 2022 +0200

    Pass through `runtime-benchmark` feature (#6110)

commit 42c043d7


Author: Keith Yeung <[email protected]>
Date:   Wed Oct 5 17:47:15 2022 +0800

    Properly migrate weights to v2 (#6091)

    * Create migration for config pallet

    * Use XcmWeight in XCM pallet extrinsics

    * Link to PR in doc comment

    * cargo fmt

    * Fix tests

    * Fix tests

    * Remove unused import

    * Update runtime/parachains/src/configuration/migration.rs

Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>

    * Add missing on_runtime_upgrade implementation

    * Use new migration API

    * cargo fmt

    * Fix log message

Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>

commit b13e07bc
Author: Chris Sosnin <[email protected]>
Date:   Wed Oct 5 11:48:50 2022 +0400

    Buffered connection management for collator-protocol (#6022)

    * Extract metrics into a separate module

    * Introduce validators buffer

    * Integrate buffer into the subsystem

    * Only reconnect on new advertisements

    * Test

    * comma

    * doc comment

    * Make capacity buffer compile time non-zero

    * Add doc comments

    * nits

    * remove derives

    * review

    * better naming

    * check timeout

    * Extract interval stream into lib

    * Ensure collator disconnects after timeout

    * spellcheck

    * rename buf

    * Remove double interval

    * Add a log on timeout

    * Cleanup buffer on timeout

commit e0e83667
Author: Robert Klotzner <[email protected]>
Date:   Tue Oct 4 18:47:52 2022 +0200

    Add unknown words (#6105)

commit 938bc96a


Author: Robert Klotzner <[email protected]>
Date:   Tue Oct 4 18:02:05 2022 +0200

    Batch vote import in dispute-distribution (#5894)

    * Start work on batching in dispute-distribution.

    * Guide work.

    * More guide changes. Still very much WIP.

    * Finish guide changes.

    * Clarification

    * Adjust argument about slashing.

    * WIP: Add constants to receiver.

    * Maintain order of disputes.

    * dispute-distribuion sender Rate limit.

    * Cleanup

    * WIP: dispute-distribution receiver.

    - [ ] Rate limiting
    - [ ] Batching

    * WIP: Batching.

    * fmt

    * Update `PeerQueues` to maintain more invariants.

    * WIP: Batching.

    * Small cleanup

    * Batching logic.

    * Some integration work.

    * Finish.

    Missing: Tests

    * Typo.

    * Docs.

    * Report missing metric.

    * Doc pass.

    * Tests for waiting_queue.

    * Speed up some crypto by 10x.

    * Fix redundant import.

    * Add some tracing.

    * Better sender rate limit

    * Some tests.

    * Tests

    * Add logging to rate limiter

    * Update roadmap/implementers-guide/src/node/disputes/dispute-distribution.md

Co-authored-by: default avatarTsvetomir Dimitrov <[email protected]>

    * Update roadmap/implementers-guide/src/node/disputes/dispute-distribution.md

Co-authored-by: default avatarTsvetomir Dimitrov <[email protected]>

    * Update node/network/dispute-distribution/src/receiver/mod.rs

Co-authored-by: default avatarTsvetomir Dimitrov <[email protected]>

    * Review feedback.

    * Also log peer in log messages.

    * Fix indentation.

    * waker -> timer

    * Guide improvement.

    * Remove obsolete comment.

    * waker -> timer

    * Fix spell complaints.

    * Fix Cargo.lock

Co-authored-by: default avatarTsvetomir Dimitrov <[email protected]>

commit a64cc4a8
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Oct 4 11:28:21 2022 +0000

    Bump lru from 0.7.8 to 0.8.0 (#6060)

    * Bump lru from 0.7.8 to 0.8.0

    Bumps [lru](https://github.com/jeromefroe/lru-rs) from 0.7.8 to 0.8.0.
    - [Release notes](https://github.com/jeromefroe/lru-rs/releases)
    - [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md)
    - [Commits](https://github.com/jeromefroe/lru-rs/compare/0.7.8...0.8.0

)

    ---
    updated-dependencies:
    - dependency-name: lru
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

Signed-off-by: default avatardependabot[bot] <[email protected]>

    * Change `LruCache` paramerter to `NonZeroUsize`

    * Change type of `session_cache_lru_size` to `NonZeroUsize`

    * Add expects instead of unwrap

Co-authored-by: default avatarBastian Köcher <[email protected]>

    * Use match to get rid of expects

Signed-off-by: default avatardependabot[bot] <[email protected]>
Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: default avatarSebastian Kunert <[email protected]>
Co-authored-by: default avatarBastian Köcher <[email protected]>

commit 7114a8cf


Author: Andrei Sandu <[email protected]>
Date:   Tue Oct 4 13:36:42 2022 +0300

    Keep sessions in window for the full unfinalized chain (#6054)

    * Impl dynamic window size. Keep sessions for unfinalized chain

Signed-off-by: default avatarAndrei Sandu <[email protected]>

    * feedback

Signed-off-by: default avatarAndrei Sandu <[email protected]>

    * Stretch also in contructor plus  tests

Signed-off-by: default avatarAndrei Sandu <[email protected]>

    * review feedback

Signed-off-by: default avatarAndrei Sandu <[email protected]>

    * fix approval-voting tests

Signed-off-by: default avatarAndrei Sandu <[email protected]>

    * grunting: dispute coordinator tests

Signed-off-by: default avatarAndrei Sandu <[email protected]>

Signed-off-by: default avatarAndrei Sandu <[email protected]>

commit ab8f04f8


Author: Serban Iorga <[email protected]>
Date:   Tue Oct 4 12:25:48 2022 +0300

    Companion for BEEFY: Simplify hashing for pallet-beefy-mmr (#6098)

    * beefy-mmr: Simplify hashing

    * update lockfile for {"substrate"}

    Co-authored-by: parity-processbot <>

* Revert "Squashed commit of the following:"

This reverts commit 5001fa5d1dcd366029d156f81c40b99ca29d8f77.

* Companion for BEEFY: Simplify hashing for pallet-beefy-mmr (#6098)

* beefy-mmr: Simplify hashing

* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>

* Keep sessions in window for the full unfinalized chain (#6054)

* Impl dynamic window size. Keep sessions for unfinalized chain

Signed-off-by: default avatarAndrei Sandu <[email protected]>

* feedback

Signed-off-by: default avatarAndrei Sandu <[email protected]>

* Stretch also in contructor plus  tests

Signed-off-by: default avatarAndrei Sandu <[email protected]>

* review feedback

Signed-off-by: default avatarAndrei Sandu <[email protected]>

* fix approval-voting tests

Signed-off-by: default avatarAndrei Sandu <[email protected]>

* grunting: dispute coordinator tests

Signed-off-by: default avatarAndrei Sandu <[email protected]>

Signed-off-by: default avatarAndrei Sandu <[email protected]>

* Bump lru from 0.7.8 to 0.8.0 (#6060)

* Bump lru from 0.7.8 to 0.8.0

Bumps [lru](https://github.com/jeromefroe/lru-rs) from 0.7.8 to 0.8.0.
- [Release notes](https://github.com/jeromefroe/lru-rs/releases)
- [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/jeromefroe/lru-rs/compare/0.7.8...0.8.0

)

---
updated-dependencies:
- dependency-name: lru
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: default avatardependabot[bot] <[email protected]>

* Change `LruCache` paramerter to `NonZeroUsize`

* Change type of `session_cache_lru_size` to `NonZeroUsize`

* Add expects instead of unwrap

Co-authored-by: default avatarBastian Köcher <[email protected]>

* Use match to get rid of expects

Signed-off-by: default avatardependabot[bot] <[email protected]>
Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: default avatarSebastian Kunert <[email protected]>
Co-authored-by: default avatarBastian Köcher <[email protected]>

* Batch vote import in dispute-distribution (#5894)

* Start work on batching in dispute-distribution.

* Guide work.

* More guide changes. Still very much WIP.

* Finish guide changes.

* Clarification

* Adjust argument about slashing.

* WIP: Add constants to receiver.

* Maintain order of disputes.

* dispute-distribuion sender Rate limit.

* Cleanup

* WIP: dispute-distribution receiver.

- [ ] Rate limiting
- [ ] Batching

* WIP: Batching.

* fmt

* Update `PeerQueues` to maintain more invariants.

* WIP: Batching.

* Small cleanup

* Batching logic.

* Some integration work.

* Finish.

Missing: Tests

* Typo.

* Docs.

* Report missing metric.

* Doc pass.

* Tests for waiting_queue.

* Speed up some crypto by 10x.

* Fix redundant import.

* Add some tracing.

* Better sender rate limit

* Some tests.

* Tests

* Add logging to rate limiter

* Update roadmap/implementers-guide/src/node/disputes/dispute-distribution.md

Co-authored-by: default avatarTsvetomir Dimitrov <[email protected]>

* Update roadmap/implementers-guide/src/node/disputes/dispute-distribution.md

Co-authored-by: default avatarTsvetomir Dimitrov <[email protected]>

* Update node/network/dispute-distribution/src/receiver/mod.rs

Co-authored-by: default avatarTsvetomir Dimitrov <[email protected]>

* Review feedback.

* Also log peer in log messages.

* Fix indentation.

* waker -> timer

* Guide improvement.

* Remove obsolete comment.

* waker -> timer

* Fix spell complaints.

* Fix Cargo.lock

Co-authored-by: default avatarTsvetomir Dimitrov <[email protected]>

* Add unknown words (#6105)

* Buffered connection management for collator-protocol (#6022)

* Extract metrics into a separate module

* Introduce validators buffer

* Integrate buffer into the subsystem

* Only reconnect on new advertisements

* Test

* comma

* doc comment

* Make capacity buffer compile time non-zero

* Add doc comments

* nits

* remove derives

* review

* better naming

* check timeout

* Extract interval stream into lib

* Ensure collator disconnects after timeout

* spellcheck

* rename buf

* Remove double interval

* Add a log on timeout

* Cleanup buffer on timeout

* Properly migrate weights to v2 (#6091)

* Create migration for config pallet

* Use XcmWeight in XCM pallet extrinsics

* Link to PR in doc comment

* cargo fmt

* Fix tests

* Fix tests

* Remove unused import

* Update runtime/parachains/src/configuration/migration.rs

Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>

* Add missing on_runtime_upgrade implementation

* Use new migration API

* cargo fmt

* Fix log message

Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>

* Pass through `runtime-benchmark` feature (#6110)

* Companion for #11649: Bound uses of `Call` (#5729)

* Fixes

* Clear out old weights

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

* Resolve merges

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

* Fix weight traits

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

* polkadot runtime: Clippy

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

* rococo runtime: update pallet configs

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

* Add preimage migration

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

* Add all migrations

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

* Democracy is not on Westend

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

* [Migration] Refund stored multisig calls (#6075)

* Add Preimages to referenda config

Needed since Gov V2 just merged.

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

* Update weights

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

* Add multisig migration to Westend+Rococo

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

* Fix Executive syntax

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>

* Bump Substrate

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
Co-authored-by: parity-processbot <>
Co-authored-by: default avatarRoman Useinov <[email protected]>

* update kvdb & co (#6111)

* toml changes

* REVERTME: patch

* adapt parachains db interface

* fix Cargo.toml patch after master rebase

* fix av-store

* fix chain-selection

* fix parachains-db?

* Revert "fix Cargo.toml patch after master rebase"

This reverts commit 3afcbf033c86027b3f2b909d83ec703591bdd287.

* Revert "REVERTME: patch"

This reverts commit 464b717cf4142d3d09c3d77b83700b632d8c5f54.

* Use `Ok` imported from prelude

Co-authored-by: default avatarBastian Köcher <[email protected]>

* update lockfile for {"substrate"}

* Revert "update lockfile for {"substrate"}"

This reverts commit fdc623de226f7645741b86c4b1a7d030fed2172d.

* cargo update -p sp-io

Co-authored-by: default avatarBastian Köcher <[email protected]>
Co-authored-by: parity-processbot <>

* Skip `unexpected metric type`

* Dump more info for `unexpected metric type`

* Skip `unexpected metric type`

* service: use MmrRootProvider as custom BEEFY payload provider (companion for 12428) (#6112)

* service: use MmrRootProvider as custom BEEFY payload provider

* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>

* Maximum value for `MultiplierUpdate` (#6021)

* update multiplier

* fix

* update lockfile for {"substrate"}

* fmt

* fix typo

Co-authored-by: parity-processbot <>

* Companion for upgrading pin-project (#6118)

* Companion for upgrading pin-project

This will remove some warnings with the latest rustc nightly/stable.

https://github.com/paritytech/substrate/pull/12426



* update lockfile for {"substrate"}

Co-authored-by: parity-processbot <>

* Companion for 12109 (#5929)

* Update following `pallet-vesting` configurable `WithdrawReasons`

* Update lib.rs

* Update lib.rs

* Update lib.rs

* update lockfile for {"substrate"}

* fix warning

Co-authored-by: default avatarShawn Tabrizi <[email protected]>
Co-authored-by: parity-processbot <>

* Add event to asset claim (#6029)

* Fix flaky test (#6131)

* Split test + decrease test timeout

* fmt

* spellcheck

* ci/guide: install mdbook-graphviz (#6119)

* ci/guide: install mdbook-graphviz

* install graphviz in build-implementers-guide

* Update scripts/ci/gitlab/pipeline/build.yml

Co-authored-by: default avatarAlexander Samusev <[email protected]>

* Revert "Squashed commit of the following:"

This reverts commit 5001fa5d1dcd366029d156f81c40b99ca29d8f77.

* * Remove unused imports

* * cargo +nightly fmt --all

* Make tweaks based on PR comments

* unit test related to gum formatting

* cargo +nightly fmt --all

* Resolve merge conflicts

* cargo +nightly fmt --all

* Fix tests so they use cli rather than cmd

* CI unused import check fix

* Move info! log to startup

* make info log more comprehensible

Signed-off-by: default avatarAndrei Sandu <[email protected]>
Signed-off-by: default avatardependabot[bot] <[email protected]>
Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
Co-authored-by: default avatarSerban Iorga <[email protected]>
Co-authored-by: default avatarAndrei Sandu <[email protected]>
Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: default avatarSebastian Kunert <[email protected]>
Co-authored-by: default avatarBastian Köcher <[email protected]>
Co-authored-by: default avatarRobert Klotzner <[email protected]>
Co-authored-by: default avatarTsvetomir Dimitrov <[email protected]>
Co-authored-by: default avatarChris Sosnin <[email protected]>
Co-authored-by: default avatarKeith Yeung <[email protected]>
Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
Co-authored-by: default avatarAlexander Theißen <[email protected]>
Co-authored-by: default avatarGavin Wood <[email protected]>
Co-authored-by: default avatarRoman Useinov <[email protected]>
Co-authored-by: default avatarAndronik <[email protected]>
Co-authored-by: default avatarBranislav Kontur <[email protected]>
Co-authored-by: default avatarAdrian Catangiu <[email protected]>
Co-authored-by: default avatarSergej Sakac <[email protected]>
Co-authored-by: default avatarLeszek Wiesner <[email protected]>
Co-authored-by: default avatarShawn Tabrizi <[email protected]>
Co-authored-by: default avatargirazoki <[email protected]>
Co-authored-by: default avatarAlexander Samusev <[email protected]>
parent a7780e07
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment