Skip to content
  1. Apr 21, 2023
  2. Apr 20, 2023
    • Marcin S.'s avatar
      PVF: Don't dispute on missing artifact (#7011) · 0940cdd1
      Marcin S. authored
      * PVF: Don't dispute on missing artifact
      
      A dispute should never be raised if the local cache doesn't provide a certain
      artifact. You can not dispute based on this reason, as it is a local hardware
      issue and not related to the candidate to check.
      
      Design:
      
      Currently we assume that if we prepared an artifact, it remains there on-disk
      until we prune it, i.e. we never check again if it's still there.
      
      We can change it so that instead of artifact-not-found triggering a dispute, we
      retry once (like we do for AmbiguousWorkerDeath, except we don't dispute if it
      still doesn't work). And when enqueuing an execute job, we check for the
      artifact on-disk, and start preparation if not found.
      
      Changes:
      
      - [x] Integration test (should fail without the following changes)
      - [x] Check if artifact exists when executing, prepare if not
      - [x] Return an internal error when file is missing
      - [x] Retry once on internal errors
      - [x] Document design (update impl guide)
      
      * Add some context to wasm error message (it is quite long)
      
      * Fix impl guide
      
      * Add check for missing/inaccessible file
      
      * Add comment referencing Substrate issue
      
      * Add test for retrying internal errors
      
      ---------
      
      Co-authored-by: parity-processbot <>
      0940cdd1
    • Keith Yeung's avatar
      XCM: Properly set the pricing for the DMP router (#6843) · 023d4598
      Keith Yeung authored
      
      
      * Properly set the pricing for the DMP router
      
      * Publicize price types
      
      * Use FixedU128 instead of Percent
      
      * Add sp-arithmetic as a dependency for rococo runtime
      
      * Add sp-arithmetic as a dependency to all runtimes
      
      * Remove duplicate import
      
      * Add missing import
      
      * Fix tests
      
      * Create an appropriate QueueDownwardMessageError variant
      
      * Recalculate delivery fee factor based on past queue sizes
      
      * Remove unused error variant
      
      * Fixes
      
      * Fixes
      
      * Remove unused imports
      
      * Rewrite fee factor update mechanism
      
      * Remove unused imports
      
      * Fixes
      
      * Update runtime/parachains/src/dmp.rs
      
      Co-authored-by: default avatarSquirrel <[email protected]>
      
      * Make DeliveryFeeFactor be a StorageMap keyed on ParaIds
      
      * Fixes
      
      * introduce limit for fee increase on dmp queue
      
      * add message_size based fee factor to increment_fee_factor
      
      * change message_size fee rate to correct value
      
      * fix div by 0 error
      
      * bind limit to variable
      
      * fix message_size_factor and add DeliveryFeeFactor test
      
      * add test for ExponentialPrice implementation
      
      * make test formula based
      
      * make delivery fee factor test formula based
      
      * add max value test for DeliveryFeeFactor and move limit to config
      
      * change threshold back to dynamic value and fix tests
      
      * fmt
      
      * suggested changes and fmt
      
      * small stylistic change
      
      * fmt
      
      * change to tokenlocation
      
      * small fixes
      
      * fmt
      
      * remove sp_arithmetic dependency
      
      * Update runtime/parachains/src/dmp.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      ---------
      
      Co-authored-by: default avatarSquirrel <[email protected]>
      Co-authored-by: default avatarJust van Stam <[email protected]>
      Co-authored-by: default avatarJust van Stam <[email protected]>
      Co-authored-by: default avatarKian Paimani <[email protected]>
      023d4598
  3. Apr 19, 2023
  4. Apr 18, 2023
  5. Apr 17, 2023
  6. Apr 14, 2023
  7. Apr 13, 2023
  8. Apr 12, 2023
  9. Apr 11, 2023
    • Mira Ressel's avatar
      use stable rust toolchain in ci · 32c9e999
      Mira Ressel authored
      cargo-fmt stays on the nightly pipeline; our fmt config uses a heap of
      unstable features.
      32c9e999
    • Mira Ressel's avatar
      apply clippy 1.68 suggestions · 0e9b0a64
      Mira Ressel authored
      * Simplify &(ref foo, _) tuple pattern matches
      * Drop unneccessary .clone() calls
      * Replace .position(cond).is_some() by .any(cond)
      * Drop unneccessary lifetime specs
      0e9b0a64
  10. Apr 08, 2023
  11. Apr 07, 2023
    • Tsvetomir Dimitrov's avatar
      Onchain scraper in `dispute-coordinator` will scrape... · 63a805ba
      Tsvetomir Dimitrov authored
      Onchain scraper in `dispute-coordinator` will scrape `SCRAPED_FINALIZED_BLOCKS_COUNT` blocks before finality (#7013)
      
      * Onchain scraper in `dispute-coordinator` will scrape `SCRAPED_FINALIZED_BLOCKS_COUNT` blocks before finality
      
      The purpose is to make the availability of a `CandidateReceipt` for finalized candidates more likely.
      
      For details see:  https://github.com/paritytech/polkadot/issues/7009
      
      * Fix off by one error
      
      * Replace `SCRAPED_FINALIZED_BLOCKS_COUNT` with `DISPUTE_CANDIDATE_LIFETIME_AFTER_FINALIZATION`
      63a805ba
    • Marcin S.'s avatar
      PVF: Minor refactor in workers code (#7012) · 5889119f
      Marcin S. authored
      * Move version check to `worker_event_loop`
      
      * More minor refactors
      
      - More consistent use of `format_invalid` and `format_internal`.
      - Fix a doc error.
      - Fix some poorly-named local variables.
      5889119f
  12. Apr 05, 2023
  13. Apr 04, 2023