Skip to content
Snippets Groups Projects
  1. Aug 16, 2024
  2. Aug 15, 2024
    • Przemek Rzad's avatar
      Update Readme of the `polkadot` crate (#5326) · 843c4db7
      Przemek Rzad authored
      - Typos.
      - Those telemetry links like https://telemetry.polkadot.io/#list/Kusama
      didn't seem to properly point to a proper list (anymore?) - updated
      them.
      - Also looks like it was trying to use rust-style linking instead of
      markdown linking, changed that.
      - Relative links do not work on crates.io - updated to absolute,
      similarly as some already existing links, such as contribution
      guidelines.
    • Kian Paimani's avatar
      allow for `u8` to be used as hold/freeze reason (#5348) · 90c91b1e
      Kian Paimani authored
      ..without needing to provide your own `newtype` around it.  
      
      This will allow `type Reason = u8` to be used as `FreezeReason` and
      `HoldReason`, which I think is a nice simplification if one doens't want
      to deal with the complications.
      
      At the same time, it is a bit of an anti-pattern.
      
      Putting it out there to check people's vibes.
    • Yuri Volkov's avatar
      Moving cargo check for runtimes to GHA (#5340) · 41a679c4
      Yuri Volkov authored
      Fixes https://github.com/paritytech/ci_cd/issues/1015
    • Przemek Rzad's avatar
      Update links in the documentation (#5175) · b5029eb4
      Przemek Rzad authored
      - Where applicable, use a regular [`reference`] instead of
      `../../../reference/index.html`.
      - Typos.
      - Update a link to `polkadot-evm` which has moved out of the monorepo.
      - ~~The link specification for `chain_spec_builder` is invalid~~
      (actually it was valid) - it works fine without it.
      
      Part of https://github.com/paritytech/eng-automation/issues/10
    • Loïs's avatar
      fix visibility for `pallet_nfts` types used as call arguments (#3634) · 069f8a6a
      Loïs authored
      
      fix #3631 
      
      Types which are impacted and fixed here are `ItemTip`,
      `PriceWithDirection`, `PreSignedMint`, `PreSignedAttributes`.
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
    • Przemek Rzad's avatar
    • Bastian Köcher's avatar
      Aura: Ensure we are building on each relay chain fork (#5352) · 63bf73d5
      Bastian Köcher authored
      
      We only want to build one block per slot for Aura on parachains.
      However, we still need to build on each relay chain fork, which is using
      the same slot.
      
      Closes: https://github.com/paritytech/polkadot-sdk/issues/5349
      
      ---------
      
      Co-authored-by: default avatarDavide Galassi <davxy@datawok.net>
      Co-authored-by: default avatarSebastian Kunert <skunert49@gmail.com>
    • Iker's avatar
      Update Identity pallet README.md (#5183) · 048f4b8e
      Iker authored
      
      Update Identity pallet README.md according to the up-to-date docs,
      particularly to explain the _username_ concept of the pallet.
      
      ---------
      
      Co-authored-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
    • dependabot[bot]'s avatar
      Bump trie-db from 0.29.0 to 0.29.1 (#5231) · e91f1463
      dependabot[bot] authored
      
      Bumps [trie-db](https://github.com/paritytech/trie) from 0.29.0 to
      0.29.1.
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/paritytech/trie/commit/48fcfa99c439949f55d29762e35f8793113edc91"><code>48fcfa9</code></a>
      memory-db: update parity-util-mem (<a
      href="https://redirect.github.com/paritytech/trie/issues/166">#166</a>)</li>
      <li><a
      href="https://github.com/paritytech/trie/commit/02b030a24bc60d46ed7f156888bdbbed6498b216"><code>02b030a</code></a>
      Prepare trie-db 0.24.0 release (<a
      href="https://redirect.github.com/paritytech/trie/issues/163">#163</a>)</li>
      <li><a
      href="https://github.com/paritytech/trie/commit/aff1cbac8f03e8dc7533263b374dc0fcd17444ad"><code>aff1cba</code></a>
      Introduce trie level cache &amp; recorder (<a
      href="https://redirect.github.com/paritytech/trie/issues/157">#157</a>)</li>
      <li><a
      href="https://github.com/paritytech/trie/commit/aa3168d6de01793e71ebd906d3a82ae4b363db59"><code>aa3168d</code></a>
      Bump actions/checkout from 2 to 3 (<a
      href="https://redirect.github.com/paritytech/trie/issues/160">#160</a>)</li>
      <li><a
      href="https://github.com/paritytech/trie/commit/d597275768f4796417c7fc9f8ad64f9b26be14d8"><code>d597275</code></a>
      Add GHA to dependabot and CODEOWNERS (<a
      href="https://redirect.github.com/paritytech/trie/issues/159">#159</a>)</li>
      <li><a
      href="https://github.com/paritytech/trie/commit/5c9267c1133000aa41a5983d8acd6d0968ab8032"><code>5c9267c</code></a>
      test prefix seek more precisely (<a
      href="https://redirect.github.com/paritytech/trie/issues/158">#158</a>)</li>
      <li><a
      href="https://github.com/paritytech/trie/commit/f64e1b0a8ced1b4b574d2b705202bf790d4394e4"><code>f64e1b0</code></a>
      Do not check for root in <code>TrieDB</code> and <code>TrieDBMut</code>
      constructors (<a
      href="https://redirect.github.com/paritytech/trie/issues/155">#155</a>)</li>
      <li><a
      href="https://github.com/paritytech/trie/commit/8d5b8675fcc8ecc8648206d08f2e4c06ab489593"><code>8d5b867</code></a>
      Update dependencies. (<a
      href="https://redirect.github.com/paritytech/trie/issues/154">#154</a>)</li>
      <li><a
      href="https://github.com/paritytech/trie/commit/fac100cbf49c197c49d102f12040bccbfa38827e"><code>fac100c</code></a>
      Adding support for eip-1186 proofs (<a
      href="https://redirect.github.com/paritytech/trie/issues/146">#146</a>)</li>
      <li><a
      href="https://github.com/paritytech/trie/commit/2e1541e44989f24cec5dbe3081c7cecf00d8b509"><code>2e1541e</code></a>
      Fix hex trace output (<a
      href="https://redirect.github.com/paritytech/trie/issues/153">#153</a>)</li>
      <li>Additional commits viewable in <a
      href="https://github.com/paritytech/trie/compare/trie-db-v0.29.0...reference-trie-v0.29.1">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      
      [![Dependabot compatibility
      score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=trie-db&package-manager=cargo&previous-version=0.29.0&new-version=0.29.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits
      that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after
      your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge
      and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating
      it. You can achieve the same result by closing it manually
      - `@dependabot show <dependency name> ignore conditions` will show all
      of the ignore conditions of the specified dependency
      - `@dependabot ignore this major version` will close this PR and stop
      Dependabot creating any more for this major version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this minor version` will close this PR and stop
      Dependabot creating any more for this minor version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this dependency` will close this PR and stop
      Dependabot creating any more for this dependency (unless you reopen the
      PR or upgrade to it yourself)
      
      
      </details>
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    • Dónal Murray's avatar
      [Coretime] Always include UnpaidExecution, not just when revenue is > 0 (#5369) · 78c3daab
      Dónal Murray authored
      The NotifyRevenue XCM from relay to coretime chain fails to pass the
      barrier when revenue is 0.
      
      
      https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/runtime/parachains/src/coretime/mod.rs#L401
      pushes notifyrevenue onto an [empty
      vec](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/runtime/parachains/src/coretime/mod.rs#L361)
      when `revenue == 0`, so it never explicitly requests unpaid execution,
      because that happens only in [the block where revenue is `>
      0`](https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/runtime/parachains/src/coretime/mod.rs#L387).
      
      This will need to be backported to 1.14 when merged.
    • Ankan's avatar
      [Pools] fix derivation of pool account (#4999) · ebf4f8d2
      Ankan authored
      
      closes https://github.com/paritytech-secops/srlabs_findings/issues/408.
      This fixes how ProxyDelegator accounts are derived but may cause issues
      in Westend since it would use the old derivative accounts. Does not
      affect Polkadot/Kusama as this pallet is not deployed to them yet.
      
      ---------
      
      Co-authored-by: default avatarGonçalo Pestana <g6pestana@gmail.com>
  3. Aug 14, 2024
    • Bastian Köcher's avatar
    • Ankan's avatar
      [Pools] Fix issues with member migration to `DelegateStake` (#4822) · feacf2f3
      Ankan authored
      
      ## Context
      Pool members using the old `TransferStake` strategy were able to
      transfer all their funds to the pool. With `DelegateStake` changes, we
      want to ensure similar behaviour by allowing members to delegate all
      their stake to the pool.
      
      ## Changes
      - Ensure all the balance including ED of an account can be delegated
      (and used in the pool) by adding a provider for delegators.
      - Gates calls that mutates the pool or pool member if they are in
      unmigrated state. Closes
      https://github.com/paritytech-secops/srlabs_findings/issues/409.
      - Adds remote test to migrate all pools and members to `DelegateStake`
      which can be used with `Kusama` and `Polkadot` runtime state. closes
      https://github.com/paritytech/polkadot-sdk/issues/4629.
      - Add new runtime apis to read pool and member balance.
      
      ## Addressing possible migration errors 
      Pool members migrating can run into two types of errors:
      - Already Staking: If the pool member is already staking, we cannot
      migrate them to `DelegateStake` since this may mean they are able to use
      the same staked funds in the pool. Users would need to withdraw all
      their funds from staking, in order to migrate their pool funds.
      - Pool contribution below ED: For these cases transfer from pool account
      to member account would fail. The affected users can top up their
      accounts and redo migration.
      
      Another error that was earlier possible was when member's free balance
      is below ED. This PR adds a provider to delegator allowing all user
      balance including ED can be contributed towards the pool. This helps
      `1095` accounts in Polkadot and `41` accounts in Kusama to migrate now
      which would have earlier failed.
      
      ## Results from RemoteExternalities Tests.
      
      ### Kusama
      `Migration stats: success: 3017, direct_stakers: 361, unexpected_errors:
      0`
      
      ### Polkadot
      `Migration stats: success: 42859, direct_stakers: 643,
      unexpected_errors: 0`
      
      ## TODO
      - [x] Add runtime api for member total balance.
      - [x] New
      [issue](https://github.com/paritytech/polkadot-sdk/issues/5009) to reap
      pool members with contribution below ED.
      - [x] Add provider for delegators so whole balance including ED can be
      held while contributing to pools.
      - [x] Gate all pool extrinsics if pool/member is in non-migrated state.
      
      ---------
      
      Co-authored-by: default avatarGonçalo Pestana <g6pestana@gmail.com>
    • Nazar Mokrynskyi's avatar
      Unify `no_genesis` check (#5360) · 5a9396f4
      Nazar Mokrynskyi authored
      
      The same exact `matches!()` was duplicated in
      `Configuration::no_genesis()` method and inline in full node parts
      creation. Since this is the same exact logic and reason, it makes sense
      to de-duplicate them.
      
      ---------
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
    • Oliver Tale-Yazdi's avatar
      [CI] Fix prdoc command (#5358) · d8c29447
      Oliver Tale-Yazdi authored
      
      Changes:
      - Run the prdoc command in a docker container since otherwise the
      set-up-gh script wont work.
      - Take try-runtime snapshot at night to avoid spamming the node with
      snapshot jobs at day.
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    • Serban Iorga's avatar
      Beefy: add benchmarks for `report_fork_voting()` (#5188) · 81d8f0c0
      Serban Iorga authored
      
      Related to #4523 
      
      This PR adds benchmarks for `report_fork_voting()`.
      
      **Important: Even though the benchmarks are now available, we still use
      `Weight::MAX`. That's because I realized while working on this PR that
      there's still one missing piece. We should also check that the ancestry
      proof is optimal. I plan to do this in a future PR, hopefully the last
      one related to #4523.**
      
      ---------
      
      Co-authored-by: default avatarBranislav Kontur <bkontur@gmail.com>
      Co-authored-by: command-bot <>
    • Alexandru Gheorghe's avatar
      Fix OurViewChange small race (#5356) · 05a8ba66
      Alexandru Gheorghe authored
      
      Always queue OurViewChange event before we send view changes to our
      peers, because otherwise we risk the peers sending us a message that can
      be processed by our subsystems before OurViewChange.
      
      Normally, this is not really a problem because the latency of the
      ViewChange we send to our peers is way higher that our subsystem
      processing OurViewChange, however on testnets like versi where CPU is
      sometimes overcommitted this race gets triggered occasionally, so let's
      fix it by sending the messages in the right order.
      
      ---------
      
      Signed-off-by: default avatarAlexandru Gheorghe <alexandru.gheorghe@parity.io>
    • Muharem Ismailov's avatar
      Make ticket non-optional and add ensure_successful method to Consideration trait (#5359) · 00946b10
      Muharem Ismailov authored
      Make ticket non-optional and add ensure_successful method to
      Consideration trait.
      
      Reverts the optional return ticket type for the new function introduced
      in
      [polkadot-sdk/4596](https://github.com/paritytech/polkadot-sdk/pull/4596)
      and adds a helper `ensure_successful` function for the runtime
      benchmarks.
      Since the existing FRAME pallet represents zero cost with a zero balance
      rather than `None` in an option, maintaining the ticket type as a
      non-optional balance is beneficial for backward compatibility and helps
      avoid unnecessary migrations.
    • Adrian Catangiu's avatar
      [tests] dedup test code, add more tests, improve naming and docs (#5338) · e4f8a6de
      Adrian Catangiu authored
      This is mostly tests cleanup:
      - uses helper macro for generating teleport tests,
      - adds missing treasury tests,
      - improves naming and docs for transfer tests.
      
      - [x] does not need a PRDOC
      
      ---------
      
      Co-authored-by: command-bot <>
    • Przemek Rzad's avatar
      Stop running the wishlist workflow on forks (#5297) · d944ac2f
      Przemek Rzad authored
      Addresses
      https://github.com/paritytech/polkadot-sdk/pull/5085#issuecomment-2277231072
    • Francisco Aguirre's avatar
      Migrate foreign assets v3::Location to v4::Location (#4129) · be74fe92
      Francisco Aguirre authored
      
      In the move from XCMv3 to XCMv4, the `AssetId` for `ForeignAssets` in
      `asset-hub-rococo` and `asset-hub-westend` was left as `v3::Location` to
      be later migrated to `v4::Location`.
      
      This is that migration PR.
      
      Because the encoding of `v3::Location` and `v4::Location` is the same,
      we don't need to do any data migration, the keys will still be
      decodable.
      The [original idea by
      Jan](https://github.com/paritytech/polkadot/pull/7236) was to make the
      v4 changes in v3 since the ABI (the encoding/decoding) didn't change.
      Corroborated the ABI is the same iterating over all storage, the code is
      on [another
      branch](https://github.com/paritytech/polkadot-sdk/blob/cisco-assert-v3-v4-encodings-equal/cumulus/parachains/runtimes/assets/migrations/src/foreign_assets_to_v4/mod.rs).
      
      We will need a data migration when we want to update from `v4::Location`
      to `v5::Location` because of [the accepted RFC changing the NetworkId
      enum](https://github.com/polkadot-fellows/RFCs/pull/108).
      I'll configure MBMs (Multi-Block Migrations) then and make the actual
      migration.
      
      Fixes https://github.com/paritytech/polkadot-sdk/issues/4128
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
      Co-authored-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
      Co-authored-by: command-bot <>
  4. Aug 13, 2024
    • Jeeyong Um's avatar
      Minor clean up (#5284) · 0cd577ba
      Jeeyong Um authored
      
      This PR performs minor code cleanup to reduce verbosity. Since the
      compiler has already optimized out indirect calls in the existing code,
      these changes improve readability but do not affect performance.
      
      ---------
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
    • Ankan's avatar
      [Pools] Ensure members can always exit the pool gracefully (#4998) · 42eb4ec0
      Ankan authored
      
      Resolves https://github.com/paritytech-secops/srlabs_findings/issues/412
      
      ## Changes
      - Clear any dangling delegation when member is removed.
      - Agents need to be killed explicitly when pools are destroyed.
      - Member withdraw amount is max of their locked funds and the value of
      their points.
      
      ---------
      
      Co-authored-by: default avatarGonçalo Pestana <g6pestana@gmail.com>
      Co-authored-by: command-bot <>
    • Sebastian Kunert's avatar
      StorageWeightReclaim: set to node pov size if higher (#5281) · 055eb537
      Sebastian Kunert authored
      This PR adds an additional defensive check to the reclaim SE. 
      
      Since it can happen that we miss some storage accesses on other SEs
      pre-dispatch, we should double check
      that the bookkeeping of the runtime stays ahead of the node-side
      pov-size.
      
      If we discover a mismatch and the node-side pov-size is indeed higher,
      we should set the runtime bookkeeping to the node-side value. In cases
      such as #5229, we would stop including extrinsics and not run `on_idle`
      at least.
      
      cc @gui1117
      
      ---------
      
      Co-authored-by: command-bot <>
    • Oliver Tale-Yazdi's avatar
      [Bot] Add prdoc generation (#5331) · b78d7955
      Oliver Tale-Yazdi authored
      
      Add a bot to automatically generate prdocs that have all the crates
      populated.
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
    • Branislav Kontur's avatar
    • Maksym H's avatar
      Create subsystem-benchmarks.yml (#5325) · ae1b84df
      Maksym H authored
      Closes https://github.com/paritytech/ci_cd/issues/1014
      
      Adds subsystem-benchmarking in GHA (only works with temp label)
    • dependabot[bot]'s avatar
      Bump libp2p-identity from 0.2.8 to 0.2.9 (#5232) · c5f6b700
      dependabot[bot] authored
      
      Bumps [libp2p-identity](https://github.com/libp2p/rust-libp2p) from
      0.2.8 to 0.2.9.
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/libp2p/rust-libp2p/releases">libp2p-identity's
      releases</a>.</em></p>
      <blockquote>
      <h2>libp2p-v0.53.2</h2>
      <p>See individual <a
      href="https://github.com/libp2p/rust-libp2p/blob/HEAD/CHANGELOG.md">changelogs</a>
      for details.</p>
      <h2>libp2p-v0.53.1</h2>
      <p>See individual <a
      href="https://github.com/libp2p/rust-libp2p/blob/HEAD/CHANGELOG.md">changelogs</a>
      for details.</p>
      <h2>libp2p-v0.53.0</h2>
      <p>The most ergonomic version of rust-libp2p yet!</p>
      <p>We've been busy again, with over <a
      href="https://github.com/libp2p/rust-libp2p/compare/libp2p-v0.52.0...master">250</a>
      PRs being merged into <code>master</code> since <code>v0.52.0</code>
      (excluding dependency updates).</p>
      <h2>Backwards-compatible features</h2>
      <p>Numerous improvements landed as patch releases since the
      <code>v0.52.0</code> release, for example a new, type-safe <a
      href="https://redirect.github.com/libp2p/rust-libp2p/pull/4120"><code>SwarmBuilder</code></a>
      that also encompasses the most common transport protocols:</p>
      <pre lang="rust"><code>let mut swarm =
      libp2p::SwarmBuilder::with_new_identity()
          .with_tokio()
          .with_tcp(
              tcp::Config::default().port_reuse(true).nodelay(true),
              noise::Config::new,
              yamux::Config::default,
          )?
          .with_quic()
          .with_dns()?
          .with_relay_client(noise::Config::new, yamux::Config::default)?
          .with_behaviour(|keypair, relay_client| Behaviour {
              relay_client,
              ping: ping::Behaviour::default(),
              dcutr: dcutr::Behaviour::new(keypair.public().to_peer_id()),
          })?
          .build();
      </code></pre>
      <p>The new builder makes heavy use of the type-system to guide you
      towards a correct composition of all transports. For example, it is
      important to compose the DNS transport as a wrapper around all other
      transports but before the relay transport. Luckily, you no longer need
      to worry about these details as the builder takes care of that for you!
      Have a look yourself if you dare <a
      href="https://github.com/libp2p/rust-libp2p/tree/master/libp2p/src/builder">here</a>
      but be warned, the internals are a bit wild :)</p>
      <p>Some more features that we were able to ship in <code>v0.52.X</code>
      patch-releases include:</p>
      <ul>
      <li><a
      href="https://redirect.github.com/libp2p/rust-libp2p/pull/4325">stable
      QUIC implementation</a></li>
      <li>for rust-libp2p compiled to WASM running in the browser
      <ul>
      <li><a
      href="https://redirect.github.com/libp2p/rust-libp2p/pull/4015">WebTransport
      support</a></li>
      <li><a
      href="https://redirect.github.com/libp2p/rust-libp2p/pull/4248">WebRTC
      support</a></li>
      </ul>
      </li>
      <li><a
      href="https://redirect.github.com/libp2p/rust-libp2p/pull/4156">UPnP
      implementation to automatically configure port-forwarding with ones
      gateway</a></li>
      <li><a
      href="https://redirect.github.com/libp2p/rust-libp2p/pull/4281">option
      to limit connections based on available memory</a></li>
      </ul>
      <p>We always try to ship as many features as possible in a
      backwards-compatible way to get them to you faster. Often times, these
      come with deprecations to give you a heads-up about what will change in
      a future version. We advise updating to each intermediate version rather
      than skipping directly to the most recent one, to avoid missing any
      crucial deprecation warnings. We highly recommend you stay up-to-date
      with the latest version to make upgrades as smooth as possible.</p>
      <p>Some improvments we unfortunately cannot ship in a way that Rust
      considers a non-breaking change but with every release, we attempt to
      smoothen the way for future upgrades.</p>
      <h2><code>#[non_exhaustive]</code> on key enums</h2>
      <!-- raw HTML omitted -->
      </blockquote>
      <p>... (truncated)</p>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li>See full diff in <a
      href="https://github.com/libp2p/rust-libp2p/commits">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      
      [![Dependabot compatibility
      score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=libp2p-identity&package-manager=cargo&previous-version=0.2.8&new-version=0.2.9)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits
      that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after
      your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge
      and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating
      it. You can achieve the same result by closing it manually
      - `@dependabot show <dependency name> ignore conditions` will show all
      of the ignore conditions of the specified dependency
      - `@dependabot ignore this major version` will close this PR and stop
      Dependabot creating any more for this major version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this minor version` will close this PR and stop
      Dependabot creating any more for this minor version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this dependency` will close this PR and stop
      Dependabot creating any more for this dependency (unless you reopen the
      PR or upgrade to it yourself)
      
      
      </details>
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
  5. Aug 12, 2024
    • eskimor's avatar
      Bump authoring duration for async backing to 2s. (#5195) · 819a5818
      eskimor authored
      
      Should be safe on all production network. 
      
      I noticed that Paseo needs to be updated, it is lacking behind in a
      couple of things.
      
      Execution environment parameters should be updated to those of Polkadot:
      
      ```
      [
            {
              MaxMemoryPages: 8,192
            }
            {
              PvfExecTimeout: [
                Backing
                2,500
              ]
            }
            {
              PvfExecTimeout: [
                Approval
                15,000
              ]
            }
          ]
        ]
        ```
      
      ---------
      
      Co-authored-by: default avatareskimor <eskimor@no-such-url.com>
    • Elias Rad's avatar
      Fix spelling issues (#5206) · bc22f086
      Elias Rad authored
      Hello
      I found several spelling errors.
      Br, Elias.
    • dependabot[bot]'s avatar
      Bump the known_good_semver group across 1 directory with 3 updates (#5315) · 79e9aa58
      dependabot[bot] authored
      
      Bumps the known_good_semver group with 2 updates in the / directory:
      [serde](https://github.com/serde-rs/serde) and
      [serde_json](https://github.com/serde-rs/json).
      
      Updates `serde` from 1.0.204 to 1.0.206
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/serde-rs/serde/releases">serde's
      releases</a>.</em></p>
      <blockquote>
      <h2>v1.0.206</h2>
      <ul>
      <li>Improve support for <code>flatten</code> attribute inside of enums
      (<a
      href="https://redirect.github.com/serde-rs/serde/issues/2567">#2567</a>,
      thanks <a
      href="https://github.com/Mingun"><code>@​Mingun</code></a>)</li>
      </ul>
      <h2>v1.0.205</h2>
      <ul>
      <li>Use serialize_entry instead of serialize_key + serialize_value when
      serialize flattened newtype enum variants (<a
      href="https://redirect.github.com/serde-rs/serde/issues/2785">#2785</a>,
      thanks <a
      href="https://github.com/Mingun"><code>@​Mingun</code></a>)</li>
      <li>Avoid triggering a collection_is_never_read lint in the
      deserialization of enums containing flattened fields (<a
      href="https://redirect.github.com/serde-rs/serde/issues/2791">#2791</a>)</li>
      </ul>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/serde-rs/serde/commit/85c73ef8dea8966d88a03876e6f0dc9359e68cc9"><code>85c73ef</code></a>
      Release 1.0.206</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/5ba1796a7e639839d4e18c3ae23b9bb32b0700b5"><code>5ba1796</code></a>
      Resolve doc_markdown pedantic lint on regression test function</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/e52b7b380f88e0112c9f84e6258bdd34ad132352"><code>e52b7b3</code></a>
      Touch up PR 2567</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/84c7419652161bf88f88eb26302b26debfff8a8c"><code>84c7419</code></a>
      Merge pull request <a
      href="https://redirect.github.com/serde-rs/serde/issues/2794">#2794</a>
      from dtolnay/neverread</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/536221b1f93a5dcf97352c7d1e3b93a5a56bf747"><code>536221b</code></a>
      Temporarily ignore collection_is_never_read on
      FlattenSkipDeserializing</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/fc55ac70d34221b38672b1583e496011fbae92aa"><code>fc55ac7</code></a>
      Merge pull request <a
      href="https://redirect.github.com/serde-rs/serde/issues/2567">#2567</a>
      from Mingun/fix-2565</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/2afe5b4ef9d0e89587ec564eadbc7583fd1f0673"><code>2afe5b4</code></a>
      Add regression test for issue <a
      href="https://redirect.github.com/serde-rs/serde/issues/2792">#2792</a></li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/b4ec2595c9dd8e380227043eba42ff85beb780c2"><code>b4ec259</code></a>
      Correctly process flatten fields in enum variants</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/c3ac7b675a38a73170879992976acb0009834ac0"><code>c3ac7b6</code></a>
      Add regression test for issue <a
      href="https://redirect.github.com/serde-rs/serde/issues/1904">#1904</a></li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/24614e44bff5466057e46c55394bac3ae20142c4"><code>24614e4</code></a>
      Add regression test for issue <a
      href="https://redirect.github.com/serde-rs/serde/issues/2565">#2565</a></li>
      <li>Additional commits viewable in <a
      href="https://github.com/serde-rs/serde/compare/v1.0.204...v1.0.206">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      Updates `serde_derive` from 1.0.204 to 1.0.206
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/serde-rs/serde/releases">serde_derive's
      releases</a>.</em></p>
      <blockquote>
      <h2>v1.0.206</h2>
      <ul>
      <li>Improve support for <code>flatten</code> attribute inside of enums
      (<a
      href="https://redirect.github.com/serde-rs/serde/issues/2567">#2567</a>,
      thanks <a
      href="https://github.com/Mingun"><code>@​Mingun</code></a>)</li>
      </ul>
      <h2>v1.0.205</h2>
      <ul>
      <li>Use serialize_entry instead of serialize_key + serialize_value when
      serialize flattened newtype enum variants (<a
      href="https://redirect.github.com/serde-rs/serde/issues/2785">#2785</a>,
      thanks <a
      href="https://github.com/Mingun"><code>@​Mingun</code></a>)</li>
      <li>Avoid triggering a collection_is_never_read lint in the
      deserialization of enums containing flattened fields (<a
      href="https://redirect.github.com/serde-rs/serde/issues/2791">#2791</a>)</li>
      </ul>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/serde-rs/serde/commit/85c73ef8dea8966d88a03876e6f0dc9359e68cc9"><code>85c73ef</code></a>
      Release 1.0.206</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/5ba1796a7e639839d4e18c3ae23b9bb32b0700b5"><code>5ba1796</code></a>
      Resolve doc_markdown pedantic lint on regression test function</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/e52b7b380f88e0112c9f84e6258bdd34ad132352"><code>e52b7b3</code></a>
      Touch up PR 2567</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/84c7419652161bf88f88eb26302b26debfff8a8c"><code>84c7419</code></a>
      Merge pull request <a
      href="https://redirect.github.com/serde-rs/serde/issues/2794">#2794</a>
      from dtolnay/neverread</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/536221b1f93a5dcf97352c7d1e3b93a5a56bf747"><code>536221b</code></a>
      Temporarily ignore collection_is_never_read on
      FlattenSkipDeserializing</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/fc55ac70d34221b38672b1583e496011fbae92aa"><code>fc55ac7</code></a>
      Merge pull request <a
      href="https://redirect.github.com/serde-rs/serde/issues/2567">#2567</a>
      from Mingun/fix-2565</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/2afe5b4ef9d0e89587ec564eadbc7583fd1f0673"><code>2afe5b4</code></a>
      Add regression test for issue <a
      href="https://redirect.github.com/serde-rs/serde/issues/2792">#2792</a></li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/b4ec2595c9dd8e380227043eba42ff85beb780c2"><code>b4ec259</code></a>
      Correctly process flatten fields in enum variants</li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/c3ac7b675a38a73170879992976acb0009834ac0"><code>c3ac7b6</code></a>
      Add regression test for issue <a
      href="https://redirect.github.com/serde-rs/serde/issues/1904">#1904</a></li>
      <li><a
      href="https://github.com/serde-rs/serde/commit/24614e44bff5466057e46c55394bac3ae20142c4"><code>24614e4</code></a>
      Add regression test for issue <a
      href="https://redirect.github.com/serde-rs/serde/issues/2565">#2565</a></li>
      <li>Additional commits viewable in <a
      href="https://github.com/serde-rs/serde/compare/v1.0.204...v1.0.206">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      Updates `serde_json` from 1.0.121 to 1.0.124
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/serde-rs/json/releases">serde_json's
      releases</a>.</em></p>
      <blockquote>
      <h2>v1.0.124</h2>
      <ul>
      <li>Fix a bug in processing string escapes in big-endian architectures
      (<a
      href="https://redirect.github.com/serde-rs/json/issues/1173">#1173</a>,
      thanks <a
      href="https://github.com/purplesyringa"><code>@​purplesyringa</code></a>)</li>
      </ul>
      <h2>v1.0.123</h2>
      <ul>
      <li>Optimize string parsing by applying SIMD-within-a-register: 30.3%
      improvement on <a
      href="https://github.com/miloyip/nativejson-benchmark/blob/v1.0.0/data/twitter.json">twitter.json</a>
      from 613 MB/s to 799 MB/s (<a
      href="https://redirect.github.com/serde-rs/json/issues/1161">#1161</a>,
      thanks <a
      href="https://github.com/purplesyringa"><code>@​purplesyringa</code></a>)</li>
      </ul>
      <h2>v1.0.122</h2>
      <ul>
      <li>Support using <code>json!</code> in no-std crates (<a
      href="https://redirect.github.com/serde-rs/json/issues/1166">#1166</a>)</li>
      </ul>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/serde-rs/json/commit/cf771a0471dd797b6fead77e767f2f7943740c98"><code>cf771a0</code></a>
      Release 1.0.124</li>
      <li><a
      href="https://github.com/serde-rs/json/commit/8b314a77bf57ad8d6089536fea1b3c3b303cba92"><code>8b314a7</code></a>
      Merge pull request <a
      href="https://redirect.github.com/serde-rs/json/issues/1173">#1173</a>
      from iex-rs/fix-big-endian</li>
      <li><a
      href="https://github.com/serde-rs/json/commit/8eba7863b126584f4b9a5b1d3cc4cbc0d0f59976"><code>8eba786</code></a>
      Fix skip_to_escape on BE architectures</li>
      <li><a
      href="https://github.com/serde-rs/json/commit/2cab07e68607ab0e11c3a8b0461a472c37886210"><code>2cab07e</code></a>
      Release 1.0.123</li>
      <li><a
      href="https://github.com/serde-rs/json/commit/346189a524694b98b92ccccb07775868d34b144c"><code>346189a</code></a>
      Fix needless_borrow clippy lint in new control character test</li>
      <li><a
      href="https://github.com/serde-rs/json/commit/859ead8e6d60f4eaed97f7ac2b18f879bec5afe5"><code>859ead8</code></a>
      Merge pull request <a
      href="https://redirect.github.com/serde-rs/json/issues/1161">#1161</a>
      from iex-rs/vectorized-string-parsing</li>
      <li><a
      href="https://github.com/serde-rs/json/commit/e43da5ee0e64819972f08254e8ce799796238791"><code>e43da5e</code></a>
      Immediately bail-out on empty strings</li>
      <li><a
      href="https://github.com/serde-rs/json/commit/8389d8a11293616ce5a4358651aede271871248d"><code>8389d8a</code></a>
      Don't run the slow algorithm from the beginning</li>
      <li><a
      href="https://github.com/serde-rs/json/commit/1f0dcf791ab1756d7ad07c20889e50bd9a7887fb"><code>1f0dcf7</code></a>
      Allow clippy::items_after_statements</li>
      <li><a
      href="https://github.com/serde-rs/json/commit/a95d6df9d08611c9a11ac6524903d693921b8eae"><code>a95d6df</code></a>
      Big endian support</li>
      <li>Additional commits viewable in <a
      href="https://github.com/serde-rs/json/compare/v1.0.121...v1.0.124">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits
      that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after
      your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge
      and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating
      it. You can achieve the same result by closing it manually
      - `@dependabot show <dependency name> ignore conditions` will show all
      of the ignore conditions of the specified dependency
      - `@dependabot ignore <dependency name> major version` will close this
      group update PR and stop Dependabot creating any more for the specific
      dependency's major version (unless you unignore this specific
      dependency's major version or upgrade to it yourself)
      - `@dependabot ignore <dependency name> minor version` will close this
      group update PR and stop Dependabot creating any more for the specific
      dependency's minor version (unless you unignore this specific
      dependency's minor version or upgrade to it yourself)
      - `@dependabot ignore <dependency name>` will close this group update PR
      and stop Dependabot creating any more for the specific dependency
      (unless you unignore this specific dependency or upgrade to it yourself)
      - `@dependabot unignore <dependency name>` will remove all of the ignore
      conditions of the specified dependency
      - `@dependabot unignore <dependency name> <ignore condition>` will
      remove the ignore condition of the specified dependency and ignore
      conditions
      
      
      </details>
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
    • Alexander Theißen's avatar
      `polkadot-node-core-pvf-common`: Fix test compilation error (#5310) · 8e8dc618
      Alexander Theißen authored
      This crate only uses `tempfile` on linux but includes it unconditionally
      in its `Cargo.toml`. It also sets `#![deny(unused_crate_dependencies)]`.
      This leads to an hard error to anything that is not Linux.
      
      This PR fixes this error. I am wondering why CI didn't catch that.
      Shouldn't the test at least be compiled (but not run) on macOS?
    • Javyer's avatar
      ci: Paused `cmd-action` commenter (#5287) · aca25a00
      Javyer authored
      Paused the action which comments on every command starting with `bot `
      until we can fix all the commands which are not working.
    • Nazar Mokrynskyi's avatar
      Remove unnecessary mut (#5318) · bcc96733
      Nazar Mokrynskyi authored
      
      Trivial leftover from
      https://github.com/paritytech/polkadot-sdk/pull/4844
      
      Co-authored-by: default avatarAdrian Catangiu <adrian@parity.io>
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
    • Michal Kucharczyk's avatar
      chain-spec: minor clarification on the genesis config patch (#5324) · b52cfc26
      Michal Kucharczyk authored
      Added minor clarification on the genesis config patch
      ([link](https://substrate.stackexchange.com/questions/11813/in-the-genesis-config-what-does-the-patch-key-do/11825#11825))
      
      ---------
      
      Co-authored-by: command-bot <>
    • Alin Dima's avatar
      fix av-distribution Jaeger spans mem leak (#5321) · fc906d5d
      Alin Dima authored
      Fixes https://github.com/paritytech/polkadot-sdk/issues/5258