- Apr 12, 2023
-
-
Adrian Catangiu authored
* add cost/benefit to gossip messages * report BEEFY gossip peer reputation changes * drop WorkerParams helper struct * add reputation costs to tests * add peer reputation cost/benefit to on-demand-requests protocol * include amount of signatures checked in invalid proof reputation cost Signed-off-by: Adrian Catangiu <[email protected]>
-
- Apr 11, 2023
-
-
Mira Ressel authored
-
yjh authored
-
- Apr 10, 2023
-
-
Liam Aharon authored
-
- Apr 09, 2023
-
-
yjh authored
* refactor: use builder api for all executors * improve a lot * remove unused args * cleanup deps * fix inconsistency about heap alloc * add `heap_pages` back to try-runtime * fix * chore: reduce duplicated code for sc-service-test * cleanup code * fmt * improve test executor * improve * use #[deprecated] * set runtime_cache_size: 4 * fix and improve * refactor builder * fix * fix bench * fix tests * fix warnings * fix warnings * fix * fix * update by suggestions * update name
-
- Apr 07, 2023
-
-
Marcin S. authored
* WASM executor: add `OutputExceedsBounds` variant to `Error` Previously this was a `WasmError`, which is intended for runtime construction errors. However this led to confusion as output-exceeds-bounds occurs due to execution of `validate_block`. * Fix warning
-
Aaro Altonen authored
* Make blocks per request configurable * Correct type * Update docs * Update client/cli/src/params/network_params.rs
-
- Apr 06, 2023
-
-
Chris Kerr authored
* Fix typo GRANPA -> GRANDPA * Fix capitalisation Fixed words capitalised in the middle of sentences.
-
Liam Aharon authored
-
- Apr 05, 2023
-
-
Bastian Köcher authored
* TrieRecorder: Start adding support for transactions * Adds `transactions` functions and some test * More tests * Docs * Ensure that we rollback failed transactions in the storage proof * FMT * Update primitives/trie/src/recorder.rs Co-authored-by: Dmitry Markin <[email protected]> * Review comments * Update primitives/trie/src/recorder.rs Co-authored-by: Sebastian Kunert <[email protected]> * ".git/.scripts/commands/fmt/fmt.sh" * For the holy clippy! * Update primitives/trie/src/recorder.rs Co-authored-by: Anton <[email protected]> --------- Co-authored-by: Dmitry Markin <[email protected]> Co-authored-by: Sebastian Kunert <[email protected]> Co-authored-by: command-bot <> Co-authored-by: Anton <[email protected]>
-
Bastian Köcher authored
Instead of registering `ReadRuntimeVersionExt` in `sp-state-machine` it is moved to `ExecutionExtension` which provides the default extensions.
-
- Apr 04, 2023
-
-
s0me0ne-unkn0wn authored
* Expose WASM extensions in executor semantics * Fix benches * Remove redundant extensions
-
Bastian Köcher authored
This removes the deprecated batch verification. This was actually never really activated. Nevertheless, we need to keep the host functions around to support old runtimes which may import these host functions. However, we do not give access to these functions anymore. This means that any new runtime can not call them anymore. The host function implementations we keep will not do batch verification and will instead fall back to the always existing option of directly verifying the passed signature. `finish_batch_verification` will return the combined result of all the batch verify calls. This removes the `TaskExecutorExt` which only existed to support the batch verification. So, any code that used this extension can just remove the registration of them. It also removes `SignatureBatching` that was used by `frame-executive` to control the batch verification. However, there wasn't any `Verify` implementation that called the batch verification functions.
-
- Apr 03, 2023
-
-
Bastian Köcher authored
This fixes the compilation on master for the node template that was not pulling the latest release as part of its build.
-
Damian Straszak authored
* Changes in RPC docs. * ".git/.scripts/commands/fmt/fmt.sh" --------- Co-authored-by: command-bot <>
-
- Mar 31, 2023
-
-
asynchronous rob authored
* Extract most aura logic out to standalone module, make use of these * Update client/consensus/aura/src/standalone.rs improve docs Co-authored-by: Bastian Köcher <[email protected]> * add slot_duration_at * ".git/.scripts/commands/fmt/fmt.sh" --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: parity-processbot <>
-
- Mar 30, 2023
-
-
Adrian Catangiu authored
* sc-consensus-beefy: add justifications to gossip protocol * sc-consensus-beefy: voter gossips finality proofs * sc-consensus-beefy: add finality proof gossip test * sc-consensus-beefy: always gossip finality proof Gossip finality proof in _both_ cases of reaching finality threshold through votes: 1. threshold reached through self vote, 2. threshold reached through incoming vote. * address comments
-
Aaro Altonen authored
* Attempt to relieve pressure on `mpsc_network_worker` `SyncingEngine` interacting with `NetworkWorker` can put a lot of strain on the channel if the number of inbound connections is high. This is because `SyncingEngine` is notified of each inbound substream which it then can either accept or reject and this causes a lot of message exchange on the already busy channel. Use a direct channel pair between `Protocol` and `SyncingEngine` to exchange notification events. It is a temporary change to alleviate the problems caused by syncing being an independent protocol and the fix will be removed once `NotificationService` is implemented. * Apply review comments * fixes * trigger ci * Fix tests Verify that both peers have a connection now that the validation goes through `SyncingEngine`. Depending on how the tasks are scheduled, one of them might not have the peer registered in `SyncingEngine` at which point the test won't make any progress because block announcement received from an unknown peer is discarded. Move polling of `ChainSync` at the end of the function so that if a block announcement causes a block request to be sent, that can be sent in the same call to `SyncingEngine::poll()`. --------- Co-authored-by: parity-processbot <>
-
- Mar 29, 2023
-
-
Davide Galassi authored
* Generic testing keystore internals * Generic local keystore internals * Restore deleted comment
-
- Mar 28, 2023
-
-
Sebastian Kunert authored
* Remove `HeaderBackend` requirement from `NetworkWorker` * Remove HeaderBackend from authority-discovery
-
- Mar 27, 2023
-
-
Bastian Köcher authored
-
- Mar 26, 2023
-
-
yjh authored
* chore(sc-cli): improve runner and signals * Update client/cli/src/runner.rs * fmt --------- Co-authored-by: Bastian Köcher <[email protected]>
-
- Mar 24, 2023
-
-
Aaro Altonen authored
`Protocol` is not a reliable source for the information of connected peers because it doesn't have real-time information of the actual connectivity state because it's not resposible for accepting/rejecting connections and gets that information with delay from `SyncinEngine`.
-
Bastian Köcher authored
* try-runtime: Use configured wasm execution method * Fix compilation
-
Davide Galassi authored
* Introduce keystore specialized sign methods * Get rid of 'AppKey::UntypedGeneric' associated type. Untyped generics are accessible using associated types 'Generic' associated type. I.e. <T as AppKey>::Public::Generic * Get rid of 'CryptoTypePublicPair' * Trivial fix * Small refactory of local keystore implementations * Remove 'crypto_id' method from 'Public' * Trivial rename of 'AppKey' to 'AppCrypto' * Remove unused import * Improve docs * Better signature related errors for authority-discovery * Apply review suggestion * Apply review suggestions Co-authored-by: Koute <[email protected]> * Authority discoverty signing error revisited * Signing error revisited for babe and aura as well * Further cleanup --------- Co-authored-by: Koute <[email protected]>
-
- Mar 23, 2023
-
-
Alexandru Vasile authored
* chain_head/tests: Mock client for custom block notification Signed-off-by: Alexandru Vasile <[email protected]> * chain_head/tests: Check finalized block event before new block Signed-off-by: Alexandru Vasile <[email protected]> * Update client/rpc-spec-v2/src/chain_head/test_utils.rs Co-authored-by: Bastian Köcher <[email protected]> * Update client/rpc-spec-v2/src/chain_head/test_utils.rs Co-authored-by: Bastian Köcher <[email protected]> * Update client/rpc-spec-v2/src/chain_head/test_utils.rs Co-authored-by: Bastian Köcher <[email protected]> * chain_head/tests: Run import events with 10min timeout Signed-off-by: Alexandru Vasile <[email protected]> * chain_head/tests: Add comments about test Signed-off-by: Alexandru Vasile <[email protected]> --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
-
Sebastian Kunert authored
* Remove unused light-client leftover * Remove more unused code
-
- Mar 22, 2023
-
-
Alexandru Vasile authored
* chain_head/follow: Ensure correct events for finalized branch Signed-off-by: Alexandru Vasile <[email protected]> * Reenable tests Signed-off-by: Alexandru Vasile <[email protected]> * Do some clean ups and add some more docs * Fix gramatic * Update client/rpc-spec-v2/src/chain_head/chain_head_follow.rs Co-authored-by: Sebastian Kunert <[email protected]> * rpc/chain_head: Introduce error for absent headers Signed-off-by: Alexandru Vasile <[email protected]> --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Sebastian Kunert <[email protected]>
-
- Mar 21, 2023
-
-
Niklas Adolfsson authored
This limit is not needed anymore as the JSON-RPC servers doesn't terminate the connection if the RPC max limit is exceeded anymore
-
Arkadiy Paronyan authored
-
- Mar 20, 2023
-
-
Davide Galassi authored
* Remove bloat about remote keystore * Update docs and remove unused 'KeystoreRef' trait * Use wherever possible, MemoryKeystore for testing * Remove unrequired fully qualified method syntax for Keystore
-
Mira Ressel authored
The comment was out of date anyway, State::Live no longer takes a snapshot_path argument.
-
- Mar 17, 2023
-
-
Oliver Tale-Yazdi authored
* Ignore flaky test Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Re-enable running_the_node_works_and_can_be_interrupted Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Re-enable notifications_back_pressure Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Unused import Signed-off-by: Oliver Tale-Yazdi <[email protected]> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]>
-
PG Herveou authored
* Fix typos in pallet-contracts
-
Davide Galassi authored
-
Davide Galassi authored
* Remove 'supported_keys' 'sign_with_any' and 'sign_with_all' from keystore trait * Remove the aync keystore * Renaming: - SyncCryptoStore -> Keystore - SyncCryptoStorePtr -> KeystorePtr - KeyStore -> MemoryKeystore * Fix authority discovery worker and tests * Rename 'insert_unknown' to 'insert' * Remove leftover
-
- Mar 16, 2023
-
-
Bastian Köcher authored
* Try to fix flaky `temp-base-path-work` test The test is most of the time failing when checking if the database path was deleted. The assumption is that it takes a little bit more time by the OS to actually clean up the temp path under high load. The pr tries to fix this by checking multiple times if the path was deleted. Besides that it also ensures that the tests that require the benchmark feature don't fail when compiled without the feature. * ".git/.scripts/commands/fmt/fmt.sh" * Capture signals earlier * Rewrite tests to let them having one big timeout * Remove unneeded dep * Update bin/node/cli/tests/common.rs Co-authored-by: Koute <[email protected]> * Review feedback * Update bin/node/cli/tests/common.rs Co-authored-by: Anton <[email protected]> --------- Co-authored-by: command-bot <> Co-authored-by: Koute <[email protected]> Co-authored-by: Anton <[email protected]>
-
Adrian Catangiu authored
* sc-consensus-beefy: improve beefy gossip validator Old gossip validator was pretty dumb, being very permissive with incoming votes - only condition it had was to be newer than best finalized. New filter conditions: - voter rounds are initialized (discarding votes until voter is actually active), - only votes for current active set id are accepted, - only votes for rounds in the current voting session are accepted, - only votes for GRANDPA finalized blocks are accepted, - when BEEFY voter reaches mandatory round, only votes for said mandatory round are accepted. New validator uses the VoterOracle to easily implement above conditions and only allow through votes that are immediately useful to the voter. After every GRANDPA or BEEFY finality, the gossip validator filter is updated. * sc-consensus-beefy: remove votes enqueueing Since gossip validator will simply disallow votes for future rounds, and only allow votes that the voter can immediately process, there is no need for the voter to enqueue votes. It will see these "future" votes later in rebroadcasts, when voter will also be able to process them. Only at that point does gossip accept and consume them. * sc-consensus-beefy: refactor persistent state Move best-beefy and best-grandpa into VoterOracle instead of passing them around as params. VoterOracle ultimately needs to know best-beefy and/or best-grandpa for most of its functions. * sc-consensus-beefy: further restrict gossip validator Assuming mandatory done in current session: Instead of allowing votes for any round in the current session, only accept votes for rounds equal or better than best BEEFY finalized. * sc-consensus-beefy: add a couple of comments * sc-consensus-beefy: fix tests involving multiple tasks Finalize blocks one a time in tests where we want gossip to happen in a certain round. Otherwise, some tasks may be left behind in terms of gossip round numbers because once "scheduled" a task will greedily process as much as possible. This change should be in line with the real-world scenario where voters run "in parallel" across nodes, the only points of synchronization being the finality notifications. * sc-consensus-beefy: address review comments --------- Signed-off-by: acatangiu <[email protected]>
-
- Mar 15, 2023
-
-
Alexandru Vasile authored
* impl_runtime_apis: Generate getters for `metadata_at` functions Signed-off-by: Alexandru Vasile <[email protected]> * runtime: Implement new `Metadata` runtime trait Signed-off-by: Alexandru Vasile <[email protected]> * runtime: Move `metadata_at` functions to construct_runtime macro Signed-off-by: Alexandru Vasile <[email protected]> * contruct_runtime: Use `OpaqueMetadata` from hidden imports Signed-off-by: Alexandru Vasile <[email protected]> * Adjust testing Signed-off-by: Alexandru Vasile <[email protected]> * frame/tests: Add tests for the new API Signed-off-by: Alexandru Vasile <[email protected]> * frame/tests: Adjust metdata naming Signed-off-by: Alexandru Vasile <[email protected]> * frame/support: Expose `metadata-v14` feature flag Signed-off-by: Alexandru Vasile <[email protected]> * frame/support: Expose metadata only under feature flags Signed-off-by: Alexandru Vasile <[email protected]> * frame/support: Expose v14 metadata by default Signed-off-by: Alexandru Vasile <[email protected]> * frame/support: Expose metadata feature for testing Signed-off-by: Alexandru Vasile <[email protected]> * frame/support: Test metadata under different feature flags Signed-off-by: Alexandru Vasile <[email protected]> * Update primitives/api/src/lib.rs Co-authored-by: Bastian Köcher <[email protected]> * Update primitives/api/src/lib.rs Co-authored-by: Bastian Köcher <[email protected]> * client/tests: Adjust testing to reflect trait Metadata change Signed-off-by: Alexandru Vasile <[email protected]> * frame/metadata-ir: Add intermediate representation types for metadata Signed-off-by: Alexandru Vasile <[email protected]> * frame/metadata-ir: Convert metadata to V14 Signed-off-by: Alexandru Vasile <[email protected]> * frame/metadata-ir: Add API to convert metadata to multiple versions Signed-off-by: Alexandru Vasile <[email protected]> * frame/metadata-ir: Expose V14 under feature flag Signed-off-by: Alexandru Vasile <[email protected]> * frame/support: Adjust to metadata IR Signed-off-by: Alexandru Vasile <[email protected]> * frame/support: More adjustments Signed-off-by: Alexandru Vasile <[email protected]> * frame/support: Guard v14 details under feature flag Signed-off-by: Alexandru Vasile <[email protected]> * frame/support: Adjust testing Signed-off-by: Alexandru Vasile <[email protected]> * CI: Ensure `quick-benchmarks` uses `metadata-v14` Signed-off-by: Alexandru Vasile <[email protected]> * frame/support: Use `metadata-v14` for benchmarks Signed-off-by: Alexandru Vasile <[email protected]> * Adjust cargo fmt Signed-off-by: Alexandru Vasile <[email protected]> * kitchensink-runtime: Add feature flag for `metadata-v14` Signed-off-by: Alexandru Vasile <[email protected]> * frame/support/test: Adjust testing Signed-off-by: Alexandru Vasile <[email protected]> * frame/support/test: Check crates locally Signed-off-by: Alexandru Vasile <[email protected]> * Activate metadata-v14 for pallets Signed-off-by: Alexandru Vasile <[email protected]> * Remove metadata-v14 feature flag Signed-off-by: Alexandru Vasile <[email protected]> * frame/metadata_ir: Move `api.rs` to `mod.rs` Signed-off-by: Alexandru Vasile <[email protected]> * frame/support: Handle latest metadata conversion via IR Signed-off-by: Alexandru Vasile <[email protected]> * frame/tests: Add constant for metadata version 14 Signed-off-by: Alexandru Vasile <[email protected]> * frame/support/test: Fix merge conflict Signed-off-by: Alexandru Vasile <[email protected]> * Update frame/support/Cargo.toml Co-authored-by: Bastian Köcher <[email protected]> * Update frame/support/src/metadata_ir/mod.rs Co-authored-by: Bastian Köcher <[email protected]> * Update frame/support/test/Cargo.toml Co-authored-by: Bastian Köcher <[email protected]> * Update primitives/api/src/lib.rs Co-authored-by: Bastian Köcher <[email protected]> * frame/metadata: Collect pallet documentation for MetadataIR Signed-off-by: Alexandru Vasile <[email protected]> * frame/tests: Check pallet documentation is propagated to MetadataIR Signed-off-by: Alexandru Vasile <[email protected]> * frame/support: Improve documentation Signed-off-by: Alexandru Vasile <[email protected]> --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: parity-processbot <> Co-authored-by: Bastian Köcher <[email protected]>
-
- Mar 14, 2023
-
-
cheme authored
-