Skip to content
  1. Aug 14, 2023
  3. Aug 11, 2023
    • Adrian Catangiu's avatar
      companion for 14754: cli: move no-beefy flag to sc-cli (#7600) · 26adab4f
      Adrian Catangiu authored 
      

* cli: move no-beefy flag to substrate sc-cli config

* bump substrate ref

---------

Signed-off-by: default avatarAdrian Catangiu <[email protected]>
      26adab4f
    • Chevdor's avatar
      Publish RC container images (#7556) · 693a29da
      Chevdor authored 
      

* WIP

* Add missing checkout

* Add debuggin

* Fix VAR name

* Bug fix

* Rework jobs

* Revert "Rework jobs"

This reverts commit 2bfa79fd3ae633c17403b838f9a5025f0f7fc3f3.

* Add cache

* Add temp default for testing

* Add missing checkout

* Fix patch

* Comment out the GPG check for now

* Rename polkadot_injected_release into a more appropriate polkadot_injected_debian

* Refactoring / renaming

* Introduce a generic image for binary injection

* Flag files to be deleted and changes to be done

* WIP

* Fix multi binaries images

* Add test build scripts

* Remove old file, add polkadot build-injected script

* Fix doc

* Fix tagging

* Add build of the injected container

* Fix for docker

* Remove the need for TTY

* Handling container publishing

* Fix owner and registry

* Fix vars

* Fix repo

* Fix var naming

* Fix case when there is no tag

* Fix case with no tag

* Handle error

* Fix spacings

* Fix tags

* Remove unnecessary grep that may fail

* Add final check

* Clean up and introduce GPG check

* Add doc

* Add doc

* Update doc/docker.md

Co-authored-by: default avatarMira Ressel <[email protected]>

* type

Co-authored-by: default avatarMira Ressel <[email protected]>

* Fix used VAR

* Improve doc

* ci: Update .build-push-image jobs to use the new build-injected.sh

* ci: fix path to build-injected.sh script

* Rename the release artifacts folder to prevent confusion due to a similar folder in the gitlab CI

* ci: check out polkadot repo in .build-push-image

This seems far cleaner than copying the entire scripts/ folder into our
job artifacts.

* feat(build-injected.sh): make PROJECT_ROOT configurable

This lets us avoid a dependency on git in our CI image.

* ci: build injected images with buildah

* ci: pass full image names to zombienet

* Add missing ignore

---------

Co-authored-by: default avatarMira Ressel <[email protected]>
      693a29da
  5. Aug 10, 2023
  7. Aug 09, 2023
  9. Aug 08, 2023
  11. Aug 07, 2023
  13. Aug 05, 2023
  15. Aug 04, 2023
  17. Aug 03, 2023
  19. Aug 02, 2023
  21. Aug 01, 2023
    • eskimor's avatar
      Take into account size as well in weight limiting. (#7369) · 367098ba
      eskimor authored 
      

* Take into account size as well in weight limiting.

* Fix logging.

* More logs.

* Remove randomized selection in provisioner

No longer supported by runtime.

* Fix and simplify weight calculation.

Random filtering of remote disputes got dropped.

* Make existing tests pass.

* Tests for size limiting.

* Fix provisioner.

* Remove rand dependency.

* Better default block length for tests.

* ".git/.scripts/commands/bench/bench.sh" runtime kusama runtime_parachains::paras_inherent

* ".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent

* ".git/.scripts/commands/bench/bench.sh" runtime westend runtime_parachains::paras_inherent

* Update runtime/parachains/src/paras_inherent/mod.rs

Co-authored-by: default avatarTsvetomir Dimitrov <[email protected]>

* Update runtime/parachains/src/paras_inherent/mod.rs

Co-authored-by: default avatarChris Sosnin <[email protected]>

* Add back missing line.

* Fix test.

* fmt fix.

* Add missing test annotation

---------

Co-authored-by: default avatareskimor <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: default avatarTsvetomir Dimitrov <[email protected]>
Co-authored-by: default avatarChris Sosnin <[email protected]>
      367098ba
    • Branislav Kontur's avatar
      ` XcmContext` to `buy_weight / refund_weight` (#7563) · 4980b644
      Branislav Kontur authored 
      

* added XcmContext to WeightTrader trait

* cargo fmt

* make xcm context optional

* make compile

* fix compile

* `XcmContext` to `buy_weight / refund_weight`

---------

Co-authored-by: default avatarPatricio Napoli <[email protected]>
Co-authored-by: default avatarGiles Cope <[email protected]>
Co-authored-by: parity-processbot <>
      4980b644
    • Marcin S.'s avatar
      PVF: Fix external workers being required for non-collator full nodes (#7566) · f226cd5a
      Marcin S. authored 
      * PVF: Fix external workers being required for non-collator full nodes

* Fix

* Make check more precise

> This might as well be if role.is_authority() as there aren't really any nodes
> that are both authorities and collators. But if there were a node that is an
> authority and a collator, it'd probably want to validate candidates (in its
> role as an authority).

* Just seeing if this fixes zombienet CI...
      f226cd5a
  23. Jul 31, 2023
    • Marcin S.'s avatar
      98.6% OF DEVELOPERS CANNOT REVIEW THIS PR! [read more...] (#7337) · 85b06f18
      Marcin S. authored 
      

* [WIP] PVF: Split out worker binaries

* Address compilation problems and re-design a bit

* Reorganize once more, fix tests

* Reformat with new nightly to make `cargo fmt` test happy

* Address `clippy` warnings

* Add temporary trace to debug zombienet tests

* Fix zombienet node upgrade test

* Fix malus and its CI

* Fix building worker binaries with malus

* More fixes for malus

* Remove unneeded cli subcommands

* Support placing auxiliary binaries to `/usr/libexec`

* Fix spelling

* Spelling

Co-authored-by: default avatarMarcin S. <[email protected]>

* Implement review comments (mostly nits)

* Fix worker node version flag

* Rework getting the worker paths

* Address a couple of review comments

* Minor restructuring

* Fix CI error

* Add tests for worker binaries detection

* Improve tests; try to fix CI

* Move workers module into separate file

* Try to fix failing test and workers not printing latest version

- Tests were not finding the worker binaries
- Workers were not being rebuilt when the version changed
- Made some errors easier to read

* Make a bunch of fixes

* Rebuild nodes on version change

* Fix more issues

* Fix tests

* Pass node version from node into dependencies to avoid recompiles

- [X] get version in CLI
- [X] pass it in to service
- [X] pass version along to PVF
- [X] remove rerun from service
- [X] add rerun to CLI

- [X] don’t rerun pvf/worker’s (these should be built by nodes which have rerun enabled)

* Some more improvements for smoother tests

- [X] Fix tests
- [X] Make puppet workers pass None for version and remove rerun
- [X] Make test collators self-contained

* Add back rerun to PVF workers

* Move worker binaries into files in cli crate

As a final optimization I've separated out each worker binary from its own crate
into the CLI crate. Before, the worker bin shared a crate with the worker lib,
so when the binaries got recompiled so did the libs and everything transitively
depending on the libs. This commit fixes this regression that was causing
recompiles after every commit.

* Fix bug (was passing worker version for node version)

* Move workers out of cli into root src/bin/ dir

- [X] Pass in node version from top-level (polkadot)
- [X] Add build.rs with rerun-git-head to root dir

* Add some sanity checks for workers to dockerfiles

* Update malus

  + [X] Make it self-contained
  + [X] Undo multiple binary changes

* Try to fix clippy errors

* Address `cargo run` issue

- [X] Add default-run for polkadot
- [X] Add note about installation to error

* Update readme (installation instructions)

* Allow disabling external workers for local/testing setups

  + [X] cli flag to enable single-binary mode
  + [X] Add message to error

* Revert unnecessary Cargo.lock changes

* Remove unnecessary build scripts from collators

* Add back missing malus commands (should fix failing ZN job)

* Some minor fixes

* Update Cargo.lock

* Fix some build errors

* Undo self-contained binaries; cli flag to disable version check

  + [X] Remove --dont-run-external-workers
  + [X] Add --disable-worker-version-check
  + [X] Remove PVF subcommands
  + [X] Redo malus changes

* Try to fix failing job and add some docs for local tests

---------

Co-authored-by: default avatarDmitry Sinyavin <[email protected]>
Co-authored-by: default avatars0me0ne-unkn0wn <[email protected]>
Co-authored-by: parity-processbot <>
      85b06f18
  25. Jul 28, 2023
  27. Jul 27, 2023
  29. Jul 25, 2023
  31. Jul 24, 2023
  33. Jul 22, 2023
    • Xiliang Chen's avatar
      add missing feature flag (#7537) · 79341dd4
      Xiliang Chen authored
      79341dd4
    • jserrat's avatar
      add tests to worker common thread (#7372) · 3f8c3454
      jserrat authored 
      

* add tests to worker common thread

* fix formatting

* move worker commons unit test from integration tests to worker file and do some improvements

* fix import on it/worker_common

* move worker commons unit test to test module

* cargo fmt

* move cpu_time_monitor_loop to test outside of thread module

* change worker thread unit test to use assert_eq

* fix formatting

* adding new methods to WaitOucome, fix pvf worker unit test

* fix formatting

* remove is_finished and is_timeout methods from WaitOutcome

* fix wait_for_threads_with_timeout_returns_outcome test

* ".git/.scripts/commands/fmt/fmt.sh"

* add common worker cond_notify_on_done_should_update_wait_outcome_when_panic test

---------

Co-authored-by: default avatarMarcin S <[email protected]>
Co-authored-by: command-bot <>
      3f8c3454
  35. Jul 21, 2023