* Nuke V2

* fmt

* Formatting and imports

* Updated benches

* Fix doc comment link

* Brace imports in ws-server

* Reworking imports

* std first

* fmt

* std on top

* Update to match changed line numbers

* Rename jsonrpsee_utils -> jsonrpsee_core

* Migrating things types -> core

* RpcError -> ErrorResponse

* Merge types::client into core::client

* Continued move types -> core

* Removing features to make checks pass

* Move rpc_module tests to tests crate

* Fixed doc comment links

* Add futures-util dependency for client

* Remove dead code

Co-authored-by: Niklas Adolfsson <[email protected]>

* fmt

* Feature gate the Client trait

* Move `Client` traits to `client` module

Co-authored-by: Niklas Adolfsson <[email protected]>

* request ID as RAII guard

* clippify

* fmt

* address grumbles: naming

`RequestIdGuard` -> `RequestIdManager`
`RequestId` -> `RequestIdGuard`

* Update tokio-rustls requirement from 0.22 to 0.23

Updates the requirements on [tokio-rustls](https://github.com/tokio-rs/tls) to permit the latest version.
- [Release notes](https://github.com/tokio-rs/tls/releases)
- [Commits](https://github.com/tokio-rs/tls/commits

)

---
updated-dependencies:
- dependency-name: tokio-rustls
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* push fixes but requires rustls-native-certs v0.6

* update native certs to 0.6.0

* fix clippy warnings

* remove webpki roots support

* Revert "remove webpki roots support"

This reverts commit 1144d567b343049ab7c967d320fc2fe162ba0f7c.

* support both native cert store and webpki

* sort deps in Cargo.toml

* Update ws-client/src/transport.rs

Co-authored-by: David <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Niklas Adolfsson <[email protected]>
Co-authored-by: David <[email protected]>

* feat(ws client): support custom headers.

Closing #531

* remove empty line

* address grumbles: more user-friendly API

* Update ws-client/src/client.rs

Co-authored-by: David <[email protected]>

* Update ws-client/src/client.rs

Co-authored-by: David <[email protected]>

* Update ws-client/src/client.rs

Co-authored-by: David <[email protected]>

* address grumbles

Co-authored-by: David <[email protected]>

* fix(ParamsSer): serialize to empty array

Serialize `ParamsSer::NoParams` to an empty array inorder to comply with the jsonrpc v2 spec.

* fix tests

* remove ParamsSer::NoParams

* address grumbles: adjust rpc params macro

* feat(ws client): support redirections

* reuse socket

* reuse socket

* add hacks

* fix build

* remove hacks

* fix bad merge

* address grumbles

* fix grumbles

* fix grumbles

* fix nit

* add redirection test

* Update test-utils/src/types.rs

* Resolved todo

* Check that redirected client actually works

* Rename test-utils "types" to "mocks"

* Fix windows test (?)

* fmt

* What is wrong with you windows?

* Ignore redirect test on windows

* fix bad transport errors

* debug windows tests

* update soketto

* maybe fix windows test

* add config flag for max redirections

* revert faulty change.

Relative reference must start with either `/` or `//`

* revert windows path

* use manual join paths

* remove url dep

* Update ws-client/src/tests.rs

* default max redirects 5

* remove needless clone vec

* fix bad merge

* cmon CI run

Co-authored-by: David Palm <[email protected]>

* Move RequestIdGuard to types::client

* Use the RequestIdGuard type for the http client as well

* Fix batch request ID handling (one batch uses one slot)

* Add a few tests to check that max_concurrent_requests work for http clients

* Docs

* fix: server should not send to closed subscription

Closing #481

* add a test

* rewrite me

* remove faulty server close

* fix tests

* fix tests

* remove needless code

* Update ws-client/src/client.rs

* fix: remove atomic flag; use `close_sender`

* remove terminate message; use close channel

* remove faulty subscription closed error msg

* fix tests

* fix grumbles

* fix build

* Re-export v2::params, error, request and response types

* Use shallow type paths

* Renames

* More renames

* fmt

* s/RpcParams/Params/

* Add a type alias `SubscriptionResponse` to `Notification` which is parametrized to `SubscriptionPayload`
Move `SubscriptionResponse` to the `response` module

* Fix doc links

* Cleanup and some docs

* Review feedback

* cleanup

* Add license headers where missing and update year

* Update examples/http.rs

Co-authored-by: Niklas Adolfsson <[email protected]>

Co-authored-by: Niklas Adolfsson <[email protected]>

* rewrite me

* require proc macro API to return result

* send unknown message when error is not CallError

* show example that auto cast StdError doesn't work

* register_*_method Into<Error>

* clippy

* replace generic errors with anyhow::Error

* fix nits

* example that anyhow::Error in register_method works

* CallError: add missing From impl

* [types]: add helper methods for Error types

The rationale is to make it possible for users to either use anyhow::Error or use the helper methods.

* fmt

* Revert "register_*_method Into<Error>"

This reverts commit 33b4fa28730b72647ba150659d3c0ab1937e524a.

* add better comment

* fix nit

Co-authored-by: David Palm <[email protected]>

* Include "macros" in the "server" feature

* Re-export SubscriptionSink

* Include the "types" feature in both the "client" and "server" features
Export types::* from façade when the "types" is active
Export types::* from servers

* fmt

* Export jsonrpsee_types under types

* fmt

* broken doc link

* fix benches

* fmt

* Fix test imports

* [clients]: use request timeout by-default

* add timeout for notif

* more feature flag mess

* rexport tokio types

* Update ws-client/src/client.rs

Co-authored-by: Maciej Hirsz <[email protected]>

* Impose a timeout on all requests

Variant of #367

This PR takes a more opinionated stance than #367, where timeouts are optional. In this PR I suggest we make a all requests use a timeout and only let users choose the length.

* fmt

* Address review grumbles

* fmt

* Use tokio::select! for cleaner code

Co-authored-by: Niklas Adolfsson <[email protected]>
Co-authored-by: Maciej Hirsz <[email protected]>
Co-authored-by: Maciej Hirsz <[email protected]>

* [jsonrpsee types]: unify types + more tests

* address grumbles

* [client types]: fix #349

Subscription::next() propogate error when parsing the response fails

* unify subscription and notification

* rename again

* Update types/src/traits.rs

* fix bad merge

* Update types/src/client.rs

Co-authored-by: David <[email protected]>

* grumbles: subscribe_method -> subscribe_to_method

* Update tests/tests/integration_tests.rs

Co-authored-by: David <[email protected]>

* grumbles: doc links

Co-authored-by: David <[email protected]>

* Stick test code to a single runtime

* Replace async-std in ws-client with tokio

* Replace std::thread::sleep with tokio::time::sleep in test

* Add compatibility layer for tokio v0.2

* Add check for both features being enabled + some improvements

* Update ws-client/src/tokio.rs

Co-authored-by: Niklas Adolfsson <[email protected]>

* [ws client]: parse `path` from the URL

This commit changes that the path/HTTP resource path is parsed from the URL and removes that option
from WsClientBuilder.

* address grumbles: introduce `RemoteWsTarget` type.

* grumbles: RemoteWsTarget -> Target

* cargo fmt

* get started

* add additional test

* fix nits

* cargo fmt

* [types]: write some tests.

* [http server]: send empty response on notifs

* [http server]: fix tests

* [rpc module]: send subscription response

* Update types/src/v2/error.rs

* fix nits

* cargo fmt

* Update types/src/v2/params.rs

* remove needless clone

* remove dead code

* [types]: impl PartialEq for JsonErrorObject + test

* use beef::Cow

* Update http-server/src/tests.rs

* Add custom_certificate to WsClientBuilder

* Use system certs instead of specified file

* Cache client_config

* Move client_config logic to fn build

* Default use_system_certificates to true

* Move out connector

* Add CertificateStore type

* cargo fmt

* cargo clippy

* Resolve comment: Rename variable

* Resolved comments

* Rename NotifResponse to SubscriptionResponse to make room for new impl

* Add support for on_notification Subscription<T> types

* Fix handling of NotificationHandler in manager

* cleanup

* Implement NotificationHandler to replace Subscription<T> and clean up plumbing

* More cleanup

* impl Drop for NotificationHandler

* Address pr feedback #1

* ws client register_notification pr feedback 2

* Fix doc

* fix typo

* Add tests, get NH working

* More cleanup of String/&str

* fix doc

* Drop notification handler on send_back_sink error

* ws client notification auto unsubscribe when channel full test

* ret err if context/params fails

* address grumbles: specific error_code context fail

* address grumbles: make env_logger dev-dependency

* address grumbles: add tests

* chore(deps): remove unused deps

* address grumbles: rename types and docs

* address grumbles: more renaming.

* fix build

* [types]: allow `data` field in jsonrpc error obj.

* fmt

* revert change to make fail

* remove redundant test

* [types]: bring back `data` and `message` in error.

Basically deducing the error message from server defined error doesn't work
and we should not strip out this information from to user which might be useful.

* remove boiler plate code

* [types]: impl From<ErrorCode> for JsonRpcError

* address grumbles

* remove more boiler plate

I went over all the atomic operations and realised I could not convince myself that all uses of `Relaxed` were ok, so better safe than sorry: let's switch to `SeqCst`.

* Fix race conditions.

* 🥵

* Use SeqCst ordering.

* Use a constant to express max request body size
Consistently use u32 in all crates

* Review grumbles

* rewrite me

* v2

* PoC works without batch request

* remove `PartialEq` bounds

* add naive benches types

* misc

* remove useless lifetime

* [ws client]: move request ID generation to client

* make tests compile again

* [client transport]: kill leaky abstractions.

* [http client transport]: minor changes in the API.

* [ws client]: fix batch requests.

* fix nits

* [ws client]: generate two request IDs for subscrib

* fix tests

* remove unused types + less alloc for params.

* fix nits

* more tweaks.

* remove unused code

* fix more nits

* remove unused legacy types

* reorg types_v2 mod

* port macros to new types

* fix tests again; more jsonvalue

* [proc macros]: bring back impl Into for params.

* fix build

* [proc macros]: make it work for external crates.

* [types]: remove weird From<Option<T>> to impl.

* cleanup again

* [examples]: remove unused async-std dep

* Update types/src/v2/mod.rs

* [types]: remove unsed dep smallvec

* rewrite me

* [types]: error code impl ser/deser

Manual implementation of serialize/deserialize to get rid of duplicated message string

* [types v2]: re-org with explicit mods

* fix faulty test

* add missed files

* [ws client]: req_manager reserve unsubscribe slot.

* simplify test code

* add tracking issue for TODO

* remove unused deps

* reclaim request id for unsubscribe requests

* fmt

* cargo fmt

* [tests]: ignore https and wss requests.

Co-authored-by: Niklas Adolfsson <[email protected]>

* [ws client]: client builder for uniform API

* Update ws-client/src/transport.rs

* Update ws-client/src/client.rs

* Update ws-client/src/client.rs

* Update ws-client/src/client.rs

* feat(http client): batch requests

* fix(http batch request): request in any order.

* Update src/types/jsonrpc/id.rs

* tests(batch out-of-order): make it less confusing.

* fix nit: `cloned` -> `copied`

* fix bad merge

* [client]: batch request generic response

* wait with impl

* [ws client]: add template for batch requests

* remove jsonvalue

* naive impl

* fix make it work,

The implemenation is quite inefficient because the responses might be unordered.
Currently, a "digest" of a BTreeSet is stored to sort the requestIDs
and don't have to try all combinations of requestIDs in the response.

* fix nits

* error handling

* fix nits

* more nits

* use error msg pattern

* add batch requests to client trait

Keep it simple by require `Vec<(Method, Params)>` could be improved.

* address review comments: use swap_remove

Replace read values with `Vec::swap_remove` instead inserting dummy value.
The reason is that `Vec::remove` is O(n)

* address review grumbles: batch trait bound Default

* don't be clever

* [http client]: faster lookup for batch request.

* fix: distguish request_id and batch_id

* thanks clippy

* fix: clarify bad response with a separate error

* fix tests

* add issue link to todo

* Update types/src/error.rs

Co-authored-by: David <[email protected]>

Co-authored-by: David <[email protected]>

* [ws client]: unsubscribe directly

When a subscription is dropped because of `max_notifs_per_subscription` is exceeded
the client didn't send an `unsubcribe request` until the subscription was dropped which this commit fixes.

This causes the server to still send messages to the subscription and the client would get lots of
error messages `InvalidRequestId`

* address grumbles

* fix: rephrase and not use request everywhere.

* add shutdown receiver to ws-client

Signed-off-by: Gregory Hill <[email protected]>

* ws-client: no clone, use AtomicBool for shutdown signal

Signed-off-by: Gregory Hill <[email protected]>

* store not swap

Signed-off-by: Gregory Hill <[email protected]>

* doesn't need to be async, update doc comment

Signed-off-by: Gregory Hill <[email protected]>

* address review: use existing backgroud channel

Co-authored-by: Niklas Adolfsson <[email protected]>

* ignore front-end receiver close on process_response

Signed-off-by: Gregory Hill <[email protected]>

* simplify errors on sending to front

* fix import nit

Co-authored-by: Niklas Adolfsson <[email protected]>

* implement background error reporting

* introduce new error variant

* [ws client]: remove `Clone`

Breaking change which removes the `Clone` on the `WsClient`.
It's better that users explictly makes it clone if that's desired,
for example by putting it in `Arc<Mutex>`.

* fix build

* Update ws-client/src/client.rs

* remove unused arc

* Update ws-client/src/client.rs

Co-authored-by: David <[email protected]>

* Update ws-client/src/client.rs

Co-authored-by: David <[email protected]>

* Update ws-client/src/client.rs

Co-authored-by: David <[email protected]>

* fix rustdoc link

Co-authored-by: David <[email protected]>