Skip to content
  1. Nov 11, 2021
  3. Nov 10, 2021
  5. Nov 09, 2021
  7. Nov 08, 2021
  9. Nov 01, 2021
  11. Oct 15, 2021
  13. Oct 12, 2021
  15. Oct 11, 2021
    • Niklas Adolfsson's avatar
      [http server]: use tokio::spawn internally in `HttpServer::start` and return `StopHandle` (#402) · 6fb61dc1
      Niklas Adolfsson authored 
      

* [ws server]: refactor start()

* remove needless clone

* fix http server too

* fmt

* unify stop APIs

* fix bad merge

* add API to use custom tokio runtime

* use futures oneshot

* fix unintentional change

* Revert "use futures oneshot"

This reverts commit 0432f6ba41d49a3494943458657a31f8afd79160.

* Update http-server/src/server.rs

Co-authored-by: default avatarMaciej Hirsz <[email protected]>

Co-authored-by: default avatarMaciej Hirsz <[email protected]>
      6fb61dc1
    • Maciej Hirsz's avatar
      Resource Limiting (#500) · 518a6155
      Maciej Hirsz authored 
      

* Squash post merge

* RAII claims and some comments

* Adding resources to Methods

* Use arrays for claiming all resources at once

* Register resources on ws-server

* Return MethodResourcesBuilder from register_method

* Return MethodResourcesBuilder from register_async_method

* fmt and comments

* Add `verify_and_insert` to get rid of `or_insert` in order to get mut ref to value

* Resources initialization

* No need for ResourceBuilder

* Comment all the things

* Handle errors on ws-server `start` method

* Passing ResourceGuard to method execution

* Start ws-server in background, simplify all the tests!

* Claiming resources on runtime

* Do checked math on resource claiming

* Clearer error path for resources at limit

* Resource limiting tests WIP

* Unbox async futures

* fmt

* Cleaner proc macro

* Fix lifetime issues with ResourceGuard with internal Arc

* Remove unnecessary lifetime generic

* Working tests

* Use turbofish in tests

* fmt

* Fixed (?) benches

* Apply suggestions from code review

Co-authored-by: default avatarDavid <[email protected]>

* Tweak more grumbles

* Adding a test for resource limiting with proc macros (WIP)

* Reworking attribute macros for resource limiting (#507)

* Squashed macros WIP

* bae-less macros!

* Make things simpler and more readable

* Some comments and DRY aliases parsing

* Naming things is hard

* Respan is no longer needed

* Simpler Arguments

* Remove stale code

* Apply suggestions from code review

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>

* syn-up all the things, handle resources on methods

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>

* Resource limiting on the http server

* Test two resources at once

* Test the HTTP server for resource limiting

* Apply suggestions from code review

Co-authored-by: default avatarDavid <[email protected]>
Co-authored-by: default avatarNiklas Adolfsson <[email protected]>

* Comment tweaks

* More explicit error type for `AttributeMeta::retain`

* Remove generic from ResourceTable; derive Default on ws Builder

* Make the macros shorter

Co-authored-by: default avatarDavid <[email protected]>
Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
      518a6155
  17. Oct 05, 2021
    • Niklas Adolfsson's avatar
      ws client redirections (#397) · 94c881b8
      Niklas Adolfsson authored 
      

* feat(ws client): support redirections

* reuse socket

* reuse socket

* add hacks

* fix build

* remove hacks

* fix bad merge

* address grumbles

* fix grumbles

* fix grumbles

* fix nit

* add redirection test

* Update test-utils/src/types.rs

* Resolved todo

* Check that redirected client actually works

* Rename test-utils "types" to "mocks"

* Fix windows test (?)

* fmt

* What is wrong with you windows?

* Ignore redirect test on windows

* fix bad transport errors

* debug windows tests

* update soketto

* maybe fix windows test

* add config flag for max redirections

* revert faulty change.

Relative reference must start with either `/` or `//`

* revert windows path

* use manual join paths

* remove url dep

* Update ws-client/src/tests.rs

* default max redirects 5

* remove needless clone vec

* fix bad merge

* cmon CI run

Co-authored-by: default avatarDavid Palm <[email protected]>
      94c881b8
  19. Oct 01, 2021
  21. Sep 24, 2021
    • Niklas Adolfsson's avatar
      fix: ws server terminate subscriptions when connection is closed by the client. (#483) · 7cd7f36a
      Niklas Adolfsson authored 
      * fix: server should not send to closed subscription

Closing #481

* add a test

* rewrite me

* remove faulty server close

* fix tests

* fix tests

* remove needless code

* Update ws-client/src/client.rs

* fix: remove atomic flag; use `close_sender`

* remove terminate message; use close channel

* remove faulty subscription closed error msg

* fix tests

* fix grumbles

* fix build
      7cd7f36a
  23. Sep 16, 2021
  25. Sep 15, 2021
    • David's avatar
      Rename and reorg types (#462) · 635142e3
      David authored 
      * Renames

* More renames

* fmt

* s/RpcParams/Params/

* Add a type alias `SubscriptionResponse` to `Notification` which is parametrized to `SubscriptionPayload`
Move `SubscriptionResponse` to the `response` module

* Fix doc links

* Cleanup and some docs

* Review feedback

* cleanup
      635142e3
  27. Sep 14, 2021
    • David's avatar
      Fix build warnings (#465) · c13f97ba
      David authored 
      * Silence warning on cors_max_age

* Revert change to `AccessControl`
      c13f97ba
    • David's avatar
      Propagate cause of `InvalidParams` (#463) · b16568b4
      David authored 
      * Add a test illustrating how to use the `call` convenience method

* Extend test + review feedback

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* Add Methods::test_subscription
Log more when params parsing fails

* Add call_with test helper (ty @niklas!) + cleanup

* Remove todo (part of https://github.com/paritytech/jsonrpsee/issues/457

)

* fmt

* Let `test_subscription` be called from other crates

* Manually fix indentation

* fmt

* SSself-review grumbles

* CallError::InvalidParams carries an anyhow::Error

* fmt

* Tweak docs

* Update utils/src/server/rpc_module.rs

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>

* review grumble

* Fix todos

* fmt

* Fixup error messages

* Include source in the error message for `CallError`

* fmt

* Update proc-macros/src/render_server.rs

Co-authored-by: default avatarMaciej Hirsz <[email protected]>

* Mention needing jsonrpsee crate in scope

* Resolve todo

* Impl ToRpcParams for 0-sized array

* optimized logging

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
Co-authored-by: default avatarMaciej Hirsz <[email protected]>
      b16568b4
    • Maciej Hirsz's avatar
      Reject overflowing connection with status code 429 (#456) · bf2fff04
      Maciej Hirsz authored 
      * Reject overflowing connection with status code 429

* fmt

* rename Handshake -> HandshakeMode for clarity; verbose test

* Gracefully shutdown after rejecting to hopefully fix the errors on windows

* HandshakeMode -> HandshakeResponse; tweak pending subscriptions on shutdown test
      bf2fff04
  29. Sep 11, 2021
  31. Sep 08, 2021
  33. Sep 01, 2021
    • Maciej Hirsz's avatar
      Tidy `StopHandle` (#425) · ffa504e2
      Maciej Hirsz authored 
      

* Experimental generic driver for methods

* Move FutureDriver to its own module

* "Infallible" sync methods + fmt

* Drive all methods to completion before background_task closes

* Testing a different stop handle

* Added the waker for the monitors

* Fix the test

* Fix a possible deadlock

* fmt

* Explain strong_count check in StopHandle Drop impl

* Clippy tweak

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>

* Added comment on atomicbool ordering

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
      ffa504e2
  35. Aug 25, 2021
  37. Aug 18, 2021
    • Niklas Adolfsson's avatar
      [proc macros] force proc macro api to return `Result` (#435) · 09abbaaa
      Niklas Adolfsson authored 
      * rewrite me

* require proc macro API to return result

* send unknown message when error is not CallError

* show example that auto cast StdError doesn't work

* register_*_method Into<Error>

* clippy

* replace generic errors with anyhow::Error

* fix nits

* example that anyhow::Error in register_method works

* CallError: add missing From impl

* [types]: add helper methods for Error types

The rationale is to make it possible for users to either use anyhow::Error or use the helper methods.

* fmt

* Revert "register_*_method Into<Error>"

This reverts commit 33b4fa28730b72647ba150659d3c0ab1937e524a.

* add better comment

* fix nit
      09abbaaa
  39. Aug 17, 2021
    • Maciej Hirsz's avatar
      Concurrent polling on async methods (#424) · c69e0dd8
      Maciej Hirsz authored 
      * Experimental generic driver for methods

* Move FutureDriver to its own module

* "Infallible" sync methods + fmt

* Drive all methods to completion before background_task closes
      c69e0dd8
  41. Aug 13, 2021
  43. Jul 12, 2021
    • Maciej Hirsz's avatar
      Module API refactor (#412) · 8db65b42
      Maciej Hirsz authored 
      

* Do not register methods on servers

* fmt

* Infallible `to_rpc` proc macro

* Remove dead code

* Check for duplicate names at compile time

* Add a UI test for name conflicts

* Apply suggestions from code review

Co-authored-by: default avatarDavid <[email protected]>

Co-authored-by: default avatarDavid Palm <[email protected]>
      8db65b42
    • David's avatar
      Rexport types for servers (#409) · 0592442e
      David authored 
      * Include "macros" in the "server" feature

* Re-export SubscriptionSink

* Include the "types" feature in both the "client" and "server" features
Export types::* from façade when the "types" is active
Export types::* from servers

* fmt

* Export jsonrpsee_types under types

* fmt

* broken doc link

* fix benches

* fmt

* Fix test imports
      0592442e
  45. Jul 10, 2021
    • David's avatar
      Pass OwnedRpcParams to async methods (#410) · d5d67e98
      David authored 
      

* Pass OwnedRpcParams to async methods

* Cow-ified RpcParams

* fmt

* Separate `RpcParamsSequence` parser from `RpcParams`

* Remove OwnedId, use Id<'static> instead

* Ensure that parsed `Id` is borrowing from input slice

* Tweak/add some docs
Test that parse() works after calling sequence()

* Fix rustdoc link

Co-authored-by: default avatarMaciej Hirsz <[email protected]>
      d5d67e98
  47. Jul 01, 2021
  49. Jun 30, 2021
    • Maciej Hirsz's avatar
      Synchronization-less async connections in ws-server (#388) · 7496afe2
      Maciej Hirsz authored 
      * WIP

* More WIP

* Simplify ConnDriver

* Progress all connections on each poll

* Make ConnDriver more opaque and less leaky

* fmt

* Spawn connections on tasks after handshake

* WIP put connections on tasks

* cargo fmt, naming clarity

* Fix grumbles

* Extra comment on swap_remove

* Remove unwrap from the handshake

* Restore the wrapping_add on connection id
      7496afe2
    • Niklas Adolfsson's avatar
      [ws server]: terminate already established connection(s) when the server is stopped (#396) · 7a33bf50
      Niklas Adolfsson authored 
      

* [ws server]: terminate connection when closed.

* fix tests

* add test

* address grumbles: return Ok when server stopped

* revert log

* revert outdated documentation

* use wrapping add for conn id

* address grumbles: replace Mutex with AtomicBool

* add comment to assertion

* fix nits

* address grumbles: naming of variables

* address grumbles: RwLock to wait for tasks

This commit introduces a RwLock instead of the Mutex to the shared by the background tasks
and the stop handle won't signal until all readers has been dropped.

* fix nit

* Update ws-server/src/server.rs

* remove AtomicBool; use stop_sender instead

* Update ws-server/src/server.rs

* Update ws-server/src/server.rs

Co-authored-by: default avatarDavid <[email protected]>

* correct subscription err messages

Co-authored-by: default avatarDavid <[email protected]>
      7a33bf50
  51. Jun 25, 2021
    • Niklas Adolfsson's avatar
      [ci]: test each individual crate's manifest (#392) · 2ca8355a
      Niklas Adolfsson authored 
      * [ci]: test each crate outside workspace

We have bitten by these a few times now with that some features are leaked from the workspace
which makes it compile in the workspace but not using it's own Cargo.toml.

* [ci]: add tests for macos and windows

* add missed `WsServer` and `HttpServer`

* [ws server]: fix features

* debug failure in CI

* remove platform dependent assertion

* fix nit; proc-macros is proc-macros

* restore removed assertion

* remove whitespaces
      2ca8355a
  53. Jun 24, 2021
  55. Jun 18, 2021
  57. Jun 10, 2021
  59. Jun 03, 2021
    • David's avatar
      Add a builder to the ws server (#365) · fa1f9e0e
      David authored 
      * Add a builder to the ws server

* Use the WsServerBuilder in tests&examples

* cleanup

* fmt

* Fix benches

* fix error message

* Add connection count limiting and associated config item

* Use the strong_count to `methods` to know how many connections we currently have

* Fix test
      fa1f9e0e
  61. Jun 02, 2021