Skip to content
  1. Dec 10, 2021
  3. Dec 06, 2021
  5. Nov 30, 2021
  7. Nov 25, 2021
  9. Nov 18, 2021
  11. Nov 11, 2021
  13. Oct 15, 2021
  15. Oct 11, 2021
    • Niklas Adolfsson's avatar
      remove `ParamsSer::NoParams` (#501) · b3e4297b
      Niklas Adolfsson authored 
      * fix(ParamsSer): serialize to empty array

Serialize `ParamsSer::NoParams` to an empty array inorder to comply with the jsonrpc v2 spec.

* fix tests

* remove ParamsSer::NoParams

* address grumbles: adjust rpc params macro
      b3e4297b
    • Maciej Hirsz's avatar
      Resource Limiting (#500) · 518a6155
      Maciej Hirsz authored 
      

* Squash post merge

* RAII claims and some comments

* Adding resources to Methods

* Use arrays for claiming all resources at once

* Register resources on ws-server

* Return MethodResourcesBuilder from register_method

* Return MethodResourcesBuilder from register_async_method

* fmt and comments

* Add `verify_and_insert` to get rid of `or_insert` in order to get mut ref to value

* Resources initialization

* No need for ResourceBuilder

* Comment all the things

* Handle errors on ws-server `start` method

* Passing ResourceGuard to method execution

* Start ws-server in background, simplify all the tests!

* Claiming resources on runtime

* Do checked math on resource claiming

* Clearer error path for resources at limit

* Resource limiting tests WIP

* Unbox async futures

* fmt

* Cleaner proc macro

* Fix lifetime issues with ResourceGuard with internal Arc

* Remove unnecessary lifetime generic

* Working tests

* Use turbofish in tests

* fmt

* Fixed (?) benches

* Apply suggestions from code review

Co-authored-by: default avatarDavid <[email protected]>

* Tweak more grumbles

* Adding a test for resource limiting with proc macros (WIP)

* Reworking attribute macros for resource limiting (#507)

* Squashed macros WIP

* bae-less macros!

* Make things simpler and more readable

* Some comments and DRY aliases parsing

* Naming things is hard

* Respan is no longer needed

* Simpler Arguments

* Remove stale code

* Apply suggestions from code review

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>

* syn-up all the things, handle resources on methods

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>

* Resource limiting on the http server

* Test two resources at once

* Test the HTTP server for resource limiting

* Apply suggestions from code review

Co-authored-by: default avatarDavid <[email protected]>
Co-authored-by: default avatarNiklas Adolfsson <[email protected]>

* Comment tweaks

* More explicit error type for `AttributeMeta::retain`

* Remove generic from ResourceTable; derive Default on ws Builder

* Make the macros shorter

Co-authored-by: default avatarDavid <[email protected]>
Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
      518a6155
  17. Sep 16, 2021
  19. Sep 15, 2021
    • David's avatar
      Rename and reorg types (#462) · 635142e3
      David authored 
      * Renames

* More renames

* fmt

* s/RpcParams/Params/

* Add a type alias `SubscriptionResponse` to `Notification` which is parametrized to `SubscriptionPayload`
Move `SubscriptionResponse` to the `response` module

* Fix doc links

* Cleanup and some docs

* Review feedback

* cleanup
      635142e3
  21. Sep 14, 2021
    • David's avatar
      Propagate cause of `InvalidParams` (#463) · b16568b4
      David authored 
      * Add a test illustrating how to use the `call` convenience method

* Extend test + review feedback

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* Add Methods::test_subscription
Log more when params parsing fails

* Add call_with test helper (ty @niklas!) + cleanup

* Remove todo (part of https://github.com/paritytech/jsonrpsee/issues/457

)

* fmt

* Let `test_subscription` be called from other crates

* Manually fix indentation

* fmt

* SSself-review grumbles

* CallError::InvalidParams carries an anyhow::Error

* fmt

* Tweak docs

* Update utils/src/server/rpc_module.rs

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>

* review grumble

* Fix todos

* fmt

* Fixup error messages

* Include source in the error message for `CallError`

* fmt

* Update proc-macros/src/render_server.rs

Co-authored-by: default avatarMaciej Hirsz <[email protected]>

* Mention needing jsonrpsee crate in scope

* Resolve todo

* Impl ToRpcParams for 0-sized array

* optimized logging

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
Co-authored-by: default avatarMaciej Hirsz <[email protected]>
      b16568b4
  23. Sep 01, 2021
    • Niklas Adolfsson's avatar
      Make it possible to treat empty JSON response as no params (#446) · bf211cb2
      Niklas Adolfsson authored 
      

* treat empty json as no params when optional

* add test with nested array brackets

* address grumbles: better tests

* Update types/src/v2/params.rs

Co-authored-by: default avatarDavid <[email protected]>

* introduce RpcParams::sequence_ignore_empty

* address grumbles: ignore empty json in RpcParams

* Update proc-macros/src/render_server.rs

* address grumbles: remove trim in next_inner()

* address grumbles: trim_start after params.next()

* address more grumbles

* [proc macros]: add test for empty array

* make proc macro kind of work

* add hack to make it work in proc macros

* add hack to make it work in proc macros

* [] ->

* revert cerebral palsy

* Update proc-macros/tests/ui/correct/basic.rs

* Update proc-macros/tests/ui/correct/basic.rs

* address grumbles

* improve is_option

* add test for core::option::Option

Co-authored-by: default avatarDavid <[email protected]>
      bf211cb2
  25. Aug 25, 2021
  27. Aug 18, 2021
    • Niklas Adolfsson's avatar
      [proc macros] force proc macro api to return `Result` (#435) · 09abbaaa
      Niklas Adolfsson authored 
      * rewrite me

* require proc macro API to return result

* send unknown message when error is not CallError

* show example that auto cast StdError doesn't work

* register_*_method Into<Error>

* clippy

* replace generic errors with anyhow::Error

* fix nits

* example that anyhow::Error in register_method works

* CallError: add missing From impl

* [types]: add helper methods for Error types

The rationale is to make it possible for users to either use anyhow::Error or use the helper methods.

* fmt

* Revert "register_*_method Into<Error>"

This reverts commit 33b4fa28730b72647ba150659d3c0ab1937e524a.

* add better comment

* fix nit
      09abbaaa
  29. Aug 13, 2021
  31. Jul 27, 2021
    • Maciej Hirsz's avatar
      Proc macro params optimizations and tests. (#421) · 3d52c6ac
      Maciej Hirsz authored 
      * WIP

* Feature-complete-ish

* WIP

* Cleaner replace marker

* Inject lifetimes in elided `Cow`s

* Use a single static &str for all injected lifetimes

* Working lifetimes

* Add the `call` method to `Methods`

* Testing proc macro with optional params

* Remove internal loop

* fmt

* Fix grumbles
      3d52c6ac
  33. Jul 10, 2021
    • David's avatar
      Pass OwnedRpcParams to async methods (#410) · d5d67e98
      David authored 
      

* Pass OwnedRpcParams to async methods

* Cow-ified RpcParams

* fmt

* Separate `RpcParamsSequence` parser from `RpcParams`

* Remove OwnedId, use Id<'static> instead

* Ensure that parsed `Id` is borrowing from input slice

* Tweak/add some docs
Test that parse() works after calling sequence()

* Fix rustdoc link

Co-authored-by: default avatarMaciej Hirsz <[email protected]>
      d5d67e98
  35. Jul 01, 2021
    • Igor Aleksanov's avatar
      New proc macro (#387) · ddb50806
      Igor Aleksanov authored 
      

* Start working on the new proc macro system

* Add skeleton for rendering

* Improve error reporting

* Main part of 'render_client'

* Implement RPC client generation

* Client successfully rendered

* Add doc-comment generation for the API client

* Check that all the methods have receiver

* Start working on the server impl

* Add helper method to find server crate

* Fix usage of client rpc path

* Decent progress on the server macro implementation

* Server macro compiled successfully

* Remove unneeded re-export

* Insert SubscriptionSink argument to the subscription server signatures

* Add basic doc-comment for the macro

* no_run -> ignore

* Trait with subscription compiles

* Extend the example

* Add integration test for client/server impl

* Add trybuild setup

* Set correct span for attribute parsing related errors

* Add basic set of trybuild tests

* Add tests for client and server generated separately

* Improve proc-macro documentation

* Update proc-macros/src/lib.rs

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>

* Fix a couple of bugs in docs

* Fix rendering subscription with params

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
      ddb50806
    • Maciej Hirsz's avatar
      Streaming RpcParams parsing (#401) · 095db9b2
      Maciej Hirsz authored 
      * Streaming RpcParams parsing

* DRY RpcParams::one again

* Fix doc comments
      095db9b2
  37. Jun 24, 2021
  39. Jun 03, 2021
    • David's avatar
      Add a builder to the ws server (#365) · fa1f9e0e
      David authored 
      * Add a builder to the ws server

* Use the WsServerBuilder in tests&examples

* cleanup

* fmt

* Fix benches

* fix error message

* Add connection count limiting and associated config item

* Use the strong_count to `methods` to know how many connections we currently have

* Fix test
      fa1f9e0e
  41. Jun 02, 2021
  43. Jun 01, 2021
  45. May 28, 2021
  47. May 19, 2021
  49. May 18, 2021
  51. May 12, 2021
    • Billy Lindeman's avatar
      [ws client] RegisterNotification support (#303) · c7384471
      Billy Lindeman authored 
      * Rename NotifResponse to SubscriptionResponse to make room for new impl

* Add support for on_notification Subscription<T> types

* Fix handling of NotificationHandler in manager

* cleanup

* Implement NotificationHandler to replace Subscription<T> and clean up plumbing

* More cleanup

* impl Drop for NotificationHandler

* Address pr feedback #1

* ws client register_notification pr feedback 2

* Fix doc

* fix typo

* Add tests, get NH working

* More cleanup of String/&str

* fix doc

* Drop notification handler on send_back_sink error

* ws client notification auto unsubscribe when channel full test
      c7384471
  53. May 04, 2021
    • Niklas Adolfsson's avatar
      [servers] return error if context or params fails (#295) · b51abeca
      Niklas Adolfsson authored 
      * ret err if context/params fails

* address grumbles: specific error_code context fail

* address grumbles: make env_logger dev-dependency

* address grumbles: add tests

* chore(deps): remove unused deps

* address grumbles: rename types and docs

* address grumbles: more renaming.

* fix build
      b51abeca
    • David's avatar
      [http server] Batch requests (#292) · 2cae10b6
      David authored 
      

* WIP

* Implement draft of batch requests

* fmt

* cleanup

* Explain why we don't use an untagged enum

* Avoid allocating a Vec for single requets

* Add comment

* Add a benchmark for batch requests

* Add more tests, noting where we diverge from the spec
Fix empty batch case, i.e. `[]`

* Obey the fmt

* Update benches/bench.rs

Co-authored-by: default avatarAndrew Plaza <[email protected]>

* Update http-server/src/server.rs

Co-authored-by: default avatarAndrew Plaza <[email protected]>

* Add link to issue

* Explain why we're closing the receiving end of the channel.

* Limit logging of requests and response to 1kb
Add more comments
Factor out batch response collection

* Wrap comment

* tweak log line

* Benchmark batch request over different batch sizes

* fmt

Co-authored-by: default avatarAndrew Plaza <[email protected]>
      2cae10b6
  55. Apr 28, 2021
  57. Apr 26, 2021
    • Niklas Adolfsson's avatar
      [types]: allow `data` field in jsonrpc error obj. (#286) · 187ee5e9
      Niklas Adolfsson authored 
      * [types]: allow `data` field in jsonrpc error obj.

* fmt

* revert change to make fail

* remove redundant test

* [types]: bring back `data` and `message` in error.

Basically deducing the error message from server defined error doesn't work
and we should not strip out this information from to user which might be useful.

* remove boiler plate code

* [types]: impl From<ErrorCode> for JsonRpcError

* address grumbles

* remove more boiler plate
      187ee5e9
  59. Apr 20, 2021
    • Niklas Adolfsson's avatar
      [client] use types v2 (less alloc) (#269) · 31153ac7
      Niklas Adolfsson authored 
      * rewrite me

* v2

* PoC works without batch request

* remove `PartialEq` bounds

* add naive benches types

* misc

* remove useless lifetime

* [ws client]: move request ID generation to client

* make tests compile again

* [client transport]: kill leaky abstractions.

* [http client transport]: minor changes in the API.

* [ws client]: fix batch requests.

* fix nits

* [ws client]: generate two request IDs for subscrib

* fix tests

* remove unused types + less alloc for params.

* fix nits

* more tweaks.

* remove unused code

* fix more nits

* remove unused legacy types

* reorg types_v2 mod

* port macros to new types

* fix tests again; more jsonvalue

* [proc macros]: bring back impl Into for params.

* fix build

* [proc macros]: make it work for external crates.

* [types]: remove weird From<Option<T>> to impl.

* cleanup again

* [examples]: remove unused async-std dep

* Update types/src/v2/mod.rs

* [types]: remove unsed dep smallvec

* rewrite me

* [types]: error code impl ser/deser

Manual implementation of serialize/deserialize to get rid of duplicated message string

* [types v2]: re-org with explicit mods

* fix faulty test

* add missed files

* [ws client]: req_manager reserve unsubscribe slot.

* simplify test code

* add tracking issue for TODO

* remove unused deps
      31153ac7
  61. Apr 12, 2021
    • Niklas Adolfsson's avatar
      [utils]: use futures mpsc instead of tokio sync (#263) · 495e0bb3
      Niklas Adolfsson authored 
      * [utils]: use futures mpsc

Use futures::channel::mpsc as it's already brought in as dependency and to avoid bring
in tokio sync as an additional dependency.

* remove unused deps/code

* fix nit

* [utils]: future mpsc works without alloc.

* [http server]: future mpsc works without alloc.
      495e0bb3
  63. Apr 01, 2021
    • Niklas Adolfsson's avatar
      HTTP server refactor (#253) · 49899740
      Niklas Adolfsson authored 
      * refactor benches

* start

* fix build: enable `raw value` feature serde_json

* start

* port it

* make tests compile

* fix bench

* fix bench

* introduce builder pattern

* tweaks

* remove unused code

* cleanup

* [http server]: configure tcp socket manually.

The major reason is to provide a uniform API with the WebSocket server to return the local address.

* remove unused deps

* [examples]: remove needless sleep

* chore: add docs and refactor noise.

* Update types/src/jsonrpc/error.rs

* http server use constants
      49899740