Skip to content
  1. Oct 11, 2021
    • Maciej Hirsz's avatar
      Resource Limiting (#500) · 518a6155
      Maciej Hirsz authored 
      

* Squash post merge

* RAII claims and some comments

* Adding resources to Methods

* Use arrays for claiming all resources at once

* Register resources on ws-server

* Return MethodResourcesBuilder from register_method

* Return MethodResourcesBuilder from register_async_method

* fmt and comments

* Add `verify_and_insert` to get rid of `or_insert` in order to get mut ref to value

* Resources initialization

* No need for ResourceBuilder

* Comment all the things

* Handle errors on ws-server `start` method

* Passing ResourceGuard to method execution

* Start ws-server in background, simplify all the tests!

* Claiming resources on runtime

* Do checked math on resource claiming

* Clearer error path for resources at limit

* Resource limiting tests WIP

* Unbox async futures

* fmt

* Cleaner proc macro

* Fix lifetime issues with ResourceGuard with internal Arc

* Remove unnecessary lifetime generic

* Working tests

* Use turbofish in tests

* fmt

* Fixed (?) benches

* Apply suggestions from code review

Co-authored-by: default avatarDavid <[email protected]>

* Tweak more grumbles

* Adding a test for resource limiting with proc macros (WIP)

* Reworking attribute macros for resource limiting (#507)

* Squashed macros WIP

* bae-less macros!

* Make things simpler and more readable

* Some comments and DRY aliases parsing

* Naming things is hard

* Respan is no longer needed

* Simpler Arguments

* Remove stale code

* Apply suggestions from code review

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>

* syn-up all the things, handle resources on methods

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>

* Resource limiting on the http server

* Test two resources at once

* Test the HTTP server for resource limiting

* Apply suggestions from code review

Co-authored-by: default avatarDavid <[email protected]>
Co-authored-by: default avatarNiklas Adolfsson <[email protected]>

* Comment tweaks

* More explicit error type for `AttributeMeta::retain`

* Remove generic from ResourceTable; derive Default on ws Builder

* Make the macros shorter

Co-authored-by: default avatarDavid <[email protected]>
Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
      518a6155
  3. Oct 05, 2021
  5. Sep 30, 2021
  7. Sep 16, 2021
  9. Sep 15, 2021
    • David's avatar
      Rename and reorg types (#462) · 635142e3
      David authored 
      * Renames

* More renames

* fmt

* s/RpcParams/Params/

* Add a type alias `SubscriptionResponse` to `Notification` which is parametrized to `SubscriptionPayload`
Move `SubscriptionResponse` to the `response` module

* Fix doc links

* Cleanup and some docs

* Review feedback

* cleanup
      635142e3
  11. Sep 14, 2021
    • David's avatar
      Propagate cause of `InvalidParams` (#463) · b16568b4
      David authored 
      * Add a test illustrating how to use the `call` convenience method

* Extend test + review feedback

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* log

* Add Methods::test_subscription
Log more when params parsing fails

* Add call_with test helper (ty @niklas!) + cleanup

* Remove todo (part of https://github.com/paritytech/jsonrpsee/issues/457

)

* fmt

* Let `test_subscription` be called from other crates

* Manually fix indentation

* fmt

* SSself-review grumbles

* CallError::InvalidParams carries an anyhow::Error

* fmt

* Tweak docs

* Update utils/src/server/rpc_module.rs

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>

* review grumble

* Fix todos

* fmt

* Fixup error messages

* Include source in the error message for `CallError`

* fmt

* Update proc-macros/src/render_server.rs

Co-authored-by: default avatarMaciej Hirsz <[email protected]>

* Mention needing jsonrpsee crate in scope

* Resolve todo

* Impl ToRpcParams for 0-sized array

* optimized logging

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
Co-authored-by: default avatarMaciej Hirsz <[email protected]>
      b16568b4
  13. Sep 13, 2021
  15. Sep 11, 2021
  17. Sep 01, 2021
    • Niklas Adolfsson's avatar
      Make it possible to treat empty JSON response as no params (#446) · bf211cb2
      Niklas Adolfsson authored 
      

* treat empty json as no params when optional

* add test with nested array brackets

* address grumbles: better tests

* Update types/src/v2/params.rs

Co-authored-by: default avatarDavid <[email protected]>

* introduce RpcParams::sequence_ignore_empty

* address grumbles: ignore empty json in RpcParams

* Update proc-macros/src/render_server.rs

* address grumbles: remove trim in next_inner()

* address grumbles: trim_start after params.next()

* address more grumbles

* [proc macros]: add test for empty array

* make proc macro kind of work

* add hack to make it work in proc macros

* add hack to make it work in proc macros

* [] ->

* revert cerebral palsy

* Update proc-macros/tests/ui/correct/basic.rs

* Update proc-macros/tests/ui/correct/basic.rs

* address grumbles

* improve is_option

* add test for core::option::Option

Co-authored-by: default avatarDavid <[email protected]>
      bf211cb2
  19. Aug 25, 2021
  21. Aug 18, 2021
    • Niklas Adolfsson's avatar
      [proc macros] force proc macro api to return `Result` (#435) · 09abbaaa
      Niklas Adolfsson authored 
      * rewrite me

* require proc macro API to return result

* send unknown message when error is not CallError

* show example that auto cast StdError doesn't work

* register_*_method Into<Error>

* clippy

* replace generic errors with anyhow::Error

* fix nits

* example that anyhow::Error in register_method works

* CallError: add missing From impl

* [types]: add helper methods for Error types

The rationale is to make it possible for users to either use anyhow::Error or use the helper methods.

* fmt

* Revert "register_*_method Into<Error>"

This reverts commit 33b4fa28730b72647ba150659d3c0ab1937e524a.

* add better comment

* fix nit
      09abbaaa
  23. Aug 16, 2021
    • David's avatar
      Don't allocate until we know it's worth it (#420) · 326d0c91
      David authored 
      * Sniff the first byte to glean if the incoming request is a single or batch request

This works around the serde limitations around `untagged` enums and `RawValue`.

* fmt

* For http server, check first byte before allocating space for the body

Also, rework the way we return errors: prefer JSON-RPC errors according to spec (application/json) wherever sensible.

* Review feedback

* Don't assume there is a first byte to read

* ty clipyp

* Review concerns

* Cleanup
      326d0c91
  25. Aug 13, 2021
  27. Aug 09, 2021
  29. Jul 27, 2021
    • Maciej Hirsz's avatar
      Proc macro params optimizations and tests. (#421) · 3d52c6ac
      Maciej Hirsz authored 
      * WIP

* Feature-complete-ish

* WIP

* Cleaner replace marker

* Inject lifetimes in elided `Cow`s

* Use a single static &str for all injected lifetimes

* Working lifetimes

* Add the `call` method to `Methods`

* Testing proc macro with optional params

* Remove internal loop

* fmt

* Fix grumbles
      3d52c6ac
  31. Jul 12, 2021
    • David's avatar
      Prepare v0.3.0 (#415) · 0f66093e
      David authored 
      * Bump versions to 0.3.0

* Add draft release checklist

* Changelog for v0.3.0

* Mention possibility of passing params to `publish.sh`

* Added PR 412
      v0.3.0
      0f66093e
    • David's avatar
      Rexport types for servers (#409) · 0592442e
      David authored 
      * Include "macros" in the "server" feature

* Re-export SubscriptionSink

* Include the "types" feature in both the "client" and "server" features
Export types::* from façade when the "types" is active
Export types::* from servers

* fmt

* Export jsonrpsee_types under types

* fmt

* broken doc link

* fix benches

* fmt

* Fix test imports
      0592442e
  33. Jul 10, 2021
    • David's avatar
      Pass OwnedRpcParams to async methods (#410) · d5d67e98
      David authored 
      

* Pass OwnedRpcParams to async methods

* Cow-ified RpcParams

* fmt

* Separate `RpcParamsSequence` parser from `RpcParams`

* Remove OwnedId, use Id<'static> instead

* Ensure that parsed `Id` is borrowing from input slice

* Tweak/add some docs
Test that parse() works after calling sequence()

* Fix rustdoc link

Co-authored-by: default avatarMaciej Hirsz <[email protected]>
      d5d67e98
  35. Jul 01, 2021
    • Igor Aleksanov's avatar
      New proc macro (#387) · ddb50806
      Igor Aleksanov authored 
      

* Start working on the new proc macro system

* Add skeleton for rendering

* Improve error reporting

* Main part of 'render_client'

* Implement RPC client generation

* Client successfully rendered

* Add doc-comment generation for the API client

* Check that all the methods have receiver

* Start working on the server impl

* Add helper method to find server crate

* Fix usage of client rpc path

* Decent progress on the server macro implementation

* Server macro compiled successfully

* Remove unneeded re-export

* Insert SubscriptionSink argument to the subscription server signatures

* Add basic doc-comment for the macro

* no_run -> ignore

* Trait with subscription compiles

* Extend the example

* Add integration test for client/server impl

* Add trybuild setup

* Set correct span for attribute parsing related errors

* Add basic set of trybuild tests

* Add tests for client and server generated separately

* Improve proc-macro documentation

* Update proc-macros/src/lib.rs

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>

* Fix a couple of bugs in docs

* Fix rendering subscription with params

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
      ddb50806
    • Maciej Hirsz's avatar
      Streaming RpcParams parsing (#401) · 095db9b2
      Maciej Hirsz authored 
      * Streaming RpcParams parsing

* DRY RpcParams::one again

* Fix doc comments
      095db9b2
    • Maciej Hirsz's avatar
      Set allowed Host header values (#399) · f705e325
      Maciej Hirsz authored 
      

* Set allowed Host header values

* Error if allowed hosts list is empty

* Grammar

Co-authored-by: default avatarDavid <[email protected]>

Co-authored-by: default avatarDavid <[email protected]>
      f705e325
  37. Jun 29, 2021
  39. Jun 24, 2021
  41. Jun 18, 2021
  43. Jun 04, 2021
    • David's avatar
      Release prep for v0.2 (#368) · b3a0748b
      David authored 
      * Release prep

* Mention proc macro limitations

* Mention publish script
      b3a0748b
    • Niklas Adolfsson's avatar
      [rpc module]: server-side close subscription (#355) · b987b811
      Niklas Adolfsson authored 
      

* [rpc module]: server-side close subscription

Add functionality that closes the subscription after the sink has been dropped.

* [integration tests]: add timeout on futures

* remove global subscriber mutex

* fix nit

* [client types]: fix #349

Subscription::next() propogate error when parsing the response fails

* [client types]: fix #349

Subscription::next() propogate error when parsing the response fails

* unify subscription and notification

* rename again

* send notif response when subscription is dropped

* stray debug stuff

* Update utils/src/server/rpc_module.rs

Co-authored-by: default avatarDavid <[email protected]>

* Revert "[client types]: fix #349"

This reverts commit c4fefade719ebd8c964a62d0eb16f89db3346ccd.

* Revert "[integration tests]: add timeout on futures"

This reverts commit 21dfb99649aaaa8c847a693b4510e0202498fa2c.

* show that actual edge-case

* fix nit

* Update types/src/traits.rs

* fix bad merge

* ugly; but works

* complete solution

* get rid of Option

* Update tests/tests/integration_tests.rs

* Update utils/src/server/rpc_module.rs

* Update utils/src/server/rpc_module.rs

Co-authored-by: default avatarDavid <[email protected]>

* grumbles: fix faulty early return

* remove weird abstraction KeepAlive

* fix nits

* revert test timeouts

* address grumbles

* fix build

Co-authored-by: default avatarDavid <[email protected]>
      b987b811
  45. Jun 03, 2021
  47. Jun 02, 2021
  49. Jun 01, 2021
    • Igor Aleksanov's avatar
      Fix clippy lints (#357) · 43ec342f
      Igor Aleksanov authored
      43ec342f
    • Igor Aleksanov's avatar
      Basic support for async methods (#327) · 2da9244b
      Igor Aleksanov authored 
      

* Add basic support for async methods

* Add support of async methods into ws server

* Add support of async methods to HTTP server

* Fix subscriptions method lookup

* Remove type that appeared to be unused

* Add comment on safety of unwrap in OwnedJsonRpcRequest::borrowed

* Update utils/src/server/rpc_module.rs

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>

Co-authored-by: default avatarMaciej Hirsz <[email protected]>
Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
      2da9244b
    • David's avatar
      Unify RpcModule types (#350) · c2c66e1a
      David authored 
      

* Remove register_* from Server

* Tests pass

* Some cleanup

* more cleanup

* Less bounds

* Remove the `RpcMethod` trait – I don't think we need it.

* fmt

* Fix benches

* Enable merging two modules with different contexts

* Module registration returns number of methods on the server and checks for dupes
Tests for module registration and some cleanup

* Export `RpcModule` from façade crate
fmt

* Revert to return error from `Server::register_module`

* Remove Server::methods

* Remove TODO

* Fix tests
Fix http server to work the same as ws-server

* Server::method_names

* fmt

* fix clippy warnings

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
      c2c66e1a
  51. May 28, 2021
  53. May 27, 2021