- Jul 21, 2020
-
-
Gavin Wood authored
* Enable transfers Also quash any conviction from Referendum Zero; Sudo was always going to have been removed so lock-voting doesn't make sense in this case. * Add test for migration; remove superfluous comment. * Fixes * Bump * Weekly elections
-
Pierre Krieger authored
* Companion PR for substrate#6676 * Update Substrate
-
Peter Goodspeed-Niklaus authored
* get conclude signal working properly; don't allocate a vector * wip: add test suite / example / explanation for using utility subsystem Unfortunately, the test fails right now for reasons which seem very odd. Just have to keep poking at it. * explicitly import everything * fix subsystem-util test The root problem here was two-fold: - there was a circular dependency from subsystem -> test-helpers/subsystem -> subsystem - cfg(test) doesn't propagate between crates The solution: move the subsystem test helpers into a sub-module within subsystem. Publicly export them from the previous location so no other code breaks. Doing this has an additional benefit: it ensures that no production code can ever accidentally use the subsystem helpers, as they are compile- gated on cfg(test). * fully commit to moving test helpers into a subsystem module * add some more tests * get rid of log tests in favor of real error forwarding It's not obvious whether we'll ever really want to chase down these errors outside a testing context, but having the capability won't hurt. * fix issue which caused test to hang on osx * only require that job errors are PartialEq when testing also fix polkadot-node-core-backing tests * get rid of any notion of partialeq * rethink testing Combine tests of starting and stopping job: leaving a test executor with a job running was pretty clearly the cause of the sometimes-hang. Also, add a timeout so tests _can't_ hang anymore; they just fail after a while. * rename fwd_errors -> forward_errors * warn on error propagation failure * fix unused import leftover from merge * derive eq for subsystemerror
-
- Jul 20, 2020
-
-
Gav Wood authored
-
Gav Wood authored
-
Gavin Wood authored
* Remove Sudo NOTE: To ensure minimal index changes to pre-existing pallet deployments, this is done with a "swap_remove" style; the previous last pallet (Purchase), which is hitherto unused, has been shifted into the old index of Sudo. * Remove CC1 designation. * Fixes * Bump * Fixes * Fixes * Fixes * Fixes * Fixes * Fixes * Fixes * Fixes * Fixes * Fixes
-
Gavin Wood authored
-
Benjamin Kampmann authored
* deterministic build check runtime * fix yaml * Apply suggestions from code review Co-authored-by: s3krit <[email protected]> * Update cargo.lock Co-authored-by: s3krit <[email protected]>
-
- Jul 18, 2020
-
-
asynchronous rob authored
* create a README on Runtime APIs * add ParaId type * write up runtime APIs * more preamble * rename * rejig runtime APIs * add occupied_since to `BlockNumber` * skeleton crate for runtime API subsystem * improve group_for_core * improve docs on availability cores runtime API * guide: freed -> free * add primitives for runtime APIs * create a v1 ParachainHost API trait * guide: make validation code return `Option`al. * skeleton runtime API helpers * make parachain-host runtime-generic * skeleton for most runtime API implementation functions * guide: add runtime API helper methods * implement new helpers of the inclusion module * guide: remove retries check, as it is unneeded * implement helpers for scheduler module for Runtime APIs * clean up `validator_groups` implementation * implement next_rotation_at and last_rotation_at * guide: more helpers on GroupRotationInfo * almost finish implementing runtime APIs * add explicit block parameter to runtime API fns * guide: generalize number parameter * guide: add group_responsible to occupied-core * update primitives due to guide changes * finishing touches on runtime API implementation; squash warnings * break out runtime API impl to separate file * add tests for next_up logic * test group rotation info * point to filed TODO * remove unused TODO [now] * indentation * guide: para -> para_id * rename para field to para_id for core meta * remove reference to outdated AvailabilityCores type * add an event in `inclusion` for candidates being included or timing out * guide: candidate events * guide: adjust language * Candidate events type from guide and adjust inclusion event * implement `candidate_events` runtime API * fix runtime test compilation * max -> min * fix typos * guide: add `RuntimeAPIRequest::CandidateEvents`
-
- Jul 17, 2020
-
-
Fedor Sakharov authored
* Use SpawnNamed instead of Spawn in Overseer * reexport SpawnNamed and fix doc tests * Fix deps
-
Shawn Tabrizi authored
-
Shawn Tabrizi authored
* initial mock * remove statement * Merge branch 'master' into shawntabrizi-crowdsale * only work for dead accounts * Revert "Merge branch 'master' into shawntabrizi-crowdsale" This reverts commit 6f8fde1b . * update storage name * Re-mock * Update comment * payouts * test signature verification * Update wording * fix tests * support both free and locked balance * Single statement set in configuration trait * Configurable purchase limit, initiated status * Account creation tests * make note about `max_amount` check * Update validity status tests * update balance tests * payment test * finish tests * enable in runtime * Test and verify ed25519 * make purchase pallet more configurable on the fly * Remove runtime check on purchase amount. * clean up trait * add basic weights * add extra super saftey check for vesting * Add vat tracking * remove unused const * Update to W3F Origins * remove stale comment * Support existing accounts w/o existing vesting schedule * Update runtime/common/src/purchase.rs Co-authored-by: Gavin Wood <[email protected]> * Add support for partially unlocked portion of purchased DOTs * add trait import * Expose constants from pallet * Fixes * Fixes * Update runtime/polkadot/src/lib.rs Co-authored-by: Gavin Wood <[email protected]>
-
André Silva authored
* runtime: update grandpa equivocation reporting api * Bump Co-authored-by: Gav Wood <[email protected]>
-
Gavin Wood authored
* Define BurnDestination, Kusama Treasury burns to Society. * Fixes * Remove the council elections enabling. * Bump * whitespace
-
ordian authored
* inclusion: split PendingAvailability storage into descriptor and commitments * inclusion: fix tests * implementers-guide: update CandidatePendingAvailability type * inclusion: simplify process_candidates a bit * implementers-guide: more updates to the inclusion module * inclusion: fix copy-paste errors in tests * inclusion: revert some of the changes * inclusion: lazy commitments loading and a test * guide: revert enact_candidate changes * inclusion: test process_bitfield for no commitments * Grammar Co-authored-by: Robert Habermeier <[email protected]> Co-authored-by: Robert Habermeier <[email protected]>
-
asynchronous rob authored
* create a README on Runtime APIs * add ParaId type * write up runtime APIs * more preamble * rename * rejig runtime APIs * add occupied_since to `BlockNumber` * improve group_for_core * improve docs on availability cores runtime API * guide: freed -> free * Update roadmap/implementers-guide/src/runtime-api/README.md Co-authored-by: Peter Goodspeed-Niklaus <[email protected]> * add explicit block parameter to runtime API fns Co-authored-by: Peter Goodspeed-Niklaus <[email protected]>
-
- Jul 16, 2020
-
-
Gavin Wood authored
-
asynchronous rob authored
* add assumptions made by the Node-side * Update roadmap/implementers-guide/src/node/README.md Co-authored-by: Peter Goodspeed-Niklaus <[email protected]> * Update roadmap/implementers-guide/src/node/README.md Co-authored-by: Peter Goodspeed-Niklaus <[email protected]> * Update roadmap/implementers-guide/src/node/README.md Co-authored-by: Bernhard Schuster <[email protected]> * more refinements Co-authored-by: Peter Goodspeed-Niklaus <[email protected]> Co-authored-by: Bernhard Schuster <[email protected]>
-
- Jul 15, 2020
-
-
s3krit authored
* Initial check_runtime.sh redux * Skip further checks if no change to runtime * remove polkadot-master reference * Fix issues found during review :) * replace static common dir with common_dirs array
-
- Jul 14, 2020
-
-
Gavin Wood authored
-
Peter Goodspeed-Niklaus authored
* Add subsystem-util crate. Start by moving the JobCanceler here. * copy utility functions for requesting runtime data; generalize * convert subsystem-util from crate to module in subsystem The point of making a sub-crate is to ensure that only the necessary parts of a program get compiled; if a dependent package needed only subsystem-util, and not subsystem, then subsystem wouldn't need to be compiled. However, that will never happen: subsystem-util depends on subsystem::messages, so subsystem will always be compiled. Therefore, it makes more sense to add it as a module in the existing crate than as a new and distinct crate. * make runtime request sender type generic * candidate backing subsystem uses util for api requests * add struct Validator representing the local validator This struct can be constructed when the local node is a validator; the constructor fails otherwise. It stores a bit of local data, and provides some utility methods. * add alternate constructor for better efficiency * refactor candidate backing to use utility methods * fix test breakage caused by reordering tests * restore test which accidentally got deleted during merge * start extracting jobs management into helper traits + structs * use util::{JobHandle, Jobs} in CandidateBackingSubsystem * implement generic job-manager subsystem impl This means that the work of implementing a subsystem boils down to implementing the job, and then writing an appropriate type definition, i.e. pub type CandidateBackingSubsystem<Spawner, Context> = util::JobManager<Spawner, Context, CandidateBackingJob>; * add hash-extraction helper to messages * fix errors caused by improper rebase * doc improvement * simplify conversion from overseer communication to job message * document fn hash for all messages * rename fn hash() -> fn relay_parent * gracefully shut down running futures on Conclude * ensure we're validating with the proper validator index * rename: handle_unhashed_msg -> handle_orphan_msg * impl Stream for Jobs<Spawner, Job> This turns out to be relatively complicated and requires some unsafe code, so we'll want either detailed review, or to choose to revert this commit. * add missing documentation for public items * use pin-project to eliminate unsafe code from this codebase * rename SenderMessage -> FromJob * reenvision the subsystem requests as an extension trait This works within `util.rs`, but fails in `core/backing/src/lib.rs`, because we don't actually create the struct soon enough. Continuing down this path would imply substantial rewriting. * Revert "reenvision the subsystem requests as an extension trait" This reverts commit a5639e36. The fact is, the new API is more complicated to no real benefit. * apply suggested futuresunordered join_all impl * CandidateValidationMessage variants have no top-level relay parents * rename handle_orphan_msg -> handle_unanchored_msg * make most node-core-backing types private Now the only public types exposed in that module are CandidateBackingSubsystem and ToJob. While ideally we could reduce the public interface to only the former type, that doesn't work because ToJob appears in the public interface of CandidateBackingSubsystem. This also involves changing the definition of CandidateBackingSubsystem; it is no longer a typedef, but a struct wrapping the job manager.
-
gabriel klawitter authored
-
- Jul 13, 2020
-
-
Max Inden authored
* *: Enable authority discovery by default Instead of having to explicitly enable the authority discovery module on validator and sentry nodes, this commit enables the module by default. Today there is no way for non validator or sentry nodes to run the module. That might change in the future. * service/src/lib: Fix typo in new_full! for test
-
Gavin Wood authored
-
- Jul 11, 2020
-
-
Gavin Wood authored
* Initial draft * Initial build * Integrate into runtime * Fix warnings. * Initial tests * Fixes and tests * Update runtime/polkadot/src/poll.rs Co-authored-by: Bastian Köcher <[email protected]> * Expose End constant * Docs * Update runtime/polkadot/src/lib.rs Co-authored-by: kaichao <[email protected]> * Update runtime/polkadot/src/poll.rs Co-authored-by: Kian Paimani <[email protected]> * Clean up filters * Warnings Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: kaichao <[email protected]> Co-authored-by: Kian Paimani <[email protected]>
-
- Jul 10, 2020
-
-
Bastian Köcher authored
* Revert log rotation https://github.com/paritytech/substrate/pull/6627 * 'Update substrate' Co-authored-by: parity-processbot <>
-
Peter Goodspeed-Niklaus authored
Per https://github.com/paritytech/polkadot/commit/69ce9ff3#r40392855
-
Joseph Mark authored
* Add Process.toml * Apply suggestions from code review Co-authored-by: Robert Habermeier <[email protected]>
-
asynchronous rob authored
* create a v1 primitives module * Improve guide on availability types * punctuate * new parachains runtime uses new primitives * tests of new runtime now use new primitives * add ErasureChunk to guide * export erasure chunk from v1 primitives * subsystem crate uses v1 primitives * node-primitives uses new v1 primitives * port overseer to new primitives * new-proposer uses v1 primitives (no ParachainHost anymore) * fix no-std compilation for primitives * service-new uses v1 primitives * network-bridge uses new primitives * statement distribution uses v1 primitives * PoV distribution uses v1 primitives; add PoV::hash fn * move parachain to v0 * remove inclusion_inherent module and place into v1 * remove everything from primitives crate root * remove some unused old types from v0 primitives * point everything else at primitives::v0 * squanch some warns up * add RuntimeDebug import to no-std as well * port over statement-table and validation * fix final errors in validation and node-primitives * add dummy Ord impl to committed candidate receipt * guide: update CandidateValidationMessage * add primitive for validationoutputs * expand CandidateValidationMessage further * bikeshed * add some impls to omitted-validation-data and available-data * expand CandidateValidationMessage * make erasure-coding generic over v1/v0 * update usages of erasure-coding * implement commitments.hash() * use Arc<Pov> for CandidateValidation * improve new erasure-coding method names * fix up candidate backing * update docs a bit * fix most tests and add short-circuiting to make_pov_available * fix remainder of candidate backing tests * squanching warns * squanch it up * some fallout * overseer fallout * free from polkadot-test-service hell
-
- Jul 09, 2020
-
-
ordian authored
* overseer: introduce a utility typemap * it's ugly but it compiles * move DummySubsystem to subsystem crate * fix tests fallout * use a struct for all subsystems * more tests fallout * add missing pov_distribution subsystem * remove unused imports and bounds * fix minimal-example
-
Fedor Sakharov authored
* Updates guide for CandidateBacking * Move assignment types to primitives * Initial implementation. * More functionality * use assert_matches * Changes to report misbehaviors * Some fixes after a review * Remove a blank line * Update guide and some types * Adds run_job function * Some comments and refactorings * Fix review * Remove warnings * Use summary in kicking off validation * Parallelize requests * Validation provides local and global validation params * Test issued validity tracking * Nits from review
-
Bastian Köcher authored
* Companiong for #6620 https://github.com/paritytech/substrate/pull/6620 * 'Update substrate' Co-authored-by: parity-processbot <>
-
asynchronous rob authored
* note that the initializer is responsible for buffering session changes * amend initializer definition to include session change buffering * support buffered changes before `on_initialize` * implement and test session buffering * Update roadmap/implementors-guide/src/runtime/README.md Co-authored-by: Bernhard Schuster <[email protected]> * expand on how this affects misbehavior reports * fix typo Co-authored-by: Bernhard Schuster <[email protected]>
-
Cecile Tonglet authored
Fixes #833
-
Pierre Krieger authored
-
- Jul 08, 2020
-
-
asynchronous rob authored
* introduce candidatedescriptor type * add PoVDistribution message type * loosen bound on PoV Distribution to account for equivocations * re-export some types from the messages module * begin PoV Distribution subsystem * remove redundant index from PoV distribution * define state machine for pov distribution * handle overseer signals * set up control flow * remove `ValidatorStatement` section * implement PoV fetching * implement distribution logic * add missing ` * implement some network bridge event handlers * stub for message processing, handle our view change * control flow for handling messages * handle `awaiting` message * handle any incoming PoVs and redistribute * actually provide a subsystem implementation * remove set-builder notation * begin testing PoV distribution * test that we send awaiting messages only to peers with same view * ensure we distribute awaited PoVs to peers on view changes * test that peers can complete fetch and are rewarded * test some reporting logic * ensure peer is reported for flooding * test punishing peers diverging from awaited protocol * test that we eagerly complete peers' awaited PoVs based on what we receive * test that we prune the awaited set after receiving * expand pov-distribution in guide to match a change I made * remove unneeded import
-
Gavin Wood authored
-
Pierre Krieger authored
-
Shawn Tabrizi authored
* Add `WeightInfo` * fix test * fix tests * fix more tests
-