Skip to content
  1. Aug 06, 2020
    • Sergey Pepyakin's avatar
      Implementer's guide: downward messages and HRMP, take 2 (#1503) · 864fff12
      Sergey Pepyakin authored
      
      
      * First stab at downward messages.
      
      That also includes a notion of horizontal messages.
      
      * Add some structure to the router.
      
      * Update `ValidationOutputs`
      
      * Add `processed_downward_messages` to `ValidationOutputs`.
      
      Forgot to check that in.
      
      * s/AccountId/ParaId
      
      * DownwardMessage::ParachainSpecfic
      
      * s/ensure_horizontal_messages_fits/ensure_horizontal_messages_fit
      
      * Clarify that Router called for each candidate
      
      * Update the preamble for Router.
      
      * Rewrite the relay-chain extrinsic routines
      
      * Update gloassary
      
      * Add DMP to the glossary
      
      * If the queue is empty, `processed_downward_messages` can be 0
      
      * WIP
      
      * Add condemned list
      
      * Pivot to message-storing channel based HRMP
      
      * Finished draft
      
      * Tidy up
      
      * Remove a duplicate glossary entry
      
      * Fix typo
      
      * Fix wording to emphasize that the channel is unidirectional
      
      * Proper decrement `HrmpOpenChannelRequestCount`
      
      * Add a comment for `HrmpOpenChannelRequestCount`.
      
      * Remove old configuration values.
      
      * Be more specific about the para{chain,thread} hrmp chan limits.
      
      * Fix indentation so the lists are rendendered properly
      
      * "to answer **the**" question instead of "a"
      
      * Add a missing call to `check_processed_downward_messages`
      
      * Clean more stuff during offboarding
      
      * Fix typo
      
      * Fix typo for the config
      
      * Add a call to `prune_dmq`
      
      * Add explicit invariants for ingress/egress indexes
      
      * Add comments for the sender/reciever deposit config fields
      
      * Document various fields and structs in Router module
      
      * More docs
      
      * Missing docs in Candidate.md
      
      * Tabs to spaces in router.md
      
      * Apply Rob's suggestion
      
      * Add the hrmp_ prefix to the router messages
      
      * Those are entry points
      
      * Use SessionIndex type for the `age` field
      
      * Use a struct to represent `HrmpChannelId`
      
      * Put only MQCs into the LocalValidationData
      
      * Close request can be initiated by the runtime directly
      
      * Close request can be initiated by the runtime directly
      
      * tabs/spaces
      
      * Maintain the list of the outgoing paras in Router
      
      * Update roadmap/implementers-guide/src/runtime/inclusion.md
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * fix typo
      
      * Remove an unnecessary pair of code quotes
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      864fff12
  2. Aug 05, 2020
  3. Aug 04, 2020
  4. Aug 03, 2020
  5. Jul 31, 2020
    • ordian's avatar
      Chain API subsystem (#1498) · d4022633
      ordian authored
      * chain-api subsystem skeleton
      
      * chain-api subsystem: draft impl
      
      * chain-api subsystem: mock testclient
      
      * chain-api subsystem: impl HeaderBacked for TestClient
      
      * chain-api subsystem: impl basic tests
      
      * chain-api subsystem: tiny guide
      
      * chain-api subsystem: rename ChainApiRequestMessage to ChainApiMessage
      
      * chain-api subsystem: add the page to the ToC
      
      * chain-api subsystem: proper error type
      
      * chain-api subsystem: impl ancestors request
      
      * chain-api subsystem: tests for ancestors request
      
      * guide: fix ancestor return type
      
      * runtime-api subsystem: remove unused dep
      
      * fix fmt
      
      * fix outdated comment
      
      * chain-api subsystem: s/format/to_string
      
      * lower-case subsystem names
      
      * chain-api subsystem: resolve Finalized todo
      
      * chain-api subsystem: remove TODO
      
      * extract request errors into a module
      
      * remove caching TODO
      
      * fix imports
      d4022633
    • asynchronous rob's avatar
      guide: collator networking & subsystems (#1452) · 0bcb6f9d
      asynchronous rob authored
      * Do a small write-up on collation-generation
      
      * preamble to collator protocol
      
      * notes on protocol
      
      * collation-generation: point to collator protocol
      
      * fix missing bracket
      
      * expand on collator protocol wire protocol
      
      * add a couple more sentences
      
      * expand on requests some more
      
      * go higher level
      
      * network bridge: note peerset
      
      * note peer-set = validation for protocols
      
      * add `ConnectToValidators` message
      
      * use ConnectToValidators in collator protocol
      
      * typo
      
      * remove references to sentry nodes
      0bcb6f9d
    • ordian's avatar
      Guide: add a diagram for Inclusion Pipeline & Approval Subsystem (#1457) · caaed9a1
      ordian authored
      * guide: optimize diagrams for readability
      
      * guide: inclusion subsystem diagram
      
      * guide: rename Approval Subsystem for clarity
      
      * guide: correct the approval subsystem
      
      * guide: clarify that validator are selected from the same set
      
      * guide: simplify secondary checkers labels
      caaed9a1
  6. Jul 30, 2020
    • asynchronous rob's avatar
      Candidate Validation Subsystem (#1432) · cdb5c408
      asynchronous rob authored
      * skeleton for candidate-validation
      
      * add to workspace
      
      * implement candidate validation logic
      
      * guide: note occupied-core assumption for candidate validation
      
      * adjust message doc
      
      * wire together `run` asynchronously
      
      * add a Subsystem implementation
      
      * clean up a couple warnings
      
      * fix compilation errors due to merge
      
      * improve candidate-validation.md
      
      * remove old reference to subsystem-test helpers crate
      
      * update Cargo.lock
      
      * add a couple new Runtime API methods
      
      * add a candidate validation message
      
      * fetch validation data from the chain state
      
      * some tests for assumption checking
      
      * make spawn_validate_exhaustive mockable
      
      * more tests on the error handling side
      
      * fix all other grumbles except for wasm validation API change
      
      * wrap a SpawnNamed in candidate-validation
      
      * warn
      
      * amend guide
      
      * squanch warning
      
      * remove duplicate after merge
      cdb5c408
  7. Jul 27, 2020
  8. Jul 23, 2020
    • asynchronous rob's avatar
      Include a reference to the validation data in the candidate descriptor (#1442) · cce0a950
      asynchronous rob authored
      * rename GlobalValidationSchedule to GlobalValidationData
      
      * guide: update candidate descriptor to contain validation data hash
      
      * guide: add note in inclusion module about checking validation data hash
      
      * primitives: update CandidateDescriptor to contain new hash
      
      * fix payload computation
      
      * add helpers for computing validation data to runtime modules
      
      * guide: note routines
      
      * inclusion: check validation data hash and fix local_validation_data bug
      
      * add a case to candidate_checks and improve that test substantially
      
      * bump versions
      
      * address review comments
      
      * add a test for including code upgrade
      
      * bump kusama version
      
      * bump westend & polkadot versions
      cce0a950
    • Peter Goodspeed-Niklaus's avatar
      implement bitfield signing subsystem (#1364) · 8217ca67
      Peter Goodspeed-Niklaus authored
      
      
      * update guide to reduce confusion and TODOs
      
      * work from previous bitfield signing effort
      
      There were large merge issues with the old bitfield signing PR, so
      we're just copying all the work from that onto this and restarting.
      
      Much of the existing work will be discarded because we now have better
      tools available, but that's fine.
      
      * start rewriting bitfield signing in terms of the util module
      
      * implement construct_availability_bitvec
      
      It's not an ideal implementation--we can make it much more concurrent--
      but at least it compiles.
      
      * implement the unimplemented portions of bitfield signing
      
      * get core availability concurrently, not sequentially
      
      * use sp-std instead of std for a parachain item
      
      * resolve type inference failure caused by multiple From impls
      
      * handle bitfield signing subsystem & Allmessages variant in overseer
      
      * fix more multi-From inference issues
      
      * more concisely handle overflow
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      
      * Revert "resolve type inference failure caused by multiple From impls"
      
      This reverts commit 7fc77805.
      
      * Revert "fix more multi-From inference issues"
      
      This reverts commit f14ffe58
      
      .
      
      * impl From<i32> for ParaId
      
      * handle another instance of AllSubsystems
      
      * improve consistency when returning existing options
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      8217ca67
    • Bernhard Schuster's avatar
      implement bitfield distribution subsystem (#1368) · 08fcbda4
      Bernhard Schuster authored
      
      
      * feat bitfield distribution
      
      * feat bitfield distribution part 2
      
      * pair programming with rustc & cargo
      
      * lets go
      
      * move bitfield-distribution to the node/network folder
      
      * shape shifting
      
      * lunchtime
      
      * ignore the two fn recursion for now
      
      * step by step
      
      * triplesteps
      
      * bandaid commit
      
      * unordered futures magic
      
      * chore
      
      * reword markdown
      
      * clarify
      
      * lacks abortable processing impl details
      
      * slimify
      
      * fix: warnings and avoid ctx.clone() improve comments
      
      * review comments
      
      * fix details
      
      * make sure outgoing messages are tracked
      
      * fix name
      
      * fix subsystem
      
      * partial test impl
      
      * relax context bounds
      
      * test
      
      * X
      
      * X
      
      * initial test
      
      * fix relay_message not tracked when origin is self
      
      * fix/guide: grammar
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * work around missing Eq+PartialEq
      
      * fix: add missing message to provisioner
      
      * unify per_job to job_data
      
      * fix/review: part one
      
      * fix/review: more grumbles
      
      * fix/review: track incoming messages per peer
      
      * fix/review: extract fn, avoid nested matches
      
      * fix/review: more tests, simplify test
      
      * fix/review: extend tests to cover more cases
      
      * chore/rename: Tracker -> ProtocolState
      
      * chore check and comment rewording
      
      * feat test: invalid peer message
      
      * remove ignored test cases and unused macros
      
      * fix master merge fallout + warnings
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      08fcbda4
  9. Jul 22, 2020
  10. Jul 18, 2020
    • asynchronous rob's avatar
      Implement Runtime APIs (#1411) · 5d7142f1
      asynchronous rob authored
      * create a README on Runtime APIs
      
      * add ParaId type
      
      * write up runtime APIs
      
      * more preamble
      
      * rename
      
      * rejig runtime APIs
      
      * add occupied_since to `BlockNumber`
      
      * skeleton crate for runtime API subsystem
      
      * improve group_for_core
      
      * improve docs on availability cores runtime API
      
      * guide: freed -> free
      
      * add primitives for runtime APIs
      
      * create a v1 ParachainHost API trait
      
      * guide: make validation code return `Option`al.
      
      * skeleton runtime API helpers
      
      * make parachain-host runtime-generic
      
      * skeleton for most runtime API implementation functions
      
      * guide: add runtime API helper methods
      
      * implement new helpers of the inclusion module
      
      * guide: remove retries check, as it is unneeded
      
      * implement helpers for scheduler module for Runtime APIs
      
      * clean up `validator_groups` implementation
      
      * implement next_rotation_at and last_rotation_at
      
      * guide: more helpers on GroupRotationInfo
      
      * almost finish implementing runtime APIs
      
      * add explicit block parameter to runtime API fns
      
      * guide: generalize number parameter
      
      * guide: add group_responsible to occupied-core
      
      * update primitives due to guide changes
      
      * finishing touches on runtime API implementation; squash warnings
      
      * break out runtime API impl to separate file
      
      * add tests for next_up logic
      
      * test group rotation info
      
      * point to filed TODO
      
      * remove unused TODO [now]
      
      * indentation
      
      * guide: para -> para_id
      
      * rename para field to para_id for core meta
      
      * remove reference to outdated AvailabilityCores type
      
      * add an event in `inclusion` for candidates being included or timing out
      
      * guide: candidate events
      
      * guide: adjust language
      
      * Candidate events type from guide and adjust inclusion event
      
      * implement `candidate_events` runtime API
      
      * fix runtime test compilation
      
      * max -> min
      
      * fix typos
      
      * guide: add `RuntimeAPIRequest::CandidateEvents`
      5d7142f1
  11. Jul 17, 2020
  12. Jul 16, 2020
  13. Jul 10, 2020
    • Peter Goodspeed-Niklaus's avatar
      add more detail to provisioner block production section (#1370) · 64d0c7ae
      Peter Goodspeed-Niklaus authored
      Per https://github.com/paritytech/polkadot/commit/69ce9ff3#r40392855
      64d0c7ae
    • asynchronous rob's avatar
      Refactor primitives (#1383) · 96af6ead
      asynchronous rob authored
      * create a v1 primitives module
      
      * Improve guide on availability types
      
      * punctuate
      
      * new parachains runtime uses new primitives
      
      * tests of new runtime now use new primitives
      
      * add ErasureChunk to guide
      
      * export erasure chunk from v1 primitives
      
      * subsystem crate uses v1 primitives
      
      * node-primitives uses new v1 primitives
      
      * port overseer to new primitives
      
      * new-proposer uses v1 primitives (no ParachainHost anymore)
      
      * fix no-std compilation for primitives
      
      * service-new uses v1 primitives
      
      * network-bridge uses new primitives
      
      * statement distribution uses v1 primitives
      
      * PoV distribution uses v1 primitives; add PoV::hash fn
      
      * move parachain to v0
      
      * remove inclusion_inherent module and place into v1
      
      * remove everything from primitives crate root
      
      * remove some unused old types from v0 primitives
      
      * point everything else at primitives::v0
      
      * squanch some warns up
      
      * add RuntimeDebug import to no-std as well
      
      * port over statement-table and validation
      
      * fix final errors in validation and node-primitives
      
      * add dummy Ord impl to committed candidate receipt
      
      * guide: update CandidateValidationMessage
      
      * add primitive for validationoutputs
      
      * expand CandidateValidationMessage further
      
      * bikeshed
      
      * add some impls to omitted-validation-data and available-data
      
      * expand CandidateValidationMessage
      
      * make erasure-coding generic over v1/v0
      
      * update usages of erasure-coding
      
      * implement commitments.hash()
      
      * use Arc<Pov> for CandidateValidation
      
      * improve new erasure-coding method names
      
      * fix up candidate backing
      
      * update docs a bit
      
      * fix most tests and add short-circuiting to make_pov_available
      
      * fix remainder of candidate backing tests
      
      * squanching warns
      
      * squanch it up
      
      * some fallout
      
      * overseer fallout
      
      * free from polkadot-test-service hell
      96af6ead
  14. Jul 09, 2020
    • Fedor Sakharov's avatar
      CandidateBackingSubsystem (#1312) · 6aa5bfba
      Fedor Sakharov authored
      * Updates guide for CandidateBacking
      
      * Move assignment types to primitives
      
      * Initial implementation.
      
      * More functionality
      
      * use assert_matches
      
      * Changes to report misbehaviors
      
      * Some fixes after a review
      
      * Remove a blank line
      
      * Update guide and some types
      
      * Adds run_job function
      
      * Some comments and refactorings
      
      * Fix review
      
      * Remove warnings
      
      * Use summary in kicking off validation
      
      * Parallelize requests
      
      * Validation provides local and global validation params
      
      * Test issued validity tracking
      
      * Nits from review
      6aa5bfba
    • asynchronous rob's avatar
      Delay session changes' effects on parachains by 1 block (#1354) · da237676
      asynchronous rob authored
      
      
      * note that the initializer is responsible for buffering session changes
      
      * amend initializer definition to include session change buffering
      
      * support buffered changes before `on_initialize`
      
      * implement and test session buffering
      
      * Update roadmap/implementors-guide/src/runtime/README.md
      
      Co-authored-by: default avatarBernhard Schuster <[email protected]>
      
      * expand on how this affects misbehavior reports
      
      * fix typo
      
      Co-authored-by: default avatarBernhard Schuster <[email protected]>
      da237676
  15. Jul 08, 2020
    • asynchronous rob's avatar
      Implement PoV Distribution Subsystem (#1344) · b651e4af
      asynchronous rob authored
      * introduce candidatedescriptor type
      
      * add PoVDistribution message type
      
      * loosen bound on PoV Distribution to account for equivocations
      
      * re-export some types from the messages module
      
      * begin PoV Distribution subsystem
      
      * remove redundant index from PoV distribution
      
      * define state machine for pov distribution
      
      * handle overseer signals
      
      * set up control flow
      
      * remove `ValidatorStatement` section
      
      * implement PoV fetching
      
      * implement distribution logic
      
      * add missing `
      
      * implement some network bridge event handlers
      
      * stub for message processing, handle our view change
      
      * control flow for handling messages
      
      * handle `awaiting` message
      
      * handle any incoming PoVs and redistribute
      
      * actually provide a subsystem implementation
      
      * remove set-builder notation
      
      * begin testing PoV distribution
      
      * test that we send awaiting messages only to peers with same view
      
      * ensure we distribute awaited PoVs to peers on view changes
      
      * test that peers can complete fetch and are rewarded
      
      * test some reporting logic
      
      * ensure peer is reported for flooding
      
      * test punishing peers diverging from awaited protocol
      
      * test that we eagerly complete peers' awaited PoVs based on what we receive
      
      * test that we prune the awaited set after receiving
      
      * expand pov-distribution in guide to match a change I made
      
      * remove unneeded import
      b651e4af
  16. Jul 07, 2020