Skip to content
  1. Oct 20, 2023
    • Bastian Köcher's avatar
      `xcm`: Change `TypeInfo::path` to not include `staging` (#1948) · f3bf5c1a
      Bastian Köcher authored
      
      
      The `xcm` crate was renamed to `staging-xcm` to be able to publish it to
      crates.io as someone as squatted `xcm`. The problem with this rename is
      that the `TypeInfo` includes the crate name which ultimately lands in
      the metadata. The metadata is consumed by downstream users like
      `polkadot-js` or people building on top of `polkadot-js`. These people
      are using the entire `path` to find the type in the type registry. Thus,
      their code would break as the type path would now be [`staging_xcm`,
      `VersionedXcm`] instead of [`xcm`, `VersionedXcm`]. This pull request
      fixes this by renaming the path segment `staging_xcm` to `xcm`.
      
      This requires: https://github.com/paritytech/scale-info/pull/197
      
      ---------
      
      Co-authored-by: default avatarFrancisco Aguirre <[email protected]>
      f3bf5c1a
    • Francisco Aguirre's avatar
      Remove some dbgs (#1949) · f0d443a0
      Francisco Aguirre authored
      Removed some debug logs
      f0d443a0
    • cheme's avatar
      Switch trie cache random seed (#1935) · f4c4c0fe
      cheme authored
      Use a more secure seed for hashsets of cache.
      f4c4c0fe
  2. Oct 19, 2023
  3. Oct 18, 2023
    • Bulat Saifullin's avatar
      Update kusama/polkadot bootnodes (#1895) · 3e980219
      Bulat Saifullin authored
      closes: https://github.com/paritytech/devops/issues/2090
      
      ## Changes
      1. Updated the list of bootnodes.
      2. Merged the Connect node and bootnode into a single node.
      3. Decreased the number of nodes.
      4. Updated the DNS name.
      
      ## Description
      The initial 8 bootnodes were planned to be replaced by community
      bootnodes, the community node was added but we did not bother to reduce
      the Parity managed bootnodes. Fixing it now.
      3e980219
    • Keith Yeung's avatar
      Introduce XcmFeesToAccount fee manager (#1234) · 3dece311
      Keith Yeung authored
      
      
      Combination of paritytech/polkadot#7005, its addon PR
      paritytech/polkadot#7585 and its companion paritytech/cumulus#2433.
      
      This PR introduces a new XcmFeesToAccount struct which implements the
      `FeeManager` trait, and assigns this struct as the `FeeManager` in the
      XCM config for all runtimes.
      
      The struct simply deposits all fees handled by the XCM executor to a
      specified account. In all runtimes, the specified account is configured
      as the treasury account.
      
      XCM __delivery__ fees are now being introduced (unless the root origin
      is sending a message to a system parachain on behalf of the originating
      chain).
      
      # Note for reviewers
      
      Most file changes are tests that had to be modified to account for the
      new fees.
      Main changes are in:
      - cumulus/pallets/xcmp-queue/src/lib.rs <- To make it track the delivery
      fees exponential factor
      - polkadot/xcm/xcm-builder/src/fee_handling.rs <- Added. Has the
      FeeManager implementation
      - All runtime xcm_config files <- To add the FeeManager to the XCM
      configuration
      
      # Important note
      
      After this change, instructions that create and send a new XCM (Query*,
      Report*, ExportMessage, InitiateReserveWithdraw, InitiateTeleport,
      DepositReserveAsset, TransferReserveAsset, LockAsset and RequestUnlock)
      will require the corresponding origin account in the origin register to
      pay for transport delivery fees, and the onward message will fail to be
      sent if the origin account does not have the required amount. This
      delivery fee is on top of what we already collect as tx fees in
      pallet-xcm and XCM BuyExecution fees!
      
      Wallet UIs that want to expose the new delivery fee can do so using the
      formula:
      
      ```
      delivery_fee_factor * (base_fee + encoded_msg_len * per_byte_fee)
      ```
      
      where the delivery fee factor can be obtained from the corresponding
      pallet based on which transport you are using (UMP, HRMP or bridges),
      the base fee is a constant, the encoded message length from the message
      itself and the per byte fee is the same as the configured per byte fee
      for txs (i.e. `TransactionByteFee`).
      
      ---------
      
      Co-authored-by: default avatarBranislav Kontur <[email protected]>
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      Co-authored-by: default avatarGiles Cope <[email protected]>
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarFrancisco Aguirre <[email protected]>
      Co-authored-by: default avatarLiam Aharon <[email protected]>
      Co-authored-by: default avatarKian Paimani <[email protected]>
      3dece311
    • Javyer's avatar
      upgraded review bot to v2.1.0 (#1908) · 1cf7d3aa
      Javyer authored
      Upgraded to version 2.1.0 which has paritytech/review-bot#94, a change
      in the logic of the action to overcome some problems with permissions
      coming from PRs from forks
      
      For this, we needed to divide the actions into two files:
      - A first action that triggers on PRs and reviews and uploads the PR
      number.
      - A second action which is triggered under the completion of the first
      one and runs as the action normally runs (but won't have any problems
      regarding permissions because it is triggered from the master branch)
      1cf7d3aa
    • alexd10s's avatar
      Trading trait and deal with metadata in Mutate trait for nonfungibles_v2 (#1561) · 3aaf62ad
      alexd10s authored
      
      
      I have added some Traits that are missing and are useful for dealing
      with non-fungible tokens on other pallets and their implementations for
      NFTs pallet.
      
      - In the Mutate trait, added methods for dealing with the metadata:
      `set_metadata`, `set_collection_metadata`, `clear_metadata` and
      `clear_collection_metadata`.
      The motivation of adding this methods coming from a StackExchange
      question asking for it: [Setting metadata of an item of the Nfts pallet
      in a custom
      pallet](https://substrate.stackexchange.com/questions/9974/setting-metadata-of-an-item-of-the-nfts-pallet-in-a-custom-pallet)
      
      - A Trait for trading non-fungible items. The methods in that Trait are
      `buy_item`, `set_price` and `item_price`
      An example of where this Trait can be useful is a pallet that deals with
      [NFT
      Royalties](https://forum.polkadot.network/t/nfts-royalty-pallet/3766)
      and needs to perform this actions.
      
      ---------
      
      Co-authored-by: default avatarJegor Sidorenko <[email protected]>
      3aaf62ad
    • joe petrowski's avatar
      Add Runtime Missing Crate Descriptions (#1909) · d3ea69b7
      joe petrowski authored
      Adds descriptions needed for publishing to crates.io.
      d3ea69b7
    • Chevdor's avatar
      Switch to the release env (#1910) · b6654094
      Chevdor authored
      Follow up of #1892, this PR now switches the env for release related
      workflows from `master` to `release`.
      b6654094
    • dependabot[bot]'s avatar
      Bump paritytech/review-bot from 2.0.1 to 2.1.0 (#1924) · 9c333a5c
      dependabot[bot] authored
      Bumps [paritytech/review-bot](https://github.com/paritytech/review-bot) from 2.0.1 to 2.1.0.
      9c333a5c
    • dependabot[bot]'s avatar
      Bump actions/checkout from 4.1.0 to 4.1.1 (#1925) · e34aa4b7
      dependabot[bot] authored
      Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.0 to 4.1.1.
      e34aa4b7
    • Serban Iorga's avatar
      Start BEEFY client by default for Polkadot nodes (#1913) · 6c39bb4a
      Serban Iorga authored
      Fellowship companion:
      https://github.com/polkadot-fellows/runtimes/pull/65
      
      This starts the BEEFY client by default for Polkadot nodes.
      
      Governance/sudo call is later required to enable/start consensus.
      
      Part of https://github.com/paritytech/parity-bridges-common/issues/2420
      6c39bb4a
    • Adrian Catangiu's avatar
      cumulus: add asset-hub-rococo runtime based on asset-hub-kusama and add... · 8b3905d2
      Adrian Catangiu authored
      
      cumulus: add asset-hub-rococo runtime based on asset-hub-kusama and add asset-bridging support to it (#1215)
      
      This commit adds Rococo Asset Hub dedicated runtime so we can test new
      features here, before merging them in Kusama Asset Hub.
      Also adds one such feature: asset transfer over bridge (Rococo AssetHub
      <> Wococo AssetHub)
      
      - clone `asset-hub-kusama-runtime` -> `asset-hub-rococo-runtime`
      - make it use Rococo primitives, names, assets, constants, etc
      - add asset-transfer-over-bridge support to Rococo AssetHub <> Wococo
      AssetHub
      
      Fixes #1128
      
      ---------
      
      Co-authored-by: default avatarBranislav Kontur <[email protected]>
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      Co-authored-by: default avatarFrancisco Aguirre <[email protected]>
      8b3905d2
    • Ignacio Palacios's avatar
      Publish `penpal-runtime` crate (#1904) · e73729b1
      Ignacio Palacios authored
      Remove `publish = false` to publish the crate
      e73729b1
  4. Oct 17, 2023
  5. Oct 16, 2023
    • Liam Aharon's avatar
      Allow Locks/Holds/Reserves/Freezes by default when using `pallet_balances`... · fcc1bb41
      Liam Aharon authored
      Allow Locks/Holds/Reserves/Freezes by default when using `pallet_balances` `TestDefaultConfig` (#1880)
      
      Allow Locks/Holds/Reserves/Freezes by default when using
      `pallet_balances` `TestDefaultConfig`.
      fcc1bb41
    • Oliver Tale-Yazdi's avatar
      Workspace maintenance (#1884) · 9c1a2b38
      Oliver Tale-Yazdi authored
      
      
      Changes:
      - Add missing crate to the workspace
      - Remove versions from local dependency links
      
      Maybe it is finally worth it to add this scrip to the CI to find these
      things earlier:
      [check-deps.py](https://github.com/ggwpez/substrate-scripts/blob/master/import-runtime-repos/check-deps.py).
      
      @paritytech/ci what would be the best location for that check?  
      It takes only a second to run, so maybe we can squeeze it into one of
      the existing checks?
      Otherwise creating a new GH workflow feels a bit wasteful... maybe i can
      group it with https://github.com/paritytech/polkadot-sdk/pull/1831
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      9c1a2b38
    • Ignacio Palacios's avatar
      Make System Parachains trusted Teleporters (#1368) · e0065cb8
      Ignacio Palacios authored
      
      
      Make System Parachain trusted Teleporters of each other.
      
      Migration of https://github.com/paritytech/cumulus/pull/2842
      
      ---------
      
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      e0065cb8
    • Chevdor's avatar
      Add missing env (#1892) · 4145902f
      Chevdor authored
      This PR adds a missing env to allow publishing the Docker image.
      4145902f
    • Muharem Ismailov's avatar
      `extract` amount method for `fungible/s` `Imbalance` (#1847) · c422e3f5
      Muharem Ismailov authored
      Introduces an `extract` amount method for `fungible/s` `Imbalance`.
      c422e3f5
    • Adrian Catangiu's avatar
      sc-consensus-beefy: fix initialization when state is unavailable (#1888) · 646ecd0e
      Adrian Catangiu authored
      
      
      Fix situation where BEEFY initial validator set could not be determined.
      
      If state is unavailable at BEEFY genesis block to get initial validator
      set, get the info from header digests. For this, we need to walk back
      the chain starting from BEEFY genesis looking for the BEEFY digest
      announcing the active validator set for that respective session.
      
      This commit fixes a silly bug where walking back the chain was stopped
      when reaching BEEFY genesis block, which is incorrect when BEEFY genesis
      is not session boundary block. When BEEFY genesis is set to some random
      block within a session, we need to walk back to the start of the session
      to see the validator set announcement.
      
      Added regression test for this fix.
      
      Fixes https://github.com/paritytech/polkadot-sdk/issues/1885
      
      Signed-off-by: default avatarAdrian Catangiu <[email protected]>
      646ecd0e
    • Bastian Köcher's avatar
      sp-api: Improve error message for duplicate runtime apis (#1877) · 4e98bec3
      Bastian Köcher authored
      Co-authored-by: command-bot <>
      4e98bec3
    • Oliver Tale-Yazdi's avatar
      [CI] Add link checker (#1875) · e0e566bc
      Oliver Tale-Yazdi authored
      
      
      Adding link checker to the CI (closes
      https://github.com/paritytech/polkadot-sdk/issues/993). It would be nice
      to have the docs people own this and extend accordingly.
      Currently all known-bad links are excluded, but we should one-by-one
      include those as well until all are fixed.
      
      This check now ensures that 1) no new broken links are introduced into
      `.rs` files and 2) that no old links break unnoticed.
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      e0e566bc
    • Bulat Saifullin's avatar
      Update the alerts to use a new metric substrate_unbounded_channel_size (#1568) · 73ec161e
      Bulat Saifullin authored
      # Description
      
      Follow up for https://github.com/paritytech/polkadot-sdk/pull/1489.
      Closes #611 
      
      Before we calculated the channel size during alert expression but in
      #1489 a new metric was introduced that reports channel size.
      ## Changes:
      1. updated alert rule to use new metric.
      73ec161e