- Aug 01, 2023
-
-
Marcin S. authored* PVF: Fix external workers being required for non-collator full nodes * Fix * Make check more precise > This might as well be if role.is_authority() as there aren't really any nodes > that are both authorities and collators. But if there were a node that is an > authority and a collator, it'd probably want to validate candidates (in its > role as an authority). * Just seeing if this fixes zombienet CI...
-
- Jul 31, 2023
-
-
Marcin S. authored
* [WIP] PVF: Split out worker binaries * Address compilation problems and re-design a bit * Reorganize once more, fix tests * Reformat with new nightly to make `cargo fmt` test happy * Address `clippy` warnings * Add temporary trace to debug zombienet tests * Fix zombienet node upgrade test * Fix malus and its CI * Fix building worker binaries with malus * More fixes for malus * Remove unneeded cli subcommands * Support placing auxiliary binaries to `/usr/libexec` * Fix spelling * Spelling Co-authored-by:
Marcin S. <[email protected]> * Implement review comments (mostly nits) * Fix worker node version flag * Rework getting the worker paths * Address a couple of review comments * Minor restructuring * Fix CI error * Add tests for worker binaries detection * Improve tests; try to fix CI * Move workers module into separate file * Try to fix failing test and workers not printing latest version - Tests were not finding the worker binaries - Workers were not being rebuilt when the version changed - Made some errors easier to read * Make a bunch of fixes * Rebuild nodes on version change * Fix more issues * Fix tests * Pass node version from node into dependencies to avoid recompiles - [X] get version in CLI - [X] pass it in to service - [X] pass version along to PVF - [X] remove rerun from service - [X] add rerun to CLI - [X] don’t rerun pvf/worker’s (these should be built by nodes which have rerun enabled) * Some more improvements for smoother tests - [X] Fix tests - [X] Make puppet workers pass None for version and remove rerun - [X] Make test collators self-contained * Add back rerun to PVF workers * Move worker binaries into files in cli crate As a final optimization I've separated out each worker binary from its own crate into the CLI crate. Before, the worker bin shared a crate with the worker lib, so when the binaries got recompiled so did the libs and everything transitively depending on the libs. This commit fixes this regression that was causing recompiles after every commit. * Fix bug (was passing worker version for node version) * Move workers out of cli into root src/bin/ dir - [X] Pass in node version from top-level (polkadot) - [X] Add build.rs with rerun-git-head to root dir * Add some sanity checks for workers to dockerfiles * Update malus + [X] Make it self-contained + [X] Undo multiple binary changes * Try to fix clippy errors * Address `cargo run` issue - [X] Add default-run for polkadot - [X] Add note about installation to error * Update readme (installation instructions) * Allow disabling external workers for local/testing setups + [X] cli flag to enable single-binary mode + [X] Add message to error * Revert unnecessary Cargo.lock changes * Remove unnecessary build scripts from collators * Add back missing malus commands (should fix failing ZN job) * Some minor fixes * Update Cargo.lock * Fix some build errors * Undo self-contained binaries; cli flag to disable version check + [X] Remove --dont-run-external-workers + [X] Add --disable-worker-version-check + [X] Remove PVF subcommands + [X] Redo malus changes * Try to fix failing job and add some docs for local tests --------- Co-authored-by:
Dmitry Sinyavin <[email protected]> Co-authored-by:
s0me0ne-unkn0wn <[email protected]> Co-authored-by: parity-processbot <>
-
- Jul 25, 2023
-
-
Marijn Schouten authored
* change HashFor to HashingFor * Update node/service/src/lib.rs Co-authored-by:
Bastian Köcher <[email protected]> * Bump Substrate Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Revert "Bump Substrate" This reverts commit 5df19d03e85a7d39c8c7faa8b5f0f2225751d19a. * Bump Substrate Signed-off-by:
-
Anton authored
* update tinyvec to 1.6.0 * update once_cell to 1.18.0 * update data-encoding to 2.4.0 * update libc * update js-sys * update wasm-bindgen-futures * update pin-project * update tokio * update syn * p2p protocol now contains `PeerId` not multihash * update arrayvec to 0.7.4 * update sha2 * update smallvec * updates to Cargo.lock after merge * redo dep updates * update lru in attempt to compile polkadot * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <> -
RadiumBlock authored
-
- Jul 22, 2023
-
-
jserrat authored
* add tests to worker common thread * fix formatting * move worker commons unit test from integration tests to worker file and do some improvements * fix import on it/worker_common * move worker commons unit test to test module * cargo fmt * move cpu_time_monitor_loop to test outside of thread module * change worker thread unit test to use assert_eq * fix formatting * adding new methods to WaitOucome, fix pvf worker unit test * fix formatting * remove is_finished and is_timeout methods from WaitOutcome * fix wait_for_threads_with_timeout_returns_outcome test * ".git/.scripts/commands/fmt/fmt.sh" * add common worker cond_notify_on_done_should_update_wait_outcome_when_panic test --------- Co-authored-by:
-
- Jul 21, 2023
-
-
Sergej Sakac authored
* Add NetworkBridgeEvent::UpdatedAuthorityIds * update collator * informing subsystems * remove outdated authority data * docs * remove accidentally added line * update docs * emit event on session change * emit * check for update and update * Update node/network/gossip-support/src/lib.rs Co-authored-by:
Andronik <[email protected]> * Update node/network/approval-distribution/src/lib.rs Co-authored-by:
-
- Jul 20, 2023
-
-
Andrei Sandu authored
Signed-off-by:Andrei Sandu <[email protected]>
-
- Jul 19, 2023
-
-
Francisco Aguirre authored
* Add polkadot XCM benchmarks * Add temp * ".git/.scripts/commands/bench/bench.sh" xcm polkadot pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm polkadot pallet_xcm_benchmarks::generic * Add weights to XCM on Polkadot * Make CI fail on old files Signed-off-by:
Keith Yeung <[email protected]> * Fix fmt * Revert "Fix fmt" This reverts commit 676f2d8db07d7427750c79f95494d4988d06fda5. * Fix fmt * Remove duplicated template code * Add back part of the template * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible * Don't skip reserve asset deposited benchmark * Remove call to non-generated benchmark yet * Underscore unused parameter * Skip not supported benchmarks and hardcode value * Remove ReserveAssetDeposited benchmark * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible * Add back ReserveAssetDeposited * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible * Use default benchmark for ReserveAssetDeposited * Add missing parameter * Revert reserve asset deposited benchmark * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm kusama pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm westend pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm rococo pallet_xcm_benchmarks::fungible * Add 'real' benchmarks * Add TrustedReserve to actual XcmConfig * Add TrustedReserve to actual XcmConfig (fix) * Whitelist from benchmarking XCM storage keys read each block (#6871) * Whitelist from benchmarking XCM storage keys read each block * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm * Remove XcmPallet SupportedVersion from the benchmark whitelist * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime kusama pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm * WIP * Add necessary traits, remove unnecessary whitelisted keys * Fix tests * Remove unused file * Remove unused import --------- Co-authored-by: command-bot <> * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm rococo pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm westend pallet_xcm_benchmarks::fungible * Fix spellchecker issues * Remove unused migration code --------- Signed-off-by:
-
- Jul 18, 2023
-
-
Michal Kucharczyk authored* chain-spec: polkadot_staging_testnet config removed The config has empty initial authority test. It is unusable. ``` $ polkadot export-blocks --chain polkadot-staging --from=0 --to=0 ... Thread 'main' panicked at 'Empty validator set for session 0 in genesis block!', /home/miszka/.cargo/git/checkouts/substrate-7e08433d4c370a21/c446786/frame/session/src/lib.rs:463 ``` * warning fix
-
André Silva authored
* companion for substrate#14423 * update lockfile for {"substrate"} * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <>
-
- Jul 17, 2023
-
-
Andrei Eres authored
* Introduce is_frequent util * Add dirty warn_if_frequent! implementation * Add freq * Fix order in condition * Update * Update docs * Fix * Remove old impl * Fix errors * Add wif to av-distr * Add wif to col prot * Rename * Add wif to state-distr * Address review comments * Change Freq implementation * Remove the zero division check * Make rate explicit * Fix typo * Update rate constant * Introduce explicit rates * Update docs * Split errors freq * Downgrade coarsetime
-
- Jul 12, 2023
-
-
Michal Kucharczyk authored
* GenesisBuild<T,I> deprecated. BuildGenesisConfig added * fmt * fixes * more fixes * more fixes * fixes * update lockfile for {"substrate"} * fix --------- Co-authored-by: parity-processbot <>
-
- Jul 11, 2023
-
-
Bastian Köcher authored
* Companion for removal of execution strategies https://github.com/paritytech/substrate/pull/14387 * Fix some tests *
🤦 * Adapt to latest changes * Start supporting the offchain transaction pool * Fix tests * FMT * Remove patches * Update Substrate * update lockfile for {"substrate"} * Fix parachain upgrade smoke test * Fix test * Rewrite all tests to use `MockSubstemClient` --------- Co-authored-by: parity-processbot <>
-
- Jul 07, 2023
-
-
Andrei Sandu authored
* Remove redundant erasure encoding Signed-off-by:
-
- Jul 06, 2023
-
-
s0me0ne-unkn0wn authored
* Introduce `ci-only-tests` feature * Add comment
-
- Jul 05, 2023
-
-
Marcin S. authored
* Begin adding landlock + test * Move PVF implementer's guide section to own page, document security * Implement test * Add some docs * Do some cleanup * Fix typo * Warn on host startup if landlock is not supported * Clarify docs a bit * Minor improvements * Add some docs about determinism * Address review comments (mainly add warning on landlock error) * Update node/core/pvf/src/host.rs Co-authored-by:
Andrei Sandu <[email protected]> * Update node/core/pvf/src/host.rs Co-authored-by:
-
Bastian Köcher authored
* Companion for Substrate#14511 https://github.com/paritytech/substrate/pull/14511 * Make benchmarking build without any native runtime * Fix warning * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <>
-
- Jul 04, 2023
-
-
Squirrel authored
-
Andrei Sandu authored
* Move expensive computations to blocking thread Signed-off-by:
-
Bastian Köcher authored
* Implement runtime apis for fake runtime These runtime api implementations are only used to make the compiler think that we have implemented all required runtime apis. They will not be called as we switch the executor to `WasmExecutor`. In the near future we will not require these fake implementations anymore after Substrate has shifted away from this compile time requirement. This brings us the advantage that the `polkadot-service` doesn't need to depend on the runtimes for getting the `RuntimeApi` type. It also removes around 1min of build time on my machine ;) * Fix warning * FMT * ".git/.scripts/commands/fmt/fmt.sh" * Use more descriptive id * Fix warnings * Adapt path * Fix
🙈 --------- Co-authored-by: command-bot <>
-
- Jun 29, 2023
-
-
Bastian Köcher authored
* Companion for Substrate#14474 This removes the requirement to pass the native dispatch. * Adapt * Better * Remove patch * ... * Fix * Update Substrate
-
- Jun 23, 2023
-
-
Andrei Eres authored
* Warn if participated in the losing side of a dispute * Update naming * Additionally filter by candidate hash * Debug zombienet tests * Update 0002-parachains-disputes.zndsl * Debug zombienet * Update node/core/dispute-coordinator/src/initialized.rs Co-authored-by:
-
- Jun 22, 2023
-
-
Oliver Tale-Yazdi authored* Disable flaky test Signed-off-by:
-
- Jun 21, 2023
-
-
Milos Kriz authored
-
Andrei Sandu authored
* Measure re-encoding time Signed-off-by:
-
Koute authored
-
- Jun 16, 2023
-
-
juangirini authored
* update genesis config * fix wrong RuntimeGenesisConfig name * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <> -
Mira Ressel authored
* docs: update references to NetworkConfiguration::extra_sets Since paritytech/substrate#14080, this struct field no longer exists, now the `add_notification_protocol()` function of `sc_network::config::FullNetworkConfiguration` is used. Also neuter the doc links for now; rustdoc can't resolve them (presumably because sc_network::config isn't in scope, though weirdly enough even spelling the link out as ``[`FullNetworkConfiguration`](struct@sc_network::config::FullNetworkConfiguration)`` doesn't work?). Normally this wouldn't be an issue and rustdoc would just not generate links, but rust 1.70 has a bug that completely crashes rustdoc in this case.
-
Aaro Altonen authored
There is a race condition in `NetworkBridgeRx` between registering incoming peers and handling overseer signals. While the peer connection was sent to `NetworkBridgeRx` first, sometimes the peer would be added to `validation/collation_peers` with enough delay that the bridge handled an overseer signal that was meant do send notifications to the registered peer and as the peer was not present in the bridge, the notification was never sent and the test would hang. When peers are registered to `NetworkBridgeRx` using `connect_peer()`, wait until they show up in `shared.validation/collation_peers` before doing anything else. Co-authored-by: parity-processbot <>
-
- Jun 15, 2023
-
-
Andrei Eres authored
* Add futures-timer * Make cost_or_benefit public * Update ReportPeer message format * Add delay to reputation updates (dirtywork) * Update ReputationAggregator * Update tests * Fix flucky tests * Move reputation to state * Use the main loop for handling reputation sendings * Update * Move reputation to utils * Update reputation sending * Fix arguments order * Update state * Remove new from state * Add constant * Add failing test for delay * Change mocking approach * Fix type errors * Fix comments * Add message handling to select * Fix bitfields-distribution tests * Add docs to reputation aggregator * Replace .into_base_rep * Use one REPUTATION_CHANGE_INTERVAL by default * Add reputation change to statement-distribution * Update polkadot-availability-bitfield-distribution * Update futures selecting in subsystems * Update reputation adding * Send malicious changes right away without adding to state * Add reputation to StatementDistributionSubsystem * Handle reputation in statement distribution * Add delay test for polkadot-statement-distribution * Fix collator-protocol tests before applying reputation delay * Remove into_base_rep * Add reputation to State * Fix failed tests * Add reputation delay * Update tests * Add batched network message for peer reporting * Update approval-distribution tests * Update bitfield-distribution tests * Update statement-distribution tests * Update collator-protocol tests * Remove levels in matching * Address clippy errors * Fix overseer test * Add a metric for original count of rep changes * Update Reputation * Revert "Add a metric for original count of rep changes" This reverts commit 6c9b0c1ec34491d16e562bdcba8db6b9dcf484db. * Update node/subsystem-util/src/reputation.rs Co-authored-by:
Vsevolod Stakhov <[email protected]> * Remove redundant vec --------- Co-authored-by:
-
- Jun 14, 2023
-
-
Andrei Sandu authored
Signed-off-by: -
eskimor authored
* Remove redundant enter call. * Remove optionality in dispute signature checking * Make enter_inner and create_inherent the same. * Remove redundant metric. * Unification: enter and create_inherent. * Remove `enter_inner` function. * Remove dead code. * Remove redundant import. * Remove dead code in disputes. * ".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent * ".git/.scripts/commands/bench/bench.sh" runtime kusama runtime_parachains::paras_inherent * ".git/.scripts/commands/bench/bench.sh" runtime westend runtime_parachains::paras_inherent * Merge fix. * Fix tests. * Remove obsolete comment. * ".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent * ".git/.scripts/commands/bench/bench.sh" runtime westend runtime_parachains::paras_inherent * ".git/.scripts/commands/bench/bench.sh" runtime kusama runtime_parachains::paras_inherent * Review remarks, fixes. * Guide updates. * Fmt. * ".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent --------- Co-authored-by:eskimor <[email protected]> Co-authored-by: command-bot <>
-
- Jun 12, 2023
-
-
eskimor authored
* Move vstaging to production (and thus past session slashing). WIP: test-runtime still needs to be fixed. * Fix test-runtime. --------- Co-authored-by:
-
- Jun 11, 2023
-
-
Squirrel authored
-
- Jun 08, 2023
-
-
Alexandru Gheorghe authored
* av-store: Move prune on a separate thread There are situations where pruning of the data could take more than a few seconds and that might make the whole subsystem unreponsive. To avoid this just move the prune process on a separate thread. See: https://github.com/paritytech/polkadot/issues/7237, for more details. Signed-off-by:
Alexandru Gheorghe <[email protected]> * av-store: Add log that prunning started Signed-off-by:
-
Alexandru Gheorghe authored
* metrics: Increase the resolution of histogram metrics These metrics are using the default histogram buckets: ``` pub const DEFAULT_BUCKETS: &[f64; 11] = &[ 0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1.0, 2.5, 5.0, 10.0, ]; ``` Which give us a resolution of 5ms, that's good, but there are some subsystems where we process hundreds or even a few thousands of messages per second like approval-voting or approval-distribution, so it makes sense to increse the resoution of the bucket to better understand if the procesisng is in the range of useconds. The new bucket ranges will be: ``` [0.0001, 0.0004, 0.0016, 0.0064, 0.0256, 0.1024, 0.4096, 1.6384, 6.5536] ``` Signed-off-by:
-
- Jun 06, 2023
-
-
Alexandru Gheorghe authored
* approval-distribution: Add approvals/assignments spans on all paths The approval and assignment logic gets called from multiple paths, so make sure we create a tracing span on all paths to make debugging easier and be able and correlate with the spans from approval-voting. Signed-off-by:
-
- Jun 05, 2023
-
-
ordian authored
* runtime/vstaging: unapplied_slashes runtime API * runtime/vstaging: key_ownership_proof runtime API * runtime/ParachainHost: submit_report_dispute_lost * fix key_ownership_proof API * runtime: submit_report_dispute_lost runtime API * nits * Update node/subsystem-types/src/messages.rs Co-authored-by:
Marcin S. <[email protected]> * revert unrelated fmt changes * dispute-coordinator: past session dispute slashing * encapsule runtime api call for submitting report * prettify: extract into a function * do not exit on runtime api error * fix tests * try initial zombienet test * try something * fix a typo * try cumulus-based collator * fix clippy * build polkadot-debug images with fast-runtime enabled * wip * runtime/inclusion: fix availability_threshold * fix wip * fix wip II * revert native provider * propagate tx submission error * DEBUG: sync=trace * print key ownership proof len * panic repro * log validator index in panic message * post merge fixes * replace debug assertion with a log * fix compilation * Let's log the dispatch info in validate block. * fix double encoding * Revert "Let's log the dispatch info in validate block." This reverts commit a70fbc51b464d7f4355dbada5e16cd83cf71eab4. * Revert "Let's log the dispatch info in validate block." This reverts commit a70fbc51b464d7f4355dbada5e16cd83cf71eab4. * fix compilation * update to latest zombienet and fix test * lower finality lag to 11 * bump zombienet again * add a workaround, but still does not work * Update .gitlab-ci.yml bump zombienet. * add a comment and search logs on all nodes --------- Co-authored-by:
Bastian Köcher <[email protected]> Co-authored-by:
Javier Viola <[email protected]>
-
- Jun 02, 2023
-
-
Marcin S. authored
* PVF: Instantiate wasm in pre-checking * Move `runtime_construction_check` to prepare thread, use bytes * [minor] Update comment * Fix compile error * Update Cargo.lock * Update docs * Add some missing docs!
-
