Skip to content
  1. Aug 01, 2023
    • Marcin S.'s avatar
      PVF: Fix external workers being required for non-collator full nodes (#7566) · f226cd5a
      Marcin S. authored
      * PVF: Fix external workers being required for non-collator full nodes
      
      * Fix
      
      * Make check more precise
      
      > This might as well be if role.is_authority() as there aren't really any nodes
      > that are both authorities and collators. But if there were a node that is an
      > authority and a collator, it'd probably want to validate candidates (in its
      > role as an authority).
      
      * Just seeing if this fixes zombienet CI...
      f226cd5a
  2. Jul 31, 2023
    • Marcin S.'s avatar
      98.6% OF DEVELOPERS CANNOT REVIEW THIS PR! [read more...] (#7337) · 85b06f18
      Marcin S. authored
      
      
      * [WIP] PVF: Split out worker binaries
      
      * Address compilation problems and re-design a bit
      
      * Reorganize once more, fix tests
      
      * Reformat with new nightly to make `cargo fmt` test happy
      
      * Address `clippy` warnings
      
      * Add temporary trace to debug zombienet tests
      
      * Fix zombienet node upgrade test
      
      * Fix malus and its CI
      
      * Fix building worker binaries with malus
      
      * More fixes for malus
      
      * Remove unneeded cli subcommands
      
      * Support placing auxiliary binaries to `/usr/libexec`
      
      * Fix spelling
      
      * Spelling
      
      Co-authored-by: default avatarMarcin S. <[email protected]>
      
      * Implement review comments (mostly nits)
      
      * Fix worker node version flag
      
      * Rework getting the worker paths
      
      * Address a couple of review comments
      
      * Minor restructuring
      
      * Fix CI error
      
      * Add tests for worker binaries detection
      
      * Improve tests; try to fix CI
      
      * Move workers module into separate file
      
      * Try to fix failing test and workers not printing latest version
      
      - Tests were not finding the worker binaries
      - Workers were not being rebuilt when the version changed
      - Made some errors easier to read
      
      * Make a bunch of fixes
      
      * Rebuild nodes on version change
      
      * Fix more issues
      
      * Fix tests
      
      * Pass node version from node into dependencies to avoid recompiles
      
      - [X] get version in CLI
      - [X] pass it in to service
      - [X] pass version along to PVF
      - [X] remove rerun from service
      - [X] add rerun to CLI
      
      - [X] don’t rerun pvf/worker’s (these should be built by nodes which have rerun enabled)
      
      * Some more improvements for smoother tests
      
      - [X] Fix tests
      - [X] Make puppet workers pass None for version and remove rerun
      - [X] Make test collators self-contained
      
      * Add back rerun to PVF workers
      
      * Move worker binaries into files in cli crate
      
      As a final optimization I've separated out each worker binary from its own crate
      into the CLI crate. Before, the worker bin shared a crate with the worker lib,
      so when the binaries got recompiled so did the libs and everything transitively
      depending on the libs. This commit fixes this regression that was causing
      recompiles after every commit.
      
      * Fix bug (was passing worker version for node version)
      
      * Move workers out of cli into root src/bin/ dir
      
      - [X] Pass in node version from top-level (polkadot)
      - [X] Add build.rs with rerun-git-head to root dir
      
      * Add some sanity checks for workers to dockerfiles
      
      * Update malus
      
        + [X] Make it self-contained
        + [X] Undo multiple binary changes
      
      * Try to fix clippy errors
      
      * Address `cargo run` issue
      
      - [X] Add default-run for polkadot
      - [X] Add note about installation to error
      
      * Update readme (installation instructions)
      
      * Allow disabling external workers for local/testing setups
      
        + [X] cli flag to enable single-binary mode
        + [X] Add message to error
      
      * Revert unnecessary Cargo.lock changes
      
      * Remove unnecessary build scripts from collators
      
      * Add back missing malus commands (should fix failing ZN job)
      
      * Some minor fixes
      
      * Update Cargo.lock
      
      * Fix some build errors
      
      * Undo self-contained binaries; cli flag to disable version check
      
        + [X] Remove --dont-run-external-workers
        + [X] Add --disable-worker-version-check
        + [X] Remove PVF subcommands
        + [X] Redo malus changes
      
      * Try to fix failing job and add some docs for local tests
      
      ---------
      
      Co-authored-by: default avatarDmitry Sinyavin <[email protected]>
      Co-authored-by: default avatars0me0ne-unkn0wn <[email protected]>
      Co-authored-by: parity-processbot <>
      85b06f18
  3. Jul 28, 2023
  4. Jul 27, 2023
  5. Jul 25, 2023
  6. Jul 24, 2023
  7. Jul 22, 2023
    • Xiliang Chen's avatar
      add missing feature flag (#7537) · 79341dd4
      Xiliang Chen authored
      79341dd4
    • jserrat's avatar
      add tests to worker common thread (#7372) · 3f8c3454
      jserrat authored
      
      
      * add tests to worker common thread
      
      * fix formatting
      
      * move worker commons unit test from integration tests to worker file and do some improvements
      
      * fix import on it/worker_common
      
      * move worker commons unit test to test module
      
      * cargo fmt
      
      * move cpu_time_monitor_loop to test outside of thread module
      
      * change worker thread unit test to use assert_eq
      
      * fix formatting
      
      * adding new methods to WaitOucome, fix pvf worker unit test
      
      * fix formatting
      
      * remove is_finished and is_timeout methods from WaitOutcome
      
      * fix wait_for_threads_with_timeout_returns_outcome test
      
      * ".git/.scripts/commands/fmt/fmt.sh"
      
      * add common worker cond_notify_on_done_should_update_wait_outcome_when_panic test
      
      ---------
      
      Co-authored-by: default avatarMarcin S <[email protected]>
      Co-authored-by: command-bot <>
      3f8c3454
  8. Jul 21, 2023
  9. Jul 20, 2023
  10. Jul 19, 2023
    • tugy's avatar
      add missing syscalls (#7521) · 86f3f640
      tugy authored
      86f3f640
    • Francisco Aguirre's avatar
      Change Fixed to WeightInfoBounds for Polkadot (#7077) · cc9f8129
      Francisco Aguirre authored
      
      
      * Add polkadot XCM benchmarks
      
      * Add temp
      
      * ".git/.scripts/commands/bench/bench.sh" xcm polkadot pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm polkadot pallet_xcm_benchmarks::generic
      
      * Add weights to XCM on Polkadot
      
      * Make CI fail on old files
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update template
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Add reserve_asset_deposited benchmark
      
      * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::generic
      
      * Update weights
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Change initiate_reserve_deposit in runtime weights
      
      * Update weights
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Remove trusted reserves from runtimes
      
      * Fix pallet-xcm-benchmarks mock
      
      * Fix test
      
      * Change pallet xcm weigher in kusama
      
      * Fix
      
      * Remove merge conflict artifact
      
      * Remove initiate_reserve_withdraw from generic benchmarks
      
      * Add missing implementation to XCM benchmark
      
      * Fix failing karura test
      
      * Remove dbg!
      
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      
      * Fix fmt
      
      * Revert "Fix fmt"
      
      This reverts commit 676f2d8db07d7427750c79f95494d4988d06fda5.
      
      * Fix fmt
      
      * Remove duplicated template code
      
      * Add back part of the template
      
      * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible
      
      * Don't skip reserve asset deposited benchmark
      
      * Remove call to non-generated benchmark yet
      
      * Underscore unused parameter
      
      * Skip not supported benchmarks and hardcode value
      
      * Remove ReserveAssetDeposited benchmark
      
      * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible
      
      * Add back ReserveAssetDeposited
      
      * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible
      
      * Use default benchmark for ReserveAssetDeposited
      
      * Add missing parameter
      
      * Revert reserve asset deposited benchmark
      
      * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm kusama pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm westend pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm rococo pallet_xcm_benchmarks::fungible
      
      * Add 'real' benchmarks
      
      * Add TrustedReserve to actual XcmConfig
      
      * Add TrustedReserve to actual XcmConfig (fix)
      
      * Whitelist from benchmarking XCM storage keys read each block (#6871)
      
      * Whitelist from benchmarking XCM storage keys read each block
      
      * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm
      
      * Remove XcmPallet SupportedVersion from the benchmark whitelist
      
      * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime kusama pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm
      
      * WIP
      
      * Add necessary traits, remove unnecessary whitelisted keys
      
      * Fix tests
      
      * Remove unused file
      
      * Remove unused import
      
      ---------
      
      Co-authored-by: command-bot <>
      
      * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm rococo pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm westend pallet_xcm_benchmarks::fungible
      
      * Fix spellchecker issues
      
      * Remove unused migration code
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      cc9f8129
    • Chris Sosnin's avatar
      paras: count upgrade delay from inclusion (#7486) · c63b557e
      Chris Sosnin authored
      * paras: count upgrade delay from inclusion
      
      * fix warning
      
      * rename check cause block number field
      
      * rename inclusion_parent -> included_at
      c63b557e
    • Oliver Tale-Yazdi's avatar
      Remove Executed Migrations (#7495) · 3bbb336e
      Oliver Tale-Yazdi authored
      
      
      * Polkadot is at .42
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Kusama is on .43
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Westend is at .43
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Rococo is at .42
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Make UMP limits migration more idempotentish
      
      Already 100% idempotent per design, but not it wont try to schedule
      an unneeded upgrade. Note that the case that the new upgrade is
      already scheduled is not checked. In that case it will still upgrade
      the same thing again, but should be no problem.
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Clippy
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Delete old migration code
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * fmt
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Remove old tests
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Polkadot is at .43
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Remove a ton of shit
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Remove more
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Remove unused code
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Rococo is NOT yet at .43, but remove anyway
      
      Rococo is the only runtime that is not yet at .43, but keeping
      the migration code just for it is not worth it since devops
      can just apply it at any time.
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Remove old test
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      Co-authored-by: parity-processbot <>
      3bbb336e
    • Tsvetomir Dimitrov's avatar
      a1eadbff
  11. Jul 18, 2023
  12. Jul 17, 2023
  13. Jul 14, 2023
    • juangirini's avatar
      Replace Index for Nonce (#7374) · b95cc76d
      juangirini authored
      * replace Index for Nonce
      
      * remove extra Nonce
      
      * update lockfile for {"substrate"}
      
      ---------
      
      Co-authored-by: parity-processbot <>
      b95cc76d
  14. Jul 13, 2023
    • gupnik's avatar
      Moves `Block` to `frame_system` instead of `construct_runtime` and removes... · 28024144
      gupnik authored
      
      Moves `Block` to `frame_system` instead of `construct_runtime` and removes `Header` and `BlockNumber` (#7431)
      
      * Companion for substrate
      
      * Minor update
      
      * Formatting
      
      * Fixes for cumulus
      
      * Fixes tests in polkadot-runtime-parachains
      
      * Minor update
      
      * Removes unused import
      
      * Fixes tests in polkadot-runtime-common
      
      * Minor fix
      
      * Update roadmap/implementers-guide/src/runtime/configuration.md
      
      Co-authored-by: default avatarordian <[email protected]>
      
      * ".git/.scripts/commands/fmt/fmt.sh"
      
      * update lockfile for {"substrate"}
      
      ---------
      
      Co-authored-by: default avatarordian <[email protected]>
      Co-authored-by: command-bot <>
      28024144
    • Liam Aharon's avatar
      fix migrations (also companion for #14421) (#7454) · bfaec080
      Liam Aharon authored
      * fix migrations
      
      * use society versioned runtime upgrade
      
      * simplify usage of versionedruntimeupgrade
      
      * use society experimental feature
      
      * improve usage of experimental flag
      
      * doc comment
      
      * Merge branch 'master' of github.com:paritytech/polkadot into liam-fix-migrations
      
      * Revert "Merge branch 'master' of github.com:paritytech/polkadot into liam-fix-migrations"
      
      This reverts commit 41ab0621811ead11b0a7f91338b0895208feef77.
      
      * doc comment
      
      * westend experimental feature
      
      * Revert "westend experimental feature"
      
      This reverts commit 42f4f1b76655ef509a92c324d18d635a1b913dcb.
      
      * feature gate experimental xcm migration
      
      * update lockfile for {"substrate"}
      
      ---------
      
      Co-authored-by: parity-processbot <>
      bfaec080
  15. Jul 12, 2023
  16. Jul 11, 2023
    • Bastian Köcher's avatar
      Companion for removal of execution strategies (#7443) · 0ff60f7d
      Bastian Köcher authored
      * Companion for removal of execution strategies
      
      https://github.com/paritytech/substrate/pull/14387
      
      * Fix some tests
      
      * 🤦
      
      * Adapt to latest changes
      
      * Start supporting the offchain transaction pool
      
      * Fix tests
      
      * FMT
      
      * Remove patches
      
      * Update Substrate
      
      * update lockfile for {"substrate"}
      
      * Fix parachain upgrade smoke test
      
      * Fix test
      
      * Rewrite all tests to use `MockSubstemClient`
      
      ---------
      
      Co-authored-by: parity-processbot <>
      0ff60f7d
    • Chris Sosnin's avatar
      configuration: drop `pvf_checking_enabled` parameter (#7396) · a032a128
      Chris Sosnin authored
      * configuration: drop pvf_checking_enabled
      
      * fix warning
      a032a128
  17. Jul 10, 2023