- Jul 04, 2023
-
-
Bastian Köcher authored
* Implement runtime apis for fake runtime These runtime api implementations are only used to make the compiler think that we have implemented all required runtime apis. They will not be called as we switch the executor to `WasmExecutor`. In the near future we will not require these fake implementations anymore after Substrate has shifted away from this compile time requirement. This brings us the advantage that the `polkadot-service` doesn't need to depend on the runtimes for getting the `RuntimeApi` type. It also removes around 1min of build time on my machine ;) * Fix warning * FMT * ".git/.scripts/commands/fmt/fmt.sh" * Use more descriptive id * Fix warnings * Adapt path * Fix
🙈 --------- Co-authored-by: command-bot <>
-
- Jun 29, 2023
-
-
Bastian Köcher authored
* Companion for Substrate#14474 This removes the requirement to pass the native dispatch. * Adapt * Better * Remove patch * ... * Fix * Update Substrate
-
- Jun 23, 2023
-
-
Andrei Eres authored
* Warn if participated in the losing side of a dispute * Update naming * Additionally filter by candidate hash * Debug zombienet tests * Update 0002-parachains-disputes.zndsl * Debug zombienet * Update node/core/dispute-coordinator/src/initialized.rs Co-authored-by:
Andrei Sandu <[email protected]> * Add checking to zombienet tests --------- Co-authored-by:
-
- Jun 22, 2023
-
-
Oliver Tale-Yazdi authored* Disable flaky test Signed-off-by:
Oliver Tale-Yazdi <[email protected]> * Fix import Signed-off-by:
-
- Jun 21, 2023
-
-
Milos Kriz authored
-
Andrei Sandu authored
* Measure re-encoding time Signed-off-by:
Andrei Sandu <[email protected]> * fix build Signed-off-by:
-
Koute authored
-
- Jun 16, 2023
-
-
juangirini authored* update genesis config * fix wrong RuntimeGenesisConfig name * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <> -
Mira Ressel authored
* docs: update references to NetworkConfiguration::extra_sets Since paritytech/substrate#14080, this struct field no longer exists, now the `add_notification_protocol()` function of `sc_network::config::FullNetworkConfiguration` is used. Also neuter the doc links for now; rustdoc can't resolve them (presumably because sc_network::config isn't in scope, though weirdly enough even spelling the link out as ``[`FullNetworkConfiguration`](struct@sc_network::config::FullNetworkConfiguration)`` doesn't work?). Normally this wouldn't be an issue and rustdoc would just not generate links, but rust 1.70 has a bug that completely crashes rustdoc in this case.
-
Aaro Altonen authored
There is a race condition in `NetworkBridgeRx` between registering incoming peers and handling overseer signals. While the peer connection was sent to `NetworkBridgeRx` first, sometimes the peer would be added to `validation/collation_peers` with enough delay that the bridge handled an overseer signal that was meant do send notifications to the registered peer and as the peer was not present in the bridge, the notification was never sent and the test would hang. When peers are registered to `NetworkBridgeRx` using `connect_peer()`, wait until they show up in `shared.validation/collation_peers` before doing anything else. Co-authored-by: parity-processbot <>
-
- Jun 15, 2023
-
-
Andrei Eres authored
* Add futures-timer * Make cost_or_benefit public * Update ReportPeer message format * Add delay to reputation updates (dirtywork) * Update ReputationAggregator * Update tests * Fix flucky tests * Move reputation to state * Use the main loop for handling reputation sendings * Update * Move reputation to utils * Update reputation sending * Fix arguments order * Update state * Remove new from state * Add constant * Add failing test for delay * Change mocking approach * Fix type errors * Fix comments * Add message handling to select * Fix bitfields-distribution tests * Add docs to reputation aggregator * Replace .into_base_rep * Use one REPUTATION_CHANGE_INTERVAL by default * Add reputation change to statement-distribution * Update polkadot-availability-bitfield-distribution * Update futures selecting in subsystems * Update reputation adding * Send malicious changes right away without adding to state * Add reputation to StatementDistributionSubsystem * Handle reputation in statement distribution * Add delay test for polkadot-statement-distribution * Fix collator-protocol tests before applying reputation delay * Remove into_base_rep * Add reputation to State * Fix failed tests * Add reputation delay * Update tests * Add batched network message for peer reporting * Update approval-distribution tests * Update bitfield-distribution tests * Update statement-distribution tests * Update collator-protocol tests * Remove levels in matching * Address clippy errors * Fix overseer test * Add a metric for original count of rep changes * Update Reputation * Revert "Add a metric for original count of rep changes" This reverts commit 6c9b0c1ec34491d16e562bdcba8db6b9dcf484db. * Update node/subsystem-util/src/reputation.rs Co-authored-by:
Vsevolod Stakhov <[email protected]> * Remove redundant vec --------- Co-authored-by:
-
- Jun 14, 2023
-
-
Andrei Sandu authored
Signed-off-by: -
eskimor authored
* Remove redundant enter call. * Remove optionality in dispute signature checking * Make enter_inner and create_inherent the same. * Remove redundant metric. * Unification: enter and create_inherent. * Remove `enter_inner` function. * Remove dead code. * Remove redundant import. * Remove dead code in disputes. * ".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent * ".git/.scripts/commands/bench/bench.sh" runtime kusama runtime_parachains::paras_inherent * ".git/.scripts/commands/bench/bench.sh" runtime westend runtime_parachains::paras_inherent * Merge fix. * Fix tests. * Remove obsolete comment. * ".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent * ".git/.scripts/commands/bench/bench.sh" runtime westend runtime_parachains::paras_inherent * ".git/.scripts/commands/bench/bench.sh" runtime kusama runtime_parachains::paras_inherent * Review remarks, fixes. * Guide updates. * Fmt. * ".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent --------- Co-authored-by:eskimor <[email protected]> Co-authored-by: command-bot <>
-
- Jun 12, 2023
-
-
eskimor authored
* Move vstaging to production (and thus past session slashing). WIP: test-runtime still needs to be fixed. * Fix test-runtime. --------- Co-authored-by:
-
- Jun 11, 2023
-
-
Squirrel authored
-
- Jun 08, 2023
-
-
Alexandru Gheorghe authored
* av-store: Move prune on a separate thread There are situations where pruning of the data could take more than a few seconds and that might make the whole subsystem unreponsive. To avoid this just move the prune process on a separate thread. See: https://github.com/paritytech/polkadot/issues/7237, for more details. Signed-off-by:
Alexandru Gheorghe <[email protected]> * av-store: Add log that prunning started Signed-off-by:
-
Alexandru Gheorghe authored
* metrics: Increase the resolution of histogram metrics These metrics are using the default histogram buckets: ``` pub const DEFAULT_BUCKETS: &[f64; 11] = &[ 0.005, 0.01, 0.025, 0.05, 0.1, 0.25, 0.5, 1.0, 2.5, 5.0, 10.0, ]; ``` Which give us a resolution of 5ms, that's good, but there are some subsystems where we process hundreds or even a few thousands of messages per second like approval-voting or approval-distribution, so it makes sense to increse the resoution of the bucket to better understand if the procesisng is in the range of useconds. The new bucket ranges will be: ``` [0.0001, 0.0004, 0.0016, 0.0064, 0.0256, 0.1024, 0.4096, 1.6384, 6.5536] ``` Signed-off-by:
-
- Jun 06, 2023
-
-
Alexandru Gheorghe authored
* approval-distribution: Add approvals/assignments spans on all paths The approval and assignment logic gets called from multiple paths, so make sure we create a tracing span on all paths to make debugging easier and be able and correlate with the spans from approval-voting. Signed-off-by:
-
- Jun 05, 2023
-
-
ordian authored
* runtime/vstaging: unapplied_slashes runtime API * runtime/vstaging: key_ownership_proof runtime API * runtime/ParachainHost: submit_report_dispute_lost * fix key_ownership_proof API * runtime: submit_report_dispute_lost runtime API * nits * Update node/subsystem-types/src/messages.rs Co-authored-by:
Marcin S. <[email protected]> * revert unrelated fmt changes * dispute-coordinator: past session dispute slashing * encapsule runtime api call for submitting report * prettify: extract into a function * do not exit on runtime api error * fix tests * try initial zombienet test * try something * fix a typo * try cumulus-based collator * fix clippy * build polkadot-debug images with fast-runtime enabled * wip * runtime/inclusion: fix availability_threshold * fix wip * fix wip II * revert native provider * propagate tx submission error * DEBUG: sync=trace * print key ownership proof len * panic repro * log validator index in panic message * post merge fixes * replace debug assertion with a log * fix compilation * Let's log the dispatch info in validate block. * fix double encoding * Revert "Let's log the dispatch info in validate block." This reverts commit a70fbc51b464d7f4355dbada5e16cd83cf71eab4. * Revert "Let's log the dispatch info in validate block." This reverts commit a70fbc51b464d7f4355dbada5e16cd83cf71eab4. * fix compilation * update to latest zombienet and fix test * lower finality lag to 11 * bump zombienet again * add a workaround, but still does not work * Update .gitlab-ci.yml bump zombienet. * add a comment and search logs on all nodes --------- Co-authored-by:
Bastian Köcher <[email protected]> Co-authored-by:
Javier Viola <[email protected]>
-
- Jun 02, 2023
-
-
Marcin S. authored
* PVF: Instantiate wasm in pre-checking * Move `runtime_construction_check` to prepare thread, use bytes * [minor] Update comment * Fix compile error * Update Cargo.lock * Update docs * Add some missing docs!
-
- May 31, 2023
-
-
Sam Johnson authored
* bump serde to 1.0.163 * bump ci * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <>
-
- May 30, 2023
-
-
Tsvetomir Dimitrov authored
* Replace `RollingSessionWindow` with `RuntimeInfo` - initial commit * Fix tests in import * Fix the rest of the tests * Remove dead code * Fix todos * Simplify session caching * Comments for `SessionInfoProvider` * Separate `SessionInfoProvider` from `State` * `cache_session_info_for_head` becomes freestanding function * Remove unneeded `mut` usage * fn session_info -> fn get_session_info() to avoid name clashes. The function also tries to initialize `SessionInfoProvider` * Fix SessionInfo retrieval * Code cleanup * Don't wrap `SessionInfoProvider` in an `Option` * Remove `earliest_session()` * Remove pre-caching -> wip * Fix some tests and code cleanup * Fix all tests * Fixes in tests * Fix comments, variable names and small style changes * Fix a warning * impl From<SessionWindowSize> for NonZeroUsize * Fix logging for `get_session_info` - remove redundant logs and decrease log level to DEBUG * Code review feedback * Storage migration removing `COL_SESSION_WINDOW_DATA` from parachains db * Remove `col_session_data` usages * Storage migration clearing columns w/o removing them * Remove session data column usages from `approval-voting` and `dispute-coordinator` tests * Add some test cases from `RollingSessionWindow` to `dispute-coordinator` tests * Fix formatting in initialized.rs * Fix a corner case in `SessionInfo` caching for `dispute-coordinator` * Remove `RollingSessionWindow` ;( * Revert "Fix formatting in initialized.rs" This reverts commit 0f94664ec9f3a7e3737a30291195990e1e7065fc. * v2 to v3 migration drops `COL_DISPUTE_COORDINATOR_DATA` instead of clearing it * Fix `NUM_COLUMNS` in `approval-voting` * Use `columns::v3::NUM_COLUMNS` when opening db * Update node/service/src/parachains_db/upgrade.rs Co-authored-by:
-
- May 29, 2023
-
-
Sam Johnson authored
-
- May 26, 2023
-
-
Marcin S. authored
* Document usage of gum crate * Small fix * Add some more basic info * Update node/gum/src/lib.rs Co-authored-by:
-
ordian authored
* runtime/vstaging: unapplied_slashes runtime API * runtime/vstaging: key_ownership_proof runtime API * runtime/ParachainHost: submit_report_dispute_lost * fix key_ownership_proof API * runtime: submit_report_dispute_lost runtime API * nits * Update node/subsystem-types/src/messages.rs Co-authored-by:
-
Adrian Catangiu authored
We consider BEEFY mature enough to run by default on all nodes for test networks (Rococo/Wococo/Versi). Right now, most nodes are not running it since it's opt-in using --beefy flag. Switch to an opt-out model for test networks. Replace --beefy flag from CLI with --no-beefy and have BEEFY client start by default on test networks. Signed-off-by:acatangiu <[email protected]>
-
- May 25, 2023
-
-
Marcin S. authored
* PVF: Refactor workers into separate crates, remove host dependency * Fix compile error * Remove some leftover code * Fix compile errors * Update Cargo.lock * Remove worker main.rs files I accidentally copied these from the other PR. This PR isn't intended to introduce standalone workers yet. * Address review comments * cargo fmt * Update a couple of comments * Update log targets
-
- May 24, 2023
-
-
Bastian Köcher authored
* Companion: Substrate#13869 https://github.com/paritytech/substrate/pull/13869 * update lockfile for {"substrate"} * ".git/.scripts/commands/fmt/fmt.sh" --------- Co-authored-by: parity-processbot <> -
Vsevolod Stakhov authored
* Fix flaky test and error reporting * Address review comments and adjust recv timeouts
-
Marcin S. authored
* impl guide: Update Collator Generation * Address review comments * Fix compile errors I don't remember why I did this. Maybe it only made sense with the async backing changes. * Remove leftover glossary
-
Alexandru Gheorghe authored
* metrics: tests: Fix flaky runtime_can_publish_metrics When an re-org happens wait_for_blocks(2) would actually exit after the second import of blocks 1, so the conditions for the metric to exist won't be met hence the occasional test failure. More details in: https://github.com/paritytech/polkadot/issues/7267 Signed-off-by:
-
Dmitry Markin authored
* Replace request-response incoming requests queue with `async-channel` * Fix unused imports * Fix channel type in tests * Fix channel type in tests (part 2) * Fix unused imports * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <>
-
- May 23, 2023
-
-
Marcin S. authored
* PVF: instantiate runtime from bytes * Update naming
-
- May 19, 2023
-
-
Gavin Wood authored
* Add ProcessXcmMessage struct * Migrate away from weights in host config * New well-known key to report UMPQ capacity * Add missing file * Fixes * Remove original UMP files * Docs * Update runtime/parachains/src/inclusion/mod.rs Co-authored-by:
asynchronous rob <[email protected]> * Add benchmarking * Benchmarks * Mock example of using the QueueChangeHandler to update the WKK * Use master Cargo.lock Signed-off-by:
🤦 Signed-off-by:Gavin Wood <[email protected]> * Update runtime/kusama/src/lib.rs Co-authored-by:
muharem <[email protected]> Signed-off-by:
Keith Yeung <[email protected]>
-
- May 17, 2023
-
-
Tsvetomir Dimitrov authored
* Make `issue_explicit_statement_with_index` regular function * Make `issue_backing_statement_with_index` regular function * Issue `RevertBlocks` as soon as a dispute has `byzantine threshold + 1` invalid votes. * Remove a comment * Fix `has_fresh_byzantine_threshold_against()` * Extend `informs_chain_selection_when_dispute_concluded_against` test
-
- May 16, 2023
-
-
Marcin S. authored
* PVF: Remove `rayon` and some uses of `tokio` 1. We were using `rayon` to spawn a superfluous thread to do execution, so it was removed. 2. We were using `rayon` to set a threadpool-specific thread stack size, and AFAIK we couldn't do that with `tokio` (it's possible [per-runtime](https://docs.rs/tokio/latest/tokio/runtime/struct.Builder.html#method.thread_stack_size) but not per-thread). Since we want to remove `tokio` from the workers [anyway](https://github.com/paritytech/polkadot/issues/7117), I changed it to spawn threads with the `std::thread` API instead of `tokio`.[^1] [^1]: NOTE: This PR does not totally remove the `tokio` dependency just yet. 3. Since `std::thread` API is not async, we could no longer `select!` on the threads as futures, so the `select!` was changed to a naive loop. 4. The order of thread selection was flipped to make (3) sound (see note in code). I left some TODO's related to panics which I'm going to address soon as part of https://github.com/paritytech/polkadot/issues/7045. * PVF: Vote invalid on panics in execution thread (after a retry) Also make sure we kill the worker process on panic errors and internal errors to potentially clear any error states independent of the candidate. * Address a couple of TODOs Addresses a couple of follow-up TODOs from https://github.com/paritytech/polkadot/pull/7153. * Add some documentation to implementer's guide * Fix compile error * Fix compile errors * Fix compile error * Update roadmap/implementers-guide/src/node/utility/candidate-validation.md Co-authored-by:
-
Marcin S. authored
-
- May 15, 2023
-
-
Tsvetomir Dimitrov authored
* Bump parity-db to 0.4.8 * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <> -
-
- May 12, 2023
-
-
Tsvetomir Dimitrov authored
* Replace `RollingSessionWindow` with `RuntimeInfo` - initial commit * Fix tests in import * Fix the rest of the tests * Remove dead code * Fix todos * Simplify session caching * Comments for `SessionInfoProvider` * Separate `SessionInfoProvider` from `State` * `cache_session_info_for_head` becomes freestanding function * Remove unneeded `mut` usage * fn session_info -> fn get_session_info() to avoid name clashes. The function also tries to initialize `SessionInfoProvider` * Fix SessionInfo retrieval * Code cleanup * Don't wrap `SessionInfoProvider` in an `Option` * Remove `earliest_session()` * Remove pre-caching -> wip * Fix some tests and code cleanup * Fix all tests * Fixes in tests * Fix comments, variable names and small style changes * Fix a warning * impl From<SessionWindowSize> for NonZeroUsize * Fix logging for `get_session_info` - remove redundant logs and decrease log level to DEBUG * Code review feedback
-
