Skip to content
  1. Apr 03, 2023
  2. Mar 31, 2023
    • PG Herveou's avatar
      [Contracts] Overflowing bounded `DeletionQueue` allows DoS against contract termination (#13702) · 1bd5d2f7
      PG Herveou authored
      
      
      * [Contracts review] Overflowing bounded `DeletionQueue` allows DoS against contract termination
      
      * wip
      
      * wip
      
      * wip
      
      * wip
      
      * wip
      
      * fix doc
      
      * wip
      
      * PR review
      
      * unbreak tests
      
      * fixes
      
      * update budget computation
      
      * PR comment: use BlockWeights::get().max_block
      
      * PR comment: Update queue_trie_for_deletion signature
      
      * PR comment: update deletion budget docstring
      
      * PR comment: impl Default with derive(DefaultNoBound)
      
      * PR comment: Remove DeletedContract
      
      * PR comment Add ring_buffer test
      
      * remove missed comment
      
      * misc comments
      
      * contracts: add sr25519_recover
      
      * Revert "contracts: add sr25519_recover"
      
      This reverts commit d4600e00934b90e5882cf5288f36f98911b51722.
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts
      
      * PR comments update print_schedule
      
      * Update frame/contracts/src/benchmarking/mod.rs
      
      * Update frame/contracts/src/storage.rs
      
      * Update frame/contracts/src/storage.rs
      
      * rm temporary fixes
      
      * fix extra ;
      
      * Update frame/contracts/src/storage.rs
      
      Co-authored-by: default avatarjuangirini <[email protected]>
      
      * Update frame/contracts/src/storage.rs
      
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      
      * Update frame/contracts/src/lib.rs
      
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      
      * Update frame/contracts/src/lib.rs
      
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      
      * Support stable rust for compiling the runtime (#13580)
      
      * Support stable rust for compiling the runtime
      
      This pull request brings support for compiling the runtime with stable Rust. This requires at least
      rust 1.68.0 to work on stable. The code is written in a way that it is backwards compatible and
      should automatically work when someone compiles with 1.68.0+ stable.
      
      * We always support nightlies!
      
      * 🤦
      
      
      
      * Sort by version
      
      * Review feedback
      
      * Review feedback
      
      * Fix version parsing
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKoute <[email protected]>
      
      ---------
      
      Co-authored-by: default avatarKoute <[email protected]>
      
      * github PR commit fixes
      
      * Revert "Support stable rust for compiling the runtime (#13580)"
      
      This reverts commit 0b985aa5ad114a42003519b712d25a6acc40b0ad.
      
      * Restore DeletionQueueMap
      
      * fix namings
      
      * PR comment
      
      * move comments
      
      * Update frame/contracts/src/storage.rs
      
      * Update frame/contracts/src/storage.rs
      
      * fixes
      
      ---------
      
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarjuangirini <[email protected]>
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: default avatarKoute <[email protected]>
      1bd5d2f7
  3. Mar 29, 2023
  4. Mar 20, 2023
    • Alexander Theißen's avatar
      contracts: Upgrade to wasmi 0.28 (#13312) · 82cb6992
      Alexander Theißen authored
      * Upgrade to wasmi 0.28
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts
      
      * Update stale comment
      
      * Renamed variants of `Determinism`
      
      * Compile fix
      
      ---------
      
      Co-authored-by: command-bot <>
      82cb6992
  5. Mar 18, 2023
    • Gavin Wood's avatar
      Deprecate `Currency`; introduce holds and freezing into `fungible` traits (#12951) · 5d81f23f
      Gavin Wood authored
      
      
      * First reworking of fungibles API
      
      * New API and docs
      
      * More fungible::* API improvements
      
      * New ref-counting logic for old API
      
      * Missing files
      
      * Fixes
      
      * Use the new transfer logic
      
      * Use fungibles for the dispatchables
      
      * Use shelve/restore names
      
      * Locking works with total balance.
      
      * repotting and removal
      
      * Separate Holds from Reserves
      
      * Introduce freezes
      
      * Missing files
      
      * Tests for freezing
      
      * Fix hold+freeze combo
      
      * More tests
      
      * Fee-free dispatchable for upgrading accounts
      
      * Benchmarks and a few fixes
      
      * Another test
      
      * Docs and refactor to avoid blanket impls
      
      * Repot
      
      * Fit out ItemOf fully
      
      * Add events to Balanced traits
      
      * Introduced events into Hold traits
      
      * Fix Assets pallet tests
      
      * Assets benchmarks pass
      
      * Missing files and fixes
      
      * Fixes
      
      * Fixes
      
      * Benchmarks fixes
      
      * Fix balance benchmarks
      
      * Formatting
      
      * Expose fungible sub modules
      
      * Move NIS to fungible API
      
      * Fix broken impl and add test
      
      * Fix tests
      
      * API for `transfer_and_hold`
      
      * Use composite APIs
      
      * Formatting
      
      * Upgraded event
      
      * Fixes
      
      * Fixes
      
      * Fixes
      
      * Fixes
      
      * Repot tests and some fixed
      
      * Fix some bits
      
      * Fix dust tests
      
      * Rename `set_balance`
      
      - `Balances::set_balance` becomes `Balances::force_set_balance`
      - `Unbalanced::set_balance` becomes `Unbalances::write_balance`
      
      * becomes
      
      * Move dust handling to fungibles API
      
      * Formatting
      
      * Fixes and more refactoring
      
      * Fixes
      
      * Fixes
      
      * Fixes
      
      * Fixes
      
      * Fixes
      
      * Fixes
      
      * Fixes
      
      * Fixes
      
      * Fixes
      
      * Use reducible_balance for better correctness on fees
      
      * Reducing hold to zero should remove entry.
      
      * Add test
      
      * Docs
      
      * Update frame/support/src/traits/tokens/fungibles/hold.rs
      
      Co-authored-by: default avatarMuharem Ismailov <[email protected]>
      
      * Update frame/support/src/traits/tokens/fungibles/regular.rs
      
      Co-authored-by: default avatarMuharem Ismailov <[email protected]>
      
      * Update frame/support/src/traits/tokens/fungible/hold.rs
      
      Co-authored-by: default avatarMuharem Ismailov <[email protected]>
      
      * Update frame/support/src/traits/tokens/fungible/regular.rs
      
      Co-authored-by: default avatarMuharem Ismailov <[email protected]>
      
      * Docs
      
      * Docs
      
      * Docs
      
      * Fix NIS benchmarks
      
      * Doc comment
      
      * Remove post_mutation
      
      * Fix some tests
      
      * Fix some grumbles
      
      * Enumify bool args to fungible(s) functions
      
      * Fix up assets and balances
      
      * Formatting
      
      * Fix contracts
      
      * Fix tests & benchmarks build
      
      * Typify minted boolean arg
      
      * Typify on_hold boolean arg; renames
      
      * Fix numerous tests
      
      * Fix dependency issue
      
      * Privatize dangerous API mutate_account
      
      * Fix contracts (@alext - please check this commit)
      
      * Remove println
      
      * Fix tests for contracts
      
      * Fix broken rename
      
      * Fix broken rename
      
      * Fix broken rename
      
      * Docs
      
      * Update frame/support/src/traits/tokens/fungible/hold.rs
      
      Co-authored-by: default avatarAnthony Alaribe <[email protected]>
      
      * remove from_ref_time
      
      * Update frame/executive/src/lib.rs
      
      Co-authored-by: default avatarAnthony Alaribe <[email protected]>
      
      * Update frame/executive/src/lib.rs
      
      Co-authored-by: default avatarAnthony Alaribe <[email protected]>
      
      * Reenable test
      
      * Update frame/support/src/traits/tokens/fungibles/hold.rs
      
      Co-authored-by: default avatarAnthony Alaribe <[email protected]>
      
      * Update frame/support/src/traits/tokens/fungible/hold.rs
      
      Co-authored-by: default avatarAnthony Alaribe <[email protected]>
      
      * Update frame/support/src/traits/tokens/fungible/hold.rs
      
      Co-authored-by: default avatarAnthony Alaribe <[email protected]>
      
      * Update frame/support/src/traits/tokens/fungible/hold.rs
      
      Co-authored-by: default avatarAnthony Alaribe <[email protected]>
      
      * Update frame/support/src/traits/tokens/currency.rs
      
      Co-authored-by: default avatarAnthony Alaribe <[email protected]>
      
      * Update frame/lottery/src/tests.rs
      
      Co-authored-by: default avatarAnthony Alaribe <[email protected]>
      
      * Update frame/support/src/traits/tokens/fungible/mod.rs
      
      Co-authored-by: default avatarAnthony Alaribe <[email protected]>
      
      * Update frame/support/src/traits/tokens/fungible/regular.rs
      
      Co-authored-by: default avatarAnthony Alaribe <[email protected]>
      
      * Update frame/support/src/traits/tokens/fungibles/freeze.rs
      
      Co-authored-by: default avatarAnthony Alaribe <[email protected]>
      
      * Update frame/support/src/traits/tokens/fungible/regular.rs
      
      Co-authored-by: default avatarAnthony Alaribe <[email protected]>
      
      * Update frame/support/src/traits/tokens/fungibles/hold.rs
      
      Co-authored-by: default avatarAnthony Alaribe <[email protected]>
      
      * Update frame/support/src/traits/tokens/fungibles/hold.rs
      
      Co-authored-by: default avatarAnthony Alaribe <[email protected]>
      
      * Update frame/support/src/traits/tokens/fungibles/hold.rs
      
      Co-authored-by: default avatarAnthony Alaribe <[email protected]>
      
      * Rename UnwantedRemoval to UnwantedAccountRemoval
      
      * Docs
      
      * Formatting
      
      * Update frame/balances/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update primitives/runtime/src/lib.rs
      
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      
      * handle_raw_dust oes nothing
      
      * Formatting
      
      * Fixes
      
      * Grumble
      
      * Fixes
      
      * Add test
      
      * Add test
      
      * Tests for reducible_balance
      
      * Fixes
      
      * Fix Salary
      
      * Fixes
      
      * Disable broken test
      
      * Disable nicely
      
      * Fixes
      
      * Fixes
      
      * Fixes
      
      * Rename some events
      
      * Fix nomination pools breakage
      
      * Add compatibility stub for transfer tx
      
      * Reinstate a safely compatible version of Balances set_balance
      
      * Fixes
      
      * Grumble
      
      * Update frame/nis/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_balances
      
      * disable flakey tests
      
      * Update frame/balances/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Grumbles
      
      * Grumble
      
      ---------
      
      Co-authored-by: default avatarMuharem Ismailov <[email protected]>
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      Co-authored-by: default avatarAnthony Alaribe <[email protected]>
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: command-bot <>
      5d81f23f
  6. Mar 15, 2023
  7. Mar 14, 2023
  8. Mar 11, 2023
    • Gavin Wood's avatar
      Logic for the (Core) Fellowship (#13503) · 4ad1ad2c
      Gavin Wood authored
      
      
      * More drafting
      
      * Paymaster pallet
      
      * Fix build
      
      * More tests
      
      * Rename
      
      * Rename
      
      * Renaming
      
      * Revert old changes
      
      * Multi-phase payouts to avoid bank-runs
      
      * Tests
      
      * Tests
      
      * Allow payment to be targeted elsewhere
      
      * Proper ssync payment failure handling
      
      * Test for repayment
      
      * Docs
      
      * Impl RankedMembers for RankedCollective
      
      * Implement Pay for Pot (i.e. basic account).
      
      * Benchmarks
      
      * Weights
      
      * Introduce Salary benchmark into node
      
      * Fix warning
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_salary
      
      * Update primitives/arithmetic/src/traits.rs
      
      Co-authored-by: default avatarJegor Sidorenko <[email protected]>
      
      * Update frame/salary/src/lib.rs
      
      Co-authored-by: default avatarJegor Sidorenko <[email protected]>
      
      * Update lib.rs
      
      * Update frame/salary/src/lib.rs
      
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      
      * Docs
      
      * Update frame/salary/src/lib.rs
      
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      
      * Update frame/salary/src/lib.rs
      
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      
      * Fix
      
      * Fixes
      
      * Fixes
      
      * Move some salary traits stuff to a shared location
      
      * Initial draft
      
      * Comment out bits
      
      * Fix
      
      * First couple of tests
      
      * One more test
      
      * Update frame/salary/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update frame/salary/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Mul floor
      
      * Tests
      
      * Mul floor
      
      * Fix warnings
      
      * Fix test
      
      * Tests
      
      * Last tests
      
      * Docs
      
      * Fix warnings
      
      * Benchmarks
      
      * Weights
      
      * Integrate benchmark
      
      * Fixes
      
      * Fix
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_core_fellowship
      
      * Better process flow
      
      * Fix benchmarks & tests
      
      * Docs
      
      * Fixes
      
      * Fixes
      
      * docs
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_core_fellowship
      
      * Docs and allow custom evidence size
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_core_fellowship
      
      * Update frame/core-fellowship/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/core-fellowship/src/tests.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/core-fellowship/src/benchmarking.rs
      
      * Update frame/core-fellowship/src/benchmarking.rs
      
      * Apply suggestions from code review
      
      * Rename
      
      * Update primitives/arithmetic/src/traits.rs
      
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      
      * Reduce magic numbers
      
      * Update frame/core-fellowship/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update frame/core-fellowship/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Benchmark result
      
      * Remove dependency
      
      * set_params should pay
      
      * induct should pay
      
      * Remove some other free calls
      
      ---------
      
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarJegor Sidorenko <[email protected]>
      Co-authored-by: default avatarjoe petrowski <[email protected]>
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      Co-authored-by: default avatarKian Paimani <[email protected]>
      4ad1ad2c
  9. Mar 07, 2023
    • Davide Galassi's avatar
      Offences report system rework (#13425) · 9dd10d13
      Davide Galassi authored
      * Experiments with common equivocation trait
      
      * Improved equivocation trait
      
      * Fix grandpa equivocation implementation
      
      * Remove some cruft
      
      * Remove some more cruft
      
      * More generic naming
      
      * Simplification of offences manipilation
      
      * More refactory
      
      * Some prograss with the encapsulation of offence report system
      
      * Finally unit type works as a universal null report system
      
      * Align substrate node code
      
      * Further simplification
      
      * Fix test utils
      
      * Remove not required associated type
      
      * Fix benches
      
      * Rollback to prev field name
      
      * Box big params
      
      * Fix typo
      
      * Remove new tag computation
      
      * Remove default implementations
      
      * Better docs
      
      * Return 'Result' instead of bool
      
      * Change offence report system return types
      
      * Some renaming and documentation
      
      * Improve documentation
      
      * More abstract offence report system
      
      * Rename 'consume_evidence' to 'process_evidence'
      
      * Further docs refinements
      
      * Doc for dummy offence report
      
      * Fix rustdoc
      
      * Fix after master merge
      
      * Apply code review suggestions
      
      * Improve docs
      9dd10d13
    • afm's avatar
      Pub enum runtime to pub struct runtime (#13250) · d86a3263
      afm authored
      
      
      * pub enum Runtime -> pub struct Runtime
      
      * changing some more
      
      * fmt
      
      * updating *.stderr files
      
      * re-run trybuild after rust update
      
      * keep a test file for `pub enum Runtime`
      
      * Delete construct_runtime_2.rs
      
      * ".git/.scripts/commands/fmt/fmt.sh"
      
      ---------
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: parity-processbot <>
      d86a3263
  10. Mar 03, 2023
  11. Mar 02, 2023
  12. Feb 27, 2023
  13. Feb 25, 2023
  14. Feb 23, 2023
  15. Feb 21, 2023
  16. Feb 14, 2023
    • Jegor Sidorenko's avatar
      [NFTs] Offchain mint (#13158) · 3b767e12
      Jegor Sidorenko authored
      
      
      * Allow to mint with the pre-signed signatures
      
      * Another try
      
      * WIP: test encoder
      
      * Fix the deposits
      
      * Refactoring + tests + benchmarks
      
      * Add sp-core/runtime-benchmarks
      
      * Remove sp-core from dev deps
      
      * Enable full_crypto for benchmarks
      
      * Typo
      
      * Fix
      
      * Update frame/nfts/src/mock.rs
      
      Co-authored-by: default avatarSquirrel <[email protected]>
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nfts
      
      * Add docs
      
      * Add attributes into the pre-signed object & track the deposit owner for attributes
      
      * Update docs
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nfts
      
      * Add the number of attributes provided to weights
      
      * Apply suggestions
      
      * Remove dead code
      
      * Remove Copy
      
      * Fix docs
      
      * Update frame/nfts/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update frame/nfts/src/lib.rs
      
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      ---------
      
      Co-authored-by: default avatarSquirrel <[email protected]>
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      3b767e12
  17. Feb 12, 2023
  18. Feb 08, 2023
  19. Feb 06, 2023
  20. Jan 30, 2023
  21. Jan 29, 2023
  22. Jan 26, 2023
  23. Jan 25, 2023
    • Kian Paimani's avatar
      reduce exec time of fast-unstake benchmarks (#13120) · 451a13c6
      Kian Paimani authored
      * reduce exec time of fast-unstake benchmarks
      
      * fix test
      
      * fmt
      
      * fix patch the tests
      
      * fix patch the tests
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * add batch size as well
      
      * update some benches to be better
      
      * fix one last test
      
      * fix
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * reduce time even more
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * fix tests
      
      * nit
      
      * remove
      
      * improve the weight calc further
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * fix benchmarks
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * update
      
      * fix
      
      * fix
      
      * fmt
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * lots of changes again...
      
      * smaller input
      
      * update
      
      * fmt
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * cleanup
      
      * small simplification
      
      * fmt
      
      * reduce exec time a bit
      
      * fix
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * test
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * increase again
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      * review comments
      
      * fmt
      
      * fix
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_fast_unstake
      
      Co-authored-by: command-bot <>
      451a13c6
  24. Jan 19, 2023
  25. Jan 18, 2023
    • Sasha Gryaznov's avatar
      [contracts] Add integrity checks by pallet hook (#12993) · 549637d9
      Sasha Gryaznov authored
      
      
      * integrity test for MaxCodeLen and CallStack::len()
      
      * integrity test for MaxDebugBufferLen
      
      * addressed review comments
      
      * fix append_debug_buffer()
      
      * ci fix
      
      * updated code_len_limit formula after further discussion
      
      * enlarged mem safe margin after discussion
      
      * +doc to Config trait associated types
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      
      * more lil fixes from code review feedback
      
      * lowered max call depth to satisfy mem limits
      
      * fix node runtime pallet params to satisfy integrity check
      
      * fix max call depth value calc
      
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      549637d9
  26. Jan 17, 2023
  27. Jan 06, 2023
  28. Jan 04, 2023
  29. Jan 03, 2023
  30. Dec 26, 2022