* Do some cleanups

Found them while looking over the code.

* More

* Fix

This annoying!

* chainHead/events: Add storage params and events

Signed-off-by: Alexandru Vasile <[email protected]>

* chainHead/tests: Check storage events serialization / deserialization

Signed-off-by: Alexandru Vasile <[email protected]>

* chainHead/error: Add error for invalid WaitForContinue storage call

Signed-off-by: Alexandru Vasile <[email protected]>

* chainHead/storage: Use new items params

Signed-off-by: Alexandru Vasile <[email protected]>

* chainHead/tests: Adjust storage tests to the new API

Signed-off-by: Alexandru Vasile <[email protected]>

* chainHead/events: Generalize StorageQuery by provided key

Signed-off-by: Alexandru Vasile <[email protected]>

* chain_head: Add dedicated ChainHeadStorage client for queries

Signed-off-by: Alexandru Vasile <[email protected]>

* chainHead/storage: Implement queries for hashes of values

Signed-off-by: Alexandru Vasile <[email protected]>

* chainHead/tests: Check storage queries for hashes of values

Signed-off-by: Alexandru Vasile <[email protected]>

* chainHead: Improve API documentation wrt multiple entries

Signed-off-by: Alexandru Vasile <[email protected]>

* chainHead/event: Rename StorageQueue ty to queue_ty

Signed-off-by: Alexandru Vasile <[email protected]>

* chianHead: Add helper to encode chainHead results as hex str

Signed-off-by: Alexandru Vasile <[email protected]>

* Update client/rpc-spec-v2/src/chain_head/error.rs

Co-authored-by: Sebastian Kunert <[email protected]>

* chainHead: Change the `queryResult` to a plain `Result`

Signed-off-by: Alexandru Vasile <[email protected]>

* chainHead: Stop producing events after the first error

Signed-off-by: Alexandru Vasile <[email protected]>

* chainHead: Change child_key to child_trie API param

Signed-off-by: Alexandru Vasile <[email protected]>

---------

Signed-off-by: Alexandru Vasile <[email protected]>
Co-authored-by: Sebastian Kunert <[email protected]>

Co-authored-by: parity-processbot <>

* add doc-only substrate entry point crate

* document a few more things

* add more

* fix width

* Update primitives/io/src/lib.rs

Co-authored-by: Gonçalo Pestana <[email protected]>

* add link

* update cargo toml file

* fix sp-io docs

* improve

* small update

* add license

* satisfy license job

* add a line about FRAME

* CI happy now

* make CI more happy

* Let the check run for the whole workspace

* Forward the substrate node again as default run

* update binary names

* upate verison test

* Fix fix fix

* Fix

* rename to substrate-node in more places

* Revert "rename to substrate-node in more places"

This reverts commit 66960f84a1b6f1f7c638b4040e28e9fbabb8adf5.

* fix

* Fix build pipeline

* Fix properly plus add some docs

---------

Co-authored-by: Gonçalo Pestana <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>

* Add ability to reset trie-cache

* comment

* Update client/db/src/lib.rs

Co-authored-by: Bastian Köcher <[email protected]>

---------

Co-authored-by: Bastian Köcher <[email protected]>

* client: fix invalid name pattern regex

* Update client/cli/src/commands/run_cmd.rs

Co-authored-by: Oliver Tale-Yazdi <[email protected]>

* client: test node name is non-empty

* client: add more tests to is_node_name_valid

---------

Co-authored-by: Oliver Tale-Yazdi <[email protected]>

* Added ECIES encryption

* tweaks

* fmt

* Make clippy happy

* Use local keystore

* qed

* grandpa: avoid importing unnecessary justifications

* grandpa: make justification_import_period configurable

* grandpa: keep the first justification

* grandpa: add test for justification import period

* grandpa: fix test

* Remove redundant locks

* Re-enable warning for a sender when a queue got processed

* Apply suggestions from code review

Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Anton <[email protected]>

* Use debug for subsequent logging

* Update client/network/src/service/out_events.rs

Co-authored-by: Bastian Köcher <[email protected]>

---------

Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Anton <[email protected]>
Co-authored-by: parity-processbot <>

* replace Index by Nonce

* replace Index by Nonce

* replace Index by Nonce

* replace Index by Nonce

* replace Index by Nonce

* wip

* remove index in lieu of nonce

* wip

* remove accountnonce in lieu of nonce

* add minor improvement

* rebase and merge conflicts

* WasmExecutor flag to ignore onchain heappages value

* fmt

* Start

* More work!

* Moar

* More changes

* More fixes

* More worrk

* More fixes

* More fixes to make it compile

* Adds `NoOffchainStorage`

* Pass the extensions

* Small basti making small progress

* Fix merge errors and remove `ExecutionContext`

* Move registration of `ReadRuntimeVersionExt` to `ExecutionExtension`

Instead of registering `ReadRuntimeVersionExt` in `sp-state-machine` it is moved to
`ExecutionExtension` which provides the default extensions.

* Fix compilation

* Register the global extensions inside runtime api instance

* Fixes

* Fix `generate_initial_session_keys` by passing the keystore extension

* Fix the grandpa tests

* Fix more tests

* Fix more tests

* Don't set any heap pages if there isn't an override

* Fix small fallout

* FMT

* Fix tests

* More tests

* Offchain worker custom extensions

* More fixes

* Make offchain tx pool creation reusable

Introduces an `OffchainTransactionPoolFactory` for creating offchain transactions pools that can be
registered in the runtime externalities context. This factory will be required for a later pr to
make the creation of offchain transaction pools easier.

* Fixes

* Fixes

* Set offchain transaction pool in BABE before using it in the runtime

* Add the `offchain_tx_pool` to Grandpa as well

* Fix the nodes

* Print some error when using the old warnings

* Fix merge issues

* Fix compilation

* Rename `babe_link`

* Rename to `offchain_tx_pool_factory`

* Cleanup

* FMT

* Fix benchmark name

* Fix `try-runtime`

* Remove `--execution` CLI args

* Make clippy happy

* Forward bls functions

* Fix docs

* Update UI tests

* Update client/api/src/execution_extensions.rs

Co-authored-by: Michal Kucharczyk <[email protected]>

* Apply suggestions from code review

Co-authored-by: Koute <[email protected]>

* Update client/cli/src/params/import_params.rs

Co-authored-by: Koute <[email protected]>

* Update client/api/src/execution_extensions.rs

Co-authored-by: Koute <[email protected]>

* Pass the offchain storage to the MMR RPC

* Update client/api/src/execution_extensions.rs

Co-authored-by: Sebastian Kunert <[email protected]>

* Review comments

* Fixes

---------

Co-authored-by: Michal Kucharczyk <[email protected]>
Co-authored-by: Koute <[email protected]>
Co-authored-by: Sebastian Kunert <[email protected]>

* chore: update some deps to prune duplicated deps

- array-bytes: 4.1.0 => 6.1.0
- cid: 0.8.6 => 0.9.0

* fix

The native runtime will be removed in the near future and thus this function will not be required
anymore.

\# Code changes

Downstream users just need to remove `native_runtime_version` from their implementation of the
`SubstrateCli` trait.

* sc-tracing: Only print events for whitelisted targets

We should only print events for whitelisted targets, otherwise we may run into some stack overflow
while printing the event.

* Update client/tracing/src/lib.rs

Co-authored-by: Koute <[email protected]>

* Fix

---------

Co-authored-by: Koute <[email protected]>

* frame-benchmarking-cli: Remove native dispatch requirement

No need for this, we can just use the `WasmExecutor` directly.

* Fixes

* Pass benchmarking host functions

* Ensure we can pass custom host functions

This improves the reporting of invalid boot nodes. First, it will only report each boot node once
as invalid and not every time we try to connect to the node. Second, the node will only report for
addresses that we added as startup and not for addresses of the boot node that the node learned from
other nodes.

Closes: https://github.com/paritytech/substrate/issues/13584
Closes: https://github.com/paritytech/polkadot/issues/7385

* once_cell now stable

* cargo fmt

---------

Co-authored-by: parity-processbot <>

* expose kademlia replication factor through node CLI

* set default CLI flag value for kademlia_replication_factor

Co-authored-by: Bastian Köcher <[email protected]>

* wrap CLI value as Option

* make kademlia replication factor non-optional

---------

Co-authored-by: Bastian Köcher <[email protected]>

* Add log target

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

* Factor out apply_inherents

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

* Factor out apply_extrinsics

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

* Factor out print_summary

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

* Pimp print_summary

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

* Cleanup

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

* Fixes

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

* Update client/basic-authorship/src/basic_authorship.rs

Co-authored-by: Bastian Köcher <[email protected]>

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>

* Extend `Notifications` logs with `SetId` where missing

* Downgrade "Ignoring request to disconnect reserved peer"

* minor: log formatting

Test was using too small a timeout of 250ms to verify equivocation is reported.

If the test machine is loaded with many async tasks running, the voters work
and subsequent gossiping does not fit within the 250ms window.

Do multiple tries to verify equivocation reporting with exponential timeouts,
most times it will be within 250ms, but the test will retry several times up
to 5seconds total before giving up.

Signed-off-by: Adrian Catangiu <[email protected]>

* [frame/im-online] remove `external_addresses` from heartbeats

Users should use DHT for discovering new nodes. The reason for adding external addresses was
unstable work of authority discovery (see https://github.com/paritytech/substrate/issues/2719),
which is now stable. Hence we can safely remove `external_addresses`.

Refs https://github.com/paritytech/polkadot/issues/7181

* remove unused import

* run benchmark

* remove external_addresses from offchain NetworkState

* add missing fn to TestNetwork

* Revert "run benchmark"

This reverts commit a282042c2d6bf8bae2c383f6e2699c3fe2970a3d.

* update weights

* address @bkchr comments

* remove duplicate fn

* cleanup benchmarking.rs

* fix executor tests

* remove peer_id from hearbeat as well

https://github.com/paritytech/substrate/pull/14251#discussion_r1210887220

* remove MaxPeerDataEncodingSize

* change storage value type to `()`

https://github.com/paritytech/substrate/pull/14251#discussion_r1214268931

* scaffold storage migration

* no need to check the type actually

* remove unnecessary types from v0 mod

* add a test for migration

* expose Config types

+ pre_upgrade and post_upgrade working fn

* fix test

* replace dummy type with ConstU32

* add some comments to migration test

* fix comment

* respond to @bkchr comments

* use BoundedOpaqueNetworkState::default

intead of using default for each field

* sc-executor-wasmtime: Do not use absolute path to `Cargo.toml` in test

As the test is executed inside the workspace, `cargo metadata` will automatically detect the correct
`Cargo.toml`. This is required for the mono repo.

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: command-bot <>

Bumps [hyper-rustls](https://github.com/ctz/hyper-rustls) from 0.23.2 to 0.24.0.
- [Commits](https://github.com/ctz/hyper-rustls/compare/v/0.23.2...v/0.24.0

)

---
updated-dependencies:
- dependency-name: hyper-rustls
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: parity-processbot <>

* fix new warning

* Too soon

* Explicitly import

* Base error code module

* Base error code module

* fmt

* define trait `HashOutput`

* improve

* improve

* Update primitives/runtime/src/traits.rs

Co-authored-by: Bastian Köcher <[email protected]>

* remove `Block::Hash: Ord`

* fmt

* add `MaybeFromStr`

* cleanup

* fix

* remove useless `HashOutput`

---------

Co-authored-by: Bastian Köcher <[email protected]>

* Finalized block should not be after best block

* Remove unwrap

* Apply code review suggestion

Co-authored-by: Koute <[email protected]>

* Add test

---------

Co-authored-by: Koute <[email protected]>

We will calculate the tree route always against the best block and thus, we also should use this one
to check if we should skip the checks.