Close: https://github.com/paritytech/polkadot-sdk/issues/7816

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Closes #7845

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Guillaume Thiolliere <guillaume.thiolliere@parity.io>

# Description

Chains like moonbeam work with an ED deposit of 0 (insecure-ed-0) which
is unsable with the current pallet-transaction-payment benchmark. This
PR adds an if-else case in case the existential deposit found is 0.

Allow using the legacy data field for GenericTransaction

#### PR Description

This pull request introduces measures to handle finality stalls by :
- notifying outdated transactions with a
[`FinalityTimeout`](https://github.com/paritytech/polkadot-sdk/blob/d821c84d/substrate/client/transaction-pool/api/src/lib.rs#L145-L147)
event.
- removing outdated views from the `view_store`

An item is considered _outdated_ when the difference between its
associated block and the current block exceeds a pre-defined threshold.

#### Note for Reviewers
The core logic is provided in the following small commits:
- `ViewStore`: new method
[`finality_stall_view_cleanup`](https://github.com/paritytech/polkadot-sdk/blob/d821c84d/substrate/client/transaction-pool/src/fork_aware_txpool/view_store.rs#L869-L903)
for removing stale views was added: 64267000
- `ForkAwareTransactionPool`: core logic for tracking finality stalls
added here: 7b37ea6f. Entry point in
[`finality_stall_cleanup`](https://github.com/paritytech/polkadot-sdk/blob/d821c84d/substrate/client/transaction-pool/src/fork_aware_txpool/fork_aware_txpool.rs#L1096-L1136)
- Some related renaming was made to better reflect purpose/shorten the
names: 1a3a1284, a511601f. Also new method
[`transactions_finality_timeout`](https://github.com/paritytech/polkadot-sdk/blob/a511601f/substrate/client/transaction-pool/src/fork_aware_txpool/multi_view_listener.rs#L771-L790)
for triggering external events was added for `MultiViewListener`.
- `included_transactions` which basically is mapping `block hash ->
included transactions hashes`, is also used to find to included
transactions.

I also sneaked in some minor improvements:
- fixed per-transaction logging: 1572f721
- `handle_pre_finalized` method was removed, it was some old leftover
which is no longer needed: a6f84ad0

,

closes: #5482

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
Co-authored-by: Iulian Barbu <14218860+iulianbarbu@users.noreply.github.com>

# Description

Builds up towards addressing #5497 by creating some zombienet-sdk code
infra that can be used to spin regular networks, as described in the
fork aware transaction pool testing setup added here #7100. It will be
used for developing tests against such networks, and to also spawn them
on demand locally through tooling that will be developed in follow ups.

## Integration

Node/runtime developers can run tests based on the zombienet-sdk infra
that spins frequently used networks which can be used for analyzing
behavior of various node related components, like fork aware transaction
pool.

## Review Notes

- Uses ttxt API implemented here:
https://github.com/michalkucharczyk/tx-test-tool/pull/22/files
- currently, only two test scenarios are considered: 10k future & 10k
ready txs are sent to two separate networks - one parachain and one
relaychain, asserting at the end on the finalization of all 20k txs on
both networks.

---------

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Co-authored-by: Javier Viola <363911+pepoviola@users.noreply.github.com>
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>

This pr ensures that we remove the `authorization` for a runtime upgrade
if the version check failed. If that check is failing, it means that the
runtime upgrade is invalid and the check will never succeed.

Besides that the pr is doing some clean ups.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

If the inner transaction extension used inside `SkipCheckIfFeeless` are
multiples then the metadata is not correct, it is now fixed.

E.g. if the transaction extension is `SkipCheckIfFeeless::<Runtime,
(Payment1, Payment2)>` then the metadata was wrong.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Bastian Köcher <git@kchr.de>

# Description

* This PR adds a new extrinsic `poke_deposit` to `pallet-proxy`. This
extrinsic will be used to re-adjust the deposits made in the pallet to
create a proxy or to create an announcement.
* Part of #5591 

## Review Notes

* Added a new extrinsic `poke_deposit` in `pallet-proxy`.
* This extrinsic checks and adjusts the deposits made for either
creating a proxy or creating an announcement or both.
* Added a new event `DepositPoked` to be emitted upon a successful call
of the extrinsic.
* Although the immediate use of the extrinsic will be to give back some
of the deposit after the AH-migration, the extrinsic is written such
that it can work if the deposit decreases or increases (both).
* The call to the extrinsic would be `free` if an actual adjustment is
made to the deposit for creating a proxy or to the deposit for creating
an announcement or both and `paid` otherwise (when no deposit is
changed).
* Added a new enum `DepositKind` to differentiate between proxy deposit
adjusted and announcement deposit adjusted when emitting events.
* Added tests to test all scenarios.

## TO-DOs
* [ ] Run CI cmd bot to benchmark

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

This PR enhances **`test_log_capture`**, ensuring logs are **captured
for assertions** and **printed to the console** during test execution.

## **Motivation**  

- Partially addresses #6119 and #6125, to improves developer **tracing
and debugging** in XCM-related tests.
- Builds on #7594, improving **log visibility** while maintaining test
**log capture capabilities**.
- While writing tests for #7234, I noticed this function was missing.
This PR adds it to streamline log handling in unit tests.

## **Changes**  

- Ensures logs up to `TRACE` level are **captured** (for assertions) and
**printed** (for visibility).
- Refines documentation to clearly specify **when to use** each
function.
- **Removes ANSI escape codes** from captured logs to ensure clean,
readable assertions.

## **When to Use?**  

| Usage | Captures Logs? | Prints Logs? | Example |

|----------------------------------------------|-----------------|--------------|-----------------------------------------------|
| `init_log_capture(LevelFilter::INFO, false)` |  Yes |  No | Capture
logs for assertions without printing. |
| `init_log_capture(LevelFilter::TRACE, true)` |  Yes |  Yes | Capture
logs and print them in test output. |
| `sp_tracing::init_for_tests()` |  No | 

 Yes | Print logs to the
console without capturing. |

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Small tweaks to the eth-rpc-tester bin

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Right now `pallet-scheduler` is not putting back postponed tasks into
the agenda when the early weight check is failing. This pull request
ensures that these tasks are put back into the agenda and are not just
"lost".

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
Co-authored-by: Alexandre R. Baldé <alexandre.balde@parity.io>

Make some more stuff public that will be useful for AHM to reduce code
duplication.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

The tokio instant timer produced an overflow when the `poll_tick` was
called because the timer period was set to `u64::max`. The period is
reduced to accommodate for the following tokio time addition:


Source code
[tokio/time/interval.rs](https://github.com/tokio-rs/tokio/blob/a2b12bd5799f06e912b32ac05a5ffb5cf1fe31cd/tokio/src/time/interval.rs#L478-L485):
```rust
        let next = if now > timeout + Duration::from_millis(5) {
            self.missed_tick_behavior
                .next_timeout(timeout, now, self.period)
        } else {
            timeout
                .checked_add(self.period)
                .unwrap_or_else(Instant::far_future)
        };
```


Detected by:
https://github.com/paritytech/polkadot-sdk/actions/runs/13648141251/job/38150825582?pr=7790


```
──── TRY 1 STDERR:       sc-network protocol::notifications::tests::conformance::litep2p_disconnects_libp2p_substream
thread 'protocol::notifications::tests::conformance::litep2p_disconnects_libp2p_substream' panicked at std/src/time.rs:417:33:
overflow when adding duration to instant
stack backtrace:
   0: rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::option::expect_failed
   3: <std::time::Instant as core::ops::arith::Add<core::time::Duration>>::add
   4: tokio::time::interval::Interval::poll_tick
   5: sc_network::protocol::notifications::tests::conformance::litep2p_disconnects_libp2p_substream::{{closure}}
   6: tokio::runtime::scheduler::current_thread::Context::enter
   7: tokio::runtime::context::scoped::Scoped<T>::set
   8: tokio::runtime::scheduler::current_thread::CurrentThread::block_on
   9: tokio::runtime::runtime::Runtime::block_on
  10: sc_network::protocol::notifications::tests::conformance::litep2p_disconnects_libp2p_substream
  11: core::ops::function::FnOnce::call_once
```

cc @paritytech/networking

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

This can error when you use `cargo remote` and probably also with `cargo
vendor`.
Still seeing two more build errors, but at least this one is fixed.

Other one:
```pre
error: set `DATABASE_URL` to use query macros online, or run `cargo sqlx prepare` to update the query cache
   --> substrate/frame/revive/rpc/src/receipt_provider/db.rs:123:17
    |
123 |               let result = query!(
    |  __________________________^
124 | |                 r#"
125 | |                 INSERT OR REPLACE INTO transaction_hashes (transaction_hash, block_hash, transaction_index)
126 | |                 VALUES ($1, $2, $3)
...   |
130 | |                 transaction_index
131 | |             )
```

and (maybe Rust version related, this is 1.84.1)
```pre
error[E0282]: type annotations needed
   --> substrate/frame/revive/rpc/src/receipt_provider/db.rs:102:34
    |
102 |         let (tx_result, logs_result) = tokio::join!(delete_transaction_hashes, delete_logs);
    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot infer type
    |
    = note: this error originates in the macro `$crate::join` which comes from the expansion of the macro `tokio::join` (in Nightly builds, run with -Z macro-backtrace for more info)
```

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Bastian Köcher <git@kchr.de>

- Refactor to use the `frame` crate.
- Use procedural macro version `construct_runtime` in mock.
- Expose `PalletId` to `frame::pallet_prelude`.
- Part of #6202.

---

Polkadot address: 156HGo9setPcU2qhFMVWLkcmtCEGySLwNqa3DaEiYSWtte4Y

---------

Signed-off-by: Xavier Lau <x@acg.box>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

In solidity `block.timestamp` should be expressed in seconds
see
https://docs.soliditylang.org/en/latest/units-and-global-variables.html#block-and-transaction-properties

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alexander Theißen <alex.theissen@me.com>

When working with storage types that are to be set in the genesis block,
deriving serde::Serialize & serde::Deserialize is necessary (to my
knowledge). This PR introduces Serialize and Deserialize into the
umbrella crate derive (and indirectly prelude) module, allowing for
similar access as the other storage value derives.

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>

Last subtask from
https://github.com/paritytech/polkadot-sdk/issues/5704.

Closes #5704.

The substrate-node is not 100% free of the native runtime yet, but the
code has become less convoluted and better documented. The final cleanup
needs https://github.com/paritytech/polkadot-sdk/issues/7748.

---------

Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>

Fixes https://github.com/paritytech/polkadot-sdk/issues/6157

This fixes the last remaining benchmark that was not correct since it
was too low level to be written in Rust. Instead, we opted.

This PR changes the benchmark that determines the scaling from
`ref_time` to PolkaVM `Gas` by benchmarking the absolute worst case of
an instruction: One that causes two cache misses by touching two cache
lines.

The Contract itself is designed to be as simple as possible. It does
random unaligned reads in a loop until the `r` (repetition) number is
reached. The randomness is fully generated by the host and written to
the guests memory before the benchmark is run. This allows the benchmark
to determine the influence of one loop iteration via linear regression.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: xermicus <cyrill@parity.io>
Co-authored-by: PG Herveou <pgherveou@gmail.com>

Description
Part of #3326
As per title, `pallet::getter` usage has been removed from
`pallet-nft-fractionalization`.

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

This PR handles a case where we called the `poll_next` on an outbound
substream notification to check if the stream is closed. It is entirely
possible that the `poll_next` would return an `io::error`, for example
end of file.

This PR ensures that we make the distinction between unexpected incoming
data, and error originated from `poll_next`.

While at it, the bulk of the PR change propagates the PeerID from the
network behavior, through the notification handler, to the notification
outbound stream for logging purposes.

cc @paritytech/networking 

Part of: https://github.com/paritytech/polkadot-sdk/issues/7722

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Fixes https://github.com/paritytech/polkadot-sdk/issues/6723

## Motivation

Internal auditors recommended to not truncate Polkadot Addresses when
deriving Ethereum addresses from it. Reasoning is that they are raw
public keys where truncating could lead to collisions when weaknesses in
those curves are discovered in the future. Additionally, some pallets
generate account addresses in a way where only the suffix we were
truncating contains any entropy. The changes in this PR act as a safe
guard against those two points.

## Changes made

We change the `to_address` function to first hash the AccountId32 and
then use trailing 20 bytes as `AccountId20`. If the `AccountId32` ends
with 12x 0xEE we keep our current behaviour of just truncating those
trailing bytes.

## Security Discussion

This will allow us to still recover the original `AccountId20` because
those are constructed by just adding those 12 bytes. Please note that
generating an ed25519 key pair where the trailing 12 bytes are 0xEE is
theoretically possible as 96bits is not a huge search space. However,
this cannot be used as an attack vector. It will merely allow this
address to interact with `pallet_revive` without registering as the
fallback account is the same as the actual address. The ultimate vanity
address. In practice, this is not relevant since the 0xEE addresses are
not valid public keys for sr25519 which is used almost everywhere.

tl:dr: We keep truncating in case of an Ethereum address derived account
id. This is safe as those are already derived via keccak. In every other
case where we have to assume that the account id might be a public key.
Therefore we first hash and then take the trailing bytes.

## Do we need a Migration for Westend

No. We changed the name of the mapping. This means the runtime will not
try to read the old data. Ethereum keys are unaffected by this change.
We just advise people to re-register their AccountId32 in case they need
to use it as it is a very small circle of users (just 3 addresses
registered). This will not cause disturbance on Westend.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Related to https://github.com/paritytech/polkadot-sdk/issues/7360

This PR adds `DecodeWithMemTracking` as a trait bound for `Header`,
`Block` and `TransactionExtension` and
derives it for all the types that implement these traits in
`polkadot-sdk`.

# Description

* This PR adds a new extrinsic `poke_deposit` to `pallet-multisig`. This
extrinsic will be used to re-adjust the deposits made in the pallet to
create a multisig operation after AHM.
* Part of #5591 

## Review Notes

* Added a new extrinsic `poke_deposit` in `pallet-multisig`.
* Added a new event `DepositPoked` to be emitted upon a successful call
of the extrinsic.
* Although the immediate use of the extrinsic will be to give back some
of the deposit after the AH-migration, the extrinsic is written such
that it can work if the deposit decreases or increases (both).
* The call to the extrinsic would be `free` if an actual adjustment is
made to the deposit and `paid` otherwise.
* Added tests to test all scenarios.

## TO-DOs
* [x] Add Benchmark
* [x] Run CI cmd bot to benchmark

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>

This PR ensures compatibility in terms of expectations between the
libp2p and litep2p network backends at the notification protocol level.

The libp2p node is tested with the `Notification` behavior that contains
the protocol controller, while litep2p is tested at the lowest level API
(without substrate shim layers).

## Notification Behavior

(I) Libp2p protocol controller will eagerly reopen a closed substream,
even if it is the one that closed it:
- When a node (libp2p or litep2p) closes the substream with **libp2p**,
the **libp2p** controller will reopen the substream
- When **libp2p** closes the substream with a node (either litep2p with
no controller or libp2p), the **libp2p** controller will reopen the
substream
- However in this case, libp2p was the one closing the substream
signaling it is no longer interested in communicating with the other
side

(II) Notifications are lost and not reported to the higher level in the
following scenario:
- T0: Node A opens a substream with Node B
- T1: Node A closes the substream or the connection with Node B
- T2: Node B sends a notification to Node A => *notification is lost*
and never reported
- T3: Node B detects the closed substream or connection


## Testing

This PR effectively checks:
- connectivity at the notification level
- litep2p rejecting libp2p substream and keep-alive mechanism
functionality
- libp2p disconnecting libp2p and connection re-establishment (and all
the other permutations)
- idling of connections with active substreams and keep-alive mechanism
is not enforced


Prior work:
- https://github.com/paritytech/polkadot-sdk/pull/7361

cc @paritytech/networking

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Co-authored-by: Dmitry Markin <dmitry@markin.tech>

closes https://github.com/paritytech/polkadot-sdk/issues/5742

Need to be backported to stable2503 release.

With the migration of staking accounts to [fungible
currency](https://github.com/paritytech/polkadot-sdk/pull/5501), we can
now allow pool users to stake directly and vice versa. This update
introduces a configurable filter mechanism to determine which accounts
can join a nomination pool.

## Example Usage  

### 1. Allow any account to join a pool  
To permit all accounts to join a nomination pool, use the `Nothing`
filter:

```rust
impl pallet_nomination_pools::Config for Runtime {
    ...
    type Filter = Nothing;
}
```

### 2. Restrict direct stakers from joining a pool

To prevent direct stakers from joining a nomination pool, use
`pallet_staking::AllStakers`:
```rust
impl pallet_nomination_pools::Config for Runtime {
    ...
    type Filter = pallet_staking::AllStakers<Runtime>;
}
```

### 3. Define a custom filter
For more granular control, you can define a custom filter:
```rust
struct MyCustomFilter<T: Config>(core::marker::PhantomData<T>);

impl<T: Config> Contains<T::AccountId> for MyCustomFilter<T> {
    fn contains(account: &T::AccountId) -> bool {
        todo!("Implement custom logic. Return `false` to allow the account to join a pool.")
    }
}
```

---------

Co-authored-by: Bastian Köcher <info@kchr.de>

This PR changes the behavior of delegate calls when the callee is not a
contract account: Instead of returning a `CodeNotFound` error, this is
allowed and the caller observes a successful call with empty output.

The change makes for example the following contract behave the same as
on EVM:

```Solidity
contract DelegateCall {
    function delegateToLibrary() external returns (bool) {
        address testAddress = 0x0000000000000000000000000000000000000000;
        (bool success, ) = testAddress.delegatecall(
            abi.encodeWithSignature("test()")
        );
        return success;
    }
}
```

Closes https://github.com/paritytech/revive/issues/235

---------

Signed-off-by: xermicus <cyrill@parity.io>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Add ECrecover 0x1 precompile and remove the unstable equivalent host
function.

- depend on https://github.com/paritytech/polkadot-sdk/pull/7676

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alexander Theißen <alex.theissen@me.com>

The runtime API implemented version is not explicitly shown in metadata,
so here we add it to improve developer experience.
We need to bump `frame-metadata` and `merkleized-metadata` to allow this
new feature.

This closes #7352 .

_Refactor_: also changing all the occurrences of `ViewFunctionMethod` to
just `ViewFunction` for metadata types.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

# Description
Seems like SubstrateWeights that used T::DBWeights was not public unlike
the frame_system's Call weights. PR just made those weights public

## Integration
Instead of using `()` impl which used RockDB weights, ExtensionWeights
can be used to to use the provided DBWeights to System config

Fix tracing should wrap around the entire call stack execution

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

`sc-cli` brings rocksdb dependency into frame-benchmarking-cli when used
with `default-features = false`.
This PR makes rocksdb deps optional that sc-cli brings in some of the
crates. I think I covered all the crates that depend on sc-cli but
please let me know if I missed any.

Fixes: https://github.com/paritytech/polkadot-sdk/issues/3793

# Description

This PR introduces a lightweight log-capturing mechanism for XCM unit
tests, simplifying debugging by enabling structured log assertions. It
partially addresses #6119 and #6125, offering an optional way to verify
logs in tests while remaining unobtrusive in normal execution.

# Key Changes

* [x] Introduces a log capture utility in `sp_tracing`.
* [x] Adds XCM test examples demonstrating how and when to use log
capturing.

# Review Notes:

* The log capture mechanism is opt-in and does not affect existing tests
unless explicitly used.
* The implementation is minimal and does not add complexity to existing
test setups.
* It provides a structured alternative to
[`sp_tracing::init_for_tests()`](https://paritytech.github.io/polkadot-sdk/master/sp_tracing/fn.init_for_tests.html)
for log verification in automated tests.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Adding chain-spec-builder as a subcommand into Polkadot omni node

Auto-update of all weights for 2025-02-21-1740149841.

Subweight results:
- [now vs
master](https://weights.tasty.limo/compare?repo=polkadot-sdk&threshold=5&path_pattern=.%2F**%2Fweights%2F**%2F*.rs%2C.%2F**%2Fweights.rs&method=asymptotic&ignore_errors=true&unit=time&old=master&new=update-weights-weekly-2025-02-21-1740149841)
- [now vs polkadot-v1.15.6
(2025-01-16)](https://weights.tasty.limo/compare?repo=polkadot-sdk&threshold=5&path_pattern=.%2F**%2Fweights%2F**%2F*.rs%2C.%2F**%2Fweights.rs&method=asymptotic&ignore_errors=true&unit=time&old=polkadot-v1.15.6&new=update-weights-weekly-2025-02-21-1740149841)
- [now vs polkadot-v1.16.2
(2024-11-14)](https://weights.tasty.limo/compare?repo=polkadot-sdk&threshold=5&path_pattern=.%2F**%2Fweights%2F**%2F*.rs%2C.%2F**%2Fweights.rs&method=asymptotic&ignore_errors=true&unit=time&old=polkadot-v1.16.2&new=update-weights-weekly-2025-02-21-1740149841)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Essentially, this locks `bandersnatch_vrfs` to a specific branch of a
repository I control. This is a temporary workaround to avoid issues
like https://github.com/paritytech/polkadot-sdk/issues/7653 until
https://github.com/paritytech/polkadot-sdk/pull/7669 is ready.

Closes: https://github.com/paritytech/polkadot-sdk/issues/7653 

@drskalman

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Remove JS examples, they now belongs to the evm-test-suite repo

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

# Description

* This PR adds a new extrinsic `reconsider` to `pallet-indices`. This
extrinsic will be used to re-adjust the deposits made in the pallet.
* Part of #5591 

## Review Notes

* Added a new extrinsic `reconsider` in `pallet-indices`.
* Added a new event `DepositReconsidered` to be emitted upon a
successful call of the extrinsic.
* Although the immediate use of the extrinsic will be to give back some
of the deposit after the AH-migration, the extrinsic is written such
that it can work if the deposit decreases or increases (both).
* The call to the extrinsic would be `free` if an actual adjustment is
made to the deposit and `paid` otherwise.
* Added tests to test all scenarios.
* Added a benchmark to test the "worst case" (maximum compute) flow of
the extrinsic which is when the deposit amount is updated to a new
value.

## TO-DOs

* [x] Run CI cmd bot to benchmark

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>