Skip to content
  1. Apr 29, 2022
    • Bisola Olasehinde's avatar
      Replace simple parameter_types (#11254) · aaf693f0
      Bisola Olasehinde authored
      
      
      * update bin/node-template/runtime/src/lib.rs
      
      * update frame/contracts/src/tests.rs
      
      * update frame/executive/src/lib.rs
      
      * update frame/grandpa/src/mock.rs
      
      * update frame/im-online/src/mock.rs
      
      * update frame/offences/benchmarking/src/mock.rs
      
      * update frame/recovery/src/mock.rs
      
      * update frame/referenda/src/mock.rs
      
      * update frame/session/benchmarking/src/mock.rs
      
      * update frame/staking/src/mock.rs
      
      * update frame/state-trie-migration/src/lib.rs
      
      * update frame/support/test/compile_pass/src/lib.rs
      
      * frame/treasury/src/tests.rs
      
      * update frame/whitelist/src/mock.rs
      
      * update frame/vesting/src/mock.rs
      
      * update test-utils/runtime/src/lib.rs
      
      * update bin/node-template/runtime/src/lib.rs
      
      * Update frame/grandpa/src/mock.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * resolve failed checks 1518659 & 1518669
      
      * resolve format check
      
      * backtrack to resolve compile error
      
      * check --all --tests 
      
      * cargo +nightly fmt 
      
      
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      aaf693f0
  2. Apr 21, 2022
    • Zeke Mostov's avatar
      staking: Proportional ledger slashing (#10982) · e0bf4f36
      Zeke Mostov authored
      
      
      * staking: Proportional ledger slashing
      
      * Some comment cleanup
      
      * Update frame/staking/src/pallet/mod.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Fix benchmarks
      
      * FMT
      
      * Try fill in all staking configs
      
      * round of feedback and imp from kian
      
      * demonstrate per_thing usage
      
      * Update some tests
      
      * FMT
      
      * Test that era offset works correctly
      
      * Update mocks
      
      * Remove unnescary docs
      
      * Remove unlock_era
      
      * Update frame/staking/src/lib.rs
      
      * Adjust tests to account for only remove when < ED
      
      * Remove stale TODOs
      
      * Remove dupe test
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: default avatarkianenigma <[email protected]>
      e0bf4f36
  3. Apr 20, 2022
  4. Apr 15, 2022
    • Georges's avatar
      Adding benchmarking for new `frame_election_provider_support` (#11149) · ae75a371
      Georges authored
      * First stab at adding benchmarking for
      `election-provider-support` onchain
      
      * Adding `BoundedPhragMMS` and fixing stuff
      
      * Fixing node runtime
      
      * Fixing tests
      
      * Finalising all benchmarking stuff
      
      * better comments
      
      * Better benchmarking config
      
      * Better `WeightInfo` and benchmarking
      
      * Fixing tests
      
      * Adding some documentation
      
      * Fixing some typos
      
      * Incorporating review feedback
      
      * cleanup of rustdocs
      
      * rustdoc changes
      
      * changes after code review
      
      * Fixing some errors.
      
      * Fixing dependencies post merge
      
      * Bringing back `UnboundedExecution`
      
      * Better rustdoc and naming
      
      * Cargo.toml formatting
      ae75a371
  5. Apr 08, 2022
  6. Mar 25, 2022
    • Georges's avatar
      Add a bounded fallback on failed elections (#10988) · e9bfdd9a
      Georges authored
      
      
      * Allow `pallet-election-provider` to accept smaller
      solutions, issue #9478
      
      * Fixing a typo
      
      * Adding some more tests
      Removing a seemingly outdated comment
      
      * making it a URL
      
      * Updating test name as per suggestion
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Updating documentation to be more explicit
      
      And to follow the general guidelines
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Fixing formatting
      
      * `Fallback` now of type `InstantElectionProvider`
      Some cleanups
      
      * Allow `pallet-election-provider` to accept smaller
      solutions, issue #9478
      
      * Fixing a typo
      
      * Adding some more tests
      Removing a seemingly outdated comment
      
      * making it a URL
      
      * Updating test name as per suggestion
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Updating documentation to be more explicit
      
      And to follow the general guidelines
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Fixing formatting
      
      * `Fallback` now of type `InstantElectionProvider`
      Some cleanups
      
      * Merging types into one type with generics
      
      * Removing `ConstUSize` and use `ConstU32`
      
      * cleaning up the code
      
      * deprecating `OnChainSequentialPhragmen`
      Renaming it to `UnboundedSequentialPhragmen` which should only be used
      at genesis and for testing.
      Use preferrably `BoundedOnChainSequentialPhragmen`
      
      * Amending docs
      
      * Adding some explicit imports
      
      * Implementing generic `BoundedOnchainExecution`
      Removing the deprecated `OnChainSequentialPhragmen`
      
      * Use the right Balancing strategy
      
      * Refactoring `onchain::Config`
      Creating `onchain::ExecutionConfig`
      
      * Merge master
      
      * fmt
      
      * Name cleanups after review suggestions
      
      * cosmetics
      
      * renaming `instant_elect` to `elect_with_bounds`
      Other corresponding changes as per @Kianenigma
      
       feedback
      
      * `BoundedOnchainExecution` -> `BoundedExecution`
      And `UnboundedOnchainExecution` -> `UnboundedExecution`
      
      * feedback from kian
      
      * fmt + unneeded import
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: default avatarkianenigma <[email protected]>
      e9bfdd9a
  7. Mar 23, 2022
  8. Mar 02, 2022
  9. Mar 01, 2022
    • Zeke Mostov's avatar
      Only maintain at most 1 `UnlockChunk` per era (#10670) · 3f5e0baf
      Zeke Mostov authored
      
      
      * Only maintain at most 1 `UnlockChunk` per era
      
      * Bound `unlocking`
      
      * Run cargo +nightly-2021-10-29 fmt
      
      * Make benchmarks stuff compile
      
      * Update frame/staking/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Remove DerefMut; Implement neccesary methods directly
      
      * Doc comments for new BoundedVec methods
      
      * Fix benchmarks
      
      * wip bonded_vec macro
      
      * Correct rust doc
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update staking::Config impls
      
      * Add MaxUnlockingChunks to more places
      
      * Use defensive saturating add
      
      * FMT
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      3f5e0baf
    • Andrew Jones's avatar
      Release primitive crates (#10937) · a3a7fe90
      Andrew Jones authored
      * cargo set-version --bump major -p pallet-contracts-primitives
      
      * cargo set-version --bump major -p sp-core
      
      * cargo set-version --bump major -p sp-runtime-interface
      
      * cargo set-version --bump major -p sp-wasm-interface
      
      * cargo set-version --bump major -p sp-runtime
      
      * cargo set-version --bump major -p sp-storage
      
      * cargo set-version --bump major -p sp-rpc
      
      * cargo set-version --bump major -p sp-io
      
      * cargo set-version --bump major -p sp-trie
      
      * cargo set-version -p sp-state-machine  -- 0.12.0
      
      * cargo set-version -p sp-externalities  -- 0.12.0
      
      * cargo set-version -p sp-keystore -- 0.12.0
      
      * cargo set-version --bump major -p sp-keyring
      
      * cargo set-version --bump major -p sp-version
      
      * cargo set-version --bump major -p sp-tracing
      
      * cargo set-version --bump major -p sp-application-crypto
      
      * cargo set-version --bump major -p sp-arithmetic
      
      * cargo unleash version bump-major -p sp-runtime-interface-proc-macro
      
      * Add codec max-encoded-len feature to sp-arithmetic
      
      * cargo unleash version bump-major -p sp-core-hashing-proc-macro
      a3a7fe90
  10. Feb 24, 2022
    • wigy's avatar
      Upgrading parity-scale-codec to v3 (#10825) · 535325d2
      wigy authored
      * Upgraded dependencies
      
      * Adapting code to scale v3
      
      * Empty commit to trigger CI
      
      * Triggering CI
      
      * Fixing UI test
      
      * Remove superfluous dev-dep added by #9228
      
      * Cryout for CI
      535325d2
  11. Feb 01, 2022
    • Alexander Theißen's avatar
      Release `pallet-contracts-primitives` (#10772) · 3938c1cb
      Alexander Theißen authored
      * Bump sp-storage
      
      * Bump sp-rpc
      
      * Bump sp-io
      
      * Bump sp-trie
      
      * Bump sp-state-machine
      
      * Bump sp-externalities
      
      * Bump sp-keystore
      
      * Bump sp-application-crypto
      
      * Bump pallet-contracts-primitives
      
      * Bump sp-core
      
      * Bump sp-runtime-interface
      
      * Bump sp-wasm-interface
      
      * Bump sp-runtime
      
      * Bump sp-storage
      
      * Update lock file
      
      * Revert "Bump sp-storage"
      
      This reverts commit f86c6db1ae334e28207b658fd90714ade0332e3b.
      
      * Update lock file
      3938c1cb
  12. Jan 31, 2022
  13. Jan 25, 2022
  14. Jan 24, 2022
  15. Jan 20, 2022
  16. Jan 05, 2022
  17. Jan 03, 2022
  18. Dec 24, 2021
    • cheme's avatar
      Inner hashing of value in state trie (runtime versioning). (#9732) · 4c651637
      cheme authored
      
      
      * starting
      
      * Updated from other branch.
      
      * setting flag
      
      * flag in storage struct
      
      * fix flagging to access and insert.
      
      * added todo to fix
      
      * also missing serialize meta to storage proof
      
      * extract meta.
      
      * Isolate old trie layout.
      
      * failing test that requires storing in meta when old hash scheme is used.
      
      * old hash compatibility
      
      * Db migrate.
      
      * runing tests with both states when interesting.
      
      * fix chain spec test with serde default.
      
      * export state (missing trie function).
      
      * Pending using new branch, lacking genericity on layout resolution.
      
      * extract and set global meta
      
      * Update to branch 4
      
      * fix iterator with root flag (no longer insert node).
      
      * fix trie root hashing of root
      
      * complete basic backend.
      
      * Remove old_hash meta from proof that do not use inner_hashing.
      
      * fix trie test for empty (force layout on empty deltas).
      
      * Root update fix.
      
      * debug on meta
      
      * Use trie key iteration that do not include value in proofs.
      
      * switch default test ext to use inner hash.
      
      * small integration test, and fix tx cache mgmt in ext.
      test  failing
      
      * Proof scenario at state-machine level.
      
      * trace for db upgrade
      
      * try different param
      
      * act more like iter_from.
      
      * Bigger batches.
      
      * Update trie dependency.
      
      * drafting codec changes and refact
      
      * before removing unused branch no value alt hashing.
      more work todo rename all flag var to alt_hash, and remove extrinsic
      replace by storage query at every storage_root call.
      
      * alt hashing only for branch with value.
      
      * fix trie tests
      
      * Hash of value include the encoded size.
      
      * removing fields(broken)
      
      * fix trie_stream to also include value length in inner hash.
      
      * triedbmut only using alt type if inner hashing.
      
      * trie_stream to also only use alt hashing type when actually alt hashing.
      
      * Refactor meta state, logic should work with change of trie treshold.
      
      * Remove NoMeta variant.
      
      * Remove state_hashed trigger specific functions.
      
      * pending switching to using threshold, new storage root api does not
      make much sense.
      
      * refactoring to use state from backend (not possible payload changes).
      
      * Applying from previous state
      
      * Remove default from storage, genesis need a special build.
      
      * rem empty space
      
      * Catch problem: when using triedb with default: we should not revert
      nodes: otherwhise thing as trie codec cannot decode-encode without
      changing state.
      
      * fix compilation
      
      * Right logic to avoid switch on reencode when default layout.
      
      * Clean up some todos
      
      * remove trie meta from root upstream
      
      * update upstream and fix benches.
      
      * split some long lines.
      
      * UPdate trie crate to work with new design.
      
      * Finish update to refactored upstream.
      
      * update to latest triedb changes.
      
      * Clean up.
      
      * fix executor test.
      
      * rust fmt from master.
      
      * rust format.
      
      * rustfmt
      
      * fix
      
      * start host function driven versioning
      
      * update state-machine part
      
      * still need access to state version from runtime
      
      * state hash in mem: wrong
      
      * direction likely correct, but passing call to code exec for genesis
      init seem awkward.
      
      * state version serialize in runtime, wrong approach, just initialize it
      with no threshold for core api < 4 seems more proper.
      
      * stateversion from runtime version (core api >= 4).
      
      * update trie, fix tests
      
      * unused import
      
      * clean some TODOs
      
      * Require RuntimeVersionOf for executor
      
      * use RuntimeVersionOf to resolve genesis state version.
      
      * update runtime version test
      
      * fix state-machine tests
      
      * TODO
      
      * Use runtime version from storage wasm with fast sync.
      
      * rustfmt
      
      * fmt
      
      * fix test
      
      * revert useless changes.
      
      * clean some unused changes
      
      * fmt
      
      * removing useless trait function.
      
      * remove remaining reference to state_hash
      
      * fix some imports
      
      * Follow chain state version management.
      
      * trie update, fix and constant threshold for trie layouts.
      
      * update deps
      
      * Update to latest trie pr changes.
      
      * fix benches
      
      * Verify proof requires right layout.
      
      * update trie_root
      
      * Update trie deps to  latest
      
      * Update to latest trie versioning
      
      * Removing patch
      
      * update lock
      
      * extrinsic for sc-service-test using layout v0.
      
      * Adding RuntimeVersionOf to CallExecutor works.
      
      * fmt
      
      * error when resolving version and no wasm in storage.
      
      * use existing utils to instantiate runtime code.
      
      * Patch to delay runtime switch.
      
      * Revert "Patch to delay runtime switch."
      
      This reverts commit 67e55fee468f1a0cda853f5362b22e0d775786da.
      
      * useless closure
      
      * remove remaining state_hash variables.
      
      * Remove outdated comment
      
      * useless inner hash
      
      * fmt
      
      * fmt and opt-in feature to apply state change.
      
      * feature gate core version, use new test feature for node and test node
      
      * Use a 'State' api version instead of Core one.
      
      * fix merge of test function
      
      * use blake macro.
      
      * Fix state api (require declaring the api in runtime).
      
      * Opt out feature, fix macro for io to select a given version
      instead of latest.
      
      * run test nodes on new state.
      
      * fix
      
      * Apply review change (docs and error).
      
      * fmt
      
      * use explicit runtime_interface in doc test
      
      * fix ui test
      
      * fix doc test
      
      * fmt
      
      * use default for path and specname when resolving version.
      
      * small review related changes.
      
      * doc value size requirement.
      
      * rename old_state feature
      
      * Remove macro changes
      
      * feature rename
      
      * state version as host function parameter
      
      * remove flag for client api
      
      * fix tests
      
      * switch storage chain proof to V1
      
      * host functions, pass by state version enum
      
      * use WrappedRuntimeCode
      
      * start
      
      * state_version in runtime version
      
      * rust fmt
      
      * Update storage proof of max size.
      
      * fix runtime version rpc test
      
      * right intent of convert from compat
      
      * fix doc test
      
      * fix doc test
      
      * split proof
      
      * decode without replay, and remove some reexports.
      
      * Decode with compatibility by default.
      
      * switch state_version to u8. And remove RuntimeVersionBasis.
      
      * test
      
      * use api when reading embedded version
      
      * fix decode with apis
      
      * extract core version instead
      
      * test fix
      
      * unused import
      
      * review changes.
      
      Co-authored-by: default avatarkianenigma <[email protected]>
      4c651637
  19. Dec 16, 2021
    • dharjeezy's avatar
      Replace parameter_types with ConstU32 &c. (#10402) · 1b0be8ae
      dharjeezy authored
      
      
      * remove parameter types and use const type
      
      * remove parameter types and use const type
      
      * Delete {
      
      * Delete count,
      
      * refractor for beefy, benchmarking, child bounties, and collective pallets
      
      * refractor for pallet contracts
      
      * refractor for elections
      
      * refractor for more pallets
      
      * fix CI issues
      
      * fix CI issues
      
      * fix CI issues
      
      * fix CI issues
      
      * remove warning to fix CI issue
      
      * remove warning to fix CI issue
      refractor for pallet preimage
      
      * remove warning to fix CI issue
      refractor for pallet proxy
      
      * remove warning to fix CI issue
      refractor for pallet recovery
      refractor for pallet randomness-collective-flip
      
      * remove warning to fix CI issue
      refractor for pallet scored-pool
      refractor for pallet scheduler
      refractor for pallet session
      
      * remove warning to fix CI issue
      refractor for pallet society, support, system, timestamp, tips
      
      * remove warning to fix CI issue
      refractor for pallet transaction_payment, transaction_storage, treasury, uniques, utility
      
      * remove warning to fix CI issue
      
      * cargo +nightly fmt
      
      * CI fix
      
      * more param refractor on beefy-mmr
      
      * refractor for beefy
      
      * Update frame/babe/src/mock.rs
      
      * Update frame/babe/src/mock.rs
      
      * Update frame/bounties/src/tests.rs
      
      * Update frame/tips/src/tests.rs
      
      * Delete mock.rs
      
      * Update frame/examples/basic/src/tests.rs
      
      * Apply suggestions from code review
      
      * Update frame/im-online/src/mock.rs
      
      * Update frame/im-online/src/mock.rs
      
      * Update frame/offences/benchmarking/src/mock.rs
      
      * Update frame/session/benchmarking/src/mock.rs
      
      * Update frame/support/test/tests/pallet_compatibility.rs
      
      * Update frame/support/test/tests/pallet_compatibility_instance.rs
      
      * Update frame/treasury/src/tests.rs
      
      * Update test-utils/runtime/src/lib.rs
      
      * some cleanup
      
      * fmt
      
      * remove unused
      
      Co-authored-by: default avatarDamilare <[email protected]>
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      1b0be8ae
  20. Dec 15, 2021
  21. Dec 13, 2021
  22. Dec 11, 2021
    • Bastian Köcher's avatar
      `inspect-key`: Adds support for `expect-public` (#10430) · f6f58f95
      Bastian Köcher authored
      * Introduce `SecretUri`
      
      * `inspect-key`: Adds support for `expect-public`
      
      `expect-public` can be used to check that a given secret uri corresponds to the given public key.
      This is mainly useful when the secret uri is protected by a password and a new derived account
      should be generated. With `--expect-public` the user can pass the public key/account-id of the
      "base" secret uri aka the one without any derivation to ensure the correct password was inserted.
      
      * Fixes
      
      * 🤦
      
      
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarAndré Silva <[email protected]>
      
      * Review feedback
      
      * FMT
      
      * Bump the versions
      
      Co-authored-by: default avatarAndré Silva <[email protected]>
      f6f58f95
  23. Dec 09, 2021
  24. Dec 08, 2021
    • David's avatar
      Release sp-core 4.0.0 (#10447) · 92dc635f
      David authored
      * Bump versions of sp-core and dependencies to v4.0.0
      
      * Update references from `4.0.0-dev` –> `4.0.0`
      
      * Funny whitespace
      
      * Funny whitespace 2
      92dc635f
  25. Nov 28, 2021
  26. Nov 20, 2021
    • Doordashcon's avatar
      tuple to struct event variants (#10257) · 09d351dd
      Doordashcon authored
      * AFNPEV recovery
      
      * AFNPEV session
      
      * cargo +nightly fmt && cargo fmt
      
      * removed redundant comments
      
      * update
      
      * update & cargo +nightly fmt
      
      * update & cargo +nightly fmt
      
      * update recovery/src/lib.rs
      
      * update session/src/lib.rs
      09d351dd
  27. Nov 17, 2021
  28. Nov 07, 2021
  29. Nov 04, 2021
  30. Oct 14, 2021
  31. Oct 13, 2021
  32. Oct 06, 2021
  33. Oct 01, 2021
    • ucover's avatar
      Test each benchmark case in own #[test] (#9860) · f8ce1864
      ucover authored
      
      
      * Generate one #[test] fn per bench case.
      
      * Update benchmark macro syntax in frame pallets.
      
      * Explain new benchmark macro syntax in example pallet.
      
      * support with and without a semicolon
      
      * update pallets to use individual tests
      
      * migrate staking too
      
      * migrate more pallets
      
      * fix up democracy and use individual tests
      
      * Fix comment
      
      * Put println message in panic
      
      * Remove `another_set_dummy` from doc
      
      `another_set_dummy` is not present in the benchmarking.rs (anymore).
      
      * Update doc for benchmarks macro
      
      * Update doc for impl_benchmark_test_suite macro
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      f8ce1864
  34. Sep 28, 2021
  35. Sep 20, 2021
    • Georges's avatar
      Generate storage info for pallet im_online (#9654) · cddafd52
      Georges authored
      * Integrating WrapperOpaque from PR #9738
      
      * Adding storage_info to pallet im-online
      Changing some `Vec` to `WeakBoundedVec`
      Adding the following bounds:
      * `MaxKeys
      * `MaxPeerInHeartbeats`
      * `MaxPeerDataEncodingSize`
      to limit the size of `WeakBoundedVec`
      
      * Fix syntax
      
      * Need to clone keys
      
      * Changes in formatting
      cddafd52
  36. Sep 17, 2021
    • Zeke Mostov's avatar
      Implement `pallet-bags-list` and its interfaces with `pallet-staking` (#9507) · 669972a1
      Zeke Mostov authored
      
      
      * remove extra whitespace
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * only emit rebag event on success
      
      * add doc explaining the term voter
      
      * revamp/simplify rebag test
      
      * ensure genesis accounts are placed into the correct nodes/bags
      
      * bond_extra implicitly rebags
      
      * types at top; doc public type
      
      * start sketching out adjustable thresholds
      
      * add integrity test for voter bag threshold requirements
      
      * get rid of BagIdx
      
      This reorganizes bag storage such that bags are always referred to
      by their upper threshold. This in turn means that adding and removing
      bags is cheaper; you only need to migrate certain voters, not all of them.
      
      * implement migration logic for when the threshold list changes
      
      * start sketching out threshold proc macros
      
      * further refine macro signatures
      
      * WIP: implement make_ratio macro
      
      * start rethinking the process of producing threshold lists
      
      The macro approach seems to be a non-starter; that only really works
      if we're throwing around numeric literals everywhere, and that's just
      not nice in this case.
      
      Instead, let's write helper functions and make it really easy to
      generate the tables in separate, permanent files, which humans
      can then edit.
      
      * write helper functions to emit voter bags module
      
      * WIP: demo generating voter bags for a realistic runtime
      
      This isn't yet done, becuase it seems to take a Very Long Time to run,
      and it really shouldn't. Need to look into that.
      
      Still, it's a lot closer than it was this morning.
      
      * rm unnecessary arg_enum
      
      * fix voter bags math
      
      Turns out that when you're working in exponential space, you need
      to divide, not subtract, in order to keep the math working properly.
      
      Also neaten up the output a little bit to make it easier to read.
      
      * add computed voter bags thresholds to node
      
      * fixup some docs
      
      * iter from large bags to small, fulfuilling the contract
      
      * make tests compile
      
      * add VoterBagThresholds to some configs
      
      * ensure that iteration covers all voters even with implied final bag
      
      * use sp_std::boxed::Box;
      
      * fix unused import
      
      * add some more voter bags tests
      
      * file_header.txt
      
      * integrity test to ensure min bag exceeds existential weight
      
      * add more debug assertions about node list length
      
      * rm unused imports
      
      * Kian enters
      
      * Update frame/election-provider-support/src/onchain.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Suggestions for #9081 (Store voters in unsorted bags) (#9328)
      
      * Add some debug asserts to node::get and remove_node
      
      * Improve the debug asserts in remove_node
      
      * improve debug asserts
      
      * Space
      
      * Remove bad assertions
      
      * Tests: WIP take_works
      
      * Take test
      
      * Doc comment
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Test storage is cleaned up;
      
      * formatting
      
      * Switch to simpler thresholds
      
      * Update the storage cleanup test
      
      * Remove hardcoded values from benchmark to make it more robust
      
      * Fix tests to acces bags properly
      
      * Sanity check WIP; tests failing
      
      * Update sanity checks to be more correct
      
      * Improve storage cleanup tests
      
      * WIP remote_ext_tests
      
      * Some notes on next steps
      
      * Remove some stuff that was for remote-ext tests
      
      * Some more cleanup to reduce diff
      
      * More :clean:
      
      * Mo cleanin
      
      * small fix
      
      * A lot of changes from kian
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: default avatarkianenigma <[email protected]>
      
      * merge fallout
      
      * Run cargo +nightly fmt
      
      * Fix a bunch of stuff, remove not needed runtime arg of make-bags
      
      * add logs
      
      * Glue the new staking bags to the election snapshot (#9415)
      
      * Glue the new staking bags to the election snapshot
      
      * add CheckedRem (#9412)
      
      * add CheckedRem
      
      * fix
      
      * Run fmt
      
      * Test comment
      
      Co-authored-by: default avatarXiliang Chen <[email protected]>
      Co-authored-by: default avataremostov <[email protected]>
      
      * Update node runtime with VoterSnapshotPerBlock
      
      * Unit test for pallet-staking unsorted bags feature (targets #9081) (#9422)
      
      * impl notional_bag_for_works
      
      * Add tests: insert_as_works & insert_works
      
      * Impl test: remove_works
      
      * Trivial cleaning
      
      * Add test: update_position_for_works
      
      * Write out edge case; probably can delete later
      
      * Add test: bags::get_works
      
      * Add test: remove_node_happy_path_works
      
      * Add test: remove_node_bad_paths_documented
      
      * WIP: voting_data_works
      
      * done
      
      * Improve test voting_data_works
      
      * Add comment
      
      * Fill out test basic_setup_works
      
      * Update: iteration_is_semi_sorted
      
      * Improve remove_works
      
      * Update update_position_for_works; create set_ledger_and_free_balance
      
      * Improve get_works
      
      * Improve storage clean up checks in remove test
      
      * Test: impl rebag_works + insert_and_remove_works
      
      * forgot file -  Test: impl rebag_works + insert_and_remove_works
      
      * Small tweak
      
      * Update voter_bags test to reflect unused bags are removed
      
      * Unbond & Rebond: do_rebag
      
      * Prevent infinite loops with duplicate tail insert
      
      * Check iter.count on voter list in pre-migrate
      
      * undo strang fmt comment stuff
      
      * Add in todo
      
      Co-authored-by: default avatarkianenigma <[email protected]>
      
      * Try prepare for master merge
      
      * Reduce diff
      
      * Add comment for test to add
      
      * Add in code TODO for update_position efficiency updates
      
      * Initial impl compiles
      
      * impl StakingVoterListStub
      
      * Sample impl<T: Config> VoterListProvider<T> for VoterList<T>
      
      * impl VoterListProvider for voter-bags
      
      * WIP integrate pallet-voter-bags to staking mock
      
      * the trait `pallet_staking::pallet::pallet::Config` is not implemented for `mock::Test`
      
      * random
      
      * pushing my stuff
      
      * Mock working
      
      * WIP voter list tests
      
      * Add bag insert, remove tests
      
      * Add test for bag insert and remove
      
      * Add remaining tests for VoterList
      
      * Add tests for node
      
      * Add rebag works
      
      * Add rebag extrinsic tests
      
      * Rename to bags-list and name the list .. list!
      
      * Rename VoterBagThresholds => BagThresholds
      
      * Add test count_works
      
      * Test on_update_works
      
      * test sanity check
      
      * a round of test fixes
      
      * push a lot of changes
      
      * my last changes
      
      * all bags-list test work; fmt
      
      * Beautify some tests
      
      * Doc comment for bags-list
      
      * Add insert warnings
      
      * Setup initial benchmark
      
      * Wire up WeightInfo
      
      * is_terminal wip; everything broken!
      
      * Is terminal working
      
      * add TODOs for remove_node
      
      * clean up remoe_node
      
      * Fix all staking tests
      
      * retire VoterBagFor
      
      * commit
      
      * bring in stashed changes
      
      * save
      
      * bench pipeline works now, but I can't run stuff
      
      * sabe
      
      * benchmarks now run, but we have a failure
      
      * WIP: Wire up make_bags
      
      * bags-thresholds compiles
      
      * Fix most build issues
      
      * This will fix all the tests
      
      * move bag thresholds to bags-list
      
      * Move bag-thresholds bin to within pallet-bags
      
      * Remove some unnescary TODOs
      
      * Impl tets wrong_rebag_is_noop
      
      * assert remove is a noop with bad data
      
      * Assert integrity test panics
      
      * Return an error when inserting duplicates
      
      * Update to handle error in staking pallet when inserting to list
      
      * Test contains and on_insert error
      
      * Test re-nominate does not mess up list or count
      
      * Everything builds and works, only the benchmark...
      
      * fuck yeah benchmarks
      
      * more cleanup, more hardening.
      
      * use the bags list again
      
      * fix benhc
      
      * Some questions and changs for List::migration
      
      * Fix migration removed_bags and new_bags usage
      
      * Some trivial aesthetic changes
      
      * Some more trivial changes
      
      * tiny changes/
      
      * mega rename
      
      * fix all tests and ci build
      
      * nit
      
      * Test and fix migration
      
      * nit
      
      * fmt
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * fmt
      
      * remove unused
      
      * make a few things pub
      
      * make node also pub.. for remote-ext test
      
      * Fix all tests again
      
      * Force bag changes in relevant benchmarks (targets #9507) (#9529)
      
      * force rebag for unbond, rebond, and bond_extra
      
      * nit
      
      * Improve utils
      
      * fmt
      
      * nits
      
      * Move generate_bags to its own pallet
      
      * Get runtime-benchmarks feature setup with prepare_on_update_benchmark
      
      * Withdraw unbonded kill working
      
      * Nominate bench working
      
      * some cleanup
      
      * WIP
      
      * update to check head pre & post conditions
      
      * Add some post condition verification stuff for on_remove
      
      * Update nominate
      
      * fmt
      
      * Improvements
      
      * Fix build
      
      * fix build with polkadot companion
      
      * Update frame/bags-list/src/list/tests.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * move generate-bag from frame to utils
      
      * wip
      
      * refactor WIP
      
      * WIP save
      
      * Refactor working
      
      * some variable renaming
      
      * WIP: prepare to remove head checks
      
      * Finish MvP refactor
      
      * Some cleanup
      
      * Soem more cleanup
      
      * save
      
      * fix a lot of stuff
      
      * Update client/db/src/bench.rs
      
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * Apply suggestions from code review
      
      * Apply suggestions from code review
      
      * Fix some issues that came from trying to merge comments on github
      
      * some small changes
      
      * simplify it
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: default avatarkianenigma <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      
      * Build works
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Remove commented out debug assert
      
      * Remove some unused deps and some unused benchmarking stuff
      
      * Fix stakings ElectionDataProvider clear
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Improving staking pallet-bags-list migration
      
      * fix build and some comments;
      
      * comment
      
      * Reduce visibility in bags list components
      
      * make node.bag_upper only accesible to benchmarks
      
      * Address some feedback; comments updates
      
      * use nominator map comment
      
      * fix vec capacity debug assert
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * clarify VoterSnapshotPerBlock
      
      * Reduce diff on create_validators by wrapping with_seed
      
      * Some small improvements to staking benches
      
      * Soem comment updates
      
      * fix vec capacity debug assert ... for real this time
      
      * Reduce ListBags viz
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Remove supports_eq_unordered & Support eq_unordered
      
      * Update utils/frame/generate-bags/src/lib.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Make total-issuance & minimium-balance CLI args; Dont use emptry ext
      
      * Improve docs for generate bags CLI args
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Don't use default bags weight in node runtime
      
      * Feature gating sanity_check not working
      
      * Feature gate sanity check by creating duplicate fns
      
      * Fix line wrapping
      
      * Document VoteWeightProvider
      
      * Make bags ext-builder not a module
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * use pallet_bags_list instead of crate in mock
      
      * Make get_bags test helper fn live in List
      
      * use remove_from_storage_unchecked for node removal
      
      * Remove count of ids removed in remove_many
      
      * Add node sanity check, improve list sanity check
      
      * Do a list sanity check after on_update
      
      * List::migrate: clean up debug assert, exit early when no change in thresholds
      
      * Improve public doc comments for pallet_bags_list::list::List
      
      * Improve public doc comments for pallet_bags_list::list::List
      
      * Update generate bags docs
      
      * Fix grammar in bags-list benchmark
      
      * Add benchmark case for `rebag` extrinsic
      
      * Add count parameter to List::clear; WIP adding MaxEncodedLen to list'
      
      * MaxEncodeLen + generate_storage_info not working for Bag or Node
      
      * Get MaxEncodeLen derive to work
      
      * Try to correctly feature gate SortedListProvider::clear
      
      * Use u32::MAX, not u32::max_value
      
      * Get up to nominators_quota noms
      
      * SortedListProvider::clear takes an Option
      
      * Eplicitly ignore SortedListProvider return value
      
      * Fix doc comment
      
      * Update node-runtime voter snapshot per block
      
      * Add test get_max_len_voters_even_if_some_nominators_are_slashed
      
      * Add test only_iterates_max_2_times_nominators_quota
      
      * Fix generate bags cargo.toml
      
      * use sp_std vec
      
      * Remove v8 migration hooks from pallet-staking
      
      * Update npos trait
      
      * Try respect line width
      
      * cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_bags_list --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/bags-list/src/weights.rs --template=./.maintain/frame-weight-template.hbs
      
      * Update frame/bags-list/src/benchmarks.rs
      
      * Unwrap try-runtime error; remove sortedlistprovider pre upgrade len  check
      
      * trigger ci
      
      * restore
      
      * trigger ci
      
      * restore
      
      * trigger ci
      
      * revert
      
      * trigger ci
      
      * revert
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      Co-authored-by: default avatarkianenigma <[email protected]>
      Co-authored-by: default avatarXiliang Chen <[email protected]>
      Co-authored-by: default avatarParity Benchmarking Bot <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      669972a1
  37. Sep 15, 2021
    • Andrew Jones's avatar
      Enrich metadata with type information (#8615) · 49b6dfd2
      Andrew Jones authored
      
      
      * Cargo.lock after merge
      
      * Restore scale-info feature
      
      * Fully qualify TypeInfo derive
      
      * Skip PendingSwap T
      
      * Add missing skip_type_params attr
      
      * metadata docs features
      
      * Reduce pallet event attribute to struct
      
      * Cargo.lock
      
      * Update frame/balances/src/tests_composite.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Line widths check
      
      * Cargo.lock
      
      * Add scale-info/std
      
      * Update frame/system/src/lib.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Use `skip_type_params` to remove `TypeInfo` requirements on checks
      
      * Revert "Remove unused Call metadata stuff"
      
      This reverts commit 41311f85
      
      * Skip BalanceSwapAction type parameter
      
      * Remove unused event metadata macro
      
      * Update frame-metadata
      
      * Update primitives/npos-elections/compact/src/codec.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Manual TypeInfo for Header
      
      * Remove TypeInfo requirement for consts in BoundedVec etc.
      
      * Another TypeInfo bound removed
      
      * review: fix indentation
      
      * TypeInfo impls for Identity types
      
      * Add some todos to add custom TypeInfo impls
      
      * Update frame/support/procedural/src/pallet/expand/pallet_struct.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Add some todos to add custom TypeInfo impls
      
      * Add a test for manual Data TypeInfo impl
      
      * Add custom TypeInfo impl for Vote
      
      * Era custom TypeInfo crimes
      
      * Revert finality-grandpa version to 0.14.z
      
      * review: renamed module to pallet_constants_metadata
      
      * New line at end of file
      
      * Add missing scale-info/std
      
      * Update frame/support/src/storage/types/mod.rs
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      
      * Remove StorageEntryType::Map unused flag
      
      * Add missing scale-info dependency after merge
      
      * SignedExtension::AdditionalSigned metadata
      
      * Update frame-metadata, use abbreviated docs and args fields
      
      * Update frame/example/Cargo.toml
      
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      
      * Add scale_info/std and remove unused scale-info dependency
      
      * Remove scale-info dependency
      
      * Remove treasury pallet::metadata
      
      * Remove redundant Event test
      
      * Add back scale-info as dev dependency
      
      * fix error metadata when no error defined in decl_module
      
      * Add Module3 to tests
      
      * Fix metadata test
      
      * Add docs feature to frame-support test
      
      * WIP fixing pallet metadata test
      
      * Remove redundant FunctionMetadata, FunctionArgumentMetadata as per https://github.com/paritytech/frame-metadata/pull/20
      
      * Use main branch of frame-metadata
      
      * Use patch of scale-info for latest changes
      
      * Use latest patched scale-info
      
      * Manual TypeInfo for DigestItem
      
      * Manual TypeInfo for DigestItem
      
      * Update scale-info
      
      * Skip __Ignore variants for Error, depends on https://github.com/paritytech/scale-info/pull/117
      
      * Named fields for FRAME v2 pallet Call variants
      
      * Named fields for FRAME v1 pallet Call variants
      
      * Add missing scale-info dependency
      
      * WIP expand benchmark call variant
      
      * fix benchmark with new function
      
      create a new function for each variant of a pallet call.
      This function is called by benchmarking macro in order not to break call
      creation with unnamed argument
      
      * fix tests
      
      * more fix
      
      * Fix staking tests
      
      * Fix offchain workers calls
      
      * Cherry pick rustfmt.toml from master
      
      * cargo +nightly-2021-06-22 fmt --all
      
      * Update to new call variant structs
      
      * More call variant struct updates
      
      * Remove unused import
      
      * More call variant structs
      
      * More call variant structs
      
      * Even more call variant structs
      
      * Mooar variant structs
      
      * Evermore variant structs
      
      * Call variant structs ad infinitum
      
      * Fmt
      
      * More call variants
      
      * Last call variant
      
      * Call variants all done?
      
      * Fix SS58Prefix type
      
      * Potential workaround for BitFlags<IdentityFields> TypeInfo
      
      * Enable docs capturing for Call, Event, and Error types
      
      * Fix IdentityFields TypeInfo
      
      * Remove metadata-docs feature
      
      * Add capture_docs = true for legacy Call, Event and Error types
      
      * Fmt
      
      * Fix metadata test type
      
      * Update benchmarks with call struct variants
      
      * Fmt
      
      * More test fixes
      
      * Fmt
      
      * Fix benches
      
      * Use latest capture_docs attr
      
      * Latest scale_info
      
      * Fmt
      
      * review: change &Vec to &[]
      
      * Remove pallet metadata attr
      
      * review: remove commented out test code
      
      * review: skip_type_params trailing comma suggestion
      
      * Update to scale-info 0.10.0
      
      * Update construct_runtime ui tests, different because of metadata TypeInfo impls
      
      * Add some TypeInfo derives for UI tests
      
      * Update storage ensure span ui stderrs
      
      * Update call argument bound ui tests
      
      Possibly changed because change from tuple to struct variants?
      
      * Add scale-info dev dependency
      
      * Update to latest finality-grandpa release
      
      * review: missing newline
      
      * review: missing scale-info/std
      
      * review: remove duplicate scale-info/std
      
      * review: remove fully qualified TypeInfo
      
      * review: add missing scale-info/std
      
      * review: remove unnecessary imports.
      
      * Fmt
      
      * Use crates.io RC version of frame-metadata
      
      * Remove scale-info/std because it is a dev dependency
      
      * Add missing scale_info dev-dependency for test
      
      * Delete empty metadata folder
      
      * Fix sp_std import
      
      * review: improve manual UncheckedExtrinsic TypeInfo impl
      
      * review: use full scale-info for dev-dependency
      
      * Remove DefaultByteGetter impl
      
      * review: derive TypeInfo for generic header
      
      * Fmt
      
      * Update primitives/runtime/src/generic/unchecked_extrinsic.rs
      
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      
      * Update primitives/runtime/src/generic/unchecked_extrinsic.rs
      
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      
      * Update bin/node/executor/Cargo.toml
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Update frame/identity/src/types.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Update frame/support/src/dispatch.rs
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * Remove redundant derive
      
      * Simplify scale-info dependency
      
      * Strip underscore prefix from call variant struct names
      
      * Another underscore field
      
      * More underscore fields
      
      * Another underscore field
      
      * Update to frame-metadata 14.0.0-rc.2 with combined StorageEntryType::Map
      
      * Fmt
      
      * Revert weights formatting
      
      * Fix up some tests
      
      * Fix up some tests for StorageEntryTypeMetadata
      
      * scale-info dev dependency
      
      * Fix test error
      
      * Add missing TypeInfo derives
      
      * Add back missing scale-info dependency
      
      * Add back missing scale-info dependency
      
      * Fix npos compact impls
      
      * Cargo.lock
      
      * Fmt
      
      * Fix errors
      
      * Fmt
      
      * Fix renamed raw_solution field
      
      * Fix error
      
      * Fmt
      
      * Fix some benchmarks
      
      * Fmt
      
      * Stray R
      
      * Fix
      
      * Add missing TypeInfos
      
      * ui test fix
      
      * Fix line widths
      
      * Revert "ui test fix"
      
      This reverts commit 2d15ec058a216e3f92d713f1174603a2bb1eac65.
      
      * Upgrade to scale-info 0.11.0
      
      * Revert "Upgrade to scale-info 0.11.0"
      
      This reverts commit 047bb179085a0059c36cd20ab405f55cf0867e28.
      
      * Add Runtime type
      
      * Update to scale-info 0.12
      
      * Update to scale-info 1.0
      
      * Update frame-metadata to version 14.0.0
      
      * Patch finality-grandpa until release available
      
      * Fix metadata tests
      
      * Fix metadata tests
      
      * Fmt
      
      * Remove patched finality-grandpa
      
      * Fix tests, use scale_info imports
      
      * Fix pallet tests
      
      * Add BlockNumber TypeInfo bound
      
      * ui test fix
      
      * Cargo.lock
      
      * Remove pallet metadata
      
      * Cargo.lock
      
      * Add missing scale-info dependency
      
      * Remove pallet event metadata
      
      * Fix error
      
      * Fix collective errors
      
      * Semicolol
      
      * Fmt
      
      * Remove another metadata attribute
      
      * Add new variant to custom digest TypeInfo
      
      * Fmt
      
      * Cargo.lock from master
      
      * Remove comma lol
      
      * Fix example call error
      
      * Fix example call error properly
      
      Co-authored-by: default avatarGuillaume Thiolliere <[email protected]>
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      Co-authored-by: default avatarShawn Tabrizi <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      49b6dfd2