Skip to content
  1. Mar 16, 2023
    • Alexander Theißen's avatar
      contracts: Simplify benchmarks (#13595) · 91bb2d29
      Alexander Theißen authored
      * Remove batching
      
      * Benchmark in bytes not kilobytes
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts
      
      * Add rationale for picking batch numbers
      
      ---------
      
      Co-authored-by: command-bot <>
      91bb2d29
    • Oliver Tale-Yazdi's avatar
      Update all weights (#13614) · 3a3d93af
      Oliver Tale-Yazdi authored
      
      
      * Empty commit
      
      * ".git/.scripts/commands/bench/bench.sh" all
      
      ---------
      
      Co-authored-by: default avatarAlexander Theißen <[email protected]>
      Co-authored-by: command-bot <>
      3a3d93af
    • Mira Ressel's avatar
      refactor cargo-check-benches logic · b117dbdf
      Mira Ressel authored
      * fix fetch refspec
      * assume base is master if the api call fails
      * merge master into pr branch rather than the other way around; same
        effect but imo cleaner and more readable
      * don't re-fetch pr branch, we want to test the version our pipeline is
        running on
      b117dbdf
    • Mira Ressel's avatar
      fix BASE lookup in cargo-check-benches · 3a9e37c0
      Mira Ressel authored
      3a9e37c0
    • Gonçalo Pestana's avatar
      Integration tests for staking + election-provider-multi-phase (#12972) · ce08e135
      Gonçalo Pestana authored
      
      
      * EPM and staking pallets: Adds new crate for integration tests
      
      a
      
      * Adds ExtBuilder and helpers with initial conditions assertions
      
      * removes account helpers; adds staking, session, etc genesis
      
      * Adds kusama incident test case
      
      * Prepare for slashing test
      
      * Adds solution submission
      
      * slash_through_offending_threshold
      
      * Renames e2e integration tests dir and crate
      
      * consistently slash 10% of validator set
      
      * finishes continous_slashes_below_offending_threshold test
      
      * Update frame/election-provider-multi-phase/test-staking-e2e/src/lib.rs
      
      Co-authored-by: default avatarAnkan <[email protected]>
      
      * Update frame/election-provider-multi-phase/test-staking-e2e/src/lib.rs
      
      Co-authored-by: default avatarAnkan <[email protected]>
      
      * Update frame/election-provider-multi-phase/test-staking-e2e/src/lib.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/election-provider-multi-phase/test-staking-e2e/src/mock.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/election-provider-multi-phase/test-staking-e2e/src/mock.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * Update frame/election-provider-multi-phase/test-staking-e2e/src/mock.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * mock fixes
      
      * Additional checks to delayed solution eras and mock fixes
      
      * nits and addresses review comments; splits ext_builder into one per pallet
      
      * helper to set balances ext builder
      
      * bring up mock.rs to master
      
      * integration test fixes and additions
      
      ---------
      
      Co-authored-by: default avatarAnkan <[email protected]>
      Co-authored-by: default avatarKian Paimani <[email protected]>
      ce08e135
    • Bastian Köcher's avatar
      Try to fix flaky `temp-base-path-work` test (#13505) · 3e73b755
      Bastian Köcher authored
      
      
      * Try to fix flaky `temp-base-path-work` test
      
      The test is most of the time failing when checking if the database path was deleted. The assumption
      is that it takes a little bit more time by the OS to actually clean up the temp path under high
      load. The pr tries to fix this by checking multiple times if the path was deleted. Besides that it
      also ensures that the tests that require the benchmark feature don't fail when compiled without the feature.
      
      * ".git/.scripts/commands/fmt/fmt.sh"
      
      * Capture signals earlier
      
      * Rewrite tests to let them having one big timeout
      
      * Remove unneeded dep
      
      * Update bin/node/cli/tests/common.rs
      
      Co-authored-by: default avatarKoute <[email protected]>
      
      * Review feedback
      
      * Update bin/node/cli/tests/common.rs
      
      Co-authored-by: default avatarAnton <[email protected]>
      
      ---------
      
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarKoute <[email protected]>
      Co-authored-by: default avatarAnton <[email protected]>
      3e73b755
    • Adrian Catangiu's avatar
      sc-consensus-beefy: improve beefy gossip validator (#13606) · 3708b156
      Adrian Catangiu authored
      
      
      * sc-consensus-beefy: improve beefy gossip validator
      
      Old gossip validator was pretty dumb, being very permissive with
      incoming votes - only condition it had was to be newer than best
      finalized.
      
      New filter conditions:
       - voter rounds are initialized (discarding votes until voter is
         actually active),
       - only votes for current active set id are accepted,
       - only votes for rounds in the current voting session are accepted,
       - only votes for GRANDPA finalized blocks are accepted,
       - when BEEFY voter reaches mandatory round, only votes for said
         mandatory round are accepted.
      
      New validator uses the VoterOracle to easily implement above conditions
      and only allow through votes that are immediately useful to the voter.
      
      After every GRANDPA or BEEFY finality, the gossip validator filter is
      updated.
      
      * sc-consensus-beefy: remove votes enqueueing
      
      Since gossip validator will simply disallow votes for future rounds,
      and only allow votes that the voter can immediately process, there
      is no need for the voter to enqueue votes.
      
      It will see these "future" votes later in rebroadcasts, when voter
      will also be able to process them. Only at that point does gossip
      accept and consume them.
      
      * sc-consensus-beefy: refactor persistent state
      
      Move best-beefy and best-grandpa into VoterOracle instead
      of passing them around as params.
      VoterOracle ultimately needs to know best-beefy and/or best-grandpa
      for most of its functions.
      
      * sc-consensus-beefy: further restrict gossip validator
      
      Assuming mandatory done in current session:
      Instead of allowing votes for any round in the current session, only
      accept votes for rounds equal or better than best BEEFY finalized.
      
      * sc-consensus-beefy: add a couple of comments
      
      * sc-consensus-beefy: fix tests involving multiple tasks
      
      Finalize blocks one a time in tests where we want gossip to happen
      in a certain round. Otherwise, some tasks may be left behind in
      terms of gossip round numbers because once "scheduled" a task will
      greedily process as much as possible.
      
      This change should be in line with the real-world scenario where
      voters run "in parallel" across nodes, the only points of
      synchronization being the finality notifications.
      
      * sc-consensus-beefy: address review comments
      
      ---------
      
      Signed-off-by: default avataracatangiu <[email protected]>
      3708b156
    • Sacha Lansky's avatar
      Fix typos (#13616) · 3d6d2954
      Sacha Lansky authored
      3d6d2954
  2. Mar 15, 2023
  3. Mar 14, 2023
  4. Mar 13, 2023
    • Bastian Köcher's avatar
      sc-slots: Cleanup (#13590) · c5aee09d
      Bastian Köcher authored
      Calculate remaining proposal duration once and also use proposal time as timeout for creating the
      inherent data.
      c5aee09d
    • Alexandru Vasile's avatar
      Metadata V15: Expose pallet documentation (#13452) · 4cbf855e
      Alexandru Vasile authored
      
      
      * frame/proc: Helpers to parse pallet documentation attributes
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      
      * frame/proc: Expand pallet with runtime metadata documentation
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      
      * frame/dispatch: Implement doc function getter for dispatch
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      
      * frame/tests: Check exposed runtime metadata documentation
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      
      * frame/tests: Add UI tests for `pallet_doc` attribute
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      
      * frame/proc: Document pallet_doc attribute
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      
      * frame/support: Use `derive_syn_parse`
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      
      * Update frame/support/procedural/src/lib.rs
      
      Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
      
      * frame/support: Improve documentation
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      
      ---------
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      Co-authored-by: parity-processbot <>
      Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
      4cbf855e
    • Dino Pačandi's avatar
      Pallet assets improvements (#13543) · efd5d98e
      Dino Pačandi authored
      efd5d98e
    • Vivek Pandya's avatar
      Remove use of trait Store from all pallets and deprecate it. (#13535) · 2009821c
      Vivek Pandya authored
      * Remove use of trait Store from staking pallet
      
      * Remove use of trait Store from bounties pallet
      
      * Remove use of trait Store from collective pallet
      
      * Remove use of trait Store from babe pallet
      
      * Remove use of trait Store from assets pallet
      
      * Remove use of trait Store from grandpa pallet
      
      * Remove use of trait Store from balances pallet
      
      * Remove use of trait Store from authorship pallet
      
      * Remove use of trait Store from authority-discovery pallet
      
      * Remove use of trait Store from atomic-swap pallet
      
      * Remove use of trait Store from sudo pallet
      
      * Remove use of trait Store from scheduler pallet
      
      * Remove use of trait Store from scored-pool pallet
      
      * Remove use of trait Store from society pallet
      
      * Remove use of trait Store from lottery pallet
      
      * Remove use of trait Store from executive pallet
      
      * Remove use of trait Store from democracy pallet
      
      * Remove use of trait Store from elections-phragmen pallet
      
      * Remove use of trait Store from indices pallet
      
      * Remove use of trait Store from identity pallet
      
      * Remove use of trait Store from multisig pallet
      
      * Remove use of trait Store from merkle-mountain-range pallet
      
      * Remove use of trait Store from im-online pallet
      
      * Remove use of trait Store from membership pallet
      
      * Remove use of trait Store from nicks pallet
      
      * Remove use of trait Store from session pallet
      
      * Remove use of trait Store from transaction-payment pallet
      
      * Remove use of trait Store from utility pallet
      
      * Remove use of trait Store from child-bounties pallet
      
      * Remove use of trait Store from nis pallet
      
      * Remove use of trait Store from nfts pallet
      
      * Remove use of trait Store from conviction-voting pallet
      
      * Remove use of trait Store from treasury pallet
      
      * Remove use of trait Store from vesting pallet
      
      * Remove use of trait Store from preimage pallet
      
      * Remove use of trait Store from uniques pallet
      
      * Remove use of trait Store from ranked-collective pallet
      
      * Remove use of trait Store from beefy-mmr pallet
      
      * Remove use of trait Store from referenda pallet
      
      * Remove use of trait Store from whitelist pallet
      
      * Remove use of trait Store from alliance pallet
      
      * Remove use of trait Store from nomination-pools pallet
      
      * Remove use of trait Store from state-trie-migration pallet
      
      * Remove use of trait Store from message-queue pallet
      
      * Remove use of trait Store from root-offences pallet
      
      * Remove use of trait Store from root-testing pallet
      
      * Remove use of trait Store from timestamps pallet
      
      * Remove use of trait Store from system pallet
      
      * Remove use of trait Store from offences pallet
      
      * Remove use of trait Store from recovery pallet
      
      * Remove use of trait Store from node-authorization pallet
      
      * Remove use of trait Store from proxy pallet
      
      * Remove use of trait Store from benchmarking pallet
      
      * Remove use of trait Store from bags-list pallet
      
      * Add deprecated warning in store_trait
      
      * Change warning message
      
      * Run cargo fmt
      
      * Fix warning and update tests
      
      * Remove unnecessary allow deprecated
      
      * Remove use of trait Store
      
      * Fix mismatch in expected output
      
      * Minor update to warning message for deprecation of generate_store with Store trait attribute
      
      * Fixes as per review comments
      
      * Fixes as per review suggestions
      
      * Remove use of Store trait from core-fellowship pallet
      
      * Fix type in store_trait.rs
      
      * Fixes as pre review comment
      2009821c
    • Jegor Sidorenko's avatar
      [NFTs] Rework permissions model (#13482) · f6b9e056
      Jegor Sidorenko authored
      * Disallow admin to transfer or burn items he doesn't own
      
      * lock_collection should be accessible by collection's owner only
      
      * Allow admin to access lock_item_properties()
      
      * Fix do_lock_item_properties
      
      * Move update_mint_settings() to Issuer
      
      * Rename check_owner to check_origin
      
      * Typo
      
      * Make admin to be in charge of managing the metadata
      
      * Make admin the main attributes manager
      
      * offchain mint should be signed by Issuer
      
      * Remove the special case when the Issuer calls the mint() function
      
      * Rework burn and destroy methods
      
      * Return back item_metadatas
      
      * Don't repatriate the deposit on transfer
      
      * A bit more tests
      
      * One more test
      
      * Add migration
      
      * Chore
      
      * Clippy
      
      * Rename to owned_item
      
      * Address comments
      
      * Replace .filter_map with .find_map
      
      * Improve version validation in pre_upgrade()
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nfts
      
      ---------
      
      Co-authored-by: parity-processbot <>
      f6b9e056
  5. Mar 11, 2023
  6. Mar 10, 2023
  7. Mar 09, 2023
  8. Mar 08, 2023
  9. Mar 07, 2023
    • Luke Schoen's avatar
      fix: Fixes #13071 change order of ldd command and update ./docker/README.md (#13072) · 1c92bd5c
      Luke Schoen authored
      * fixes #13071
      
      * remove warning
      1c92bd5c
    • Davide Galassi's avatar
      Offences report system rework (#13425) · 9dd10d13
      Davide Galassi authored
      * Experiments with common equivocation trait
      
      * Improved equivocation trait
      
      * Fix grandpa equivocation implementation
      
      * Remove some cruft
      
      * Remove some more cruft
      
      * More generic naming
      
      * Simplification of offences manipilation
      
      * More refactory
      
      * Some prograss with the encapsulation of offence report system
      
      * Finally unit type works as a universal null report system
      
      * Align substrate node code
      
      * Further simplification
      
      * Fix test utils
      
      * Remove not required associated type
      
      * Fix benches
      
      * Rollback to prev field name
      
      * Box big params
      
      * Fix typo
      
      * Remove new tag computation
      
      * Remove default implementations
      
      * Better docs
      
      * Return 'Result' instead of bool
      
      * Change offence report system return types
      
      * Some renaming and documentation
      
      * Improve documentation
      
      * More abstract offence report system
      
      * Rename 'consume_evidence' to 'process_evidence'
      
      * Further docs refinements
      
      * Doc for dummy offence report
      
      * Fix rustdoc
      
      * Fix after master merge
      
      * Apply code review suggestions
      
      * Improve docs
      9dd10d13