Skip to content
  1. Mar 15, 2023
    • Mira Ressel's avatar
      timestamp gitlab ci job outputs (#13605) · 8945c1bd
      Mira Ressel authored
      * timestamp gitlab ci job outputs
      
      Based on previous work by @alvicsam in #13047.
      
      * inline timestamp script
      
      Some of our jobs don't check out the substrate repo.
      
      * include .timestamp in pipelines overriding the default before_script
      
      Still not including it in the zombienet jobs, they have their own
      timestamping anyway.
      
      * move timestamp.yml to shared pipeline repo
      
      https://gitlab.parity.io/parity/infrastructure/ci_cd/shared
      8945c1bd
    • Kian Paimani's avatar
      Pallet dispatchable+storage doc module. (#13341) · 992a53f3
      Kian Paimani authored
      
      
      * doc-only pallet
      
      * cargo fmt
      
      * generics fix for dispatchables
      
      * use a module instead
      
      * add doc comment warning that the dispatchable functions are generated
      
      * clean up
      
      * fix typo
      
      * hide Instance4-Instance16 from `pallet` module docs
      
      * revamp Instance1-16 comment
      
      * Document storage types
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * fmt
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * remove unused variables
      
      * crate::Call => Call
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * fix indentation
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * remove unneeded block
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * don't need a Vec
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * add "doc only" to coment
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * crate::Call => Call
      
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      
      * cargo fmt
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      Co-authored-by: default avatarSam Johnson <[email protected]>
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      Co-authored-by: parity-processbot <>
      992a53f3
    • Ross Bulat's avatar
      Nomination Pool Commission (#13128) · 20d5e358
      Ross Bulat authored
      
      
      * + nomination pool commission
      
      * fmt
      
      * use register_update()
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarGonçalo Pestana <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarGonçalo Pestana <[email protected]>
      
      * fmt
      
      * amend comments
      
      * + test for set_commission
      
      * fix
      
      * Update frame/nomination-pools/fuzzer/src/call.rs
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * rm comment
      
      * use PalletError
      
      * some feedback item amendments
      
      * update weights
      
      * revert PalletError stuff
      
      * ".git/.scripts/commands/fmt/fmt.sh"
      
      * make pool_events_since_last_call more modular
      
      * fmt
      
      * fix call indexes + test
      
      * add payout teste
      
      * add event to max_commisson updating current
      
      * begin refactor
      
      * some debugging
      
      * update
      
      * more tests
      
      * rewardpol not working
      
      * commission refactor
      
      * pending rewards returns commission
      
      * fmt
      
      * add claim_commission call
      
      * + claim_commission
      
      * fix benchmarks
      
      * weight 0 for now
      
      * + claim_commission benchmark
      
      * fmt
      
      * apply commission to benchmarks
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nomination_pools
      
      * ".git/.scripts/commands/fmt/fmt.sh"
      
      * clippy
      
      * + pending
      
      * add RewardPool.total_rewards_acounted
      
      * fixes
      
      * println
      
      * more logs
      
      * Fix plus cleanups
      
      * fix assert
      
      * tidy up
      
      * tests work + tidy up
      
      * rm unused
      
      * clippy fix
      
      * persist reward_pool update
      
      * claim_commission_works tests
      
      * .
      
      * some test formatting
      
      * add high level docs
      
      * add calls
      
      * docs
      
      * rename
      
      * rename
      
      * docs
      
      * rename
      
      * fmt
      
      * use matches!
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarGonçalo Pestana <[email protected]>
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarGonçalo Pestana <[email protected]>
      
      * Update frame/nomination-pools/src/tests.rs
      
      Co-authored-by: default avatarGonçalo Pestana <[email protected]>
      
      * comment
      
      * Update frame/nomination-pools/src/lib.rs
      
      Co-authored-by: default avatarGonçalo Pestana <[email protected]>
      
      * .
      
      * weights order
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nomination_pools
      
      * use from_parts
      
      * comment
      
      * ".git/.scripts/commands/fmt/fmt.sh"
      
      * revert clippy suggestions on old migrations
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nomination_pools
      
      * add InitialGlobalMaxCommission
      
      * fix migration
      
      * reward counter comments & explanations
      
      * format
      
      * add commission implementation note
      
      * fmt
      
      * revert InitialGlobalMaxCommission
      
      * global max commission migration generic
      
      * text
      
      * 100% commission no payout test
      
      * add commission_accumulates_on_multiple_rewards
      
      * non-zero fuzzer GlobalMaxCommission
      
      * add last_recorded_total_payouts_needs_commission
      
      * commission event fix + claim commission test
      
      ---------
      
      Co-authored-by: default avatarGonçalo Pestana <[email protected]>
      Co-authored-by: default avatarKian Paimani <[email protected]>
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      20d5e358
  2. Mar 14, 2023
  3. Mar 13, 2023
    • Bastian Köcher's avatar
      sc-slots: Cleanup (#13590) · c5aee09d
      Bastian Köcher authored
      Calculate remaining proposal duration once and also use proposal time as timeout for creating the
      inherent data.
      c5aee09d
    • Alexandru Vasile's avatar
      Metadata V15: Expose pallet documentation (#13452) · 4cbf855e
      Alexandru Vasile authored
      
      
      * frame/proc: Helpers to parse pallet documentation attributes
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      
      * frame/proc: Expand pallet with runtime metadata documentation
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      
      * frame/dispatch: Implement doc function getter for dispatch
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      
      * frame/tests: Check exposed runtime metadata documentation
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      
      * frame/tests: Add UI tests for `pallet_doc` attribute
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      
      * frame/proc: Document pallet_doc attribute
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      
      * frame/support: Use `derive_syn_parse`
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      
      * Update frame/support/procedural/src/lib.rs
      
      Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
      
      * frame/support: Improve documentation
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      
      ---------
      
      Signed-off-by: default avatarAlexandru Vasile <[email protected]>
      Co-authored-by: parity-processbot <>
      Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
      4cbf855e
    • Dino Pačandi's avatar
      Pallet assets improvements (#13543) · efd5d98e
      Dino Pačandi authored
      efd5d98e
    • Vivek Pandya's avatar
      Remove use of trait Store from all pallets and deprecate it. (#13535) · 2009821c
      Vivek Pandya authored
      * Remove use of trait Store from staking pallet
      
      * Remove use of trait Store from bounties pallet
      
      * Remove use of trait Store from collective pallet
      
      * Remove use of trait Store from babe pallet
      
      * Remove use of trait Store from assets pallet
      
      * Remove use of trait Store from grandpa pallet
      
      * Remove use of trait Store from balances pallet
      
      * Remove use of trait Store from authorship pallet
      
      * Remove use of trait Store from authority-discovery pallet
      
      * Remove use of trait Store from atomic-swap pallet
      
      * Remove use of trait Store from sudo pallet
      
      * Remove use of trait Store from scheduler pallet
      
      * Remove use of trait Store from scored-pool pallet
      
      * Remove use of trait Store from society pallet
      
      * Remove use of trait Store from lottery pallet
      
      * Remove use of trait Store from executive pallet
      
      * Remove use of trait Store from democracy pallet
      
      * Remove use of trait Store from elections-phragmen pallet
      
      * Remove use of trait Store from indices pallet
      
      * Remove use of trait Store from identity pallet
      
      * Remove use of trait Store from multisig pallet
      
      * Remove use of trait Store from merkle-mountain-range pallet
      
      * Remove use of trait Store from im-online pallet
      
      * Remove use of trait Store from membership pallet
      
      * Remove use of trait Store from nicks pallet
      
      * Remove use of trait Store from session pallet
      
      * Remove use of trait Store from transaction-payment pallet
      
      * Remove use of trait Store from utility pallet
      
      * Remove use of trait Store from child-bounties pallet
      
      * Remove use of trait Store from nis pallet
      
      * Remove use of trait Store from nfts pallet
      
      * Remove use of trait Store from conviction-voting pallet
      
      * Remove use of trait Store from treasury pallet
      
      * Remove use of trait Store from vesting pallet
      
      * Remove use of trait Store from preimage pallet
      
      * Remove use of trait Store from uniques pallet
      
      * Remove use of trait Store from ranked-collective pallet
      
      * Remove use of trait Store from beefy-mmr pallet
      
      * Remove use of trait Store from referenda pallet
      
      * Remove use of trait Store from whitelist pallet
      
      * Remove use of trait Store from alliance pallet
      
      * Remove use of trait Store from nomination-pools pallet
      
      * Remove use of trait Store from state-trie-migration pallet
      
      * Remove use of trait Store from message-queue pallet
      
      * Remove use of trait Store from root-offences pallet
      
      * Remove use of trait Store from root-testing pallet
      
      * Remove use of trait Store from timestamps pallet
      
      * Remove use of trait Store from system pallet
      
      * Remove use of trait Store from offences pallet
      
      * Remove use of trait Store from recovery pallet
      
      * Remove use of trait Store from node-authorization pallet
      
      * Remove use of trait Store from proxy pallet
      
      * Remove use of trait Store from benchmarking pallet
      
      * Remove use of trait Store from bags-list pallet
      
      * Add deprecated warning in store_trait
      
      * Change warning message
      
      * Run cargo fmt
      
      * Fix warning and update tests
      
      * Remove unnecessary allow deprecated
      
      * Remove use of trait Store
      
      * Fix mismatch in expected output
      
      * Minor update to warning message for deprecation of generate_store with Store trait attribute
      
      * Fixes as per review comments
      
      * Fixes as per review suggestions
      
      * Remove use of Store trait from core-fellowship pallet
      
      * Fix type in store_trait.rs
      
      * Fixes as pre review comment
      2009821c
    • Jegor Sidorenko's avatar
      [NFTs] Rework permissions model (#13482) · f6b9e056
      Jegor Sidorenko authored
      * Disallow admin to transfer or burn items he doesn't own
      
      * lock_collection should be accessible by collection's owner only
      
      * Allow admin to access lock_item_properties()
      
      * Fix do_lock_item_properties
      
      * Move update_mint_settings() to Issuer
      
      * Rename check_owner to check_origin
      
      * Typo
      
      * Make admin to be in charge of managing the metadata
      
      * Make admin the main attributes manager
      
      * offchain mint should be signed by Issuer
      
      * Remove the special case when the Issuer calls the mint() function
      
      * Rework burn and destroy methods
      
      * Return back item_metadatas
      
      * Don't repatriate the deposit on transfer
      
      * A bit more tests
      
      * One more test
      
      * Add migration
      
      * Chore
      
      * Clippy
      
      * Rename to owned_item
      
      * Address comments
      
      * Replace .filter_map with .find_map
      
      * Improve version validation in pre_upgrade()
      
      * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nfts
      
      ---------
      
      Co-authored-by: parity-processbot <>
      f6b9e056
  4. Mar 11, 2023
  5. Mar 10, 2023
  6. Mar 09, 2023
  7. Mar 08, 2023
  8. Mar 07, 2023
  9. Mar 06, 2023
    • Liu-Cheng Xu's avatar
      Expose `new_full_parts_with_genesis_builder` from sc-service (#13539) · 58d1d9e1
      Liu-Cheng Xu authored
      I forgot this in https://github.com/paritytech/substrate/pull/12291
      58d1d9e1
    • Aaro Altonen's avatar
      Extract syncing protocol from `sc-network` (#12828) · 1a7f5be0
      Aaro Altonen authored
      
      
      * Move import queue out of `sc-network`
      
      Add supplementary asynchronous API for the import queue which means
      it can be run as an independent task and communicated with through
      the `ImportQueueService`.
      
      This commit removes removes block and justification imports from
      `sc-network` and provides `ChainSync` with a handle to import queue so
      it can import blocks and justifications. Polling of the import queue is
      moved complete out of `sc-network` and `sc_consensus::Link` is
      implemented for `ChainSyncInterfaceHandled` so the import queue
      can still influence the syncing process.
      
      * Move stuff to SyncingEngine
      
      * Move `ChainSync` instanation to `SyncingEngine`
      
      Some of the tests have to be rewritten
      
      * Move peer hashmap to `SyncingEngine`
      
      * Let `SyncingEngine` to implement `ChainSyncInterface`
      
      * Introduce `SyncStatusProvider`
      
      * Move `sync_peer_(connected|disconnected)` to `SyncingEngine`
      
      * Implement `SyncEventStream`
      
      Remove `SyncConnected`/`SyncDisconnected` events from
      `NetworkEvenStream` and provide those events through
      `ChainSyncInterface` instead.
      
      Modify BEEFY/GRANDPA/transactions protocol and `NetworkGossip` to take
      `SyncEventStream` object which they listen to for incoming sync peer
      events.
      
      * Introduce `ChainSyncInterface`
      
      This interface provides a set of miscellaneous functions that other
      subsystems can use to query, for example, the syncing status.
      
      * Move event stream polling to `SyncingEngine`
      
      Subscribe to `NetworkStreamEvent` and poll the incoming notifications
      and substream events from `SyncingEngine`.
      
      The code needs refactoring.
      
      * Make `SyncingEngine` into an asynchronous runner
      
      This commits removes the last hard dependency of syncing from
      `sc-network` meaning the protocol now lives completely outside of
      `sc-network`, ignoring the hardcoded peerset entry which will be
      addressed in the future.
      
      Code needs a lot of refactoring.
      
      * Fix warnings
      
      * Code refactoring
      
      * Use `SyncingService` for BEEFY
      
      * Use `SyncingService` for GRANDPA
      
      * Remove call delegation from `NetworkService`
      
      * Remove `ChainSyncService`
      
      * Remove `ChainSync` service tests
      
      They were written for the sole purpose of verifying that `NetworWorker`
      continues to function while the calls are being dispatched to
      `ChainSync`.
      
      * Refactor code
      
      * Refactor code
      
      * Update client/finality-grandpa/src/communication/tests.rs
      
      Co-authored-by: default avatarAnton <[email protected]>
      
      * Fix warnings
      
      * Apply review comments
      
      * Fix docs
      
      * Fix test
      
      * cargo-fmt
      
      * Update client/network/sync/src/engine.rs
      
      Co-authored-by: default avatarAnton <[email protected]>
      
      * Update client/network/sync/src/engine.rs
      
      Co-authored-by: default avatarAnton <[email protected]>
      
      * Add missing docs
      
      * Refactor code
      
      ---------
      
      Co-authored-by: default avatarAnton <[email protected]>
      1a7f5be0
    • Martin Pugh's avatar
      [CI] Remove redundant trigger-review-pipeline job (#13547) · 8adde843
      Martin Pugh authored
      This job is now redundant since pipelines are run for each commit, so it can be safely removed. Cheers
      8adde843
    • yjh's avatar
      chore: reduce copy times for bytes in core-hashing (#13519) · 9b996439
      yjh authored
      * chore: reduce copy bytes for core-hashing
      
      * improve by suggestions and remove unused `xx_into`
      
      * chore: replace sha2 crate by `sp_core::hashing` for pallet-alliance
      
      * fix features
      
      * use sp-core-hashing directly
      
      * add to dev-dep
      9b996439