Skip to content
  1. Nov 27, 2021
  2. Nov 23, 2021
    • Zeke Mostov's avatar
      Inherent filtering follow up (#4305) · 90e12734
      Zeke Mostov authored
      
      
      * Add feature more feature gating for benchmarking + tests
      
      * New line
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_paras_inherent.rs
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_paras_inherent.rs
      
      * Do not assume we use max validators per core
      
      * Use kusama weights for rococo (hopefully temp)
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_paras_inherent.rs
      
      * Add more validity votes when neccesary
      
      * Some fixes for the last commit
      
      * Restore westend weights
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_paras_inherent.rs
      
      * Revert bad westend weights write
      
      * Make sure to update val idx before skipping
      
      * Fix validity vote range to max at group size'
      
      * Temp setup for rococo
      
      * cargo run --quiet --release --features runtime-benchmarks -- benchmark --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtime/rococo/src/weights/runtime_parachains_paras_inherent.rs --header=./file_header.txt
      
      * Augment generated Rococo weights
      
      * Make it compile
      
      * Revert range for enter_backed_candidates_variable
      
      * Delete runtime/kusama/src/weights/runtime_paras_paras_inherent.rs
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      90e12734
  3. Nov 19, 2021
  4. Nov 18, 2021
  5. Nov 17, 2021
  6. Nov 16, 2021
    • Bernhard Schuster's avatar
      move paras inherent filtering to runtime (#4028) · 1aa6a4ab
      Bernhard Schuster authored
      
      
      * move things around, add filter methods
      
      * validator keys, modify availability bitfields according to disputes
      
      * simplify, keep the filter -> sanitize generic for both usecases
      
      * minor
      
      * assure tests still work, reduce changeset
      
      * integration
      
      * start entropy passing
      
      * fixins
      
      * compile, 1 failing test
      
      * filter with coverage
      
      * fixins
      
      * Update runtime/parachains/src/paras_inherent.rs
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * slip of the pen
      
      * improve test cases
      
      * misc
      
      * fix
      
      * fixins
      
      * test avoid extra into() calls in assert_noop!
      
      * chores
      
      * ff
      
      * test fixup superfluous into call
      
      * chore: pfmt
      
      * improve apply_block_weight_limit to try to maximize the number of sufficiently backed
      
      blocks and add extra bitfields in a round-robin fashion
      
      * new code treats the lack of backed candidates as ok
      
      * Use vrf based entropy
      
      * fixup vrf random
      
      * add warn
      
      * slip of the pen
      
      * fixup
      
      * assure ordering
      
      * rethink apply_weights
      
      * mock
      
      * use a closure as predicate check
      
      * extract and use DisputedBitfield
      
      * chore: simplify
      
      * remove stray dbg
      
      * chore: fmt
      
      * address feedback
      
      * fix test, halfway there
      
      * stage1
      
      * dbg stuff
      
      * make group selection align
      
      * fix session index
      
      * fix wrongly returned candidates
      
      * cleanup
      
      * chore fmt
      
      * fix ensure check
      
      * make good case test work
      
      * more tests for bitfields
      
      * create sanitize_backed_candidates
      
      * fixup tests
      
      * update guide
      
      * add check referenced in the guide
      
      * improve weights code
      
      * fmt
      
      * fixins
      
      * Update roadmap/implementers-guide/src/runtime/inclusion.md
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * compiling + address review
      
      * add comments
      
      * fix weight calc
      
      * address review comments and test failure
      
      * fix
      
      * fix: condition
      
      * Fix random_sel function
      
      * Fix overlength block check
      
      * Zeke + Ladi commit for disputes filtering + integration test builder + runtime benchmarks + integration tests
      
      * Add benchmarks for code upgrades
      
      * Code upgrade bench; Feature gate TestWeightInfo
      
      * Try and make CI happier
      
      * Feature gate enter test to not(benchmarks)
      
      * Make sure no unused imports/fn
      
      * refactor, re-use, the beginning
      
      * Fix issue with frame benchmarking dep compilation
      
      * More precise feature gating for some derives
      
      * integrate piece-wise
      
      * foo
      
      * fixins
      
      * chore fmt
      
      * fixins
      
      * rename const generic
      
      * Update runtime/parachains/src/paras_inherent.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Fix compilation
      
      * limit to test
      
      * remove unused spam slots
      
      * spellcheck
      
      * remove a tick, fix a typo
      
      * Add Code upgrade weights
      
      * comment improvements + >=
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * remove another tick
      
      * Update runtime/parachains/src/paras_inherent/benchmarking.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * saturating fixins + some spaces
      
      * fix
      
      * benchmarking - preliminary results
      
      * Add training wheels
      
      * Refactor some early exit logic for enter
      
      * Gracefully handle filtering bitfields & candidates (#4280)
      
      This updates the logic for sanitize_bitfields and sanitize_backed_candidates to never error when there is an issue, but instead to simply skip the problematic items.
      
      * Refactor inherent data weight limiting logic (#4287)
      
      * Apply suggestions from code review
      
      * Update runtime/parachains/src/builder.rs
      
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      
      * Update runtime/parachains/src/builder.rs
      
      * Update runtime/parachains/src/paras_inherent.rs
      
      * final pass
      
      * Run cargo +nightly-2021-10-29 fmt
      
      * Update implementors guide with `sanitize_*` & `enter` (#4294)
      
      * Make spell check happier
      
      * Make wasm runtimes compile with benchmarks enabled (#4303)
      
      * comment stuff out, use old toml
      
      * Seems to be working?
      
      * Remove feature gating from builder
      
      * Remove commented out stuff
      
      * Remove generic from digest
      
      * Update weight files for runtime
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      Co-authored-by: default avatarLldenaurois <[email protected]>
      Co-authored-by: default avatarZeke Mostov <[email protected]>
      Co-authored-by: default avatarBastian Köcher <[email protected]>
      1aa6a4ab
    • dependabot[bot]'s avatar
      Bump serde_json from 1.0.69 to 1.0.70 (#4284) · 02c6ed32
      dependabot[bot] authored
      
      
      Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.69 to 1.0.70.
      - [Release notes](https://github.com/serde-rs/json/releases)
      - [Commits](https://github.com/serde-rs/json/compare/v1.0.69...v1.0.70)
      
      ---
      updated-dependencies:
      - dependency-name: serde_json
        dependency-type: direct:production
        update-type: version-update:semver-patch
      ...
      
      Signed-off-by: default avatardependabot[bot] <[email protected]>
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      02c6ed32
  7. Nov 15, 2021
  8. Nov 13, 2021
  9. Nov 12, 2021
  10. Nov 09, 2021
  11. Nov 04, 2021
  12. Oct 29, 2021
    • Bastian Köcher's avatar
      Introduce `OriginPrivilegeCmp` (#4166) · e0d6b95a
      Bastian Köcher authored
      * Introduce `OriginPrivilegeCmp`
      
      Make use of the new `OriginPrivilegeCmp` feature of pallet scheduler.
      The idea is to make sure that a council origin with more yes votes has
      higher privileges than a council origin with less yes votes. This solves
      a problem that happened recently on Kusama where the council tried to
      cancel a scheduled task, but that required that the same council origin
      was used while the cancel motion had more yes votes than the origin
      motion that scheduled this task. With this origin privilege compare it
      should now be solved by checking the yes votes directly.
      
      * Feedback
      
      * update lockfile for substrate
      
      Co-authored-by: parity-processbot <>
      e0d6b95a
  13. Oct 27, 2021
    • Shawn Tabrizi's avatar
      Fix XCM Teleport Benchmark (#4146) · 1031a57d
      Shawn Tabrizi authored
      
      
      * fix xcm benchmark
      
      * fix overflow
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::fungible --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs
      
      * fix spelling
      
      * fmt
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::fungible --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      1031a57d
    • Gavin Wood's avatar
      Allow Queries and Subscriptions (#4150) · d7513f53
      Gavin Wood authored
      * Allow Queries and Subscriptions
      
      * Formatting
      
      * Formatting
      d7513f53
  14. Oct 25, 2021
  15. Oct 22, 2021
  16. Oct 20, 2021
  17. Oct 15, 2021
  18. Oct 12, 2021
  19. Oct 08, 2021
  20. Oct 06, 2021
    • Bernhard Schuster's avatar
      collect included disputes from on-chain (#3924) · 30bdc8f5
      Bernhard Schuster authored
      
      
      * dummy: impl another runtime API
      
      * query the on chain disputes, and inform self
      
      * make use of the refactor
      
      * minro
      
      * SPLIT ME
      
      * write dispute values
      
      * wip
      
      * impl for all runtimes
      
      * chore: fmt
      
      * [] -> get
      
      * fixup mock runtime
      
      * fixup
      
      * fixup discovery for overseer init
      
      * chore: fmt
      
      * spellcheck
      
      * rename imported_on_chain_disputes -> on_chain_votes
      
      * reduction
      
      * make it mockable
      
      * rename and refactor
      
      * don't query on chain info if it's not needed
      
      * yikes
      
      * fmt
      
      * fix test
      
      * minimal fix for existing tests
      
      * attempt to fetch the session info from the rolling window before falling back
      
      * moved
      
      * comments
      
      * comments
      
      * test for backing votes
      
      * rename
      
      * Update runtime/polkadot/src/lib.rs
      
      * chore: spellcheck + dict
      
      * chore: fmt
      
      * fixup cache size
      
      * add warning
      
      * logging, rationale, less defense
      
      * introduce new unchecked, that still checks in debug builds
      
      * fix
      
      * draft alt approach
      
      * fix unused imports
      
      * include the session
      
      * Update node/core/dispute-coordinator/src/real/mod.rs
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * provide where possible
      
      * expand comment
      
      * fixin
      
      * fixup
      
      * ValidityVote <-> ValidityAttestation <-> CompactStatement has a 1:1 representation
      
      * mark TODO
      
      * Update primitives/src/v1/mod.rs
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      
      * address review comments
      
      * update docs
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      30bdc8f5
    • André Silva's avatar
      Companion for substrate#9448 (#3527) · 9bdded5f
      André Silva authored
      
      
      * Companion for substrate#9448
      
      * fix on_disabled
      
      * use temporary beefy branch
      
      * revert beefy updates
      
      * update Substrate
      
      Co-authored-by: default avatarAndronik Ordian <[email protected]>
      Co-authored-by: parity-processbot <>
      9bdded5f
    • Kian Paimani's avatar
  21. Oct 05, 2021
    • Shawn Tabrizi's avatar
      Allow an Offset to Lease Periods (#3980) · d6d37621
      Shawn Tabrizi authored
      
      
      * add slot offset for slots
      
      * trying things out
      
      * fix test
      
      * improve api to return the first block of a new lease period
      
      * add an integration test with offset
      
      * de-duplicate test
      
      * hide lease period_period_length from public api
      
      * fix benchmarks
      
      * Update runtime/common/src/slots.rs
      
      * support the exact same range of crowdloans
      
      * fix docs
      
      * fix docs again
      
      * introduce offset to runtimes
      
      * fix and check edge case w/ offset and lease period first block
      
      * remove newline
      
      * turn into an option
      
      * fix benchmarks
      
      Co-authored-by: default avatarRobert Habermeier <[email protected]>
      d6d37621
  22. Oct 04, 2021
  23. Sep 30, 2021
  24. Sep 29, 2021
  25. Sep 28, 2021
    • Keith Yeung's avatar
      Add benchmarking for parachain runtime initializer pallet (#3913) · 7da1421b
      Keith Yeung authored
      
      
      * Add benchmarking for parachain runtime initializer pallet
      
      * Fix default impl for initializer pallet WeightInfo
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::initializer --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_initializer.rs
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::initializer --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_initializer.rs
      
      * Use real weights and use max_block as default weight
      
      * Add variable for digest vec length for initializer benchmark
      
      * Fix compilation errors
      
      * Add WeightInfo to parachains_initializer config in polkadot runtime
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::initializer --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_initializer.rs
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::initializer --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_initializer.rs
      
      * Appease spellchecker
      
      * Use kusama weights in polkadot runtime for parachain initializer pallet
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      7da1421b
  26. Sep 27, 2021
    • Shawn Tabrizi's avatar
      XCM Benchmarks for Asset Transactor w/ Fungible Asset (#3818) · 7c8804c0
      Shawn Tabrizi authored
      
      
      * benchmarks for fungibles
      
      * add benchmark to westend
      
      * fix hex
      
      * clean up a bit
      
      * update code doc
      
      * fix warnings
      
      * cargo run --quiet --release --features runtime-benchmarks -- benchmark --chain=westend-dev --pallet=pallet_xcm_benchmarks::fungible --extrinsic=* --steps=10 --repeat=10 --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./ --execution=wasm --wasm-execution=compiled
      
      * use skip
      
      * fix spelling
      
      * Update Cargo.lock
      
      * add scale-info
      
      * Update Cargo.lock
      
      * update bench
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::fungible --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs
      
      * weights compile
      
      * update westend to use weights
      
      * fmt
      
      * spelling fixes
      
      * Delete pallet_xcm_benchmarks::fungible.rs
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarKian Paimani <[email protected]>
      
      * fix code review
      
      * update weight
      
      * fix report_error
      
      * fix spell check
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      Co-authored-by: default avatarKian Paimani <[email protected]>
      7c8804c0
  27. Sep 24, 2021
  28. Sep 23, 2021
  29. Sep 22, 2021
    • Georges's avatar
      Companion for Generate storage info for pallet babe #9760 (#3831) · 24a141b5
      Georges authored
      
      
      * Adding MaxSegmentLength and MaxAuthorities
      to pallet babe
      
      * Missed a few to_vec
      
      * Removing `MaxSegmentLength` as not needed anymore
      
      * Adding `MaxAuthorities` to couple of missing place
      
      * Adding missing definition of `MaxAuthorities`
      
      * Adding a missing to_vec
      
      * update Substrate
      
      Co-authored-by: default avatarthiolliere <[email protected]>
      Co-authored-by: parity-processbot <>
      24a141b5
    • Kian Paimani's avatar
      Companion for substrate PR#9766 (#3900) · 8c684129
      Kian Paimani authored
      * fix weights
      
      * reduce time
      
      * update Substrate
      
      Co-authored-by: parity-processbot <>
      8c684129
    • Georges's avatar
      Companion for Generate storage info for pallet grandpa #9817 (#3892) · 9d7972ab
      Georges authored
      * Adding `MaxAuthorities` to pallet grandpa
      This is neede after changes to substrate
      
      * Adding `MaxAuthorities` to granda in test-runtime
      
      * Missed one `MaxAuthorities`
      
      * update Substrate
      
      Co-authored-by: parity-processbot <>
      9d7972ab
    • Keith Yeung's avatar
      Add benchmarking for parachain runtime paras pallet (#3888) · db0b7e00
      Keith Yeung authored
      
      
      * Crate basic barebones benchmarking infrastructure for paras
      
      * Fill in benchmarking contents
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_paras.rs
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_paras.rs
      
      * Use autogenerated WeightInfos for kusama and westend
      
      * cargo fmt
      
      * Use saturating_sub
      
      * Add missing import
      
      * Try and hit the worst possible time complexity as much as possible
      
      * cargo fmt
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_paras.rs
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_paras.rs
      
      * Add a MAX_HEAD_DATA_SIZE constant
      
      * Prefill vectors with sample data for worst case complexity
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_paras.rs
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_paras.rs
      
      * Improve comment on SAMPLE_SIZE constant
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      db0b7e00