Skip to content
  1. Jan 02, 2022
  2. Jan 01, 2022
  3. Dec 31, 2021
    • Sergey Pepyakin's avatar
      paras: fix upgrade restriction signal (#4603) · 5f6a0392
      Sergey Pepyakin authored
      Closes #3971
      
      Read the linked issue.
      
      Apart from that, this addresses the concern raised in this [comment] by
      just adding a test. I couldn't find a clean way to reconcile a block
      number delay with a PVF voting TTL, so I just resorted to rely on the
      test. Should be fine for now.
      
      [comment]: https://github.com/paritytech/polkadot/pull/4457#discussion_r770517562
      5f6a0392
  4. Dec 30, 2021
    • Sergey Pepyakin's avatar
      configuration: Rename validation_upgrade_{frequency -> cooldown} (#4635) · 72a92eaf
      Sergey Pepyakin authored
      This just renames a member of `HostConfiguration` from
      validation_upgrade_frequency to -//-_cooldown.
      
      As was already pointed out in #4460 the existing name is a misnomer, the
      member actually represents a minimum time period between upgrades, which
      is neatly expressed by a word cooldown.
      
      I've been planning this rename already for some time and the term is
      already used in paras module:
      
      https://github.com/paritytech/polkadot/blob/1394b70d/runtime/parachains/src/paras.rs#L1568-L1574
      72a92eaf
  5. Dec 29, 2021
    • dependabot[bot]'s avatar
      Bump lru from 0.7.1 to 0.7.2 (#4633) · 86a9658f
      dependabot[bot] authored
      
      
      Bumps [lru](https://github.com/jeromefroe/lru-rs) from 0.7.1 to 0.7.2.
      - [Release notes](https://github.com/jeromefroe/lru-rs/releases)
      - [Changelog](https://github.com/jeromefroe/lru-rs/blob/master/CHANGELOG.md)
      - [Commits](https://github.com/jeromefroe/lru-rs/compare/0.7.1...0.7.2)
      
      ---
      updated-dependencies:
      - dependency-name: lru
        dependency-type: direct:production
        update-type: version-update:semver-patch
      ...
      
      Signed-off-by: default avatardependabot[bot] <[email protected]>
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      86a9658f
    • Sergey Pepyakin's avatar
      paras: add governance control dispatchables (#4575) · 4bf62d85
      Sergey Pepyakin authored
      
      
      * paras: add governance control dispatchables
      
      Adds a couple of functions for governance control for the paras module
      in the anticipation of PVF pre-checking enabling.
      
      Specifically, this commit adds a function for pre-registering a PVF that
      governance trusts enough. This function will come in handy in case there
      is a parachain that does not follow the GoAhead signal. That is, does
      not include https://github.com/paritytech/cumulus/pull/517.
      
      This may be not an exhaustive list of the functions that may come in
      handy. Any suggestions to add more are welcome.
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_paras.rs
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_paras.rs
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_paras.rs
      
      * cargo run --quiet --release --features runtime-benchmarks -- benchmark --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/rococo/src/weights/runtime_parachains_paras.rs
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      4bf62d85
    • ordian's avatar
      custom cargo profiles for production (#4627) · a44349f6
      ordian authored
      
      
      * add custom profiles and specify MSVR as 1.57
      
      * fix host-perf-check command
      
      * use testnet profile for CI images
      
      * do not do lto for testnet profile
      
      * fix artifact path
      
      * test with testnet profile to reuse build artifacts
      
      * Revert "fix host-perf-check command"
      
      This reverts commit f1d15492204b8251685a97636cbb5a5f394f21da.
      
      * bump zombienet version
      
      Co-authored-by: default avatarJavier Viola <[email protected]>
      a44349f6
    • Sergey Pepyakin's avatar
      pvf-precheck: update implementers' guide (#4612) · 1394b70d
      Sergey Pepyakin authored
      
      
      This commit incorporates the changes made to the runtime in the
      following PRs:
      
      - https://github.com/paritytech/polkadot/pull/4408
      - https://github.com/paritytech/polkadot/pull/4457
      - https://github.com/paritytech/polkadot/pull/4540
      - https://github.com/paritytech/polkadot/pull/4542
      - https://github.com/paritytech/polkadot/pull/4581
      
      Note that this PR does not include the description of the PVF
      pre-checker subsystem. This should be addressed within
      https://github.com/paritytech/polkadot/issues/4611
      
      Co-authored-by: default avatarsandreim <[email protected]>
      1394b70d
    • Keith Yeung's avatar
      Use derive macro to generate XcmWeightInfo trait (#4618) · cf509bdb
      Keith Yeung authored
      * Use derive macro to generate XcmWeightInfo trait
      
      * Move the Weight type alias out of proc macro
      cf509bdb
    • dependabot[bot]'s avatar
      Bump proc-macro2 from 1.0.34 to 1.0.36 (#4619) · ebfe0b71
      dependabot[bot] authored
      
      
      Bumps [proc-macro2](https://github.com/dtolnay/proc-macro2) from 1.0.34 to 1.0.36.
      - [Release notes](https://github.com/dtolnay/proc-macro2/releases)
      - [Commits](https://github.com/dtolnay/proc-macro2/compare/1.0.34...1.0.36)
      
      ---
      updated-dependencies:
      - dependency-name: proc-macro2
        dependency-type: direct:production
        update-type: version-update:semver-patch
      ...
      
      Signed-off-by: default avatardependabot[bot] <[email protected]>
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      ebfe0b71
  6. Dec 28, 2021
  7. Dec 27, 2021
    • sandreim's avatar
      Bump sleep from 10 to 30s (#4613) · 979fa1f5
      sandreim authored
      
      
      Signed-off-by: default avatarAndrei Sandu <[email protected]>
      979fa1f5
    • Sergey Pepyakin's avatar
      configuration: Unified consistency checks (#4581) · 4d768787
      Sergey Pepyakin authored
      This commit refactors the consistency checks. Instead of each individual
      setter performs its checks locally, we delegate those checks to the
      already existing function `check_consistency`. This removes duplication
      and simplifies the logic.
      
      A motivating example of this one is the next PR in the stack that will
      introduce a check for a field, which validity depends on the validity of
      other two fields. Without this refactoring we will have to place a check
      not only to the field in question, but also to the other two fields so
      that if they are changed they do not violate consistency criteria. It's
      easy to imagine how this can go unwieldy with the number of checks.
      
      This also adds a test that verifies that the default chain spec host
      configuration is consistent.
      4d768787
    • ordian's avatar
      zombienet: fixed adder-collator image for the smoke test (#4600) · d077ac2c
      ordian authored
      
      
      * zombinet: fixed adder-collator image for the smoke test
      
      * update COL_IMAGE
      
      * bump zombienet version
      
      * try a different version
      
      Co-authored-by: default avatarJavier Viola <[email protected]>
      d077ac2c
    • João Paulo Silva de Souza's avatar
      make check-dependent-* only be executed in PRs (#4588) · b3e36538
      João Paulo Silva de Souza authored
      Make check-dependent-* jobs only be executed in PRs instead of both PRs and
      master.
      
      Reason 1: The companion is not merged at the same time as the parent PR
      ([1](https://github.com/paritytech/parity-processbot/issues/347#issuecomment-994729950)),
      therefore the pipeline will fail on master since the companion PR is not yet
      merged in the other repository. This scenario is demonstrated by the pipeline
      of
      https://github.com/paritytech/substrate/commit/82cc3746450ae9722a249f4ddf83b8de59ba6e0d.
      
      Reason 2: The job can still fail on master due to a new commit on the companion
      PR's repository which was merged after `bot merge` happened, as demonstrated by
      the following scheme:
      
      1. Parent PR is merged
      2. Companion PR is updated and set to merge in the future
      3. In the meantime a new commit is merged into the companion PR repository's
        master branch
      4. The `check-dependent-*` job runs on master but, due to the new commit, it
        fails for unrelated reasons
      
      While "Reason 2" can be used as an argument against this PR, in that it would
      be useful to know if the integration is failing on master, "Reason 1" should be
      taken care of due to this inherent flaw of the current companion build system
      design.
      b3e36538
    • ordian's avatar
      9efb223a
    • ordian's avatar
      session-info: add new fields + migration (#4545) · b342ae11
      ordian authored
      
      
      * session_info: v2 + migration
      
      * use primitives::v2
      
      * use polkadot_primitives::v2
      
      * impl primitives::v2
      
      * fix approval-voting tests
      
      * fix other tests
      
      * hook storage migration up
      
      * backwards compat (1)
      
      * backwards compat (2)
      
      * fmt
      
      * fix tests
      
      * FMT
      
      * do not reexport v1 in v2
      
      * fmt
      
      * set storage version to 1
      
      Co-authored-by: default avatarJavier Viola <[email protected]>
      b342ae11
  8. Dec 25, 2021
  9. Dec 24, 2021
    • cheme's avatar
      Companion for substrate#9732 (#4104) · 48dc6750
      cheme authored
      * merge master (do not compile)
      
      * fix
      
      * lock
      
      * update lock
      
      * Update to refactoring.
      
      * runtime version
      
      * fmt
      
      * remove trie patch
      
      * remove patch
      
      * No layout alias for bridge proof.
      
      * update depupdate depss
      
      * No switch until migration.
      
      * master lock
      
      * test
      
      * test
      
      * Revert "test"
      
      This reverts commit 57325ef73332bf4b054aa4a667bb716fcf8a0d89.
      
      * Revert "test"
      
      This reverts commit ce74d0e2062806f72c0e9e9ca07b14165f43521e.
      
      * rename feature
      
      * state version as parameter, use the feature only on runtimes.
      
      * update
      
      * update to state version in runtime
      
      * state version from storage
      
      * update lockfile for substrate
      
      Co-authored-by: parity-processbot <>
      48dc6750
    • Robert Klotzner's avatar
      03495958
  10. Dec 23, 2021
    • Bastian Köcher's avatar
      Fix checking for the `ParachainHost` runtime api (#4594) · b409837b
      Bastian Köcher authored
      The function `has_api` checks that the api + version matches, which
      isn't true anymore after bumping the version. The fix is to just compare
      the runtime api version being at least `1`.
      b409837b
    • Bastian Köcher's avatar
      runtime-api: Fix runtime version checking (#4595) · 97506a15
      Bastian Köcher authored
      The runtime version check `runtime_version <= version` was wrong, it
      needs to be `>=`. Besides that the `WIDELY_DEPLOYED_API_VERSION` is
      removed. The runtime version is already cached, aka we don't always call
      into the runtime when requesting the runtime version. So, there is no
      need to "optimize" this.
      97506a15
    • dependabot[bot]'s avatar
      Bump syn from 1.0.82 to 1.0.83 (#4590) · 18a47cf2
      dependabot[bot] authored
      
      
      Bumps [syn](https://github.com/dtolnay/syn) from 1.0.82 to 1.0.83.
      - [Release notes](https://github.com/dtolnay/syn/releases)
      - [Commits](https://github.com/dtolnay/syn/compare/1.0.82...1.0.83)
      
      ---
      updated-dependencies:
      - dependency-name: syn
        dependency-type: direct:production
        update-type: version-update:semver-patch
      ...
      
      Signed-off-by: default avatardependabot[bot] <[email protected]>
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      18a47cf2
    • Robert Klotzner's avatar
      First step in implementing #4386 (#4437) · 846828f6
      Robert Klotzner authored
      * First step in implementing https://github.com/paritytech/polkadot/issues/4386
      
      This PR:
      
      - Reduces MAX_UNSHARED_UPLOAD_TIME to 150ms
      - Increases timeout on collation fetching to 1200ms
      - Reduces limit on needed backing votes in the runtime
      
      This PR does not yet reduce the number of needed backing votes on the
      node as this can only be meaningfully enacted once the changed limit in
      the runtime is live.
      
      * Fix tests.
      
      * Guide updates.
      
      * Review remarks.
      
      * Bump minimum required backing votes to 2 in runtime.
      
      * Make sure node side code won't make runtime vomit.
      
      * cargo +nightly fmt
      846828f6
  11. Dec 22, 2021
  12. Dec 21, 2021
    • asynchronous rob's avatar
      Fix currently-checking-cache (#4410) · ca358e12
      asynchronous rob authored
      
      
      * alter currently-checking-set to launch work only on new candidates
      
      * fmt
      
      * fix compilation
      
      * address review
      
      * Introduce approvals cache test that ensures approval work is only triggered once for each Candidate Hash
      
      * Fix formatting
      
      * Address Feedback
      
      * Move final message await into handle function
      
      Co-authored-by: default avatarChris Sosnin <[email protected]>
      Co-authored-by: default avatarLldenaurois <[email protected]>
      ca358e12
    • Adrian Catangiu's avatar
      Companion for Substrate#10445 (#4506) · 30423f79
      Adrian Catangiu authored
      * runtimes: use updated BeefyApi
      
      * update lockfile for substrate
      30423f79
    • Sergey Pepyakin's avatar
      pvf-precheck: update rustdoc for paras module (#4459) · 0e046a00
      Sergey Pepyakin authored
      Basically updates the docs for the paras module.
      0e046a00
    • Sergey Pepyakin's avatar
      pvf-precheck: hook up runtime API (#4542) · 3cb138d2
      Sergey Pepyakin authored
      
      
      This commit hooks up the API provided by #4457 to the runtime API
      subsystem. In a following PR this API will be consumed by the PVF
      pre-checking subsystem.
      
      Co-authored-by: default avatarChris Sosnin <[email protected]>
      
      Co-authored-by: default avatarChris Sosnin <[email protected]>
      3cb138d2
    • Sergey Pepyakin's avatar
      parachains: Fix configuration module (#4540) · 5a3ee43c
      Sergey Pepyakin authored
      
      
      * parachains: Fix configuration module
      
      Closes #4529
      Closes #4533
      
      I figured that trying to avoid updates does not really worth it to keep.
      This is because we seem to not update the configuration often and when
      we do we approach this carefully. Thus possibility of a redundant update
      is really negligable. At the same time, if such a redundant update does
      happen then the effects of that are really small: just some wasted
      storage interactions.
      
      On the other hand, making it work was a little bit annoying. With the
      proper fix for the pending updates this would be even more annoying
      since now we would have to add combinatorically more cases to test this.
      
      So I figured that I will just scrap that and simplify the code.
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::configuration --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_configuration.rs
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::configuration --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_configuration.rs
      
      * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::configuration --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_configuration.rs
      
      * review fixes
      
      Co-authored-by: default avatarParity Bot <[email protected]>
      5a3ee43c
    • dependabot[bot]'s avatar
      Bump bounded-vec from 0.4.0 to 0.5.0 (#4082) · 478ac958
      dependabot[bot] authored
      
      
      Bumps [bounded-vec](https://github.com/ergoplatform/bounded-vec) from 0.4.0 to 0.5.0.
      - [Release notes](https://github.com/ergoplatform/bounded-vec/releases)
      - [Changelog](https://github.com/ergoplatform/bounded-vec/blob/develop/CHANGELOG.md)
      - [Commits](https://github.com/ergoplatform/bounded-vec/compare/v0.4.0...v0.5.0)
      
      ---
      updated-dependencies:
      - dependency-name: bounded-vec
        dependency-type: direct:production
        update-type: version-update:semver-minor
      ...
      
      Signed-off-by: default avatardependabot[bot] <[email protected]>
      
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      478ac958