1. Jan 16, 2023
    • Bastian Köcher's avatar
      pallet-offences-benchmarking: Box events in verify (#13151) · 52a56e5f
      Bastian Köcher authored
      * pallet-offences-benchmarking: Box events in verify
      
      Events in frame are represented by an enum in the pallet and the runtime. The size of an enum in
      Rust depends on the size of biggest variant. This means we always need to allocate memory for the
      biggest variant when allocating memory for an event. The offences benchmarking is verifying the
      benchmarking results by checking the events. To check the events it is generating all the expected
      events. With the recent changes in Polkadot the events are too big and lead to issues when running
      this verify functions. The solution is to box each event, as the vector holding all the events will
      then only need to hold fat pointers * expected events, instead of size_of(event) * expected events.
      This issue isn't a problem in production, as we never read the events on chain. When we are reading
      the events, it is done in an offchain context and they are only decoded one by one.
      
      Besides that this also enables the benchmarking verification for everyone running these benchmarks.
      
      * FMT
      
      * Disable checking again
      52a56e5f
  2. Jan 15, 2023
  3. Jan 13, 2023
  4. Jan 12, 2023
  5. Jan 11, 2023
  6. Jan 10, 2023
  7. Jan 09, 2023
  8. Jan 08, 2023
  9. Jan 07, 2023
  10. Jan 06, 2023
  11. Jan 05, 2023
  12. Jan 04, 2023