Skip to content
  1. Mar 14, 2023
    • Bastian Köcher's avatar
      sp-api: Support expanding the macro code (#13573) · 4ef1d0df
      Bastian Köcher authored 
      * sp-api: Support expanding the macro code

This pr introduces the `expander` crate to expand the generated source code into a file. This gives
better error reporting when trying to fix issues in the macro itself as Rustc will point to the line
in this file. The feature can be enabled by setting `SP_API_EXPAND=1` at compile time.

Besides that the generated code is changed to fix warnings in the exanped version.

* Fixes
      4ef1d0df
    • cheme's avatar
      update trie deps (#13601) · ef165cec
      cheme authored
      ef165cec
    • Adrian Catangiu's avatar
      sc-consensus-beefy: fix on-demand async state machine (#13599) · 81a02cb7
      Adrian Catangiu authored 
      

`futures_util::pending!()` macro only yields to the event loop once,
resulting in many calls to the `OnDemandJustificationsEngine::next()`
made by the tokio reactor even though the on-demand-engine is idle.

Replace it with the correct `futures::future::pending::<()>()` function
which forever yields to the event loop, which is what we want when
the engine is idle.

Signed-off-by: default avatarAdrian Catangiu <[email protected]>
      81a02cb7
    • Aaro Altonen's avatar
      Move code from `sc-network-common` back to `sc-network` (#13592) · 9ced14e2
      Aaro Altonen authored 
      

* Move service tests to `client/network/tests`

These tests depend on `sc-network` and `sc-network-sync` so they should
live outside the crate.

* Move some configs from `sc-network-common` to `sc-network`

* Move `NetworkService` traits to `sc-network`

* Move request-responses to `sc-network`

* Remove more stuff

* Remove rest of configs from `sc-network-common` to `sc-network`

* Remove more stuff

* Fix warnings

* Update client/network/src/request_responses.rs

Co-authored-by: default avatarDmitry Markin <[email protected]>

* Fix cargo doc

---------

Co-authored-by: default avatarDmitry Markin <[email protected]>
      9ced14e2
    • Jegor Sidorenko's avatar
      [NFTs] Allow to set the role to None (#13591) · 5d718e45
      Jegor Sidorenko authored 
      * Allow to unset the role

* Chore

* Array instead of vec

---------

Co-authored-by: parity-processbot <>
      5d718e45
  3. Mar 13, 2023
    • Bastian Köcher's avatar
      sc-slots: Cleanup (#13590) · c5aee09d
      Bastian Köcher authored 
      Calculate remaining proposal duration once and also use proposal time as timeout for creating the
inherent data.
      c5aee09d
    • Alexandru Vasile's avatar
      Metadata V15: Expose pallet documentation (#13452) · 4cbf855e
      Alexandru Vasile authored 
      

* frame/proc: Helpers to parse pallet documentation attributes

Signed-off-by: default avatarAlexandru Vasile <[email protected]>

* frame/proc: Expand pallet with runtime metadata documentation

Signed-off-by: default avatarAlexandru Vasile <[email protected]>

* frame/dispatch: Implement doc function getter for dispatch

Signed-off-by: default avatarAlexandru Vasile <[email protected]>

* frame/tests: Check exposed runtime metadata documentation

Signed-off-by: default avatarAlexandru Vasile <[email protected]>

* frame/tests: Add UI tests for `pallet_doc` attribute

Signed-off-by: default avatarAlexandru Vasile <[email protected]>

* frame/proc: Document pallet_doc attribute

Signed-off-by: default avatarAlexandru Vasile <[email protected]>

* frame/support: Use `derive_syn_parse`

Signed-off-by: default avatarAlexandru Vasile <[email protected]>

* Update frame/support/procedural/src/lib.rs

Co-authored-by: default avatarNiklas Adolfsson <[email protected]>

* frame/support: Improve documentation

Signed-off-by: default avatarAlexandru Vasile <[email protected]>

---------

Signed-off-by: default avatarAlexandru Vasile <[email protected]>
Co-authored-by: parity-processbot <>
Co-authored-by: default avatarNiklas Adolfsson <[email protected]>
      4cbf855e
    • Dino Pačandi's avatar
      Pallet assets improvements (#13543) · efd5d98e
      Dino Pačandi authored
      efd5d98e
    • Vivek Pandya's avatar
      Remove use of trait Store from all pallets and deprecate it. (#13535) · 2009821c
      Vivek Pandya authored 
      * Remove use of trait Store from staking pallet

* Remove use of trait Store from bounties pallet

* Remove use of trait Store from collective pallet

* Remove use of trait Store from babe pallet

* Remove use of trait Store from assets pallet

* Remove use of trait Store from grandpa pallet

* Remove use of trait Store from balances pallet

* Remove use of trait Store from authorship pallet

* Remove use of trait Store from authority-discovery pallet

* Remove use of trait Store from atomic-swap pallet

* Remove use of trait Store from sudo pallet

* Remove use of trait Store from scheduler pallet

* Remove use of trait Store from scored-pool pallet

* Remove use of trait Store from society pallet

* Remove use of trait Store from lottery pallet

* Remove use of trait Store from executive pallet

* Remove use of trait Store from democracy pallet

* Remove use of trait Store from elections-phragmen pallet

* Remove use of trait Store from indices pallet

* Remove use of trait Store from identity pallet

* Remove use of trait Store from multisig pallet

* Remove use of trait Store from merkle-mountain-range pallet

* Remove use of trait Store from im-online pallet

* Remove use of trait Store from membership pallet

* Remove use of trait Store from nicks pallet

* Remove use of trait Store from session pallet

* Remove use of trait Store from transaction-payment pallet

* Remove use of trait Store from utility pallet

* Remove use of trait Store from child-bounties pallet

* Remove use of trait Store from nis pallet

* Remove use of trait Store from nfts pallet

* Remove use of trait Store from conviction-voting pallet

* Remove use of trait Store from treasury pallet

* Remove use of trait Store from vesting pallet

* Remove use of trait Store from preimage pallet

* Remove use of trait Store from uniques pallet

* Remove use of trait Store from ranked-collective pallet

* Remove use of trait Store from beefy-mmr pallet

* Remove use of trait Store from referenda pallet

* Remove use of trait Store from whitelist pallet

* Remove use of trait Store from alliance pallet

* Remove use of trait Store from nomination-pools pallet

* Remove use of trait Store from state-trie-migration pallet

* Remove use of trait Store from message-queue pallet

* Remove use of trait Store from root-offences pallet

* Remove use of trait Store from root-testing pallet

* Remove use of trait Store from timestamps pallet

* Remove use of trait Store from system pallet

* Remove use of trait Store from offences pallet

* Remove use of trait Store from recovery pallet

* Remove use of trait Store from node-authorization pallet

* Remove use of trait Store from proxy pallet

* Remove use of trait Store from benchmarking pallet

* Remove use of trait Store from bags-list pallet

* Add deprecated warning in store_trait

* Change warning message

* Run cargo fmt

* Fix warning and update tests

* Remove unnecessary allow deprecated

* Remove use of trait Store

* Fix mismatch in expected output

* Minor update to warning message for deprecation of generate_store with Store trait attribute

* Fixes as per review comments

* Fixes as per review suggestions

* Remove use of Store trait from core-fellowship pallet

* Fix type in store_trait.rs

* Fixes as pre review comment
      2009821c
    • Jegor Sidorenko's avatar
      [NFTs] Rework permissions model (#13482) · f6b9e056
      Jegor Sidorenko authored 
      * Disallow admin to transfer or burn items he doesn't own

* lock_collection should be accessible by collection's owner only

* Allow admin to access lock_item_properties()

* Fix do_lock_item_properties

* Move update_mint_settings() to Issuer

* Rename check_owner to check_origin

* Typo

* Make admin to be in charge of managing the metadata

* Make admin the main attributes manager

* offchain mint should be signed by Issuer

* Remove the special case when the Issuer calls the mint() function

* Rework burn and destroy methods

* Return back item_metadatas

* Don't repatriate the deposit on transfer

* A bit more tests

* One more test

* Add migration

* Chore

* Clippy

* Rename to owned_item

* Address comments

* Replace .filter_map with .find_map

* Improve version validation in pre_upgrade()

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nfts

---------

Co-authored-by: parity-processbot <>
      f6b9e056
  5. Mar 11, 2023
  7. Mar 10, 2023
  9. Mar 09, 2023
  11. Mar 08, 2023
  13. Mar 07, 2023
  15. Mar 06, 2023
    • Liu-Cheng Xu's avatar
      Expose `new_full_parts_with_genesis_builder` from sc-service (#13539) · 58d1d9e1
      Liu-Cheng Xu authored 
      I forgot this in https://github.com/paritytech/substrate/pull/12291
      58d1d9e1
    • Aaro Altonen's avatar
      Extract syncing protocol from `sc-network` (#12828) · 1a7f5be0
      Aaro Altonen authored 
      

* Move import queue out of `sc-network`

Add supplementary asynchronous API for the import queue which means
it can be run as an independent task and communicated with through
the `ImportQueueService`.

This commit removes removes block and justification imports from
`sc-network` and provides `ChainSync` with a handle to import queue so
it can import blocks and justifications. Polling of the import queue is
moved complete out of `sc-network` and `sc_consensus::Link` is
implemented for `ChainSyncInterfaceHandled` so the import queue
can still influence the syncing process.

* Move stuff to SyncingEngine

* Move `ChainSync` instanation to `SyncingEngine`

Some of the tests have to be rewritten

* Move peer hashmap to `SyncingEngine`

* Let `SyncingEngine` to implement `ChainSyncInterface`

* Introduce `SyncStatusProvider`

* Move `sync_peer_(connected|disconnected)` to `SyncingEngine`

* Implement `SyncEventStream`

Remove `SyncConnected`/`SyncDisconnected` events from
`NetworkEvenStream` and provide those events through
`ChainSyncInterface` instead.

Modify BEEFY/GRANDPA/transactions protocol and `NetworkGossip` to take
`SyncEventStream` object which they listen to for incoming sync peer
events.

* Introduce `ChainSyncInterface`

This interface provides a set of miscellaneous functions that other
subsystems can use to query, for example, the syncing status.

* Move event stream polling to `SyncingEngine`

Subscribe to `NetworkStreamEvent` and poll the incoming notifications
and substream events from `SyncingEngine`.

The code needs refactoring.

* Make `SyncingEngine` into an asynchronous runner

This commits removes the last hard dependency of syncing from
`sc-network` meaning the protocol now lives completely outside of
`sc-network`, ignoring the hardcoded peerset entry which will be
addressed in the future.

Code needs a lot of refactoring.

* Fix warnings

* Code refactoring

* Use `SyncingService` for BEEFY

* Use `SyncingService` for GRANDPA

* Remove call delegation from `NetworkService`

* Remove `ChainSyncService`

* Remove `ChainSync` service tests

They were written for the sole purpose of verifying that `NetworWorker`
continues to function while the calls are being dispatched to
`ChainSync`.

* Refactor code

* Refactor code

* Update client/finality-grandpa/src/communication/tests.rs

Co-authored-by: default avatarAnton <[email protected]>

* Fix warnings

* Apply review comments

* Fix docs

* Fix test

* cargo-fmt

* Update client/network/sync/src/engine.rs

Co-authored-by: default avatarAnton <[email protected]>

* Update client/network/sync/src/engine.rs

Co-authored-by: default avatarAnton <[email protected]>

* Add missing docs

* Refactor code

---------

Co-authored-by: default avatarAnton <[email protected]>
      1a7f5be0
    • Martin Pugh's avatar
      [CI] Remove redundant trigger-review-pipeline job (#13547) · 8adde843
      Martin Pugh authored 
      This job is now redundant since pipelines are run for each commit, so it can be safely removed. Cheers
      8adde843
    • yjh's avatar
      chore: reduce copy times for bytes in core-hashing (#13519) · 9b996439
      yjh authored 
      * chore: reduce copy bytes for core-hashing

* improve by suggestions and remove unused `xx_into`

* chore: replace sha2 crate by `sp_core::hashing` for pallet-alliance

* fix features

* use sp-core-hashing directly

* add to dev-dep
      9b996439
    • Sasha Gryaznov's avatar
      [contracts] Forbid calling back to contracts after switching to runtime (#13443) · f85d6dc6
      Sasha Gryaznov authored 
      

* save: compiles and tests pass

* save: added global

* done + test

* cleanup

* changelog update

* cleanup

* address feedback, step 1

* address feedback, step 2

* address feedback, step 3

* returned updated gas_estimation_call_runtime test

* clippy fix

* address feedback, step 4

* address feedback, step 5

* move data from context to inputs

* docs fix

* Apply suggestions from code review

Co-authored-by: default avatarAlexander Theißen <[email protected]>

* address feedback, step 6

---------

Co-authored-by: default avatarAlexander Theißen <[email protected]>
      f85d6dc6
  17. Mar 05, 2023
  19. Mar 04, 2023