Skip to content
Snippets Groups Projects
  1. Oct 25, 2023
  2. Oct 24, 2023
    • Bastian Köcher's avatar
    • drskalman's avatar
      Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto (#1815) · fbd57771
      drskalman authored
      
      Next step in process of making BEEFY being able to generate both ECDSA
      and BLS signature after #1705. It allows BEEFY to use a pair of ECDSA
      and BLS key as a AuthorityId.
      
      ---------
      
      Co-authored-by: default avatarDavide Galassi <davxy@datawok.net>
      Co-authored-by: default avatarRobert Hambrock <roberthambrock@gmail.com>
      fbd57771
    • Alexander Samusev's avatar
      [ci] Run check-rust-feature-propagation in pr and master (#2012) · 8a79fb22
      Alexander Samusev authored
      Need to run this job in master to make it `Required`
      8a79fb22
    • Oliver Tale-Yazdi's avatar
      Improve features dev-ex (#1831) · 4a443567
      Oliver Tale-Yazdi authored
      
      Adds a config file that allows to run `zepter` without any arguments in
      the workspace to address all issues.
      A secondary workflow for the CI is provided as `zepter run check`. Both
      the formatting and linting are now in one check for efficiancy.
      
      The latest version also detects some more things that `featalign` was
      already showing.
      
      Error message [in the
      CI](https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3916205)
      now looks like this:
      ```pre
      ...
      crate 'test-parachains' (/Users/vados/Documents/work/polkadot-sdk/polkadot/parachain/test-parachains/Cargo.toml)
        feature 'std'
          must propagate to:
            parity-scale-codec
      Found 55 issues (run with --fix to fix).
      Error: Command 'lint propagate-feature' failed with exit code 1
      
      Polkadot-SDK uses the Zepter CLI to detect abnormalities in the feature configuration.
      It looks like one more more checks failed; please check the console output. You can try to automatically address them by running `zepter`.
      Otherwise please ask directly in the Merge Request, GitHub Discussions or on Matrix Chat, thank you.
      
      For more information, see:
        - https://github.com/paritytech/polkadot-sdk/issues/1831
        - https://github.com/ggwpez/zepter
      ```
      
      TODO:
      - [x] Check that CI fails correctly
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
      4a443567
    • eskimor's avatar
      Remove obsolete comment. (#2008) · 12130a76
      eskimor authored
      
      it is indeed correct.
      
      Co-authored-by: default avatareskimor <eskimor@no-such-url.com>
      12130a76
    • Tsvetomir Dimitrov's avatar
      Refactor candidates test in paras_inherent (#2004) · 0284e21f
      Tsvetomir Dimitrov authored
      Splits the test in multiple cases.
      0284e21f
    • Marcin S.'s avatar
      e39253c0
    • dependabot[bot]'s avatar
      Bump actions/setup-node from 3.8.1 to 4.0.0 (#1997) · 8cba5b90
      dependabot[bot] authored
      
      Bumps [actions/setup-node](https://github.com/actions/setup-node) from
      3.8.1 to 4.0.0.
      <details>
      <summary>Release notes</summary>
      <p><em>Sourced from <a
      href="https://github.com/actions/setup-node/releases">actions/setup-node's
      releases</a>.</em></p>
      <blockquote>
      <h2>v4.0.0</h2>
      <h2>What's Changed</h2>
      <p>In scope of this release we changed version of node runtime for
      action from node16 to node20 and updated dependencies in <a
      href="https://redirect.github.com/actions/setup-node/pull/866">actions/setup-node#866</a></p>
      <p>Besides, release contains such changes as:</p>
      <ul>
      <li>Upgrade actions/checkout to v4 by <a
      href="https://github.com/gmembre-zenika"><code>@​gmembre-zenika</code></a>
      in <a
      href="https://redirect.github.com/actions/setup-node/pull/868">actions/setup-node#868</a></li>
      <li>Update actions/checkout for documentation and yaml by <a
      href="https://github.com/dmitry-shibanov"><code>@​dmitry-shibanov</code></a>
      in <a
      href="https://redirect.github.com/actions/setup-node/pull/876">actions/setup-node#876</a></li>
      </ul>
      <h2>New Contributors</h2>
      <ul>
      <li><a
      href="https://github.com/gmembre-zenika"><code>@​gmembre-zenika</code></a>
      made their first contribution in <a
      href="https://redirect.github.com/actions/setup-node/pull/868">actions/setup-node#868</a></li>
      </ul>
      <p><strong>Full Changelog</strong>: <a
      href="https://github.com/actions/setup-node/compare/v3...v4.0.0">https://github.com/actions/setup-node/compare/v3...v4.0.0</a></p>
      <h2>v3.8.2</h2>
      <h2>What's Changed</h2>
      <ul>
      <li>Update semver by <a
      href="https://github.com/dmitry-shibanov"><code>@​dmitry-shibanov</code></a>
      in <a
      href="https://redirect.github.com/actions/setup-node/pull/861">actions/setup-node#861</a></li>
      <li>Update temp directory creation by <a
      href="https://github.com/nikolai-laevskii"><code>@​nikolai-laevskii</code></a>
      in <a
      href="https://redirect.github.com/actions/setup-node/pull/859">actions/setup-node#859</a></li>
      <li>Bump <code>@​babel/traverse</code> from 7.15.4 to 7.23.2 by <a
      href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
      href="https://redirect.github.com/actions/setup-node/pull/870">actions/setup-node#870</a></li>
      <li>Add notice about binaries not being updated yet by <a
      href="https://github.com/nikolai-laevskii"><code>@​nikolai-laevskii</code></a>
      in <a
      href="https://redirect.github.com/actions/setup-node/pull/872">actions/setup-node#872</a></li>
      <li>Update toolkit cache and core by <a
      href="https://github.com/dmitry-shibanov"><code>@​dmitry-shibanov</code></a>
      and <a
      href="https://github.com/seongwon-privatenote"><code>@​seongwon-privatenote</code></a>
      in <a
      href="https://redirect.github.com/actions/setup-node/pull/875">actions/setup-node#875</a></li>
      </ul>
      <p><strong>Full Changelog</strong>: <a
      href="https://github.com/actions/setup-node/compare/v3...v3.8.2">https://github.com/actions/setup-node/compare/v3...v3.8.2</a></p>
      </blockquote>
      </details>
      <details>
      <summary>Commits</summary>
      <ul>
      <li><a
      href="https://github.com/actions/setup-node/commit/8f152de45cc393bb48ce5d89d36b731f54556e65"><code>8f152de</code></a>
      Update actions/checkout for documentation and yaml (<a
      href="https://redirect.github.com/actions/setup-node/issues/876">#876</a>)</li>
      <li><a
      href="https://github.com/actions/setup-node/commit/23755b521f87533c8ed7f8fb13674f9021579e34"><code>23755b5</code></a>
      upgrade actions/checkout to v4 (<a
      href="https://redirect.github.com/actions/setup-node/issues/868">#868</a>)</li>
      <li><a
      href="https://github.com/actions/setup-node/commit/54534a2a9ba7308e8a8995af3104899e6a95b681"><code>54534a2</code></a>
      Change node version for action to node20 (<a
      href="https://redirect.github.com/actions/setup-node/issues/866">#866</a>)</li>
      <li><a
      href="https://github.com/actions/setup-node/commit/1a4442cacd436585916779262731d5b162bc6ec7"><code>1a4442c</code></a>
      Update toolkit cache and core (<a
      href="https://redirect.github.com/actions/setup-node/issues/875">#875</a>)</li>
      <li><a
      href="https://github.com/actions/setup-node/commit/6e9e44895f11c5489716beba7b3be1cd4d76f8e9"><code>6e9e448</code></a>
      Merge pull request <a
      href="https://redirect.github.com/actions/setup-node/issues/872">#872</a>
      from akv-platform/add-notice-about-binaries-not-being...</li>
      <li><a
      href="https://github.com/actions/setup-node/commit/e52912ef25bc38da27c83c00c3c61bbb5b7bddc3"><code>e52912e</code></a>
      Update tests</li>
      <li><a
      href="https://github.com/actions/setup-node/commit/ac16ae42d727f28d8231c7ce87ef399a68ce8d80"><code>ac16ae4</code></a>
      Update message to use waning instead of info</li>
      <li><a
      href="https://github.com/actions/setup-node/commit/5a8d9111e32e049e80167427e34aad324f306b77"><code>5a8d911</code></a>
      Update build</li>
      <li><a
      href="https://github.com/actions/setup-node/commit/9e956a555c2c3d534ac93f57280063bfa7c63468"><code>9e956a5</code></a>
      Add notice about binaries not being updated yet</li>
      <li><a
      href="https://github.com/actions/setup-node/commit/7da2a7eb0c8ca16886c2abd4199f2cdda6f64dd4"><code>7da2a7e</code></a>
      Bump <code>@​babel/traverse</code> from 7.15.4 to 7.23.2 (<a
      href="https://redirect.github.com/actions/setup-node/issues/870">#870</a>)</li>
      <li>Additional commits viewable in <a
      href="https://github.com/actions/setup-node/compare/v3.8.1...v4.0.0">compare
      view</a></li>
      </ul>
      </details>
      <br />
      
      
      [![Dependabot compatibility
      score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-node&package-manager=github_actions&previous-version=3.8.1&new-version=4.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
      
      Dependabot will resolve any conflicts with this PR as long as you don't
      alter it yourself. You can also trigger a rebase manually by commenting
      `@dependabot rebase`.
      
      [//]: # (dependabot-automerge-start)
      [//]: # (dependabot-automerge-end)
      
      ---
      
      <details>
      <summary>Dependabot commands and options</summary>
      <br />
      
      You can trigger Dependabot actions by commenting on this PR:
      - `@dependabot rebase` will rebase this PR
      - `@dependabot recreate` will recreate this PR, overwriting any edits
      that have been made to it
      - `@dependabot merge` will merge this PR after your CI passes on it
      - `@dependabot squash and merge` will squash and merge this PR after
      your CI passes on it
      - `@dependabot cancel merge` will cancel a previously requested merge
      and block automerging
      - `@dependabot reopen` will reopen this PR if it is closed
      - `@dependabot close` will close this PR and stop Dependabot recreating
      it. You can achieve the same result by closing it manually
      - `@dependabot show <dependency name> ignore conditions` will show all
      of the ignore conditions of the specified dependency
      - `@dependabot ignore this major version` will close this PR and stop
      Dependabot creating any more for this major version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this minor version` will close this PR and stop
      Dependabot creating any more for this minor version (unless you reopen
      the PR or upgrade to it yourself)
      - `@dependabot ignore this dependency` will close this PR and stop
      Dependabot creating any more for this dependency (unless you reopen the
      PR or upgrade to it yourself)
      
      
      </details>
      
      Signed-off-by: default avatardependabot[bot] <support@github.com>
      Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
      8cba5b90
    • Muharem Ismailov's avatar
      rococo benchmarks · 66a66110
      Muharem Ismailov authored
      66a66110
    • Muharem Ismailov's avatar
    • André Silva's avatar
      polkadot: enable tikv-jemallocator/unprefixed_malloc_on_supported_platforms (#2002) · 017f8d80
      André Silva authored
      This is indirectly enabled by rocksdb crate, better to make it explicit
      (https://github.com/tikv/rust-rocksdb/blob/2096b9a161f93e437f7adee49e68cd1570aea42f/librocksdb_sys/Cargo.toml#L35-L38).
      017f8d80
    • georgepisaltu's avatar
      Make `IdentityInfo` generic in `pallet-identity` (#1661) · 91851951
      georgepisaltu authored
      Fixes #179 
      
      # Description
      
      This PR makes the structure containing identity information used in
      `pallet-identity` generic through the pallet `Config`. Additionally, the
      old structure is now available in a separate module called `simple`
      (pending rename) and is compatible with the new interface.
      
      Another change in this PR is that while the `additional` field in
      `IdentityInfo` stays for backwards compatibility reasons, the associated
      costs are stil present in the pallet through the `additional` function
      in the `IdentityInformationProvider` interface. This function is marked
      as deprecated as it is only a temporary solution to the backwards
      compatibility problem we had. In short, we could have removed the
      additional fields in the struct and done a migration, but we chose to
      wait and do it off-chain through the genesis of the system parachain.
      After we move the identity pallet to the parachain, additional fields
      will be migrated into the existing fields and the `additional` key-value
      store will be removed. Until that happens, this interface will provide
      the necessary information to properly account for the associated costs.
      
      Additionally, this PR fixes an unrelated issue; the `IdentityField` enum
      used to represent the fields as bitflags couldn't store more than 8
      fields, even though it was marked as `#[repr(u64)]`. This was because of
      the `derive` implementation of `TypeInfo`, which assumed `u8` semantics.
      The custom implementation of this trait in
      https://github.com/paritytech/polkadot-sdk/commit/0105cc03
      
      
      fixes the issue.
      
      ---------
      
      Signed-off-by: default avatargeorgepisaltu <george.pisaltu@parity.io>
      Co-authored-by: default avatarSam Johnson <sam@durosoft.com>
      Co-authored-by: default avatarjoe petrowski <25483142+joepetrowski@users.noreply.github.com>
      91851951
    • Muharem Ismailov's avatar
      adjustments for rococo tests · bbca52d6
      Muharem Ismailov authored
      bbca52d6
    • Muharem Ismailov's avatar
      adjustments for rococo setup · 2b13f27e
      Muharem Ismailov authored
      2b13f27e
    • Kian Paimani's avatar
      Ensure correct variant count in `Runtime[Hold/Freeze]Reason` (#1900) · 35eb133b
      Kian Paimani authored
      
      closes https://github.com/paritytech/polkadot-sdk/issues/1882
      
      ## Breaking Changes
      
      This PR introduces a new item to `pallet_balances::Config`:
      
      ```diff
      trait Config {
      ++    type RuntimeFreezeReasons;
      }
      ```
      
      This value is only used to check it against `type MaxFreeze`. A similar
      check has been added for `MaxHolds` against `RuntimeHoldReasons`, which
      is already given to `pallet_balances`.
      
      In all contexts, you should pass the real `RuntimeFreezeReasons`
      generated by `construct_runtime` to `type RuntimeFreezeReasons`. Passing
      `()` would also work, but it would imply that the runtime uses no
      freezes at all.
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
      Co-authored-by: default avatarOliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
      35eb133b
    • Bastian Köcher's avatar
      `CheckWeight`: Add more logging (#1996) · a5a2432d
      Bastian Köcher authored
      This adds more logging to `CheckWeight` to get a better understanding
      why a transaction exhausts resources.
      a5a2432d
    • Brian Anderson's avatar
      Update wasm-opt to 0.116 (#1995) · 39c04fdd
      Brian Anderson authored
      Just keeping wasm-opt up to date.
      
      I don't see anything in the [binaryen
      changelog](https://github.com/WebAssembly/binaryen/blob/main/CHANGELOG.md)
      that should affect substrate.
      
      This release includes dwarf passes that were accidentally omitted from
      previous versions of the wasm-opt crate. I suspect this will not affect
      substrate as their omission hasn't been noticed until recently.
      39c04fdd
  3. Oct 23, 2023
    • Muharem Ismailov's avatar
    • Muharem Ismailov's avatar
      Resolve Credit to Account impls of `OnUnbalanced` trait (#1876) · d0fd2660
      Muharem Ismailov authored
      Implements the `OnUnbalanced` trait to resolve received credits to the
      specified account. Credits that fail to resolve are dropped.
      
      ### Motivation 
      Throughout the codebase, several types implement the trait with the same
      behavior. While some currently utilize older currency trait, a migration
      to the new fungible/s is anticipated for all. Examples:
      [1](https://github.com/paritytech/polkadot-sdk/blob/1b34571c/cumulus/parachains/common/src/impls.rs#L37),
      [2](https://github.com/paritytech/polkadot-sdk/blob/1b34571c/polkadot/runtime/common/src/impls.rs#L36),
      [3](https://github.com/paritytech/polkadot-sdk/blob/1b34571c/substrate/bin/node/runtime/src/impls.rs#L40),
      [4](https://github.com/paritytech/polkadot-sdk/blob/1b34571c/substrate/bin/node/runtime/src/lib.rs#L1969),
      [5](https://github.com/paritytech/polkadot-sdk/blob/1b34571c/substrate/frame/broker/src/mock.rs#L198),
      [6](https://github.com/paritytech/polkadot-sdk/blob/1b34571c/substrate/frame/society/src/lib.rs#L2031),
      [7](https://github.com/paritytech/polkadot-sdk/blob/1b34571c/substrate/frame/treasury/src/lib.rs#L1118)
      d0fd2660
    • Bastian Köcher's avatar
      Always schedule at least one job onto a core (#1990) · 676bacd7
      Bastian Köcher authored
      Even if the host configuration is returning `0` for the `lookahead`, we
      should schedule at least one job on a core if the core exists.
      676bacd7
    • Muharem Ismailov's avatar
    • ordian's avatar
      polkadot: eradicate `LeafStatus` (#1565) · 5ca909cc
      ordian authored
      Fixes #768.
      5ca909cc
    • joe petrowski's avatar
      Re-enable Identity on Westend and Rococo (#1901) · 95052437
      joe petrowski authored
      Reverts https://github.com/paritytech/polkadot-sdk/pull/1476
      
      The `lock_pallet` / `unlock_pallet` additions in
      https://github.com/paritytech/polkadot-sdk/pull/1814 will result in less
      downtime for users than using runtime upgrades.
      95052437
    • Branislav Kontur's avatar
      [testnet] BridgeHubRococo nits (#1972) · e0620fd9
      Branislav Kontur authored
      This PR does not introduce any functional changes to the existing code,
      it merely addresses several minor refactors:
      - Moving bridging pallets to separate files.
      - Improving the readability and naming of weight files for bridging
      pallets and bridging pallet instances.
      
      The reason for this refactor is to facilitate easier plugin integration
      for the upcoming bridge between Rococo and Westend.
      
      ---------
      
      Co-authored-by: command-bot <>
      e0620fd9
    • Branislav Kontur's avatar
      Remove `(rococo/westend)-runtime` deps from testnet AssetHubs (#1979) · c284a931
      Branislav Kontur authored
      ## Problem
      
      This PR addresses the issue with testnet AssetHub builds, which was
      discovered during the execution of `bot bench`.
      
      https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4038738
      ```
           Compiling asset-hub-rococo-runtime-wasm v1.0.0 (/builds/parity/mirrors/polkadot-sdk/target/production/wbuild/asset-hub-rococo-runtime)
        warning: Linking globals named 'Core_version': symbol multiply defined!
        error: failed to load bitcode of module "rococo_runtime-8799ee884447805a.rococo_runtime.0bc572b8-cgu.0.rcgu.o": 
        warning: `asset-hub-rococo-runtime-wasm` (lib) generated 1 warning
        error: could not compile `asset-hub-rococo-runtime-wasm` (lib) due to previous error; 1 warning emitted
      ```
      
      https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4038739
      ```
      Compiling asset-hub-westend-runtime-wasm v1.0.0 (/builds/parity/mirrors/polkadot-sdk/target/production/wbuild/asset-hub-westend-runtime)
        warning: Linking globals named 'Core_version': symbol multiply defined!
        error: failed to load bitcode of module "westend_runtime-86d7844430f97d5c.westend_runtime.b7678d03-cgu.0.rcgu.o": 
        warning: `asset-hub-westend-runtime-wasm` (lib) generated 1 warning
        error: could not compile `asset-hub-westend-runtime-wasm` (lib) due to previous error; 1 warning emitted
      ```
      
      ## Solution
      
      - Removed dependencies on `rococo-runtime` and `westend-runtime`
      introduced by [this
      PR](https://github.com/paritytech/polkadot-sdk/pull/1234/files#diff-a86375df98e04ca3cce1ea35c40257a222e2d5087f5f528ff33307678b78dc2dR534-R550).
      - Replaced `<rococo_runtime::Treasury as PalletInfoAccess>::index()`
      with `rococo_runtime_constants::TREASURY_PALLET_ID`.
      - Added `check_treasury_pallet_id` to the relay runtimes to ensure that
      the constant is aligned with the pallet id.
      - Added "Rococo Treasury" to the waived locations (that will not be
      charged fees in the executor) for `BridgeHubRococo` (to be aligned with
      AssetHubs).
      
      ## References
      
      [Full element discussion
      here](https://matrix.to/#/!JUeaZUiYbdrvzvtwSL:parity.io/$2PnjYMsWRjR7M3oOfGuRI0XkjdoqJLtRcAPVcDLuLVg?via=parity.io&via=web3.foundation).
      
      ---------
      
      Co-authored-by: command-bot <>
      c284a931