Remove `(rococo/westend)-runtime` deps from testnet AssetHubs (#1979)
## Problem This PR addresses the issue with testnet AssetHub builds, which was discovered during the execution of `bot bench`. https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4038738 ``` Compiling asset-hub-rococo-runtime-wasm v1.0.0 (/builds/parity/mirrors/polkadot-sdk/target/production/wbuild/asset-hub-rococo-runtime) warning: Linking globals named 'Core_version': symbol multiply defined! error: failed to load bitcode of module "rococo_runtime-8799ee884447805a.rococo_runtime.0bc572b8-cgu.0.rcgu.o": warning: `asset-hub-rococo-runtime-wasm` (lib) generated 1 warning error: could not compile `asset-hub-rococo-runtime-wasm` (lib) due to previous error; 1 warning emitted ``` https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4038739 ``` Compiling asset-hub-westend-runtime-wasm v1.0.0 (/builds/parity/mirrors/polkadot-sdk/target/production/wbuild/asset-hub-westend-runtime) warning: Linking globals named 'Core_version': symbol multiply defined! error: failed to load bitcode of module "westend_runtime-86d7844430f97d5c.westend_runtime.b7678d03-cgu.0.rcgu.o": warning: `asset-hub-westend-runtime-wasm` (lib) generated 1 warning error: could not compile `asset-hub-westend-runtime-wasm` (lib) due to previous error; 1 warning emitted ``` ## Solution - Removed dependencies on `rococo-runtime` and `westend-runtime` introduced by [this PR](https://github.com/paritytech/polkadot-sdk/pull/1234/files#diff-a86375df98e04ca3cce1ea35c40257a222e2d5087f5f528ff33307678b78dc2dR534-R550). - Replaced `<rococo_runtime::Treasury as PalletInfoAccess>::index()` with `rococo_runtime_constants::TREASURY_PALLET_ID`. - Added `check_treasury_pallet_id` to the relay runtimes to ensure that the constant is aligned with the pallet id. - Added "Rococo Treasury" to the waived locations (that will not be charged fees in the executor) for `BridgeHubRococo` (to be aligned with AssetHubs). ## References [Full element discussion here](https://matrix.to/#/!JUeaZUiYbdrvzvtwSL:parity.io/$2PnjYMsWRjR7M3oOfGuRI0XkjdoqJLtRcAPVcDLuLVg?via=parity.io&via=web3.foundation). --------- Co-authored-by: command-bot <>
Showing
- Cargo.lock 0 additions, 2 deletionsCargo.lock
- cumulus/parachains/runtimes/assets/asset-hub-rococo/Cargo.toml 0 additions, 4 deletions...us/parachains/runtimes/assets/asset-hub-rococo/Cargo.toml
- cumulus/parachains/runtimes/assets/asset-hub-rococo/src/xcm_config.rs 1 addition, 2 deletions...chains/runtimes/assets/asset-hub-rococo/src/xcm_config.rs
- cumulus/parachains/runtimes/assets/asset-hub-westend/Cargo.toml 0 additions, 4 deletions...s/parachains/runtimes/assets/asset-hub-westend/Cargo.toml
- cumulus/parachains/runtimes/assets/asset-hub-westend/src/xcm_config.rs 1 addition, 2 deletions...hains/runtimes/assets/asset-hub-westend/src/xcm_config.rs
- cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/pallet_bridge_relayers.rs 22 additions, 24 deletions...s/bridge-hub-rococo/src/weights/pallet_bridge_relayers.rs
- cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/xcm_config.rs 18 additions, 6 deletions.../runtimes/bridge-hubs/bridge-hub-rococo/src/xcm_config.rs
- polkadot/runtime/rococo/constants/src/lib.rs 3 additions, 0 deletionspolkadot/runtime/rococo/constants/src/lib.rs
- polkadot/runtime/rococo/src/lib.rs 3 additions, 56 deletionspolkadot/runtime/rococo/src/lib.rs
- polkadot/runtime/rococo/src/tests.rs 63 additions, 0 deletionspolkadot/runtime/rococo/src/tests.rs
- polkadot/runtime/westend/constants/src/lib.rs 3 additions, 0 deletionspolkadot/runtime/westend/constants/src/lib.rs
- polkadot/runtime/westend/src/tests.rs 8 additions, 0 deletionspolkadot/runtime/westend/src/tests.rs
Please register or sign in to comment