- Oct 20, 2022
-
-
Michal Kucharczyk authored
* BlockId removal: refactor: BlockImportOperation+Bknd::finalize_block It changes the arguments of methods of `BlockImportOperation` trait from: block: `BlockId<Block>` to: hash: `&Block::Hash` `Backend::finalize_block` was also changed. This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292) * Review suggestion applied thx to @davxy * trigger CI job
-
Michal Kucharczyk authored
* BlockId removal: refactor: Finalizer It changes the arguments of methods of `Finalizer` trait from: block: `BlockId<Block>` to: hash: `&Block::Hash` This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292) * minor corrections * failing test corrected * minor rework
-
- Oct 19, 2022
-
-
Alexander Theißen authored
* Decrease amount of benchmark iterations for long slow ones * ".git/.scripts/bench-bot.sh" pallet dev pallet_contracts Co-authored-by: command-bot <>
-
Oliver Tale-Yazdi authored
* CI check for rust feature bleed Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Cargo not available Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Handle missing programs Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Check for deps Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Add doc Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Use correct CI image Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Remove --offline Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Install cargo-workspaces Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Remove cargo-workspaces dep Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Fix try-runtime feature Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Fix features Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Fix features Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Fix more features... Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Use pipeline-script Signed-off-by: Oliver Tale-Yazdi <[email protected]> *
🤡 Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Make stupid change to test the CI Signed-off-by: Oliver Tale-Yazdi <[email protected]> * This reverts commit ad2746aa117fa7cb473521113a9bec89aaf26484. * Use correct branch Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Allow failure Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Make stupid change to test the CI Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Revert "Make stupid change to test the CI" This reverts commit 16ec00e1675c7ec57c988315549ff71e832a3093. Signed-off-by: Oliver Tale-Yazdi <[email protected]> -
Kian Paimani authored
* allow for duplicate signed submissions * Fix a bunch of things, seems all good now * fmt * Fix * Update frame/election-provider-multi-phase/src/signed.rs Co-authored-by: Niklas Adolfsson <[email protected]> * Update frame/election-provider-multi-phase/src/signed.rs Co-authored-by: Niklas Adolfsson <[email protected]> * add migratin * fmt * comment typo * some review comments * fix bench Co-authored-by: Niklas Adolfsson <[email protected]> Co-authored-by: Ross Bulat <[email protected]>
-
dharjeezy authored
* evaluate repatriate reserved error in pallet identity * fix benchmarks * add repatriate reserved error test * benchmark fix * undo lock * include balance to use for benchmarks * rename test * Update frame/identity/src/benchmarking.rs * Update frame/identity/src/benchmarking.rs Co-authored-by: Bastian Köcher <[email protected]>
-
Michal Kucharczyk authored
* BlockId removal: refactor: ProofProvider It changes the arguments of methods of `ProofProvider` trait from: block: `BlockId<Block>` to: hash: `&Block::Hash` This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292) * LightClientRequestHandler: excessive BlockIdTo bound removed * imports cleanup * formatting * args tyeps cleanup
-
- Oct 18, 2022
-
-
Niklas Adolfsson authored
* hack together a PoC * Update utils/frame/rpc-utils/Cargo.toml Co-authored-by: Kian Paimani <[email protected]> * Update utils/frame/rpc-utils/src/lib.rs Co-authored-by: Kian Paimani <[email protected]> * rpc_utils -> substrate_rpc_client * try runtime: remove keep connection * make CI happy * cargo fmt * fix ci * update lock file * fix * fix Co-authored-by: Kian Paimani <[email protected]> Co-authored-by: kianenigma <[email protected]>
-
Sebastian Kunert authored
* Use ArgAction::Set for enable-offchain-indexing * Provide default value for `enable-offchain-indexing`
-
Michal Kucharczyk authored
* BlockId removal: refactor: StorageProvider It changes the arguments of `Backend::StorageProvider` trait from: block: `BlockId<Block>` to: hash: `&Block::Hash` This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292) * Apply suggestions from code review Co-authored-by: Bastian Köcher <[email protected]> * Update client/api/src/backend.rs Co-authored-by: Dmitrii Markin <[email protected]> * GrandpaBlockImport::current_set_id reworked * ExportStateCmd reworked * trigger CI job * trigger CI job Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Dmitrii Markin <[email protected]>
-
Serban Iorga authored
-
Bastian Köcher authored
-
Pierre Krieger authored
Co-authored-by: Bastian Köcher <[email protected]>
-
dharjeezy authored
* implement storage decode length for BTreeSet * Orderly moving of things around * include test for append and decode_len * fix cargo clippy issue
-
Sebastian Kunert authored
* Bump clap to 3.2.22 * Replace `from_os_str` with `value_parser` * Replace `from_str` and `try_from_str` with `value_parser` * Move possible_values to the new format * Remove unwanted print * Add missing match branch * Update clap to 4.0.9 and make it compile * Replace deprecated `clap` macro with `command` and `value` * Move remaining `clap` attributes to `arg` * Remove no-op value_parsers * Adjust value_parser for state_version * Remove "deprecated" feature flag and bump to 4.0.11 * Improve range Co-authored-by: Bastian Köcher <[email protected]> * Apply suggestions * Trigger CI * Fix unused error warning * Fix doc errors * Fix ArgGroup naming conflict * Change default_value to default_value_t * Use 1.. instead of 0.. Co-authored-by: Bastian Köcher <[email protected]>
-
- Oct 17, 2022
-
-
Ankan authored
* execute try-state at end of tests * run post condition only with try runtime * Revert "run post condition only with try runtime" This reverts commit 7db0ecf7eaa2ee5afa5a995487b73d023ba3bcd9. * voterlist contains validators as well * fmt * simplify * fmt Co-authored-by: parity-processbot <>
-
Dmitry Markin authored
* cargo upgrade libp2p * Get rid of `NetworkBehaviourEventProcess` in handling of `CustomMessageOutcome` * Get rid of `NetworkBehaviourEventProcess` in handling of `request_responses::Event` * Get rid of `NetworkBehaviourEventProcess` in handling of `peer_info::PeerInfoEvent` * Get rid of `NetworkBehaviourEventProcess` in handling of `DiscoveryOut` * Get rid of `poll()` method in `Bahaviour` * minor: comments * Upgrade libp2p to 0.49.0 (unreleased) * Support multiple Kad protocol names * Make borrow checker happy * minor: wording * Make substrate build with libp2p-0.49.0 * rustfmt * Get rid of MdnsWrapper * Resolve deprecation warnings * Fix documentation * Apply suggestions from code review: fix typos Co-authored-by: Aaro Altonen <[email protected]> * Apply suggestion: simplify kad protocol name matching Co-authored-by: Aaro Altonen <[email protected]>
-
omahs authored
Fix: typo
-
Adrian Catangiu authored
* pallet-mmr: cosmetic improvements * pallet-mmr: fix offchain storage for initial sync * address review comments * pallet-mmr: change offchain fork-resistant key to `(prefix, pos, parent_hash)` Do this so that both canon and fork-resitant keys have the same `(prefix, pos).encode()` prefix. Might be useful in the future if we'd be able to to "get" offchain db entries using key prefixes as well. Signed-off-by: acatangiu <[email protected]> Signed-off-by: acatangiu <[email protected]>
-
Bastian Köcher authored
The runtime api implementation contained invalid unsafe trait bounds. `Sync` was never correct there and `Send` should have not been "force implemented".
-
Aaro Altonen authored
* Introduce `ChainSyncInterface` `ChainSyncInterface` provides an asynchronous interface for other subsystems to submit calls to `ChainSync`. This allows `NetworkService` to delegate calls to `ChainSync` while still providing the same API for other subsystems (for now). This makes it possible to move the syncing code in piecemeal fashion out of `protocol.rs` as the calls are just forwarded to `ChainSync`. * Apply review comments * Fix tests
-
Kevin Wang authored
Co-authored-by: parity-processbot <>
-
- Oct 14, 2022
-
-
Oliver Tale-Yazdi authored
Signed-off-by: Oliver Tale-Yazdi <[email protected]> Signed-off-by: Oliver Tale-Yazdi <[email protected]>
-
Michal Kucharczyk authored
* Minor naming improved * BlockId removal refactor: Backend::state_at * formatting
-
- Oct 13, 2022
-
-
Michal Kucharczyk authored
-
Koute authored
-
Sergej Sakac authored
* pallet-mmr: RPC API works with block_numbers * fixes * update rpc * fmt * final touches in the rpc * temporary fix * fix * fmt * docs * Update lib.rs * use NumberFor * validate input * update runtime * convert block_number to u64 * small edit * update runtime api * test fix * runtime fix * update test function * fmt * fix nits * remove block_num_to_leaf_index from runtime api * Update frame/merkle-mountain-range/src/lib.rs Co-authored-by: Robert Hambrock <[email protected]> * fix tests * get the code to compile after merge * get the tests to compile * fix in tests? * fix test * Update frame/merkle-mountain-range/src/tests.rs Co-authored-by: Adrian Catangiu <[email protected]> * Update frame/merkle-mountain-range/src/lib.rs Co-authored-by: Adrian Catangiu <[email protected]> * Update primitives/merkle-mountain-range/src/lib.rs Co-authored-by: Adrian Catangiu <[email protected]> * fix errors & nits * change block_num_to_leaf_index * don't make any assumptions * Update frame/merkle-mountain-range/src/tests.rs Co-authored-by: Adrian Catangiu <[email protected]> * Update frame/merkle-mountain-range/src/tests.rs Co-authored-by: Adrian Catangiu <[email protected]> * Update frame/merkle-mountain-range/src/tests.rs Co-authored-by: Adrian Catangiu <[email protected]> * fix * small fix * use best_known_block_number * best_known_block_number instead of leaves_count * more readable? * remove warning * Update frame/merkle-mountain-range/src/lib.rs Co-authored-by: Robert Hambrock <[email protected]> * simplify * update docs * nits * fmt & fix * merge fixes * fix * small fix * docs & nit fixes * Nit fixes * remove leaf_indices_to_block_numbers() * fmt Co-authored-by: Robert Hambrock <[email protected]> Co-authored-by: Adrian Catangiu <[email protected]>
-
Aaro Altonen authored
* Introduce mockable `ChainSync` object for testing `mockall` allows to mock `ChainSync` and to verify that the calls made to `ChaiSync` are firstly executed at all, that they're executed in correct order and with correct parameters. This allows to verify, e.g., that delegating calls directly to `ChainSync` from `NetworkService` still calls the correct functions with correct arguments even if `Protocol` middleman is removed. * Add Cargo.lock * Fix tests * Update client/network/Cargo.toml Co-authored-by: Bastian Köcher <[email protected]> * Update Cargo.lock * Fix clippy and documentation Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: parity-processbot <>
-
Dmitry Markin authored
* Decrease peer reputation for duplicate GRANDPA neighbor messages. * Fix comparison * Fix update_peer_state() validity condition * Add negative test * Rework update_peer_state() validity condition, add tests * update_peer_state() validity condition: invert comparison * Split InvalidViewChange and DuplicateNeighborMessage misbehaviors * Enforce rate-limiting of duplicate GRANDPA neighbor packets * Update client/finality-grandpa/src/communication/gossip.rs Co-authored-by: André Silva <[email protected]> * Make rolling clock back in a test safer Co-authored-by: André Silva <[email protected]>
-
- Oct 12, 2022
-
-
Shawn Tabrizi authored
* dont use benchmark range on constant function * update weights * fix * new weights * Update frame/examples/basic/src/benchmarking.rs Co-authored-by: parity-processbot <>
-
Michal Kucharczyk authored
* Trivial BlockId::Number => Hash * missed BlockId::Hash added
-
Pierre Krieger authored
-
Michal Kucharczyk authored
-
- Oct 11, 2022
-
-
Michal Kucharczyk authored
* finalized block event triggers tx maintanance * tx-pool: enactment helper introduced * tx-pool: ChainApi: added tree_route method * enactment logic implemented + tests Signed-off-by: Michal Kucharczyk <[email protected]> * Some additional tests * minor improvements * trigger CI job * fix compilation errors ChainApi::tree_route return type changed to Result<Option<..>>, as some implementations (tests) are not required to provide this tree route. * formatting * trait removed * implementation slightly simplified (thanks to @koute ) * get rid of Arc<> in EnactmentState return value * minor improvement * Apply suggestions from code review Co-authored-by: André Silva <[email protected]> * Apply suggestions from code review * comment updated + formatting * Apply suggestions from code review Co-authored-by: André Silva <[email protected]> Co-authored-by: Davide Galassi <[email protected]> * formatting * finalization notification bug fix + new test case + log::warn message when finalized block is being retracted by new event * added error message on tree_route failure * Apply suggestions from code review Co-authored-by: Bastian Köcher <[email protected]> * use provided tree_route in Finalized event * Option removed from ChainApi::tree_route * doc added, test and logs improved * handle_enactment aligned with original implementation * use async-await * Apply suggestions from code review Co-authored-by: André Silva <[email protected]> * Apply suggestions from code review Co-authored-by: Bastian Köcher <[email protected]> * formatting + warn->debug * compilation error fix * enactment_state initializers added * enactment_state: Option removed * manual-seal: compilation & tests fix * manual-seal: tests fixed * tests cleanup * another compilation error fixed * TreeRoute::new added * get rid of pub hack * one more test added * formatting * TreeRoute::new doc added + formatting * Apply suggestions from code review Co-authored-by: Davide Galassi <[email protected]> * (bool,Option) simplified to Option * log message improved * yet another review suggestions applied * get rid of hash in handle_enactment * Apply suggestions from code review Co-authored-by: Bastian Köcher <[email protected]> * Update client/transaction-pool/src/lib.rs Co-authored-by: Bastian Köcher <[email protected]> * minor corrections * EnactmentState moved to new file * File header corrected * error formatting aligned with codebase * Apply suggestions from code review Co-authored-by: Bastian Köcher <[email protected]> * remove commented code * small nits Signed-off-by: Michal Kucharczyk <[email protected]> Co-authored-by: André Silva <[email protected]> Co-authored-by: Davide Galassi <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: André Silva <[email protected]>
-
Shawn Tabrizi authored
* dont use unstable sort * remove comment * add clippy rule
-
Keith Yeung authored
* Rename `from_components` to `from_parts` * Fixes * Spelling
-
Aaro Altonen authored
Sometimes `NotificationStreamOpenened` would be received for the other protocol before `SyncConnected` was received so when the connection was closed, an incorrect event was read from the event stream.
-
Pierre Krieger authored
* Remove the unused light client requests * Add comment about new ids
-
Alexandru Vasile authored
* rpc/tx: Add transaction structures for serialization Signed-off-by: Alexandru Vasile <[email protected]> * rpc/tx: Add public facing `TransactionEvent` To circumvent the fact that serde does not allow mixing `#[serde(tag = "event")]` with `#[serde(tag = "event", content = "block")]` the public facing subscription structure is serialized and deserialized to an intermmediate representation. Signed-off-by: Alexandru Vasile <[email protected]> * rpc/tx: Add trait for the `transaction` API Signed-off-by: Alexandru Vasile <[email protected]> * rpc/tx: Convert RPC errors to transaction events Signed-off-by: Alexandru Vasile <[email protected]> * rpc/tx: Implement `transaction` RPC methods Signed-off-by: Alexandru Vasile <[email protected]> * tx-pool: Propagate tx index to events Signed-off-by: Alexandru Vasile <[email protected]> * tx-pool: Adjust testing to reflect tx index in events Signed-off-by: Alexandru Vasile <[email protected]> * rpc/tx: Convert tx-pool events for the new RPC spec Signed-off-by: Alexandru Vasile <[email protected]> * rpc/tx: Convert tx-pool `FinalityTimeout` event to `Dropped` Signed-off-by: Alexandru Vasile <[email protected]> * service: Enable the `transaction` API Signed-off-by: Alexandru Vasile <[email protected]> * rpc/tx: Add tests for tx event encoding and decoding Signed-off-by: Alexandru Vasile <[email protected]> * tx: Add indentation for subscriptions Signed-off-by: Alexandru Vasile <[email protected]> * rpc/tx: Fix documentation Signed-off-by: Alexandru Vasile <[email protected]> * rpc/tx: Serialize usize to hex Signed-off-by: Alexandru Vasile <[email protected]> * tx-pool: Rename closure parameters Signed-off-by: Alexandru Vasile <[email protected]> * service: Separate RPC spec versions Signed-off-by: Alexandru Vasile <[email protected]> * rpc/tx: Use `H256` for testing block's hash Signed-off-by: Alexandru Vasile <[email protected]> * rpc/tx: Serialize numbers as string Signed-off-by: Alexandru Vasile <[email protected]> * tx-pool: Backward compatibility with RPC v1 Signed-off-by: Alexandru Vasile <[email protected]> * Update client/rpc-spec-v2/src/transaction/transaction.rs Co-authored-by: Niklas Adolfsson <[email protected]> * rpc/tx: Remove comment about serde clone Signed-off-by: Alexandru Vasile <[email protected]> * rpc/tx: Use RPC custom error code for invalid tx format Signed-off-by: Alexandru Vasile <[email protected]> * Update client/rpc-spec-v2/src/transaction/event.rs Co-authored-by: James Wilson <[email protected]> * rpc/tx: Adjust internal structures for serialization/deserialization Signed-off-by: Alexandru Vasile <[email protected]> Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: Niklas Adolfsson <[email protected]> Co-authored-by: James Wilson <[email protected]>
-
- Oct 10, 2022
-
-
Vladimir Istyufeev authored
* Update UI tests for Rust 1.64 * Test with the staging image * Switch back to production
-