- Aug 14, 2023
-
-
Oliver Tale-Yazdi authored
* Use same rustfmt.toml as Substrate Signed-off-by: Oliver Tale-Yazdi <[email protected]> * format format file Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Format with new config Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Add Substrate Clippy config Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Print Clippy version in CI Otherwise its difficult to reproduce locally. Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Make fmt happy Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Update node/core/pvf/src/error.rs Co-authored-by: Tsvetomir Dimitrov <[email protected]> * Update node/core/pvf/src/error.rs Co-authored-by: Tsvetomir Dimitrov <[email protected]> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Tsvetomir Dimitrov <[email protected]>
-
Aaro Altonen authored
-
jserrat authored
* pvf: use test-utils feature to export test only * adding comment to test-utils feature * make prepare-worker and execute-worker as optional dependencies and add comments to test-utils * remove doc hidden from pvf testing * add prepare worker and execute worker entrypoints to test-utils feature * pvf: add sp_tracing as optional dependency of test-utils * add test-utils for polkadot and malus * add test-utils feature to prepare and execute workers script * remove required features from prepare and executing * Try to trigger CI again to fix broken jobs --------- Co-authored-by: Marcin S <[email protected]>
-
- Aug 11, 2023
-
-
Adrian Catangiu authored
* cli: move no-beefy flag to substrate sc-cli config * bump substrate ref --------- Signed-off-by: Adrian Catangiu <[email protected]>
-
- Aug 10, 2023
-
-
Andrei Eres authored
* Add counter for unapproved candidates * Update metrics * Split metrics * Remove depth metric * Print only the oldest unapproved candidates * Update logging condition * Fix logging condition * Update logging * Update node/core/approval-voting/src/lib.rs Co-authored-by: Andrei Sandu <[email protected]> --------- Co-authored-by: Andrei Sandu <[email protected]>
-
- Aug 08, 2023
-
-
Marcin S. authored
-
- Aug 04, 2023
-
-
Lulu authored
* Add license to crates This is required to publish to crates.io * Add more licenses
-
Andrei Eres authored
* Fix flaky reputation change test * Remove fixme Co-authored-by: Oliver Tale-Yazdi <[email protected]> --------- Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: parity-processbot <>
-
- Aug 02, 2023
-
-
drskalman authored
* rename BEEFY `crypto` →`ecdsa_crypto` * - bump up `BeefyApi` to version 3 - deal with `PeerId` error. * update BEEFY dependency names for `fake-runtime` and `chain_spec` revert Cargo.toml * cargo fmt * Use master Cargo.lock * update lockfile for {"substrate"} --------- Co-authored-by: Davide Galassi <[email protected]> Co-authored-by: parity-processbot <>
-
Dmitry Markin authored
* Update `NetworkPeers` trait interface * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <>
-
- Aug 01, 2023
-
-
eskimor authored
* Take into account size as well in weight limiting. * Fix logging. * More logs. * Remove randomized selection in provisioner No longer supported by runtime. * Fix and simplify weight calculation. Random filtering of remote disputes got dropped. * Make existing tests pass. * Tests for size limiting. * Fix provisioner. * Remove rand dependency. * Better default block length for tests. * ".git/.scripts/commands/bench/bench.sh" runtime kusama runtime_parachains::paras_inherent * ".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent * ".git/.scripts/commands/bench/bench.sh" runtime westend runtime_parachains::paras_inherent * Update runtime/parachains/src/paras_inherent/mod.rs Co-authored-by: Tsvetomir Dimitrov <[email protected]> * Update runtime/parachains/src/paras_inherent/mod.rs Co-authored-by: Chris Sosnin <[email protected]> * Add back missing line. * Fix test. * fmt fix. * Add missing test annotation --------- Co-authored-by: eskimor <[email protected]> Co-authored-by: command-bot <> Co-authored-by: Tsvetomir Dimitrov <[email protected]> Co-authored-by: Chris Sosnin <[email protected]>
-
Marcin S. authored
* PVF: Fix external workers being required for non-collator full nodes * Fix * Make check more precise > This might as well be if role.is_authority() as there aren't really any nodes > that are both authorities and collators. But if there were a node that is an > authority and a collator, it'd probably want to validate candidates (in its > role as an authority). * Just seeing if this fixes zombienet CI...
-
- Jul 31, 2023
-
-
Marcin S. authored
* [WIP] PVF: Split out worker binaries * Address compilation problems and re-design a bit * Reorganize once more, fix tests * Reformat with new nightly to make `cargo fmt` test happy * Address `clippy` warnings * Add temporary trace to debug zombienet tests * Fix zombienet node upgrade test * Fix malus and its CI * Fix building worker binaries with malus * More fixes for malus * Remove unneeded cli subcommands * Support placing auxiliary binaries to `/usr/libexec` * Fix spelling * Spelling Co-authored-by: Marcin S. <[email protected]> * Implement review comments (mostly nits) * Fix worker node version flag * Rework getting the worker paths * Address a couple of review comments * Minor restructuring * Fix CI error * Add tests for worker binaries detection * Improve tests; try to fix CI * Move workers module into separate file * Try to fix failing test and workers not printing latest version - Tests were not finding the worker binaries - Workers were not being rebuilt when the version changed - Made some errors easier to read * Make a bunch of fixes * Rebuild nodes on version change * Fix more issues * Fix tests * Pass node version from node into dependencies to avoid recompiles - [X] get version in CLI - [X] pass it in to service - [X] pass version along to PVF - [X] remove rerun from service - [X] add rerun to CLI - [X] don’t rerun pvf/worker’s (these should be built by nodes which have rerun enabled) * Some more improvements for smoother tests - [X] Fix tests - [X] Make puppet workers pass None for version and remove rerun - [X] Make test collators self-contained * Add back rerun to PVF workers * Move worker binaries into files in cli crate As a final optimization I've separated out each worker binary from its own crate into the CLI crate. Before, the worker bin shared a crate with the worker lib, so when the binaries got recompiled so did the libs and everything transitively depending on the libs. This commit fixes this regression that was causing recompiles after every commit. * Fix bug (was passing worker version for node version) * Move workers out of cli into root src/bin/ dir - [X] Pass in node version from top-level (polkadot) - [X] Add build.rs with rerun-git-head to root dir * Add some sanity checks for workers to dockerfiles * Update malus + [X] Make it self-contained + [X] Undo multiple binary changes * Try to fix clippy errors * Address `cargo run` issue - [X] Add default-run for polkadot - [X] Add note about installation to error * Update readme (installation instructions) * Allow disabling external workers for local/testing setups + [X] cli flag to enable single-binary mode + [X] Add message to error * Revert unnecessary Cargo.lock changes * Remove unnecessary build scripts from collators * Add back missing malus commands (should fix failing ZN job) * Some minor fixes * Update Cargo.lock * Fix some build errors * Undo self-contained binaries; cli flag to disable version check + [X] Remove --dont-run-external-workers + [X] Add --disable-worker-version-check + [X] Remove PVF subcommands + [X] Redo malus changes * Try to fix failing job and add some docs for local tests --------- Co-authored-by: Dmitry Sinyavin <[email protected]> Co-authored-by: s0me0ne-unkn0wn <[email protected]> Co-authored-by: parity-processbot <>
-
- Jul 25, 2023
-
-
Marijn Schouten authored
* change HashFor to HashingFor * Update node/service/src/lib.rs Co-authored-by: Bastian Köcher <[email protected]> * Bump Substrate Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Revert "Bump Substrate" This reverts commit 5df19d03e85a7d39c8c7faa8b5f0f2225751d19a. * Bump Substrate Signed-off-by: Oliver Tale-Yazdi <[email protected]> * fmt Signed-off-by: Oliver Tale-Yazdi <[email protected]> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
-
Anton authored
* update tinyvec to 1.6.0 * update once_cell to 1.18.0 * update data-encoding to 2.4.0 * update libc * update js-sys * update wasm-bindgen-futures * update pin-project * update tokio * update syn * p2p protocol now contains `PeerId` not multihash * update arrayvec to 0.7.4 * update sha2 * update smallvec * updates to Cargo.lock after merge * redo dep updates * update lru in attempt to compile polkadot * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <>
-
RadiumBlock authored
-
- Jul 22, 2023
-
-
jserrat authored
* add tests to worker common thread * fix formatting * move worker commons unit test from integration tests to worker file and do some improvements * fix import on it/worker_common * move worker commons unit test to test module * cargo fmt * move cpu_time_monitor_loop to test outside of thread module * change worker thread unit test to use assert_eq * fix formatting * adding new methods to WaitOucome, fix pvf worker unit test * fix formatting * remove is_finished and is_timeout methods from WaitOutcome * fix wait_for_threads_with_timeout_returns_outcome test * ".git/.scripts/commands/fmt/fmt.sh" * add common worker cond_notify_on_done_should_update_wait_outcome_when_panic test --------- Co-authored-by: Marcin S <[email protected]> Co-authored-by: command-bot <>
-
- Jul 21, 2023
-
-
Sergej Sakac authored
* Add NetworkBridgeEvent::UpdatedAuthorityIds * update collator * informing subsystems * remove outdated authority data * docs * remove accidentally added line * update docs * emit event on session change * emit * check for update and update * Update node/network/gossip-support/src/lib.rs Co-authored-by: Andronik <[email protected]> * Update node/network/approval-distribution/src/lib.rs Co-authored-by: Andronik <[email protected]> * Update node/network/bitfield-distribution/src/lib.rs Co-authored-by: Andronik <[email protected]> * Update node/network/bridge/src/rx/mod.rs Co-authored-by: Andronik <[email protected]> * Update node/network/collator-protocol/src/validator_side/mod.rs Co-authored-by: Andronik <[email protected]> * Update node/network/collator-protocol/src/collator_side/mod.rs Co-authored-by: Andronik <[email protected]> * Update node/network/bridge/src/rx/mod.rs Co-authored-by: Andronik <[email protected]> * Update node/subsystem-types/src/messages.rs Co-authored-by: Andronik <[email protected]> * Update node/subsystem-types/src/messages.rs Co-authored-by: Andronik <[email protected]> * Update node/network/statement-distribution/src/lib.rs Co-authored-by: Andronik <[email protected]> * Update node/network/statement-distribution/src/lib.rs Co-authored-by: Andronik <[email protected]> * Update node/subsystem-types/src/messages/network_bridge_event.rs Co-authored-by: Andronik <[email protected]> * Update node/subsystem-types/src/messages.rs Co-authored-by: Andronik <[email protected]> * fixes * merge fixes * make clippy happy again * fix --------- Co-authored-by: Andronik <[email protected]>
-
- Jul 20, 2023
-
-
Andrei Sandu authored
Signed-off-by: Andrei Sandu <[email protected]>
-
- Jul 19, 2023
-
-
Francisco Aguirre authored
* Add polkadot XCM benchmarks * Add temp * ".git/.scripts/commands/bench/bench.sh" xcm polkadot pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm polkadot pallet_xcm_benchmarks::generic * Add weights to XCM on Polkadot * Make CI fail on old files Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Update template Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Add reserve_asset_deposited benchmark * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::generic * Update weights Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Change initiate_reserve_deposit in runtime weights * Update weights Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Remove trusted reserves from runtimes * Fix pallet-xcm-benchmarks mock * Fix test * Change pallet xcm weigher in kusama * Fix * Remove merge conflict artifact * Remove initiate_reserve_withdraw from generic benchmarks * Add missing implementation to XCM benchmark * Fix failing karura test * Remove dbg! Co-authored-by: Keith Yeung <[email protected]> * Fix fmt * Revert "Fix fmt" This reverts commit 676f2d8db07d7427750c79f95494d4988d06fda5. * Fix fmt * Remove duplicated template code * Add back part of the template * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible * Don't skip reserve asset deposited benchmark * Remove call to non-generated benchmark yet * Underscore unused parameter * Skip not supported benchmarks and hardcode value * Remove ReserveAssetDeposited benchmark * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible * Add back ReserveAssetDeposited * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible * Use default benchmark for ReserveAssetDeposited * Add missing parameter * Revert reserve asset deposited benchmark * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm kusama pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm westend pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm rococo pallet_xcm_benchmarks::fungible * Add 'real' benchmarks * Add TrustedReserve to actual XcmConfig * Add TrustedReserve to actual XcmConfig (fix) * Whitelist from benchmarking XCM storage keys read each block (#6871) * Whitelist from benchmarking XCM storage keys read each block * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm * Remove XcmPallet SupportedVersion from the benchmark whitelist * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime kusama pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm * ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm * WIP * Add necessary traits, remove unnecessary whitelisted keys * Fix tests * Remove unused file * Remove unused import --------- Co-authored-by: command-bot <> * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm rococo pallet_xcm_benchmarks::fungible * ".git/.scripts/commands/bench/bench.sh" xcm westend pallet_xcm_benchmarks::fungible * Fix spellchecker issues * Remove unused migration code --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: command-bot <> Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Keith Yeung <[email protected]>
-
- Jul 18, 2023
-
-
Michal Kucharczyk authored
* chain-spec: polkadot_staging_testnet config removed The config has empty initial authority test. It is unusable. ``` $ polkadot export-blocks --chain polkadot-staging --from=0 --to=0 ... Thread 'main' panicked at 'Empty validator set for session 0 in genesis block!', /home/miszka/.cargo/git/checkouts/substrate-7e08433d4c370a21/c446786/frame/session/src/lib.rs:463 ``` * warning fix
-
André Silva authored
* companion for substrate#14423 * update lockfile for {"substrate"} * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <>
-
- Jul 17, 2023
-
-
Andrei Eres authored
* Introduce is_frequent util * Add dirty warn_if_frequent! implementation * Add freq * Fix order in condition * Update * Update docs * Fix * Remove old impl * Fix errors * Add wif to av-distr * Add wif to col prot * Rename * Add wif to state-distr * Address review comments * Change Freq implementation * Remove the zero division check * Make rate explicit * Fix typo * Update rate constant * Introduce explicit rates * Update docs * Split errors freq * Downgrade coarsetime
-
- Jul 12, 2023
-
-
Michal Kucharczyk authored
* GenesisBuild<T,I> deprecated. BuildGenesisConfig added * fmt * fixes * more fixes * more fixes * fixes * update lockfile for {"substrate"} * fix --------- Co-authored-by: parity-processbot <>
-
- Jul 11, 2023
-
-
Bastian Köcher authored
* Companion for removal of execution strategies https://github.com/paritytech/substrate/pull/14387 * Fix some tests *
🤦 * Adapt to latest changes * Start supporting the offchain transaction pool * Fix tests * FMT * Remove patches * Update Substrate * update lockfile for {"substrate"} * Fix parachain upgrade smoke test * Fix test * Rewrite all tests to use `MockSubstemClient` --------- Co-authored-by: parity-processbot <>
-
- Jul 07, 2023
-
-
Andrei Sandu authored
* Remove redundant erasure encoding Signed-off-by: Andrei Sandu <[email protected]> * Review feedback Signed-off-by: Andrei Sandu <[email protected]> * fix comments Signed-off-by: Andrei Sandu <[email protected]> --------- Signed-off-by: Andrei Sandu <[email protected]>
-
- Jul 06, 2023
-
-
s0me0ne-unkn0wn authored
* Introduce `ci-only-tests` feature * Add comment
-
- Jul 05, 2023
-
-
Marcin S. authored
* Begin adding landlock + test * Move PVF implementer's guide section to own page, document security * Implement test * Add some docs * Do some cleanup * Fix typo * Warn on host startup if landlock is not supported * Clarify docs a bit * Minor improvements * Add some docs about determinism * Address review comments (mainly add warning on landlock error) * Update node/core/pvf/src/host.rs Co-authored-by: Andrei Sandu <[email protected]> * Update node/core/pvf/src/host.rs Co-authored-by: Andrei Sandu <[email protected]> * Fix unused fn * Update ABI docs to reflect latest discussions * Remove outdated notes * Try to trigger new test-linux-oldkernel-stable job Job introduced in https://github.com/paritytech/polkadot/pull/7371. --------- Co-authored-by: Andrei Sandu <[email protected]>
-
Bastian Köcher authored
* Companion for Substrate#14511 https://github.com/paritytech/substrate/pull/14511 * Make benchmarking build without any native runtime * Fix warning * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <>
-
- Jul 04, 2023
-
-
Squirrel authored
-
Andrei Sandu authored
* Move expensive computations to blocking thread Signed-off-by: Andrei Sandu <[email protected]> * fix test Signed-off-by: Andrei Sandu <[email protected]> * add internal error and fix dependent subystems Signed-off-by: Andrei Sandu <[email protected]> * fmt Signed-off-by: Andrei Sandu <[email protected]> * fix test fix Signed-off-by: Andrei Sandu <[email protected]> * minor refactor and TODOs Signed-off-by: Andrei Sandu <[email protected]> * Impl Feedback for Review Signed-off-by: Andrei Sandu <[email protected]> * review feedback Signed-off-by: Andrei Sandu <[email protected]> * More docs Signed-off-by: Andrei Sandu <[email protected]> * add some example timings in comments Signed-off-by: Andrei Sandu <[email protected]> --------- Signed-off-by: Andrei Sandu <[email protected]>
-
Bastian Köcher authored
* Implement runtime apis for fake runtime These runtime api implementations are only used to make the compiler think that we have implemented all required runtime apis. They will not be called as we switch the executor to `WasmExecutor`. In the near future we will not require these fake implementations anymore after Substrate has shifted away from this compile time requirement. This brings us the advantage that the `polkadot-service` doesn't need to depend on the runtimes for getting the `RuntimeApi` type. It also removes around 1min of build time on my machine ;) * Fix warning * FMT * ".git/.scripts/commands/fmt/fmt.sh" * Use more descriptive id * Fix warnings * Adapt path * Fix
🙈 --------- Co-authored-by: command-bot <>
-
- Jun 29, 2023
-
-
Bastian Köcher authored
* Companion for Substrate#14474 This removes the requirement to pass the native dispatch. * Adapt * Better * Remove patch * ... * Fix * Update Substrate
-
- Jun 23, 2023
-
-
Andrei Eres authored
* Warn if participated in the losing side of a dispute * Update naming * Additionally filter by candidate hash * Debug zombienet tests * Update 0002-parachains-disputes.zndsl * Debug zombienet * Update node/core/dispute-coordinator/src/initialized.rs Co-authored-by: Andrei Sandu <[email protected]> * Add checking to zombienet tests --------- Co-authored-by: Andrei Sandu <[email protected]>
-
- Jun 22, 2023
-
-
Oliver Tale-Yazdi authored
* Disable flaky test Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Fix import Signed-off-by: Oliver Tale-Yazdi <[email protected]> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]>
-
- Jun 21, 2023
-
-
Milos Kriz authored
-
Andrei Sandu authored
* Measure re-encoding time Signed-off-by: Andrei Sandu <[email protected]> * fix build Signed-off-by: Andrei Sandu <[email protected]> --------- Signed-off-by: Andrei Sandu <[email protected]>
-
Koute authored
-
- Jun 16, 2023
-
-
juangirini authored
* update genesis config * fix wrong RuntimeGenesisConfig name * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <>
-
Mira Ressel authored
* docs: update references to NetworkConfiguration::extra_sets Since paritytech/substrate#14080, this struct field no longer exists, now the `add_notification_protocol()` function of `sc_network::config::FullNetworkConfiguration` is used. Also neuter the doc links for now; rustdoc can't resolve them (presumably because sc_network::config isn't in scope, though weirdly enough even spelling the link out as ``[`FullNetworkConfiguration`](struct@sc_network::config::FullNetworkConfiguration)`` doesn't work?). Normally this wouldn't be an issue and rustdoc would just not generate links, but rust 1.70 has a bug that completely crashes rustdoc in this case.
-