Skip to content
  1. May 17, 2024
    • Svyatoslav Nikolsky's avatar
      Bridge: fixed relayer version metric value (#4492) · 2c48b9dd
      Svyatoslav Nikolsky authored
      Before relayer crates have been moved + merged, the `MetricsParams` type
      has been created from a `substrate-relay` crate (binary) and hence it
      has been setting the `substrate_relay_build_info` metic value properly -
      to the binary version. Now it is created from the
      `substrate-relay-helper` crate, which has the fixed (it isn't published)
      version `0.1.0`, so our relay provides incorrect metric value. This
      'breaks' our monitoring tools - we see that all relayers have that
      incorrect version, which is not cool.
      
      The idea is to have a global static variable (shame on me) that is
      initialized by the binary during initialization like we do with the
      logger initialization already. Was considering some alternative options:
      - adding a separate argument to every relayer subcommand and propagating
      it to the `MetricsParams::new()` causes a lot of changes and introduces
      even more noise to the binary code, which is supposed to be as small as
      possible in the new design. But I could do that if team thinks it is
      better;
      - adding a `structopt(skip) pub relayer_version: RelayerVersion`
      argument to all subcommand params won't work, because it will be
      initialized by default and `RelayerVersion` needs to reside in some util
      crate (not the binary), so it'll have the wrong value again.
      2c48b9dd
    • PG Herveou's avatar
      Contracts: remove kitchensink dynamic parameters (#4489) · f86f2131
      PG Herveou authored
      Using Dynamic Parameters for contracts seems like a bad idea for now.
      
      Given that we have benchmarks for each host function (in addition to our
      extrinsics), parameter storage reads will be counted multiple times. We
      will work on updates to the benchmarking framework to mitigate this
      issue in future iterations.
      
      ---------
      
      Co-authored-by: command-bot <>
      f86f2131
  2. May 16, 2024
  3. May 15, 2024
  4. May 14, 2024
  5. May 13, 2024