Skip to content
  1. Oct 26, 2023
    • Branislav Kontur's avatar
      Removed TODO from test-case for hard-coded delivery fee estimation (#2042) · 21d36b7b
      Branislav Kontur authored 
      

Co-authored-by: default avatarAdrian Catangiu <[email protected]>
      21d36b7b
    • Dastan's avatar
      Expose collection attributes from `Inspect` trait (#1914) · 0bcebac4
      Dastan authored 
      # Description

- What does this PR do?

While working with `pallet_nfts` through `nonfungibles_v2` traits
`Inspect, Mutate`, I found out that once you have set the collection
attribute with `<Nfts as Mutate>::set_collection_attribute()`, it's not
possible to read it with `<Nfts as Inspect>::collection_attribute()`
since they use different `namespace` values. When setting the attribute,
`AttributeNamespace::Pallet` is used, while
`AttributeNamespace::CollectionOwner` is used when reading.

more context:
https://github.com/freeverseio/laos/issues/7#issuecomment-1766137370

This PR makes `item` an optional parameter in
`Inspect::system_attribute()`, to be able to read collection attributes.

- Why are these changes needed?

To be able to read collection level attributes when reading attributes
of the collection. It will be possible to read collection attributes by
passing `None` for `item`

- How were these changes implemented and what do they affect?

`NftsApi` is also affected and `NftsApi::system_attribute()` now accepts
optional `item` parameter.

## Breaking change

Because of the change in the `NftsApi::system_attribute()` method's
`item` param, parachains who integrated the `NftsApi` need to update
their API code and frontend integrations accordingly. AssetHubs are
unaffected since the NftsApi wasn't released on those parachains yet.
      0bcebac4
  3. Oct 25, 2023
    • Joshy Orndorff's avatar
      `polkadot-parachain-primitives` should not depend on `frame-support`. (#1897) · bdf18687
      Joshy Orndorff authored 
      

This PR does not make any functional changes to the code. Rather, it
restructures the dependency graph.

Before this PR, the crate `polkadot-parachain-primitives` depended
directly on the crate `frame-support`. This is wrong in principal
because a parachain does not necessarily have anything to do with frame.

This dependency was only for the `Weight` type which was just a
re-export from `sp-weights` anyway. So this PR changes the dependency to
be directly on the much lighter `sp-weights`.

---------

Co-authored-by: default avatarJoshy Orndorff <[email protected]>
Co-authored-by: command-bot <>
      bdf18687
    • Branislav Kontur's avatar
      [testnet] Align testnet system parachain runtimes using... · f6560c2b
      Branislav Kontur authored 
      [testnet] Align testnet system parachain runtimes using `RelayTreasuryLocation` and `SystemParachains` in the same way (#2023)

This PR addresses several issues:
- simplify referencing `RelayTreasuryLocation` without needing
additional `RelayTreasury` struct
- fix for referencing `SystemParachains` from parachain with `parents:
1` instead of `parents: 0`
- removed hard-coded constants and fix tests for `asset-hub-rococo`
which was merged to master after
https://github.com/paritytech/polkadot-sdk/pull/1726

---------

Co-authored-by: command-bot <>
      f6560c2b
    • Oliver Tale-Yazdi's avatar
      Sort the benchmarks before listing them (#2026) · c86b6336
      Oliver Tale-Yazdi authored 
      

Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      c86b6336
    • Xiliang Chen's avatar
      publish pallet-root-testing (#2017) · b7a8532d
      Xiliang Chen authored 
      so we can use it in our tests
      b7a8532d
    • PG Herveou's avatar
      Contracts: Add benchmarks to include files (#2022) · 3148063a
      PG Herveou authored 
      Project that includes pallet-contracts via crates.io will fail to run 
```bash
cargo check --features=runtime-benchmarks
```

without the currently not included benchmarks files
      3148063a
    • Liam Aharon's avatar
      Small optimisation to `--profile dev` wasm builds (#1851) · ff3a3bca
      Liam Aharon authored 
      `wasm-builder` was adjusted to default to building wasm blobs in
`release` mode even when cargo is in `debug` because `debug` wasm is too
slow.

A side effect of this was `.compact` and `.compact.compressed` getting
built when the dev is running build in `debug`, adding ~5s to the build
time of every wasm runtime.

I think it's reasonable to assume if the dev is running `debug` build
they want to optimise speed and do not care about the size of the wasm
binary. Compacting a blob has negligible impact on its actual
performance.

In this PR, I adjusted the behavior of the wasm builder so it does not
produce `.compact` or `.compact.compressed` wasm when the user is
running in `debug`. The builder will continue to produce the bloaty wasm
in release mode unless it is overriden with an env var.

As suggested by @koute in review, also refactored the
`maybe_compact_wasm_and_copy_blobs` into multiple funuctions, and
renamed things to better support RISC-V in the future.

---

There is no `T-runtime` label so @KiChjang

 told me to put `T1-FRAME` :)

---------

Co-authored-by: default avatarKoute <[email protected]>
      ff3a3bca
  5. Oct 24, 2023
  7. Oct 23, 2023
  9. Oct 22, 2023
    • Bastian Köcher's avatar
      sc-executor: Increase maximum instance count (#1856) · e2b21d00
      Bastian Köcher authored 
      

Changes the maximum instances count for `wasmtime` to `64`. It also
allows to only pass in maximum `32` for `--max-runtime-instances` as
`256` was way too big. With `64` instances in total and `32` that can be
configured in maximum, there should be enough space to accommodate for
extra instances that are may required to be allocated adhoc.

---------

Co-authored-by: default avatarKoute <[email protected]>
      e2b21d00
  11. Oct 21, 2023
  13. Oct 20, 2023
  15. Oct 19, 2023