- Mar 01, 2022
-
-
Tsvetomir Dimitrov authored
Include changes made in #4134 and #4854 Fixes #4397
-
dependabot[bot] authored
* Bump expander from 0.0.4 to 0.0.5 Bumps [expander](https://github.com/drahnr/expander) from 0.0.4 to 0.0.5. - [Release notes](https://github.com/drahnr/expander/releases) - [Commits](https://github.com/drahnr/expander/compare/v0.0.4...v0.0.5) --- updated-dependencies: - dependency-name: expander dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * no default features unless we use them * fixup cargo lock Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bernhard Schuster <[email protected]>
-
ordian authored
* dispute-distribution: downgrade a warn * change at the logging side instead
-
dependabot[bot] authored
Bumps [clap](https://github.com/clap-rs/clap) from 3.1.2 to 3.1.3. - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](https://github.com/clap-rs/clap/compare/v3.1.2...v3.1.3) --- updated-dependencies: - dependency-name: clap dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
asynchronous rob authored
* add disputes pallet to Polkadot * fix & add bench * cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::disputes --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_disputes.rs Co-authored-by: Parity Bot <[email protected]>
-
- Feb 28, 2022
-
-
Bastian Köcher authored
-
Andrei Sandu authored
* WIP: Wasm compilation perf Signed-off-by: Andrei Sandu <[email protected]> * Fix Signed-off-by: Andrei Sandu <[email protected]> * Undying collator WIP Signed-off-by: Andrei Sandu <[email protected]> * Fix build Signed-off-by: Andrei Sandu <[email protected]> * more fixes Signed-off-by: Andrei Sandu <[email protected]> * update test with undying Signed-off-by: Andrei Sandu <[email protected]> * Correctly compute post hash Signed-off-by: Andrei Sandu <[email protected]> * update helper Signed-off-by: Andrei Sandu <[email protected]> * squash bugs Signed-off-by: Andrei Sandu <[email protected]> * Add --pov-size cli parameter Signed-off-by: Andrei Sandu <[email protected]> * refactor Signed-off-by: Andrei Sandu <[email protected]> * fix strings Signed-off-by: Andrei Sandu <[email protected]> * Add pov-size param to export genesis state Signed-off-by: Andrei Sandu <[email protected]> * Fix graveyard size Signed-off-by: Andrei Sandu <[email protected]> * docs + fmt Signed-off-by: Andrei Sandu <[email protected]> * Fix PVF bug and switch to u8 graves Signed-off-by: Andrei Sandu <[email protected]> * Update tests Signed-off-by: Andrei Sandu <[email protected]> * Build/publish undying collator as colander img Signed-off-by: Andrei Sandu <[email protected]> * add undying-collator to colander image * Fix transaction overflow Signed-off-by: Andrei Sandu <[email protected]> * warn fix Signed-off-by: Andrei Sandu <[email protected]> * add parachain id for export genesis cli Signed-off-by: Andrei Sandu <[email protected]> * fix Signed-off-by: Andrei Sandu <[email protected]> * fix the build Signed-off-by: Andrei Sandu <[email protected]> * scale test up Signed-off-by: Andrei Sandu <[email protected]> * default parachain id Signed-off-by: Andrei Sandu <[email protected]> * Add PVF complexity param Signed-off-by: Andrei Sandu <[email protected]> * Hash on each iteration Signed-off-by: Andrei Sandu <[email protected]> * Update pvf metric histogram buckets Signed-off-by: Andrei Sandu <[email protected]> * Ladi attempt to fix tests * Fix test * Fix typos * Fix pvf typo * CI integration Signed-off-by: Andrei Sandu <[email protected]> * cargo lock missing Signed-off-by: Andrei Sandu <[email protected]> * fix clap merge damage Signed-off-by: Andrei Sandu <[email protected]> * add zombienet image back Signed-off-by: Andrei Sandu <[email protected]> * Use collator image from env Signed-off-by: Andrei Sandu <[email protected]> * bump zombienet version * update test to check pvf prep/exec Signed-off-by: Andrei Sandu <[email protected]> * delete file Signed-off-by: Andrei Sandu <[email protected]> * use default bootnode in upgrade test * FIx tests Signed-off-by: Andrei Sandu <[email protected]> * add some stress - pvf exec times up to 2s Signed-off-by: Andrei Sandu <[email protected]> * fix name Signed-off-by: Andrei Sandu <[email protected]> * Dial down pvf execution time < 2s Signed-off-by: Andrei Sandu <[email protected]> * 1100 Signed-off-by: Andrei Sandu <[email protected]> * bump Signed-off-by: Andrei Sandu <[email protected]> * try again Signed-off-by: Andrei Sandu <[email protected]> * Add connectivity check Signed-off-by: Andrei Sandu <[email protected]> * Fixes and refactor folder struct Signed-off-by: Andrei Sandu <[email protected]> * change toml name to match Signed-off-by: Andrei Sandu <[email protected]> * bump zombienet Signed-off-by: Andrei Sandu <[email protected]> * impl Feedback for Review
😎 Signed-off-by: Andrei Sandu <[email protected]> * spell check Signed-off-by: Andrei Sandu <[email protected]> * Zombienet: add disputes test (#4859) * Zombienet disputes test Signed-off-by: Andrei Sandu <[email protected]> * CI: add zombienet-parachain-disputes Signed-off-by: Andrei Sandu <[email protected]> * Bump zombienet Signed-off-by: Andrei Sandu <[email protected]> * reduce duration Signed-off-by: Andrei Sandu <[email protected]> * Update zombienet_tests/functional/0002-parachains-disputes.feature fix test * Update zombienet_tests/functional/0002-parachains-disputes.feature fix fix * more logs and set collator image Signed-off-by: Andrei Sandu <[email protected]> * spellcheck Signed-off-by: Andrei Sandu <[email protected]> * fix cargo lock damage Signed-off-by: Andrei Sandu <[email protected]> * merge fixes Signed-off-by: Andrei Sandu <[email protected]> * bump zombienet image Signed-off-by: Andrei Sandu <[email protected]> * cargo lock Signed-off-by: Andrei Sandu <[email protected]> * debugging CI run - scale down test Signed-off-by: Andrei Sandu <[email protected]> * fix cargo merge damage Signed-off-by: Andrei Sandu <[email protected]> * default command fix Signed-off-by: Andrei Sandu <[email protected]> * Revert "debugging CI run - scale down test" This reverts commit eec2ba7e65ede3f929e2f0a8fe44930df2119450. * more review feedback Signed-off-by: Andrei Sandu <[email protected]> Co-authored-by: Javier Viola <[email protected]> Co-authored-by: Lldenaurois <[email protected]>
-
- Feb 26, 2022
-
-
Davide Galassi authored
* Manage new `sr25519::Signature::from_slice` fallible constructor Constructor now returns an `Option` * update lockfile for {"substrate"} Co-authored-by: parity-processbot <>
-
Falco Hirschenberger authored
* Claim grounds, not working yet. * still wip, nothing to see * Module visibility problem * Add benchmarks for all parachain-enabled chains * Add missing mock weights * Fix mock weight info * Add max-weight to extrinsic weight * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::ump --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_ump.rs * sorting declarations * Use a maximum size message to benchmark worst-case * remove warning * Fix msg size overflow in tests * Use benchmarked weight in PostInfo * Update runtime/parachains/src/ump.rs Co-authored-by: Alexander Popiak <[email protected]> * Delete obsolete file * Compile fix * Fix spelling * Add benchmark for `UmpSink::process_upward_message` It benchmarks the time to process a message, mainly the size-dependent decoding time. This is used interally for refunding weight from `service_overweight` * Fix warning * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::ump --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_ump.rs * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::ump --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_ump.rs * Update runtime/parachains/src/ump.rs Co-authored-by: Kian Paimani <[email protected]> * Give mock weights for tests a name instead of () * Add benchmark for `initializer_on_new_session` aka. `perform_outgoing_para_cleanup` * Remove unnescessary pub specifier and change folding to a for loop suggestions by @pepyakin * Update runtime/parachains/src/ump.rs Co-authored-by: Kian Paimani <[email protected]> * Update runtime/parachains/src/ump.rs Co-authored-by: Kian Paimani <[email protected]> * Add comment on weight calculation and expected slight overestimation * Introduce a size bound constant for upward messages * Use KiB not kB for message size bound * Enforce max-message size bound * Use a const for upward message size bound. * Decrease max_upward_message_sizes to 50KiB as suggested by @pepyakin * Fix creating overweight messages * cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::ump --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/rococo/src/weights/runtime_parachains_ump.rs * cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::ump --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_ump.rs * cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::ump --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_ump.rs * Remove unused variable * Rename benchmark function to the function actually benchmarked and some code cleanup * cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::ump --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_ump.rs * cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark --chain=rococo-dev --steps=50 --repeat=20 --pallet=runtime_parachains::ump --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/rococo/src/weights/runtime_parachains_ump.rs * cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::ump --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_ump.rs * Better variable naming * Fix build * Fix build * Fix some remarks from @pepyakin Co-authored-by: Parity Bot <[email protected]> Co-authored-by: Alexander Popiak <[email protected]> Co-authored-by: Kian Paimani <[email protected]> Co-authored-by: emostov <[email protected]>
-
- Feb 25, 2022
-
-
dependabot[bot] authored
Bumps [color-eyre](https://github.com/yaahc/color-eyre) from 0.6.0 to 0.6.1. - [Release notes](https://github.com/yaahc/color-eyre/releases) - [Changelog](https://github.com/yaahc/color-eyre/blob/master/CHANGELOG.md) - [Commits](https://github.com/yaahc/color-eyre/compare/v0.6.0...v0.6.1) --- updated-dependencies: - dependency-name: color-eyre dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
Vsevolod Stakhov authored
* Add a simple metric for statements out-of-view * Avoid repeated out-of-view peer reputation change messages * Log reporting status * Address review comments * Use counter to store a number of unexpected messages from a peer * Distinguish different unexpected statements in the metrics * Fix labels cardinality * Rename metric name to `statements_unexpected` * Move metrics to a separate unit, avoid unnecessary enum * Prefer specific methods in lieu of public constants
-
Oliver Tale-Yazdi authored
* Add storage benchmarking Signed-off-by: Oliver Tale-Yazdi <[email protected]> * update lockfile for {"substrate"} Co-authored-by: parity-processbot <>
-
Bernhard Schuster authored
* seed commit for fatality based errors * fatality * first draft of fatality * cleanup * differnt approach * simplify * first working version for enums, with documentation * add split * fix simple split test case * extend README.md * update fatality impl * make tests passed * apply fatality to first subsystem * fatality fixes * use fatality in a subsystem * fix subsystemg * fixup proc macro * fix/test: log::*! do not execute when log handler is missing * fix spelling * rename Runtime2 to something sane * allow nested split with `forward` annotations * add free license * enable and fixup all tests * use external fatality Makes this more reviewable. * bump fatality dep Avoid duplicate expander compilations. * migrate availability distribution * more fatality usage * chore: bump fatality to 0.0.6 * fixup remaining subsystems * chore: fmt * make cargo spellcheck happy * remove single instance of `#[fatal(false)]` * last quality sweep * fixup
-
Bernhard Schuster authored
-
Bastian Köcher authored
* Try to fix disputes test * Enable all native runtimes
-
wigy authored
* Updating dependencies * Adapting code to scale v3 * Upgrade bitvec to 1.0.0 * Fix bitvec arithmetics * Update Cargo.lock * Update sp-io * Fixing the build * Yanked scale-info 2.0.0 Co-authored-by: Bastian Köcher <[email protected]>
-
- Feb 24, 2022
-
-
Mara Broda authored
* ci: add manual dispatch docker publish workflow * ci: fix date in dispatch trigger * ci: avoid specifying gpg keyserver in multiple places
-
Mara Broda authored
* scripts: fix polkadot_injected_release gpg errors * ci: publish-docker-release: remove keyserver arg * scripts: join RUNs in polkadot_injected_release
-
Bastian Köcher authored
* Switch to edition 2021 * Reset bridges * Fix compilation * Fix test-runtime * Fix malus
-
dependabot[bot] authored
Bumps [proc-macro-crate](https://github.com/bkchr/proc-macro-crate) from 1.1.2 to 1.1.3. - [Release notes](https://github.com/bkchr/proc-macro-crate/releases) - [Commits](https://github.com/bkchr/proc-macro-crate/commits) --- updated-dependencies: - dependency-name: proc-macro-crate dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
dependabot[bot] authored
Bumps [clap](https://github.com/clap-rs/clap) from 3.1.1 to 3.1.2. - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](https://github.com/clap-rs/clap/compare/v3.1.1...v3.1.2) --- updated-dependencies: - dependency-name: clap dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
- Feb 23, 2022
-
-
Bernhard Schuster authored
* introduce expander * unify towards expand * bubble up expand * spelling Co-authored-by: Andrei Sandu <[email protected]> * add newlines Co-authored-by: Andrei Sandu <[email protected]>
-
dependabot[bot] authored
* Bump clap from 3.0.14 to 3.1.1 Bumps [clap](https://github.com/clap-rs/clap) from 3.0.14 to 3.1.1. - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](https://github.com/clap-rs/clap/compare/v3.0.14...v3.1.1) --- updated-dependencies: - dependency-name: clap dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * avoid deprecated AppSettings::Hidden * avoid another deprecated instance Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bernhard Schuster <[email protected]>
-
- Feb 22, 2022
-
-
André Silva authored
* Companion for substrate#10878 * update lockfile for {"substrate"} Co-authored-by: parity-processbot <>
-
Tsvetomir Dimitrov authored
handle_import_statements() from Dispute-Coordinator does spam detection by counting unconfirmed dispute statements from each validator. This patch adjusts the logic so that only fresh dispute statements are counted. Fresh dispute statement in this case means a statement which was not loaded from overlay db.
-
ordian authored
* approval-distribution: a fix for out-of-view messages * approval-distribution: trace logs * adjust the guide slightly * comments and nits
-
Radu Popa authored
-
dependabot[bot] authored
Bumps [strum](https://github.com/Peternator7/strum) from 0.23.0 to 0.24.0. - [Release notes](https://github.com/Peternator7/strum/releases) - [Changelog](https://github.com/Peternator7/strum/blob/master/CHANGELOG.md) - [Commits](https://github.com/Peternator7/strum/commits) --- updated-dependencies: - dependency-name: strum dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
dependabot[bot] authored
Bumps [tokio-tungstenite](https://github.com/snapview/tokio-tungstenite) from 0.16.1 to 0.17.1. - [Release notes](https://github.com/snapview/tokio-tungstenite/releases) - [Changelog](https://github.com/snapview/tokio-tungstenite/blob/master/CHANGELOG.md) - [Commits](https://github.com/snapview/tokio-tungstenite/compare/v0.16.1...v0.17.1) --- updated-dependencies: - dependency-name: tokio-tungstenite dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
Sergei Shulepov authored
This commit adds a new primitive called `ParachainsCache` to manipulate the `Parachains` storage entry in a more convenient way. Then, on top of that, this commit changes the logic of `initialize_para_now` so that it is identical to what is used for initialization of onboarding.
-
Bernhard Schuster authored
* pyroscope * fixup * add pyroscope target * fixins * spellcheck * rename 'pyroscoped' feature to 'pyroscope' * build testnet binary with pyroscope feature * Update Cargo.toml Co-authored-by: Andronik <[email protected]> * make args a string, resolve using std::net * fixup * remove --features pyroscope for testnet builds Until the panics are fixed in upstream, this is sane. * chore: bump pyroscope to 0.3.1 Fixes an underflow panic. * Revert "remove --features pyroscope for testnet builds" This reverts commit 57dbdc7aa5f6427aeb1e3dfdfc97071c3a74851e. * fix: Make sample rate a prime Co-authored-by: Pierre Besson <[email protected]> Co-authored-by: Andronik <[email protected]>
-
Koute authored
* Bump `tokio` to 1.17.0 * Bump the `tokio` version in the test service too * Revert changes to `bridges/relays/client-substrate/Cargo.toml` Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
-
Mara Broda authored
* westend: bump transaction_version * polkadot: bump transaction_version * kusama: bump transaction_version
-
- Feb 21, 2022
-
-
dependabot[bot] authored
Bumps [tracing-subscriber](https://github.com/tokio-rs/tracing) from 0.3.8 to 0.3.9. - [Release notes](https://github.com/tokio-rs/tracing/releases) - [Commits](https://github.com/tokio-rs/tracing/compare/tracing-subscriber-0.3.8...tracing-subscriber-0.3.9) --- updated-dependencies: - dependency-name: tracing-subscriber dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
- Feb 18, 2022
-
-
Niklas Adolfsson authored
* staking miner: use config for emergency solution Fixes #4678 * bump jsonrpsee * run `monitor_cmd_for` until the connection is closed * new tokio task for submit_and_watch xt * re-use header subscription * update jsonrpsee + simplify code * revert polkadot runtime changes * fix grumbles * Update utils/staking-miner/src/monitor.rs * staking miner: reuse ws conn for remote-ext * Revert "revert polkadot runtime changes" This reverts commit 5fddbbec40702c122b079526915cabac8facdbc1. * cargo fmt * revert unintentional change * revert unintentional change * add type SharedRpcClient * cargo fmt * fix nits * spelling * use tracing_subcriber and cleanup * remove some needless clones * fix some nits * fix spellcheck
-
asynchronous rob authored
* Revert "collator-protocol: fix wrong warning (#4909)" This reverts commit 128421b5. * Revert "collator-protocol: short-term fixes for connectivity (#4640)" This reverts commit aff88a86 . * make the slots great again Co-authored-by: Andronik <[email protected]>
-
dependabot[bot] authored
Bumps [tracing](https://github.com/tokio-rs/tracing) from 0.1.30 to 0.1.31. - [Release notes](https://github.com/tokio-rs/tracing/releases) - [Commits](https://github.com/tokio-rs/tracing/compare/tracing-0.1.30...tracing-0.1.31) --- updated-dependencies: - dependency-name: tracing dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
- Feb 17, 2022
-
-
Robert Klotzner authored
* Only bypass spam slots on actualy approval/backing vote import. * Fix spam slot treatment. * More tests. * Make sure backing statements import works. * Aaaaaand the actual proper fix. * Better docs + spelling fixes. * Fix. * Typo Co-authored-by: Robert Habermeier <[email protected]> * Fix doc. * Update node/core/dispute-coordinator/src/real/initialized.rs * minor rewording, line wrap * fix test case * Fix obsolete comment. Co-authored-by: Robert Habermeier <[email protected]> Co-authored-by: Bernhard Schuster <[email protected]>
-
dependabot[bot] authored
Bumps [proc-macro-crate](https://github.com/bkchr/proc-macro-crate) from 1.1.0 to 1.1.2. - [Release notes](https://github.com/bkchr/proc-macro-crate/releases) - [Commits](https://github.com/bkchr/proc-macro-crate/commits) --- updated-dependencies: - dependency-name: proc-macro-crate dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
- Feb 16, 2022
-
-
lumir-mrkva authored
the comments we're flipped between accepted and rejected events causing confusion, but usage of events is correct
-