1. Aug 04, 2023
  2. Aug 02, 2023
  3. Aug 01, 2023
    • eskimor's avatar
      Take into account size as well in weight limiting. (#7369) · 367098ba
      eskimor authored
      
      
      * Take into account size as well in weight limiting.
      
      * Fix logging.
      
      * More logs.
      
      * Remove randomized selection in provisioner
      
      No longer supported by runtime.
      
      * Fix and simplify weight calculation.
      
      Random filtering of remote disputes got dropped.
      
      * Make existing tests pass.
      
      * Tests for size limiting.
      
      * Fix provisioner.
      
      * Remove rand dependency.
      
      * Better default block length for tests.
      
      * ".git/.scripts/commands/bench/bench.sh" runtime kusama runtime_parachains::paras_inherent
      
      * ".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent
      
      * ".git/.scripts/commands/bench/bench.sh" runtime westend runtime_parachains::paras_inherent
      
      * Update runtime/parachains/src/paras_inherent/mod.rs
      
      Co-authored-by: default avatarTsvetomir Dimitrov <[email protected]>
      
      * Update runtime/parachains/src/paras_inherent/mod.rs
      
      Co-authored-by: default avatarChris Sosnin <[email protected]>
      
      * Add back missing line.
      
      * Fix test.
      
      * fmt fix.
      
      * Add missing test annotation
      
      ---------
      
      Co-authored-by: default avatareskimor <[email protected]>
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarTsvetomir Dimitrov <[email protected]>
      Co-authored-by: default avatarChris Sosnin <[email protected]>
      367098ba
    • Marcin S.'s avatar
      PVF: Fix external workers being required for non-collator full nodes (#7566) · f226cd5a
      Marcin S. authored
      * PVF: Fix external workers being required for non-collator full nodes
      
      * Fix
      
      * Make check more precise
      
      > This might as well be if role.is_authority() as there aren't really any nodes
      > that are both authorities and collators. But if there were a node that is an
      > authority and a collator, it'd probably want to validate candidates (in its
      > role as an authority).
      
      * Just seeing if this fixes zombienet CI...
      f226cd5a
  4. Jul 31, 2023
    • Marcin S.'s avatar
      98.6% OF DEVELOPERS CANNOT REVIEW THIS PR! [read more...] (#7337) · 85b06f18
      Marcin S. authored
      
      
      * [WIP] PVF: Split out worker binaries
      
      * Address compilation problems and re-design a bit
      
      * Reorganize once more, fix tests
      
      * Reformat with new nightly to make `cargo fmt` test happy
      
      * Address `clippy` warnings
      
      * Add temporary trace to debug zombienet tests
      
      * Fix zombienet node upgrade test
      
      * Fix malus and its CI
      
      * Fix building worker binaries with malus
      
      * More fixes for malus
      
      * Remove unneeded cli subcommands
      
      * Support placing auxiliary binaries to `/usr/libexec`
      
      * Fix spelling
      
      * Spelling
      
      Co-authored-by: default avatarMarcin S. <[email protected]>
      
      * Implement review comments (mostly nits)
      
      * Fix worker node version flag
      
      * Rework getting the worker paths
      
      * Address a couple of review comments
      
      * Minor restructuring
      
      * Fix CI error
      
      * Add tests for worker binaries detection
      
      * Improve tests; try to fix CI
      
      * Move workers module into separate file
      
      * Try to fix failing test and workers not printing latest version
      
      - Tests were not finding the worker binaries
      - Workers were not being rebuilt when the version changed
      - Made some errors easier to read
      
      * Make a bunch of fixes
      
      * Rebuild nodes on version change
      
      * Fix more issues
      
      * Fix tests
      
      * Pass node version from node into dependencies to avoid recompiles
      
      - [X] get version in CLI
      - [X] pass it in to service
      - [X] pass version along to PVF
      - [X] remove rerun from service
      - [X] add rerun to CLI
      
      - [X] don’t rerun pvf/worker’s (these should be built by nodes which have rerun enabled)
      
      * Some more improvements for smoother tests
      
      - [X] Fix tests
      - [X] Make puppet workers pass None for version and remove rerun
      - [X] Make test collators self-contained
      
      * Add back rerun to PVF workers
      
      * Move worker binaries into files in cli crate
      
      As a final optimization I've separated out each worker binary from its own crate
      into the CLI crate. Before, the worker bin shared a crate with the worker lib,
      so when the binaries got recompiled so did the libs and everything transitively
      depending on the libs. This commit fixes this regression that was causing
      recompiles after every commit.
      
      * Fix bug (was passing worker version for node version)
      
      * Move workers out of cli into root src/bin/ dir
      
      - [X] Pass in node version from top-level (polkadot)
      - [X] Add build.rs with rerun-git-head to root dir
      
      * Add some sanity checks for workers to dockerfiles
      
      * Update malus
      
        + [X] Make it self-contained
        + [X] Undo multiple binary changes
      
      * Try to fix clippy errors
      
      * Address `cargo run` issue
      
      - [X] Add default-run for polkadot
      - [X] Add note about installation to error
      
      * Update readme (installation instructions)
      
      * Allow disabling external workers for local/testing setups
      
        + [X] cli flag to enable single-binary mode
        + [X] Add message to error
      
      * Revert unnecessary Cargo.lock changes
      
      * Remove unnecessary build scripts from collators
      
      * Add back missing malus commands (should fix failing ZN job)
      
      * Some minor fixes
      
      * Update Cargo.lock
      
      * Fix some build errors
      
      * Undo self-contained binaries; cli flag to disable version check
      
        + [X] Remove --dont-run-external-workers
        + [X] Add --disable-worker-version-check
        + [X] Remove PVF subcommands
        + [X] Redo malus changes
      
      * Try to fix failing job and add some docs for local tests
      
      ---------
      
      Co-authored-by: default avatarDmitry Sinyavin <[email protected]>
      Co-authored-by: default avatars0me0ne-unkn0wn <[email protected]>
      Co-authored-by: parity-processbot <>
      85b06f18
  5. Jul 25, 2023
  6. Jul 22, 2023
    • jserrat's avatar
      add tests to worker common thread (#7372) · 3f8c3454
      jserrat authored
      
      
      * add tests to worker common thread
      
      * fix formatting
      
      * move worker commons unit test from integration tests to worker file and do some improvements
      
      * fix import on it/worker_common
      
      * move worker commons unit test to test module
      
      * cargo fmt
      
      * move cpu_time_monitor_loop to test outside of thread module
      
      * change worker thread unit test to use assert_eq
      
      * fix formatting
      
      * adding new methods to WaitOucome, fix pvf worker unit test
      
      * fix formatting
      
      * remove is_finished and is_timeout methods from WaitOutcome
      
      * fix wait_for_threads_with_timeout_returns_outcome test
      
      * ".git/.scripts/commands/fmt/fmt.sh"
      
      * add common worker cond_notify_on_done_should_update_wait_outcome_when_panic test
      
      ---------
      
      Co-authored-by: default avatarMarcin S <[email protected]>
      Co-authored-by: command-bot <>
      3f8c3454
  7. Jul 21, 2023
  8. Jul 20, 2023
  9. Jul 19, 2023
    • Francisco Aguirre's avatar
      Change Fixed to WeightInfoBounds for Polkadot (#7077) · cc9f8129
      Francisco Aguirre authored
      
      
      * Add polkadot XCM benchmarks
      
      * Add temp
      
      * ".git/.scripts/commands/bench/bench.sh" xcm polkadot pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm polkadot pallet_xcm_benchmarks::generic
      
      * Add weights to XCM on Polkadot
      
      * Make CI fail on old files
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Update template
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Add reserve_asset_deposited benchmark
      
      * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::generic
      
      * Update weights
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Change initiate_reserve_deposit in runtime weights
      
      * Update weights
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      
      * Remove trusted reserves from runtimes
      
      * Fix pallet-xcm-benchmarks mock
      
      * Fix test
      
      * Change pallet xcm weigher in kusama
      
      * Fix
      
      * Remove merge conflict artifact
      
      * Remove initiate_reserve_withdraw from generic benchmarks
      
      * Add missing implementation to XCM benchmark
      
      * Fix failing karura test
      
      * Remove dbg!
      
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      
      * Fix fmt
      
      * Revert "Fix fmt"
      
      This reverts commit 676f2d8db07d7427750c79f95494d4988d06fda5.
      
      * Fix fmt
      
      * Remove duplicated template code
      
      * Add back part of the template
      
      * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible
      
      * Don't skip reserve asset deposited benchmark
      
      * Remove call to non-generated benchmark yet
      
      * Underscore unused parameter
      
      * Skip not supported benchmarks and hardcode value
      
      * Remove ReserveAssetDeposited benchmark
      
      * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible
      
      * Add back ReserveAssetDeposited
      
      * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm polkadot pallet_xcm_benchmarks::fungible
      
      * Use default benchmark for ReserveAssetDeposited
      
      * Add missing parameter
      
      * Revert reserve asset deposited benchmark
      
      * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm kusama pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench-vm/bench-vm.sh" xcm westend pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm rococo pallet_xcm_benchmarks::fungible
      
      * Add 'real' benchmarks
      
      * Add TrustedReserve to actual XcmConfig
      
      * Add TrustedReserve to actual XcmConfig (fix)
      
      * Whitelist from benchmarking XCM storage keys read each block (#6871)
      
      * Whitelist from benchmarking XCM storage keys read each block
      
      * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm
      
      * Remove XcmPallet SupportedVersion from the benchmark whitelist
      
      * ".git/.scripts/commands/bench/bench.sh" runtime polkadot pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime kusama pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime westend pallet_xcm
      
      * ".git/.scripts/commands/bench/bench.sh" runtime rococo pallet_xcm
      
      * WIP
      
      * Add necessary traits, remove unnecessary whitelisted keys
      
      * Fix tests
      
      * Remove unused file
      
      * Remove unused import
      
      ---------
      
      Co-authored-by: command-bot <>
      
      * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm kusama pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm rococo pallet_xcm_benchmarks::fungible
      
      * ".git/.scripts/commands/bench/bench.sh" xcm westend pallet_xcm_benchmarks::fungible
      
      * Fix spellchecker issues
      
      * Remove unused migration code
      
      ---------
      
      Signed-off-by: default avatarOliver Tale-Yazdi <[email protected]>
      Co-authored-by: command-bot <>
      Co-authored-by: default avatarOliver Tale-Yazdi <[email protected]>
      Co-authored-by: default avatarKeith Yeung <[email protected]>
      cc9f8129
  10. Jul 18, 2023
    • Michal Kucharczyk's avatar
      `chain-spec`: `polkadot_staging_testnet` config removed (#7509) · b15a5697
      Michal Kucharczyk authored
      * chain-spec: polkadot_staging_testnet config removed
      
      The config has empty initial authority test. It is unusable.
      
      ```
      $ polkadot export-blocks --chain polkadot-staging --from=0 --to=0
      ...
      Thread 'main' panicked at 'Empty validator set for session 0 in genesis block!',
      /home/miszka/.cargo/git/checkouts/substrate-7e08433d4c370a21/c446786/frame/session/src/lib.rs:463
      ```
      
      * warning fix
      b15a5697
    • André Silva's avatar
      companion for substrate#14423 (#7484) · 9f760192
      André Silva authored
      * companion for substrate#14423
      
      * update lockfile for {"substrate"}
      
      * update lockfile for {"substrate"}
      
      ---------
      
      Co-authored-by: parity-processbot <>
      9f760192
  11. Jul 17, 2023
    • Andrei Eres's avatar
      Alert on frequent network errors (#7410) · 174f23d1
      Andrei Eres authored
      * Introduce is_frequent util
      
      * Add dirty warn_if_frequent! implementation
      
      * Add freq
      
      * Fix order in condition
      
      * Update
      
      * Update docs
      
      * Fix
      
      * Remove old impl
      
      * Fix errors
      
      * Add wif to av-distr
      
      * Add wif to col prot
      
      * Rename
      
      * Add wif to state-distr
      
      * Address review comments
      
      * Change Freq implementation
      
      * Remove the zero division check
      
      * Make rate explicit
      
      * Fix typo
      
      * Update rate constant
      
      * Introduce explicit rates
      
      * Update docs
      
      * Split errors freq
      
      * Downgrade coarsetime
      174f23d1
  12. Jul 12, 2023
  13. Jul 11, 2023
  14. Jul 07, 2023
  15. Jul 06, 2023
  16. Jul 05, 2023
  17. Jul 04, 2023
  18. Jun 29, 2023
  19. Jun 23, 2023
  20. Jun 22, 2023
  21. Jun 21, 2023
  22. Jun 16, 2023
    • juangirini's avatar
      Companion for Soft deprecate GenesisConfig (#7288) · ced77b3d
      juangirini authored
      * update genesis config
      
      * fix wrong RuntimeGenesisConfig name
      
      * update lockfile for {"substrate"}
      
      ---------
      
      Co-authored-by: parity-processbot <>
      ced77b3d
    • Mira Ressel's avatar
      docs: update references to NetworkConfiguration::extra_sets (#7386) · e7560710
      Mira Ressel authored
      * docs: update references to NetworkConfiguration::extra_sets
      
      Since paritytech/substrate#14080, this struct field no longer exists,
      now the `add_notification_protocol()` function of
      `sc_network::config::FullNetworkConfiguration` is used.
      
      Also neuter the doc links for now; rustdoc can't resolve them
      (presumably because sc_network::config isn't in scope, though weirdly
      enough even spelling the link out as
      ``[`FullNetworkConfiguration`](struct@sc_network::config::FullNetworkConfiguration)``
      doesn't work?). Normally this wouldn't be an issue and rustdoc would
      just not generate links, but rust 1.70 has a bug that completely crashes
      rustdoc in this case.
      e7560710
    • Aaro Altonen's avatar
      Wait peers to connect before doing anything else (#7375) · 134655ee
      Aaro Altonen authored
      There is a race condition in `NetworkBridgeRx` between registering
      incoming peers and handling overseer signals. While the peer connection
      was sent to `NetworkBridgeRx` first, sometimes the peer would be added to
      `validation/collation_peers` with enough delay that the bridge handled
      an overseer signal that was meant do send notifications to the registered
      peer and as the peer was not present in the bridge, the notification was
      never sent and the test would hang.
      
      When peers are registered to `NetworkBridgeRx` using `connect_peer()`,
      wait until they show up in `shared.validation/collation_peers` before
      doing anything else.
      
      Co-authored-by: parity-processbot <>
      134655ee
  23. Jun 15, 2023
    • Andrei Eres's avatar
      Delay reputation updates (#7214) · 0a1bc654
      Andrei Eres authored
      
      
      * Add futures-timer
      
      * Make cost_or_benefit public
      
      * Update ReportPeer message format
      
      * Add delay to reputation updates (dirtywork)
      
      * Update ReputationAggregator
      
      * Update tests
      
      * Fix flucky tests
      
      * Move reputation to state
      
      * Use the main loop for handling reputation sendings
      
      * Update
      
      * Move reputation to utils
      
      * Update reputation sending
      
      * Fix arguments order
      
      * Update state
      
      * Remove new from state
      
      * Add constant
      
      * Add failing test for delay
      
      * Change mocking approach
      
      * Fix type errors
      
      * Fix comments
      
      * Add message handling to select
      
      * Fix bitfields-distribution tests
      
      * Add docs to reputation aggregator
      
      * Replace .into_base_rep
      
      * Use one REPUTATION_CHANGE_INTERVAL by default
      
      * Add reputation change to statement-distribution
      
      * Update polkadot-availability-bitfield-distribution
      
      * Update futures selecting in subsystems
      
      * Update reputation adding
      
      * Send malicious changes right away without adding to state
      
      * Add reputation to StatementDistributionSubsystem
      
      * Handle reputation in statement distribution
      
      * Add delay test for polkadot-statement-distribution
      
      * Fix collator-protocol tests before applying reputation delay
      
      * Remove into_base_rep
      
      * Add reputation to State
      
      * Fix failed tests
      
      * Add reputation delay
      
      * Update tests
      
      * Add batched network message for peer reporting
      
      * Update approval-distribution tests
      
      * Update bitfield-distribution tests
      
      * Update statement-distribution tests
      
      * Update collator-protocol tests
      
      * Remove levels in matching
      
      * Address clippy errors
      
      * Fix overseer test
      
      * Add a metric for original count of rep changes
      
      * Update Reputation
      
      * Revert "Add a metric for original count of rep changes"
      
      This reverts commit 6c9b0c1ec34491d16e562bdcba8db6b9dcf484db.
      
      * Update node/subsystem-util/src/reputation.rs
      
      Co-authored-by: default avatarVsevolod Stakhov <[email protected]>
      
      * Remove redundant vec
      
      ---------
      
      Co-authored-by: default avatarVsevolod Stakhov <[email protected]>
      0a1bc654
  24. Jun 14, 2023
    • Andrei Sandu's avatar
      adjust buckets (#7368) · edfbbc8c
      Andrei Sandu authored
      
      
      Signed-off-by: default avatarAndrei Sandu <[email protected]>
      edfbbc8c
    • eskimor's avatar
      Unify code paths of create_inherent and enter (#7137) · 596a9ccd
      eskimor authored
      
      
      * Remove redundant enter call.
      
      * Remove optionality in dispute signature checking
      
      * Make enter_inner and create_inherent the same.
      
      * Remove redundant metric.
      
      * Unification: enter and create_inherent.
      
      * Remove `enter_inner` function.
      
      * Remove dead code.
      
      * Remove redundant import.
      
      * Remove dead code in disputes.
      
      * ".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent
      
      * ".git/.scripts/commands/bench/bench.sh" runtime kusama runtime_parachains::paras_inherent
      
      * ".git/.scripts/commands/bench/bench.sh" runtime westend runtime_parachains::paras_inherent
      
      * Merge fix.
      
      * Fix tests.
      
      * Remove obsolete comment.
      
      * ".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent
      
      * ".git/.scripts/commands/bench/bench.sh" runtime westend runtime_parachains::paras_inherent
      
      * ".git/.scripts/commands/bench/bench.sh" runtime kusama runtime_parachains::paras_inherent
      
      * Review remarks, fixes.
      
      * Guide updates.
      
      * Fmt.
      
      * ".git/.scripts/commands/bench/bench.sh" runtime polkadot runtime_parachains::paras_inherent
      
      ---------
      
      Co-authored-by: default avatareskimor <[email protected]>
      Co-authored-by: command-bot <>
      596a9ccd
  25. Jun 12, 2023
  26. Jun 11, 2023