Skip to content
  1. Nov 17, 2022
  2. Nov 16, 2022
    • Tsvetomir Dimitrov's avatar
      Provisioner should ignore unconfirmed disputes (#6294) · a0f4287d
      Tsvetomir Dimitrov authored
      * Fix typos
      
      * Filter unconfirmed disputes in provisioner -  random_selection
      
      * Rework dispute coordinator to return `DisputeStatus` with
      `ActiveDisputes` message.
      * Rework the random_selection implementation of `select_disptues` in
        `provisioner` to return only confirmed disputes.
      
      * Filter unconfirmed disputes in provisioner - prioritized_selection
      
      * Add test for unconfirmed disputes handling
      
      * Fix `dispute-distribution` tests
      a0f4287d
    • Alexander Samusev's avatar
      [ci] Improve pipeline stopper (#6300) · 40221806
      Alexander Samusev authored
      * [ci] Improve pipeline stopper
      
      * break test-linux-stable
      
      * fix test-linux-stable
      40221806
  3. Nov 15, 2022
    • Niklas Adolfsson's avatar
      companion for #12599 (#6290) · 4b9f3aa8
      Niklas Adolfsson authored
      * companion for #12599
      
      * update Cargo.lock
      
      * use cargo path instead of diener
      
      * update lockfile for {"substrate"}
      
      Co-authored-by: parity-processbot <>
      4b9f3aa8
    • Marcin S.'s avatar
      Fixes "for loop over an `Option`" warnings (#6291) · d53513ff
      Marcin S. authored
      Was seeing these warnings when running `cargo check --all`:
      
      ```
      warning: for loop over an `Option`. This is more readably written as an `if let` statement
          --> node/core/approval-voting/src/lib.rs:1147:21
           |
      1147 |             for activated in update.activated {
           |                              ^^^^^^^^^^^^^^^^
           |
           = note: `#[warn(for_loops_over_fallibles)]` on by default
      help: to check pattern in a loop use `while let`
           |
      1147 |             while let Some(activated) = update.activated {
           |             ~~~~~~~~~~~~~~~         ~~~
      help: consider using `if let` to clear intent
           |
      1147 |             if let Some(activated) = update.activated {
           |             ~~~~~~~~~~~~         ~~~
      ```
      
      My guess is that `activated` used to be a SmallVec or similar, as is
      `deactivated`. It was changed to an `Option`, the `for` still compiled (it's
      technically correct, just weird), and the compiler didn't catch it until now.
      d53513ff
    • eskimor's avatar
      c606deb3
  4. Nov 14, 2022
  5. Nov 13, 2022
  6. Nov 12, 2022
  7. Nov 11, 2022
    • Tsvetomir Dimitrov's avatar
      Update disputes prioritisation in `dispute-coordinator` (#6130) · ff09b18d
      Tsvetomir Dimitrov authored
      
      
      * Scraper processes CandidateBacked events
      
      * Change definition of best-effort
      
      * Fix `dispute-coordinator` tests
      
      * Unit test for dispute filtering
      
      * Clarification comment
      
      * Add tests
      
      * Fix logic
      
      If a dispute is not backed, not included and not confirmed we
      don't participate but we do import votes.
      
      * Add metrics for refrained participations
      
      * Revert "Add tests"
      
      This reverts commit 7b8391a087922ced942cde9cd2b50ff3f633efc0.
      
      * Revert "Unit test for dispute filtering"
      
      This reverts commit 92ba5fe678214ab360306313a33c781338e600a0.
      
      * fix dispute-coordinator tests
      
      * Fix scraping
      
      * new tests
      
      * Small fixes in guide
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarAndrei Sandu <[email protected]>
      
      * Fix some comments and remove a pointless test
      
      * Code review feedback
      
      * Clarification comment in tests
      
      * Some tests
      
      * Reference counted `CandidateHash` in scraper
      
      * Proper handling for Backed and Included candidates in scraper
      
      Backed candidates which are not included should be kept for a
      predetermined window of finalized blocks. E.g. if a candidate is backed
      but not included in block 2, and the window size is 2, the same
      candidate should be cleaned after block 4 is finalized.
      
      Add reference counting for candidates in scraper. A candidate can be
      added on multiple block heights so we have to make sure we don't clean
      it prematurely from the scraper.
      
      Add tests.
      
      * Update comments in tests
      
      * Guide update
      
      * Fix cleanup logic for `backed_candidates_by_block_number`
      
      * Simplify cleanup
      
      * Make spellcheck happy
      
      * Update tests
      
      * Extract candidate backing logic in separate struct
      
      * Code review feedback
      
      * Treat  backed and included candidates in the same fashion
      
      * Update some comments
      
      * Small improvements in test
      
      * spell check
      
      * Fix some more comments
      
      * clean -> prune
      
      * Code review feedback
      
      * Reword comment
      
      * spelling
      
      Co-authored-by: default avatarAndrei Sandu <[email protected]>
      ff09b18d
    • Bradley Olson's avatar
      Brad implementers guide revisions 2 (#6239) · 0cea4eed
      Bradley Olson authored
      * Add disputes subsystems fix
      
      * Updated dispute approval vote import reasoning
      
      * Improved wording of my changes
      
      * Resolving issues brought up in comments
      0cea4eed
    • cheme's avatar
      State trie migration rococo runtime changes. (#6127) · 79d9ea4f
      cheme authored
      * add state-trie-migration (warn key need to be changed)
      
      * rococo root
      
      * restore master benchs (weights from substrate are used).
      
      * use ord_parameter macro.
      
      * do not upgrade runtime version yet
      
      * apply review changes
      
      * to test ci
      
      * Revert "to test ci"
      
      This reverts commit 5df6c5c74c5d172f254579cbb76caeb44af80ec2.
      
      * test ci
      
      * Revert "test ci"
      
      This reverts commit 0747761644ba566f9756e195e5304758370dc52c.
      
      Co-authored-by: parity-processbot <>
      79d9ea4f
  8. Nov 10, 2022
  9. Nov 09, 2022
  10. Nov 08, 2022
  11. Nov 07, 2022
  12. Nov 05, 2022
  13. Nov 04, 2022
  14. Nov 03, 2022
    • Sergej Sakac's avatar
      Xcm-Simulator Docs (#6178) · 63d7ce61
      Sergej Sakac authored
      * Xcm-Simulator Docs
      
      * spelling
      
      * examples
      
      * better docs
      
      Co-authored-by: parity-processbot <>
      63d7ce61
    • Michal Kucharczyk's avatar
      BlockId removal: refactor: Backend::block_indexed_body (#6233) · a87b2e52
      Michal Kucharczyk authored
      * BlockId removal: refactor: Backend::block_indexed_body
      
      It changes the arguments of `Backend::block_indexed_body` method from: `BlockId<Block>` to: `&Block::Hash`
      
      This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)
      
      * update lockfile for {"substrate"}
      
      Co-authored-by: parity-processbot <>
      a87b2e52
  15. Nov 02, 2022
    • Michal Kucharczyk's avatar
      BlockId removal: refactor: Backend::justifications (#6229) · a4a5fa85
      Michal Kucharczyk authored
      * BlockId removal: refactor: Backend::justifications
      
      It changes the arguments of `Backend::justifications` method from: `BlockId<Block>` to: `&Block::Hash`
      
      This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)
      
      * formatting
      
      * update lockfile for {"substrate"}
      
      Co-authored-by: parity-processbot <>
      a4a5fa85
  16. Nov 01, 2022
    • alexgparity's avatar
      Replace parachain/parathread boolean by enum (#6198) · 6d83525b
      alexgparity authored
      
      
      * Replace parachain/parathread boolean by enum
      
      * Address PR comments
      
      * Update dependencies
      
      * ParaType -> ParaKind
      
      * Swap enum field order to avoid migration
      
      * Rename paratype field to parakind
      
      * Manual en-/decocing of Parakind
      
      * Manual TypeInfo for ParaKind
      
      * rename field back to parachain
      
      * minor
      
      * Update runtime/parachains/src/paras/mod.rs
      
      Co-authored-by: default avatarAndrei Sandu <[email protected]>
      
      * Manual serde Serialize and Deserialize for ParaKind
      
      * cargo fmt
      
      * Update runtime/parachains/src/paras/mod.rs
      
      Co-authored-by: default avatarAndronik <[email protected]>
      
      * Add test for serde_json encoding/decoding
      
      * Move serde_json dep to dev-deps
      
      Co-authored-by: default avatarAndrei Sandu <[email protected]>
      Co-authored-by: default avatarAndronik <[email protected]>
      6d83525b
    • Michal Kucharczyk's avatar
      BlockId removal: refactor: BlockBackend::block_body (#6223) · be70e445
      Michal Kucharczyk authored
      * BlockId removal: refactor: BlockBackend::block_body
      
      It changes the arguments of `BlockBackend::block_body` method from: `BlockId<Block>` to: `&Block::Hash`
      
      This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)
      
      * update lockfile for {"substrate"}
      
      Co-authored-by: parity-processbot <>
      be70e445
    • Marcin S.'s avatar
      PVF timeouts follow-up (#6151) · 1f821976
      Marcin S. authored
      * Rename timeout consts and timeout parameter; bump leniency
      
      * Update implementor's guide with info about PVFs
      
      * Make glossary a bit easier to read
      
      * Add a note to LENIENT_PREPARATION_TIMEOUT
      
      * Remove PVF-specific section from glossary
      
      * Fix some typos
      1f821976
  17. Oct 31, 2022