Skip to content
Snippets Groups Projects
  1. Jan 17, 2023
  2. Jan 16, 2023
    • Michal Kucharczyk's avatar
      txpool: don't maintain the pool during major sync (#13004) · 5134dabb
      Michal Kucharczyk authored
      
      * txpool: don't maintain the pool during major sync
      
      Fix shall prevent from wasting the CPU during the major sync. No actions
      are actually required in transaction pool during the major sync.
      
      Fixes: #12903
      
      * passing sync_oracle to maintain method
      
      * fixed: builder, txpool tests
      
      * do not maintain tx-pool if node gone out of sync
      
      * EnactmentAction: all logic moved to EnactmentState
      
      Tests to be done.
      
      * maintain guard logic moved directly to MaintainedTransactionPool
      
      * minor fixes
      
      * EnactmentAction: all logic moved to EnactmentState (again)
      
      * SyncOracle fixes here and there
      
      * Update client/transaction-pool/src/enactment_state.rs
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      
      * Update client/transaction-pool/src/enactment_state.rs
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      
      * sync_oracle removed
      
      * spelling + fmt + doc
      
      * Review suggestions applied
      
      * log::info -> debug
      
      * Update client/transaction-pool/src/enactment_state.rs
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      
      * ".git/.scripts/commands/fmt/fmt.sh"
      
      Co-authored-by: parity-processbot <>
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      5134dabb
    • JP's avatar
      More improvements for the crate publishing pipeline (#13153) · 21141f5d
      JP authored
      * more improvements for the crate publishing pipeline
      
      * move default definitions to the publish-crates script
      
      * add script to check the crate publishing pipeline at the start
      
      * fix yaml references
      
      * move more variables to .crates-publishing-pipeline
      
      * separate .crates-publishing-pipeline from .crates-publishing-variables
      
      * clean up redundant and unused code
      21141f5d
    • Bastian Köcher's avatar
      pallet-offences-benchmarking: Box events in verify (#13151) · 52a56e5f
      Bastian Köcher authored
      * pallet-offences-benchmarking: Box events in verify
      
      Events in frame are represented by an enum in the pallet and the runtime. The size of an enum in
      Rust depends on the size of biggest variant. This means we always need to allocate memory for the
      biggest variant when allocating memory for an event. The offences benchmarking is verifying the
      benchmarking results by checking the events. To check the events it is generating all the expected
      events. With the recent changes in Polkadot the events are too big and lead to issues when running
      this verify functions. The solution is to box each event, as the vector holding all the events will
      then only need to hold fat pointers * expected events, instead of size_of(event) * expected events.
      This issue isn't a problem in production, as we never read the events on chain. When we are reading
      the events, it is done in an offchain context and they are only decoded one by one.
      
      Besides that this also enables the benchmarking verification for everyone running these benchmarks.
      
      * FMT
      
      * Disable checking again
      52a56e5f
  3. Jan 15, 2023
  4. Jan 13, 2023
  5. Jan 12, 2023
  6. Jan 11, 2023
  7. Jan 10, 2023
    • Vladimir Istyufeev's avatar
      Update tests for 1.66 and switch CI to stable Rust 1.66 (#13118) · 280fce71
      Vladimir Istyufeev authored
      * Update UI tests for 1.66
      
      * Fix `test_enum` assertion for Rust 1.66
      
      * Fix another `test_enum` assertion for Rust 1.66
      
      * Fix another `test_enum` assertion for Rust 1.66
      
      * Fix another `test_enum` assertion for Rust 1.66
      280fce71
    • Anthony Alaribe's avatar
      introduce log-target constant to more frame pallets (#13116) · c04e68fd
      Anthony Alaribe authored
      
      * introduce log-target constant to more frame pallets
      
      * cargo fmt
      
      * make LOG_TARGET in session public
      
      * Update frame/elections-phragmen/src/lib.rs
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      
      * Update frame/elections-phragmen/src/migrations/v3.rs
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      
      * Update frame/elections-phragmen/src/migrations/v3.rs
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      
      * Update frame/elections-phragmen/src/migrations/v3.rs
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      
      * move LOG_TARGET=runtime::session_historical to migrations module, where it's actually used
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      c04e68fd
    • JP's avatar
      Avoid unintentionally canceling the scheduled crate publishing job (#13088) · 72f086b7
      JP authored
      
      * avoid unintentionally canceling the scheduled crate publishing job
      
      because publish-crates and publish-crates-manual share the resource group
      "crates-publishing", any instance of publish-crates-manual cancels a running
      instance of publish-crates, as demonstrated by
      https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2212179
      
      a workaround for that unintended interaction is to avoid creating instances of
      publish-crates-manual and instead require pipelines to be triggered manually by
      checking $CI_JOB_MANUAL == "true"
      
      * check manual pipelines by $CI_PIPELINE_SOURCE instead of $CI_JOB_MANUAL
      
      * make crate-publishing pipelines uninterruptible
      
      * use conditional includes to work around interruptible limitations
      
      * organize comments
      
      * remove interruptible from common pipeline
      
      * wip: check include
      
      * wip: check include
      
      * fix include
      
      * fix include
      
      * fix include
      
      * fix yaml
      
      * fix yaml
      
      * remove shared common-pipeline
      
      * wip: retry common-pipeline
      
      * move .default-template to .gitlab-ci.yml
      
      * fix the pipeline
      
      add comments
      
      * fix default-pipeline.yml
      
      * revert publish-crates-manual to when: manual
      
      * move "needs:" back to publish-crates
      
      * avoid manual repetition
      
      * improve previous commit
      
      * try to avoid manual repetition
      
      * fix indentation
      
      * minor adjustments
      
      * move defaults to top of .gitlab-ci.yml
      
      * fix positioning on default in the diff
      
      * comments
      
      * indentation
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarAlexander Samusev <41779041+alvicsam@users.noreply.github.com>
      
      Co-authored-by: default avatarAlexander Samusev <41779041+alvicsam@users.noreply.github.com>
      72f086b7
    • alexgparity's avatar
      Add solution hint to error message (#13111) · dcbccbd6
      alexgparity authored
      
      * Add solution hint to error message
      
      * make it compile
      
      * Update frame/support/procedural/src/pallet/expand/hooks.rs
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      
      * Update frame/support/procedural/src/pallet/expand/storage.rs
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      
      * Update frame/support/procedural/src/pallet/expand/storage.rs
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      
      * Update frame/support/procedural/src/pallet/expand/storage.rs
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      
      Co-authored-by: default avatarBastian Köcher <git@kchr.de>
      dcbccbd6
  8. Jan 09, 2023
  9. Jan 08, 2023
  10. Jan 07, 2023
  11. Jan 06, 2023
  12. Jan 05, 2023