Before the refactoring the sync loop would wait until a client finished
handling a request before issuing another one. This behaviour was
inadvertently changed during the refactoring leading to race conditions.
This commit makes sure that the previous behaviour is respected.

Svyatoslav Nikolsky authored Jun 18, 2020 and Hernando Castano committed Jun 18, 2020

Both Substrate and Ethereum's RPCs use positional (array) parameters,
so in order to be compatible with both we need to make sure that
our API is defined with positional paramters in mind.

Some of the RPCs that were "high level" didn't necessarily belong
as part of the trait, so they were removed.

By using a `jsonrpsee::Client` we are able to remove all the shared
mutable references required when interacting with the RPC server. This
is convenient as trying to sharing mutable references in code that uses
async/await is a bit of a pain.

However, using a `Client` instead of a `RawClient` is not yet supported
by the `jsonrpsee::rpc_api` macro, so a fork must be used for the moment.

* Use async_trait for SourceClient

* Use aync_trait for TargetClient

* Revert async_trait usage for Source/Target client

This reverts commit f636ffaf.
This reverts commit 2c15755e

.

I'm having a very hard time finding out what is causing compilation
issues, and I think it's best to start over again.

* Use async_trait for TargetClient

* Use async_trait for SourceClient

* Move where non-async methods are

* RustFmt

* QueuedHeader holds Arc to actual data

* Clean up async return type

Co-authored-by: Svyatoslav Nikolsky <[email protected]>

* Clean up async return type

Co-authored-by: Svyatoslav Nikolsky <[email protected]>

* Clean up async return type

Co-authored-by: Svyatoslav Nikolsky <[email protected]>

* Remove unused import

Co-authored-by: Svyatoslav Nikolsky <[email protected]>

* Substrate 606c56d2e2f69f68f3947551224be6a3515dff60

* update jsonrpsee

* Add diagrams from draw.io

I'm trying to figure out how best to share these in such a way that we
can all contribute to them easily. While integration between draw.io
and GitHub exists, it requires read/write permissions to all ParityTech
repos, which doesn't comfort me. I think having the .drawio file and
the corresponding pictures available in a folder is a good start.

I imagine the workflow would be something like this: Someone wants to
update a diagram, so they go to draw.io and upload the .drawio file
from the repo. They make their changes, download the new .drawio file
and corresponding SVG, and commit their changes to the repo.

* Make diagrams consistent with background/filling

The background for each diagram has been removed (now it's transparent)
and the boxes that make up the diagrams have gotten a filled in white
colour. This will make it possible to have these diagrams show up on
non-white backgrounds.

* Add file for describing diagrams

* Add missing extension

* removeInMemoryStorage + extract Kovan stuff to runtime

* removed comment from the future

* remove redundant conversions

* remove redundant `u8 as usize`

* remove redundant `u8 as usize`

* Update modules/ethereum/src/mock.rs

Co-authored-by: Hernando Castano <[email protected]>

* use hex-literal in kovan config

* cargo fmt --all

* extracted insert_header

* cargo fmt --all

* finality cache

* cargo fmt --all

* cargo fmt --all

* impl Default for FinalityVotes

Co-authored-by: Hernando Castano <[email protected]>
Co-authored-by: Hernando Castano <[email protected]>

* Revert "Bump async-std from 1.5.0 to 1.6.0 (#126)"

This reverts commit a865976e.

* Add async-std=1.6 to ignore.

* Add descriptions for folder structure + node

* Beef up descriptions of project components

* Fix list formatting

* Add note about nightly Rust

* Update README.md

Co-authored-by: Tomasz Drwięga <[email protected]>

* Update README.md

Co-authored-by: Tomasz Drwięga <[email protected]>

* Reword Tomek's currency-exchange suggestion

* Add link to Substrate's installation guide

Co-authored-by: Tomasz Drwięga <[email protected]>