Merge branch 'generate-json-rpc-doc' of https://github.com/cpurta/parity-ethereum into cpurta-generate-json-rpc-doc-03

Niklas Adolfsson authored Aug 17, 2018 and ordian committed Aug 17, 2018

* Enable more logs for light client `on_demand`

* Remove extra whitespace

* fix indentation

Niklas Adolfsson authored Aug 17, 2018 and Andrew Jones committed Aug 17, 2018

* Provide `default_nonce` in tx`s when it´s missing

When `nonce` is missing in a `EthTransaction` will cause it to fall in
these cases provide `default_nonce` value instead!

* Changed http:// to https:// on Yasm link (#9369)

Changed http:// to https:// on Yasm link in README.md

* Provide `default_nonce` in tx`s when it´s missing

When `nonce` is missing in a `EthTransaction` will cause it to fall in
these cases provide `default_nonce` value instead!

* Address grumbles

Marius Kjærstad authored Aug 17, 2018 and Wei Tang committed Aug 17, 2018

Changed http:// to https:// on Yasm link in README.md

Tomasz Drwięga authored Aug 14, 2018 and Marek Kotewicz committed Aug 14, 2018

* Lower the max size of transaction packet to prevent going oversize.

* Log RLP size.

This refactors `prepare_trace_output` to instead directly take the reference of return values, so that it's simpler and we save a stack item. This should also fixes [the issue](https://github.com/paritytech/parity-ethereum/pull/9236#issuecomment-408444995) @udoprog is facing. Replaces #9236 

Tomasz Drwięga authored Aug 14, 2018 and Niklas Adolfsson committed Aug 14, 2018

* Log details for light logs.

* Create Log directly.

cheme authored Aug 14, 2018 and Marek Kotewicz committed Aug 14, 2018

* Fix PubSub for logs when using light client :
prior to this fix the pubsub process did send a
query for each new block header (and for each subs : there is something
to optimize here) by setting from and to of the filter at this block
number; but there was a bug in the code that fetch logs : it was non
inclusive for its start bound, meaning that with start bound = end bound
we never query any block (and attached logs).

* Option iter instead of once.
Use of bloom existing function to check if a bloom contains another.

* Makes from block header checking explicit

* Remove pass-by-reference return data value from executive

* Fix tests

* Fix a missing test output

* typo: wasm_activation_test

* Tracing change in output

* json_tests: fix compile

* typo: 0..32 -> ..32 to keep it consistent with other occurance

* Fix tests

* Feed in ActionParams on VM creation

* Fix ethcore after Vm interface change

* Move informant inside Interpreter struct

* Move do_trace to Interpreter struct

* Move all remaining exec variables to Interpreter struct

* Refactor VM to allow single opcode step

* Fix all EVM tests

* Fix all wasm tests

* Fix wasm runner tests

* Fix a check case where code length is zero

* Fix jsontests compile

* Fix cargo lock

* Use match instead of expect

* Use cheaper check reader.len() == 0 for the initial special case

* Get rid of try_and_done! macro by using Result<(), ReturnType>

* Use Never instead of ()

* Fix parity-bytes path

* Bypass gasometer lifetime problem by borrow only for a instance

* typo: missing {

* Fix ethcore test compile

* Fix evm tests

* fix(light_sync): calculate `load_share` properly

* refactor(api.rs): extract `light_params` fn, add test

* style(api.rs): add trailing commas

* Implement EIP234

* Make filter conversion returns error if both blockHash and from/toBlock is found

This also changes PollFilter to store the EthFilter type, instead of the jsonrpc one, saving repeated conversion.

* Return error if block filtering target is not found in eth_getLogs

Use the old behavior (unwrap_or_default) for anywhere else.

* fix test: secret_store

* Fix weird indentation

* Make client log filter return error in case a block cannot be found

* Return blockId error in rpc

* test_client: allow return error on logs

* Add a mocked test for eth_getLogs error

* fix: should return error if from_block/to_block greater than best block number

* Add notes on pending

* Add comment for UNSUPPORTED_REQUEST

* Address grumbles

* Return err if from > to

André Silva authored Aug 10, 2018 and ordian committed Aug 10, 2018

* ethcore: fix pow difficulty validation

* ethcore: validate difficulty is not zero

* ethcore: add issue link to regression test

* ethcore: fix tests

* ethcore: move difficulty_to_boundary to ethash crate

* ethcore: reuse difficulty_to_boundary and boundary_to_difficulty

* ethcore: fix grumbles in difficulty_to_boundary_aux

Niklas Adolfsson authored Aug 10, 2018 and David committed Aug 10, 2018

* remove needless macro import

* enable ethcore/macros in tests

Pierre Krieger authored Aug 10, 2018 and Marek Kotewicz committed Aug 10, 2018

* Allow setting the panic hook with parity-clib

* Make all FFI functions unsafe

* Fix comment

* Fix concern

Tomasz Drwięga authored Aug 10, 2018 and Marek Kotewicz committed Aug 10, 2018

* Prevent blockchain & miner racing when accessing pending block.

* Fix unavailability of pending block during reseal.

Kirill Fomichev authored Aug 10, 2018 and Marek Kotewicz committed Aug 10, 2018

* Docker alpine: use multi-stage concept

* Docker alpine: create config directory

* Rename a few types & methods.

* Change `(Log)Builder::format` (closure) arg.

David authored Aug 09, 2018 and Marek Kotewicz committed Aug 09, 2018

* Add a `fastmap` crate that provides the H256FastMap specialized HashMap

* Use `fastmap` instead of `plain_hasher`

* Update submodules for Reasons™

* Submodule update

* deserialize block only once during verification

* ethcore-sync uses Unverified

* ethcore-sync uses Unverified

* fixed build error

* removed Block::is_good

* applied review suggestions

* ethcore-sync deserializes headers and blocks only once

André Silva authored Aug 07, 2018 and Andrew Jones committed Aug 07, 2018

* ethcore: add transition flag for transaction permission contract

* ethcore: fix transaction permission contract tests

* Completely remove all dapps struct from rpc

* Remove unused pub use

* Remove dapp policy/permission func in ethcore

* Remove all dapps settings from rpc

* Fix rpc tests

* Use both origin and user_agent

* Address grumbles

* Address grumbles

* Fix tests

Wei Tang authored Aug 07, 2018 and Marek Kotewicz committed Aug 07, 2018

* Improve return data truncate logic

* fix: size -> offset + size

* Basic implementation for kip4

* Add KIP-4 config flags

* typo: docs fix

* Fix args offset

* Add tests for create2

* tests: evm

* Update wasm-tests and fix all gas costs

* Update wasm-tests

* Update wasm-tests and fix gas costs

Pierre Krieger authored Aug 03, 2018 and Niklas Adolfsson committed Aug 03, 2018

* Avoid using $HOME if not necessary

* Fix concerns and issues

* Fix path to parity.h

* Fix other paths as well

Closes #9255 

This PR also removes the limit of max 64 transactions per packet, currently we only attempt to prevent the packet size to go over 8MB. This will only be the case for super-large transactions or high-block-gas-limit chains.

Patching this is important only for chains that have blocks that can fit more than 4k transactions (over 86M block gas limit)

For mainnet, we should actually see a tiny bit faster propagation since instead of computing 4k pending set, we only need `4 * 8M / 21k = 1523` transactions.

Running some tests on `dekompile` node right now, to check how it performs in the wild.

in total:
- removed 4 redundant rlp deserializations
- avoid 1 redundant block data copy