1. May 09, 2018
    • Nicolas Gotchac's avatar
      Refactoring `ethcore-sync` - Fixing warp-sync barrier (#8543) · 8b0ba97c
      Nicolas Gotchac authored
      * Start dividing sync chain : first supplier method
      
      * WIP - updated chain sync supplier
      
      * Finish refactoring the Chain Sync Supplier
      
      * Create Chain Sync Requester
      
      * Add Propagator for Chain Sync
      
      * Add the Chain Sync Handler
      
      * Move tests from mod -> handler
      
      * Move tests to propagator
      
      * Refactor SyncRequester arguments
      
      * Refactoring peer fork header handler
      
      * Fix wrong highest block number in snapshot sync
      
      * Small refactor...
      
      * Address PR grumbles
      
      * Retry failed CI job
      
      * Fix tests
      
      * PR Grumbles
      8b0ba97c
    • Wei Tang's avatar
      Remove State::replace_backend (#8569) · b8468216
      Wei Tang authored
      b8468216
    • Tomasz Drwięga's avatar
      Don't block sync when importing old blocks (#8530) · 24838bbc
      Tomasz Drwięga authored
      * Alter IO queueing.
      
      * Don't require IoMessages to be Clone
      
      * Ancient blocks imported via IoChannel.
      
      * Get rid of private transactions io message.
      
      * Get rid of deadlock and fix disconnected handler.
      
      * Revert to old disconnect condition.
      
      * Fix tests.
      
      * Fix deadlock.
      24838bbc
    • Wei Tang's avatar
      Trace precompiled contracts when the transfer value is not zero (#8486) · 7a00d979
      Wei Tang authored
      * Trace precompiled contracts when the transfer value is not zero
      
      * Add tests for precompiled CALL tracing
      
      * Use byzantium test machine for the new test
      
      * Add notes in comments on why we don't trace all precompileds
      
      * Use is_transferred instead of transferred
      7a00d979
  2. May 08, 2018
    • David's avatar
      Rlp decode returns Result (#8527) · 28c73188
      David authored
      rlp::decode returns Result
      
      Make a best effort to handle decoding errors gracefully throughout the code, using `expect` where the value is guaranteed to be valid (and in other places where it makes sense).
      28c73188
  3. May 07, 2018
    • Wei Tang's avatar
      Keep all enacted blocks notify in order (#8524) · 528497b8
      Wei Tang authored
      * Keep all enacted blocks notify in order
      
      * Collect is unnecessary
      
      * Update ChainNotify to use ChainRouteType
      
      * Fix all ethcore fn defs
      
      * Wrap the type within ChainRoute
      
      * Fix private-tx and sync api
      
      * Fix secret_store API
      
      * Fix updater API
      
      * Fix rpc api
      
      * Fix informant api
      
      * Eagerly cache enacted/retracted and remove contain_enacted/retracted
      
      * Fix indent
      
      * tests: should use full expr form for struct constructor
      
      * Use into_enacted_retracted to further avoid copy
      
      * typo: not a function
      
      * rpc/tests: ChainRoute -> ChainRoute::new
      528497b8
    • André Silva's avatar
  4. May 05, 2018
    • Toralf Wittner's avatar
      Consolidate crypto functionality in `ethcore-crypto`. (#8432) · e30839e8
      Toralf Wittner authored and Marek Kotewicz's avatar Marek Kotewicz committed
      * Consolidate crypto functionality in `ethcore-crypto`.
      
      - Move `ecdh`/`ecies` modules to `ethkey`.
      - Refactor `ethcore-crypto` to use file per module.
      - Replace `subtle` with `ethcore_crypto::is_equal`.
      - Add `aes_gcm` module to `ethcore-crypto`.
      
      * Rename `aes::{encrypt,decrypt,decrypt_cbc}` ...
      
      ... to `aes::{encrypt_128_ctr,decrypt_128_ctr,decrypt_128_cbc}`.
      e30839e8
    • Wei Tang's avatar
      EIP 145: Bitwise shifting instructions in EVM (#8451) · a4c7843a
      Wei Tang authored and Marek Kotewicz's avatar Marek Kotewicz committed
      * Add SHL, SHR, SAR opcodes
      
      * Add have_bitwise_shifting schedule flag
      
      * Add all EIP tests for SHL
      
      * Add SHR implementation and tests
      
      * Implement SAR and add tests
      
      * Add eip145transition config param
      
      * Change map_or to map_or_else when possible
      a4c7843a
  5. May 03, 2018
    • Andrew Jones's avatar
      Don't panic in import_block if invalid rlp (#8522) · 66c0638f
      Andrew Jones authored and Marek Kotewicz's avatar Marek Kotewicz committed
      * Don't panic in import_block if invalid rlp
      
      * Remove redundant type annotation
      
      * Replace RLP header view usage with safe decoding
      
      Using the view will panic with invalid RLP. Here we use Rlp decoding directly which will return a `Result<_, DecoderError>`. While this path currently should not have any invalid RLP - it makes it safer if ever called with invalid RLP from other code paths.
      66c0638f
  6. May 02, 2018
    • Wei Tang's avatar
      Pass on storage keys tracing to handle the case when it is not modified (#8491) · eec73647
      Wei Tang authored
      * Pass on storage keys even if it is not modified
      
      * typo: account and storage query
      
      `to_pod_diff` builds both `touched_addresses` merge and storage keys merge.
      
      * Fix tests
      
      * Use state query directly because of suicided accounts
      
      * Fix a RefCell borrow issue
      
      * Add tests for unmodified storage trace
      
      * Address grumbles
      
      * typo: remove unwanted empty line
      
      * ensure_cached compiles with the original signature
      eec73647
    • Wei Tang's avatar
      Fetching logs by hash in blockchain database (#8463) · b1009450
      Wei Tang authored and Marek Kotewicz's avatar Marek Kotewicz committed
      * Fetch logs by hash in blockchain database
      
      * Fix tests
      
      * Add unit test for branch block logs fetching
      
      * Add docs that blocks must already be sorted
      
      * Handle branch block cases properly
      
      * typo: empty -> is_empty
      
      * Remove return_empty_if_none by using a closure
      
      * Use BTreeSet to avoid sorting again
      
      * Move is_canon to BlockChain
      
      * typo: pass value by reference
      
      * Use loop and wrap inside blocks to simplify the code
      
      Borrowed from https://github.com/paritytech/parity/pull/8463#discussion_r183453326
      
      * typo: missed a comment
      b1009450
  7. May 01, 2018
  8. Apr 27, 2018
  9. Apr 26, 2018
  10. Apr 25, 2018
  11. Apr 21, 2018
  12. Apr 20, 2018
    • Anton Gavrilov's avatar
      Private transactions processing error handling (#8431) · d86333af
      Anton Gavrilov authored
      * Integration test for private transaction returned
      
      * Do not interrupt verification in case of errors
      
      * Helpers use specified
      
      * Review comments fixed
      d86333af
    • Wei Tang's avatar
      Improve VM executor stack size estimation rules (#8439) · 28b5906d
      Wei Tang authored
      * Improve VM executor stack size estimation rules
      
      * typo: docs add "(Debug build)" comment
      
      * Fix an off by one typo and set minimal stack size
      
      This avoids the case if `depth_threshold == max_depth`. Usually setting stack size to zero will just rebound it to
      platform minimal stack size, but we set it here just in case.
      
      * Use saturating_sub to avoid potential overflow
      28b5906d
    • André Silva's avatar
      Block reward contract (#8419) · 24f6d829
      André Silva authored
      * engine: add block reward contract abi and helper client
      
      * aura: add support for block reward contract
      
      * engine: test block reward contract client
      
      * aura: test block reward contract
      
      * engine + aura: add missing docs
      
      * engine: share SystemCall type alias
      
      * aura: add transition for block reward contract
      
      * engine: fix example block reward contract source link and bytecode
      24f6d829
    • Wei Tang's avatar
      Permission fix (#8441) · 9c5e3554
      Wei Tang authored
      9c5e3554
  13. Apr 19, 2018
    • lihuafeng's avatar
      remove From::from. (#8390) · 8fb47b52
      lihuafeng authored and Marek Kotewicz's avatar Marek Kotewicz committed
      * Some tiny modifications.
      1. fix some typo in the comment.
      2. sort the order of methods in 'impl state::Backend for StateDB`
      
      * Remove the clone of code_cache, as it has been done in clone_basic.
      
      * remove From::from. It seems not necessary.
      8fb47b52
    • Andrew Jones's avatar
      Move ethcore::Error to error_chain (#8386) · 14361cc7
      Andrew Jones authored
      * WIP
      
      * Convert Ethcore error to use error_chain
      
      * Use error_chain for ImportError and BlockImportError
      
      * Fix error pattern matches for error_chain in miner
      
      * Implement explicit From for AccountsError
      
      * Fix pattern matches for ErrorKinds
      
      * Handle ethcore error_chain in light client
      
      * Explicitly define Result type to avoid shadowing
      
      * Fix remaining Error pattern matches
      
      * Fix tab space formatting
      
      * Helps if the tests compile
      
      * Fix error chain matching after merge
      14361cc7
    • Tomasz Drwięga's avatar
      Fix receipts stripping. (#8414) · 461b2d48
      Tomasz Drwięga authored
      461b2d48
  14. Apr 16, 2018
    • Andrew Jones's avatar
      Replace legacy Rlp with UntrustedRlp and use in ethcore rlp views (#8316) · a04c5b18
      Andrew Jones authored
      * WIP
      
      * Replace Rlp with UntrustedRlp in views, explicity unwrap with expect
      
      First pass to get it to compile. Need to figure out whether to do this or to propogate Errors upstream, which would require many more changes to dependent code. If we do this way we are assuming that the views are always used in a context where the rlp is trusted to be valid e.g. when reading from our own DB. So need to fid out whether views are used with data received from an untrusted (e.g. extrernal peer).
      
      * Remove original Rlp impl, rename UntrustedRlp -> Rlp
      
      * Create rlp views with view! macro to record debug info
      
      Views are assumed to be over valid rlp, so if there is a decoding error we record where the view was created in the first place and report it in the expect
      
      * Use $crate in view! macro to avoid import, fix tests
      
      * Expect valid rlp in decode functions for now
      
      * Replace spaces with tabs in new file
      
      * Add doc tests for creating views with macro
      
      * Update rlp docs to reflect removing of UntrustedRlp
      
      * Replace UntrustedRlp usages in private-tx merge
      a04c5b18
  15. Apr 14, 2018
  16. Apr 13, 2018
    • Wei Tang's avatar
      Unify and limit rocksdb dependency places (#8371) · 897a9464
      Wei Tang authored
      * secret_store: remove kvdb_rocksdb dependency
      
      * cli: init db mod for open dispatch
      
      * cli: move db, client_db, restoration_db, secretstore_db to a separate mod
      
      * migration: rename to migration-rocksdb and remove ethcore-migrations
      
      * ethcore: re-move kvdb-rocksdb dep to test
      
      * mark test_helpers as test only and fix migration mod naming
      
      * Move restoration_db_handler to test_helpers_internal
      
      * Fix missing preambles in test_helpers_internal and rocksdb/helpers
      
      * Move test crates downward
      
      * Fix missing docs
      
      * cli, db::open_db: move each argument to a separate line
      
      * Use featuregate instead of dead code for `open_secretstore_db`
      
      * Move pathbuf import to open_secretstore_db
      
      Because it's only used there behind a feature gate
      897a9464
    • Tomasz Drwięga's avatar
      New Transaction Queue implementation (#8074) · 1cd93e4c
      Tomasz Drwięga authored and Marek Kotewicz's avatar Marek Kotewicz committed
      * Implementation of Verifier, Scoring and Ready.
      
      * Queue in progress.
      
      * TransactionPool.
      
      * Prepare for txpool release.
      
      * Miner refactor [WiP]
      
      * WiP reworking miner.
      
      * Make it compile.
      
      * Add some docs.
      
      * Split blockchain access to a separate file.
      
      * Work on miner API.
      
      * Fix ethcore tests.
      
      * Refactor miner interface for sealing/work packages.
      
      * Implement next nonce.
      
      * RPC compiles.
      
      * Implement couple of missing methdods for RPC.
      
      * Add transaction queue listeners.
      
      * Compiles!
      
      * Clean-up and parallelize.
      
      * Get rid of RefCell in header.
      
      * Revert "Get rid of RefCell in header."
      
      This reverts commit 0f2424c9b7319a786e1565ea2a8a6d801a21b4fb.
      
      * Override Sync requirement.
      
      * Fix status display.
      
      * Unify logging.
      
      * Extract some cheap checks.
      
      * Measurements and optimizations.
      
      * Fix scoring bug, heap size of bug and add cache
      
      * Disable tx queueing and parallel verification.
      
      * Make ethcore and ethcore-miner compile again.
      
      * Make RPC compile again.
      
      * Bunch of txpool tests.
      
      * Migrate transaction queue tests.
      
      * Nonce Cap
      
      * Nonce cap cache and tests.
      
      * Remove stale future transactions from the queue.
      
      * Optimize scoring and write some tests.
      
      * Simple penalization.
      
      * Clean up and support for different scoring algorithms.
      
      * Add CLI parameters for the new queue.
      
      * Remove banning queue.
      
      * Disable debug build.
      
      * Change per_sender limit to be 1% instead of 5%
      
      * Avoid cloning when propagating transactions.
      
      * Remove old todo.
      
      * Post-review fixes.
      
      * Fix miner options default.
      
      * Implement back ready transactions for light client.
      
      * Get rid of from_pending_block
      
      * Pass rejection reason.
      
      * Add more details to drop.
      
      * Rollback heap size of.
      
      * Avoid cloning hashes when propagating and include more details on rejection.
      
      * Fix tests.
      
      * Introduce nonces cache.
      
      * Remove uneccessary hashes allocation.
      
      * Lower the mem limit.
      
      * Re-enable parallel verification.
      
      * Add miner log. Don't check the type if not below min_gas_price.
      
      * Add more traces, fix disabling miner.
      
      * Fix creating pending blocks twice on AuRa authorities.
      
      * Fix tests.
      
      * re-use pending blocks in AuRa
      
      * Use reseal_min_period to prevent too frequent update_sealing.
      
      * Fix log to contain hash not sender.
      
      * Optimize local transactions.
      
      * Fix aura tests.
      
      * Update locks comments.
      
      * Get rid of unsafe Sync impl.
      
      * Review fixes.
      
      * Remove excessive matches.
      
      * Fix compilation errors.
      
      * Use new pool in private transactions.
      
      * Fix private-tx test.
      
      * Fix secret store tests.
      
      * Actually use gas_floor_target
      
      * Fix config tests.
      
      * Fix pool tests.
      
      * Address grumbles.
      1cd93e4c
    • asynchronous rob's avatar
  17. Apr 11, 2018
  18. Apr 10, 2018