1. Aug 04, 2020
  2. Jul 28, 2020
    • asynchronous rob's avatar
      Add new Runtime API messages and make runtime API request fallible (#1485) · 7ed4cb9c
      asynchronous rob authored
      * polkadot-subsystem: update runtime API message types
      
      * update all networking subsystems to use fallible runtime APIs
      
      * fix bitfield-signing and make it use new runtime APIs
      
      * port candidate-backing to handle runtime API errors and new types
      
      * remove old runtime API messages
      
      * remove unused imports
      
      * fix grumbles
      
      * fix backing tests
      7ed4cb9c
  3. Jul 21, 2020
    • Peter Goodspeed-Niklaus's avatar
      Add test suite and minor refinements to the utility subsystem (#1403) · cc2d7afd
      Peter Goodspeed-Niklaus authored
      * get conclude signal working properly; don't allocate a vector
      
      * wip: add test suite / example / explanation for using utility subsystem
      
      Unfortunately, the test fails right now for reasons which seem
      very odd. Just have to keep poking at it.
      
      * explicitly import everything
      
      * fix subsystem-util test
      
      The root problem here was two-fold:
      
      - there was a circular dependency from subsystem -> test-helpers/subsystem ->
        subsystem
      - cfg(test) doesn't propagate between crates
      
      The solution: move the subsystem test helpers into a sub-module
      within subsystem. Publicly export them from the previous location
      so no other code breaks.
      
      Doing this has an additional benefit: it ensures that no production
      code can ever accidentally use the subsystem helpers, as they are compile-
      gated on cfg(test).
      
      * fully commit to moving test helpers into a subsystem module
      
      * add some more tests
      
      * get rid of log tests in favor of real error forwarding
      
      It's not obvious whether we'll ever really want to chase down
      these errors outside a testing context, but having the capability
      won't hurt.
      
      * fix issue which caused test to hang on osx
      
      * only require that job errors are PartialEq when testing
      
      also fix polkadot-node-core-backing tests
      
      * get rid of any notion of partialeq
      
      * rethink testing
      
      Combine tests of starting and stopping job: leaving a test executor
      with a job running was pretty clearly the cause of the sometimes-hang.
      
      Also, add a timeout so tests _can't_ hang anymore; they just fail
      after a while.
      
      * rename fwd_errors -> forward_errors
      
      * warn on error propagation failure
      
      * fix unused import leftover from merge
      
      * derive eq for subsystemerror
      cc2d7afd
  4. Jul 17, 2020
  5. Jul 14, 2020
    • Peter Goodspeed-Niklaus's avatar
      mod subsystem-util (#1376) · d7684115
      Peter Goodspeed-Niklaus authored
      * Add subsystem-util crate.
      
      Start by moving the JobCanceler here.
      
      * copy utility functions for requesting runtime data; generalize
      
      * convert subsystem-util from crate to module in subsystem
      
      The point of making a sub-crate is to ensure that only the necessary
      parts of a program get compiled; if a dependent package needed only
      subsystem-util, and not subsystem, then subsystem wouldn't need to
      be compiled.
      
      However, that will never happen: subsystem-util depends on
      subsystem::messages, so subsystem will always be compiled.
      
      Therefore, it makes more sense to add it as a module in the existing
      crate than as a new and distinct crate.
      
      * make runtime request sender type generic
      
      * candidate backing subsystem uses util for api requests
      
      * add struct Validator representing the local validator
      
      This struct can be constructed when the local node is a validator;
      the constructor fails otherwise. It stores a bit of local data, and
      provides some utility methods.
      
      * add alternate constructor for better efficiency
      
      * refactor candidate backing to use utility methods
      
      * fix test breakage caused by reordering tests
      
      * restore test which accidentally got deleted during merge
      
      * start extracting jobs management into helper traits + structs
      
      * use util::{JobHandle, Jobs} in CandidateBackingSubsystem
      
      * implement generic job-manager subsystem impl
      
      This means that the work of implementing a subsystem boils down
      to implementing the job, and then writing an appropriate
      type definition, i.e.
      
      pub type CandidateBackingSubsystem<Spawner, Context> =
      	util::JobManager<Spawner, Context, CandidateBackingJob>;
      
      * add hash-extraction helper to messages
      
      * fix errors caused by improper rebase
      
      * doc improvement
      
      * simplify conversion from overseer communication to job message
      
      * document fn hash for all messages
      
      * rename fn hash() -> fn relay_parent
      
      * gracefully shut down running futures on Conclude
      
      * ensure we're validating with the proper validator index
      
      * rename: handle_unhashed_msg -> handle_orphan_msg
      
      * impl Stream for Jobs<Spawner, Job>
      
      This turns out to be relatively complicated and requires some
      unsafe code, so we'll want either detailed review, or to choose
      to revert this commit.
      
      * add missing documentation for public items
      
      * use pin-project to eliminate unsafe code from this codebase
      
      * rename SenderMessage -> FromJob
      
      * reenvision the subsystem requests as an extension trait
      
      This works within `util.rs`, but fails in `core/backing/src/lib.rs`,
      because we don't actually create the struct soon enough. Continuing
      down this path would imply substantial rewriting.
      
      * Revert "reenvision the subsystem requests as an extension trait"
      
      This reverts commit a5639e36.
      
      The fact is, the new API is more complicated to no real benefit.
      
      * apply suggested futuresunordered join_all impl
      
      * CandidateValidationMessage variants have no top-level relay parents
      
      * rename handle_orphan_msg -> handle_unanchored_msg
      
      * make most node-core-backing types private
      
      Now the only public types exposed in that module are
      CandidateBackingSubsystem and ToJob. While ideally we could reduce
      the public interface to only the former type, that doesn't work
      because ToJob appears in the public interface of CandidateBackingSubsystem.
      
      This also involves changing the definition of CandidateBackingSubsystem;
      it is no longer a typedef, but a struct wrapping the job manager.
      d7684115
  6. Jul 09, 2020
    • Fedor Sakharov's avatar
      CandidateBackingSubsystem (#1312) · 6aa5bfba
      Fedor Sakharov authored
      * Updates guide for CandidateBacking
      
      * Move assignment types to primitives
      
      * Initial implementation.
      
      * More functionality
      
      * use assert_matches
      
      * Changes to report misbehaviors
      
      * Some fixes after a review
      
      * Remove a blank line
      
      * Update guide and some types
      
      * Adds run_job function
      
      * Some comments and refactorings
      
      * Fix review
      
      * Remove warnings
      
      * Use summary in kicking off validation
      
      * Parallelize requests
      
      * Validation provides local and global validation params
      
      * Test issued validity tracking
      
      * Nits from review
      6aa5bfba