1. Dec 25, 2020
  2. Nov 24, 2020
  3. Nov 20, 2020
    • Peter Goodspeed-Niklaus's avatar
      Add tracing support to node (#1940) · f7ea3d07
      Peter Goodspeed-Niklaus authored
      * drop in tracing to replace log
      
      * add structured logging to trace messages
      
      * add structured logging to debug messages
      
      * add structured logging to info messages
      
      * add structured logging to warn messages
      
      * add structured logging to error messages
      
      * normalize spacing and Display vs Debug
      
      * add instrumentation to the various 'fn run'
      
      * use explicit tracing module throughout
      
      * fix availability distribution test
      
      * don't double-print errors
      
      * remove further redundancy from logs
      
      * fix test errors
      
      * fix more test errors
      
      * remove unused kv_log_macro
      
      * fix unused variable
      
      * add tracing spans to collation generation
      
      * add tracing spans to av-store
      
      * add tracing spans to backing
      
      * add tracing spans to bitfield-signing
      
      * add tracing spans to candidate-selection
      
      * add tracing spans to candidate-validation
      
      * add tracing spans to chain-api
      
      * add tracing spans to provisioner
      
      * add tracing spans to runtime-api
      
      * add tracing spans to availability-distribution
      
      * add tracing spans to bitfield-distribution
      
      * add tracing spans to network-bridge
      
      * add tracing spans to collator-protocol
      
      * add tracing spans to pov-distribution
      
      * add tracing spans to statement-distribution
      
      * add tracing spans to overseer
      
      * cleanup
      f7ea3d07
  4. Nov 17, 2020
    • ordian's avatar
      update most of the dependencies (#1946) · 31fb8fed
      ordian authored
      * update tiny-keccak to 0.2
      
      * update deps except bitvec and shared_memory
      
      * fix some warning after futures upgrade
      
      * remove useless package rename caused by bug in cargo-upgrade
      
      * revert parity-util-mem *
      
      * remove unused import
      
      * cargo update
      
      * remove all renames on parity-scale-codec
      
      * remove the leftovers
      
      * remove unused dep
      31fb8fed
  5. Oct 27, 2020
  6. Aug 17, 2020
    • Peter Goodspeed-Niklaus's avatar
      implement collation generation subsystem (#1557) · e750a825
      Peter Goodspeed-Niklaus authored
      * start sketching out a collation generation subsystem
      
      * invent a basic strategy for double initialization
      
      * clean up warnings
      
      * impl util requests from runtime assuming a context instead of a FromJob sender
      
      * implement collation generation algorithm from guide
      
      * update AllMessages in tests
      
      * fix trivial review comments
      
      * remove another redundant declaration from merge
      
      * filter availability cores by para_id
      
      * handle new activations each in their own async task
      
      * update guide according to the actual current implementation
      
      * add initialization to guide
      
      * add general-purpose subsystem_test_harness helper
      
      * write first handle_new_activations test
      
      * add test that handle_new_activations filters local_validation_data requests
      
      * add (failing) test of collation distribution message sending
      
      * rustfmt
      
      * broken: work on fixing sender test
      
      Unfortunately, for reasons that are not yet clear, despite the public key
      and checked data being identical, the signer is not producing an identical
      signature. This commit produces this output (among more):
      
      signing with  Public(c4733ab0bbe3ba4c096685d1737a7f498cdbdd167a767d04a21dc7df12b8c858 (5GWHUNm5...))
      checking with Public(c4733ab0bbe3ba4c096685d1737a7f498cdbdd167a767d04a21dc7df12b8c858 (5GWHUNm5...))
      signed payload:  [4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 10, 0, 0, 0, c7, e5, c0, 64, 7a, db, fe, 44, 81, e5, 51, 11, 79, 9f, a5, 63, 93, 94, 3c, c4, 36, c6, 30, 36, c2, c5, 44, a2, 1b, db, b7, 82, 3, 17, a, 2e, 75, 97, b7, b7, e3, d8, 4c, 5, 39, 1d, 13, 9a, 62, b1, 57, e7, 87, 86, d8, c0, 82, f2, 9d, cf, 4c, 11, 13, 14]
      checked payload: [4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 10, 0, 0, 0, c7, e5, c0, 64, 7a, db, fe, 44, 81, e5, 51, 11, 79, 9f, a5, 63, 93, 94, 3c, c4, 36, c6, 30, 36, c2, c5, 44, a2, 1b, db, b7, 82, 3, 17, a, 2e, 75, 97, b7, b7, e3, d8, 4c, 5, 39, 1d, 13, 9a, 62, b1, 57, e7, 87, 86, d8, c0, 82, f2, 9d, cf, 4c, 11, 13, 14]
      
      * fix broken test
      
      * collation function returns commitments hash
      
      It doesn't look like we use the actual commitments data anywhere, and
      it's not obvious if there are any fields of `CandidateCommitments`
      not available to the collator, so this commit just assigns them the
      entire responsibility of generating the hash.
      
      * add missing overseer impls
      
      * calculating erasure coding is polkadot's responsibility, not cumulus
      
      * concurrentize per-relay_parent requests
      e750a825
  7. Aug 07, 2020
  8. Jul 28, 2020
  9. Jul 27, 2020
    • Peter Goodspeed-Niklaus's avatar
      add ActiveLeavesUpdate, remove StartWork, StopWork (#1458) · 12a02556
      Peter Goodspeed-Niklaus authored
      * add ActiveLeavesUpdate, remove StartWork, StopWork
      
      * replace StartWork, StopWork in subsystem crate tests
      
      * mechanically update OverseerSignal in other modules
      
      * convert overseer to take advantage of new multi-hash update abilities
      
      Note: this does not yet convert the tests; some of the tests now freeze:
      
      test tests::overseer_start_stop_works ... test tests::overseer_start_stop_works has been running for over 60 seconds
      test tests::overseer_finalize_works ... test tests::overseer_finalize_works has been running for over 60 seconds
      
      * fix broken overseer tests
      
      * manually impl PartialEq for ActiveLeavesUpdate, rm trait Equivalent
      
      This cleans up the code a bit and makes it easier in the future to
      do the right thing when comparing ALUs.
      
      * use target in all network bridge logging
      
      * reduce spamming of  and
      12a02556
  10. Jul 21, 2020
    • Peter Goodspeed-Niklaus's avatar
      Add test suite and minor refinements to the utility subsystem (#1403) · cc2d7afd
      Peter Goodspeed-Niklaus authored
      * get conclude signal working properly; don't allocate a vector
      
      * wip: add test suite / example / explanation for using utility subsystem
      
      Unfortunately, the test fails right now for reasons which seem
      very odd. Just have to keep poking at it.
      
      * explicitly import everything
      
      * fix subsystem-util test
      
      The root problem here was two-fold:
      
      - there was a circular dependency from subsystem -> test-helpers/subsystem ->
        subsystem
      - cfg(test) doesn't propagate between crates
      
      The solution: move the subsystem test helpers into a sub-module
      within subsystem. Publicly export them from the previous location
      so no other code breaks.
      
      Doing this has an additional benefit: it ensures that no production
      code can ever accidentally use the subsystem helpers, as they are compile-
      gated on cfg(test).
      
      * fully commit to moving test helpers into a subsystem module
      
      * add some more tests
      
      * get rid of log tests in favor of real error forwarding
      
      It's not obvious whether we'll ever really want to chase down
      these errors outside a testing context, but having the capability
      won't hurt.
      
      * fix issue which caused test to hang on osx
      
      * only require that job errors are PartialEq when testing
      
      also fix polkadot-node-core-backing tests
      
      * get rid of any notion of partialeq
      
      * rethink testing
      
      Combine tests of starting and stopping job: leaving a test executor
      with a job running was pretty clearly the cause of the sometimes-hang.
      
      Also, add a timeout so tests _can't_ hang anymore; they just fail
      after a while.
      
      * rename fwd_errors -> forward_errors
      
      * warn on error propagation failure
      
      * fix unused import leftover from merge
      
      * derive eq for subsystemerror
      cc2d7afd
  11. Jul 14, 2020
    • Peter Goodspeed-Niklaus's avatar
      mod subsystem-util (#1376) · d7684115
      Peter Goodspeed-Niklaus authored
      * Add subsystem-util crate.
      
      Start by moving the JobCanceler here.
      
      * copy utility functions for requesting runtime data; generalize
      
      * convert subsystem-util from crate to module in subsystem
      
      The point of making a sub-crate is to ensure that only the necessary
      parts of a program get compiled; if a dependent package needed only
      subsystem-util, and not subsystem, then subsystem wouldn't need to
      be compiled.
      
      However, that will never happen: subsystem-util depends on
      subsystem::messages, so subsystem will always be compiled.
      
      Therefore, it makes more sense to add it as a module in the existing
      crate than as a new and distinct crate.
      
      * make runtime request sender type generic
      
      * candidate backing subsystem uses util for api requests
      
      * add struct Validator representing the local validator
      
      This struct can be constructed when the local node is a validator;
      the constructor fails otherwise. It stores a bit of local data, and
      provides some utility methods.
      
      * add alternate constructor for better efficiency
      
      * refactor candidate backing to use utility methods
      
      * fix test breakage caused by reordering tests
      
      * restore test which accidentally got deleted during merge
      
      * start extracting jobs management into helper traits + structs
      
      * use util::{JobHandle, Jobs} in CandidateBackingSubsystem
      
      * implement generic job-manager subsystem impl
      
      This means that the work of implementing a subsystem boils down
      to implementing the job, and then writing an appropriate
      type definition, i.e.
      
      pub type CandidateBackingSubsystem<Spawner, Context> =
      	util::JobManager<Spawner, Context, CandidateBackingJob>;
      
      * add hash-extraction helper to messages
      
      * fix errors caused by improper rebase
      
      * doc improvement
      
      * simplify conversion from overseer communication to job message
      
      * document fn hash for all messages
      
      * rename fn hash() -> fn relay_parent
      
      * gracefully shut down running futures on Conclude
      
      * ensure we're validating with the proper validator index
      
      * rename: handle_unhashed_msg -> handle_orphan_msg
      
      * impl Stream for Jobs<Spawner, Job>
      
      This turns out to be relatively complicated and requires some
      unsafe code, so we'll want either detailed review, or to choose
      to revert this commit.
      
      * add missing documentation for public items
      
      * use pin-project to eliminate unsafe code from this codebase
      
      * rename SenderMessage -> FromJob
      
      * reenvision the subsystem requests as an extension trait
      
      This works within `util.rs`, but fails in `core/backing/src/lib.rs`,
      because we don't actually create the struct soon enough. Continuing
      down this path would imply substantial rewriting.
      
      * Revert "reenvision the subsystem requests as an extension trait"
      
      This reverts commit a5639e36.
      
      The fact is, the new API is more complicated to no real benefit.
      
      * apply suggested futuresunordered join_all impl
      
      * CandidateValidationMessage variants have no top-level relay parents
      
      * rename handle_orphan_msg -> handle_unanchored_msg
      
      * make most node-core-backing types private
      
      Now the only public types exposed in that module are
      CandidateBackingSubsystem and ToJob. While ideally we could reduce
      the public interface to only the former type, that doesn't work
      because ToJob appears in the public interface of CandidateBackingSubsystem.
      
      This also involves changing the definition of CandidateBackingSubsystem;
      it is no longer a typedef, but a struct wrapping the job manager.
      d7684115
  12. Jun 30, 2020
    • asynchronous rob's avatar
      Implement Network Bridge (#1280) · eaae8653
      asynchronous rob authored
      
      
      * network bridge skeleton
      
      * move some primitives around and add debug impls
      
      * protocol registration glue & abstract network interface
      
      * add send_msgs to subsystemctx
      
      * select logic
      
      * transform different events into actions and handle
      
      * implement remaining network bridge state machine
      
      * start test skeleton
      
      * make network methods asynchronous
      
      * extract subsystem out to subsystem crate
      
      * port over overseer to subsystem context trait
      
      * fix minimal example
      
      * fix overseer doc test
      
      * update network-bridge crate
      
      * write a subsystem test-helpers crate
      
      * write a network test helper for network-bridge
      
      * set up (broken) view test
      
      * Revamp network to be more async-friendly and not require Sync
      
      * fix spacing
      
      * fix test compilation
      
      * insert side-channel for actions
      
      * Add some more message types to AllMessages
      
      * introduce a test harness
      
      * add some tests
      
      * ensure service compiles and passes tests
      
      * fix typo
      
      * fix service-new compilation
      
      * Subsystem test helpers send messages synchronously
      
      * remove smelly action inspector
      
      * remove superfluous let binding
      
      * fix warnings
      
      * Update node/network/bridge/src/lib.rs
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      
      * fix compilation
      
      Co-authored-by: default avatarPeter Goodspeed-Niklaus <[email protected]>
      eaae8653
  13. Jun 17, 2020
  14. Jun 05, 2020